FeedReader::readFeedNode() - Code Metrics - Inspection of "Implement feed reader" - jdecool/jsonfeed - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cf8ab0...30f4d3 )

by Jérémy

created 2017-05-29 08:14 UTC

FeedReader::readFeedNode() B

↳ Parent: FeedReader

Complexity

Conditions	6
Paths	6

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.439
c	0
b	0
f	0
cc	6
eloc	18
nc	6
nop	1

<?php

namespace JDecool\JsonFeed\Reader\Version1;

use DateTime;
use InvalidArgumentException;
use JDecool\JsonFeed\Attachment;
use JDecool\JsonFeed\Author;
use JDecool\JsonFeed\Feed;
use JDecool\JsonFeed\Hub;
use JDecool\JsonFeed\Item;
use JDecool\JsonFeed\Reader\ReaderInterface;
use Symfony\Component\PropertyAccess\PropertyAccess;

class FeedReader implements ReaderInterface
{
    /** @var \Symfony\Component\PropertyAccess\PropertyAccessor */
    private $accessor;

    /** @var FeedReader */
    private static $instance;

    /**
     * Create reader instance
     *
     * @return FeedReader
     */
    public static function create()
    {
        if (null === self::$instance) {
            self::$instance = new self;
        }

        return self::$instance;
    }

    /**
     * Constructor
     */
    private function __construct()
    {
        $this->accessor = PropertyAccess::createPropertyAccessor();
    }

    /**
     * {@inheritdoc}
     */
    public function readFromJson($json)
    {
        $content = json_decode($json, true);
        if (!is_array($content)) {
            throw new InvalidArgumentException('Invalid JSONFeed string');
        }

        return $this->readFeedNode($content);
    }

    /**
     * Browse feed node
     *
     * @param array $content
     * @return Feed
     */
    private function readFeedNode(array $content)
    {
        $feed = new Feed('');

        foreach ($content as $key => $value) {
            if ('version' === $key) {
                continue;
            }

            switch ($key) {
                case 'author':
                    $feed->setAuthor($this->readAuthorNode($value));
                    break;

                case 'hubs':
                    $feed->setHubs(array_map([$this, 'readHubNode'], $value));
                    break;

                case 'items':
                    $feed->setItems(array_map([$this, 'readItemNode'], $value));
                    break;

                default:
                    $this->accessor->setValue($feed, $key, $value);
            }
        }

        return $feed;

    }

    /**
     * Browse item node
     *
     * @param array $content
     * @return Item
     */
    private function readItemNode(array $content)
    {
        $id = isset($content['id']) ? $content['id'] : '';

        $item = new Item($id);
        foreach ($content as $key => $value) {
            if ('id' === $key) {
                continue;
            }

            switch ($key) {
                case 'attachments':
                    $item->setAttachments(array_map([$this, 'readAttachmentNode'], $value));
                    break;

                case 'author':
                    $item->setAuthor($this->readAuthorNode($value));
                    break;

                case 'date_published':
                case 'date_modified':
                    $this->accessor->setValue($item, $key, new DateTime($value));
                    break;

                default:
                    $this->accessor->setValue($item, $key, $value);
            }
        }

        return $item;

    }

    /**
     * Browse author node
     *
     * @param array $content
     * @return Author
     */
    private function readAuthorNode(array $content)
    {
        $name = (isset($content['name'])) ? $content['name'] : '';

        $author = new Author($name);
        foreach ($content as $key => $value) {
            if ('name' === $key) {
                continue;
            }

            $this->accessor->setValue($author, $key, $value);
        }

        return $author;

    }

    /**
     * Browse hub node
     *
     * @param array $content
     * @return Hub
     */
    private function readHubNode(array $content)
    {
        $type = isset($content['type']) ? $content['type'] : '';
        $url = isset($content['url']) ? $content['url'] : '';

        return new Hub($type, $url);
    }

    /**
     * Browse attachment node
     *
     * @param array $content
     * @return Attachment
     */
    private function readAttachmentNode(array $content)
    {
        $url = isset($content['url']) ? $content['url'] : '';
        $mimeType = isset($content['mime_type']) ? $content['mime_type'] : '';

        $attachment = new Attachment($url, $mimeType);
        foreach ($content as $key => $value) {
            switch ($key) {
                case 'size_in_bytes':
                    $attachment->setSize($value);
                    break;

                case 'duration_in_seconds':
                    $attachment->setDuration($value);
                    break;
            }
        }

        return $attachment;
    }
}


1			<?php
2
3			namespace JDecool\JsonFeed\Reader\Version1;
4
5			use DateTime;
6			use InvalidArgumentException;
7			use JDecool\JsonFeed\Attachment;
8			use JDecool\JsonFeed\Author;
9			use JDecool\JsonFeed\Feed;
10			use JDecool\JsonFeed\Hub;
11			use JDecool\JsonFeed\Item;
12			use JDecool\JsonFeed\Reader\ReaderInterface;
13			use Symfony\Component\PropertyAccess\PropertyAccess;
14
15			class FeedReader implements ReaderInterface
16			{
17			/** @var \Symfony\Component\PropertyAccess\PropertyAccessor */
18			private $accessor;
19
20			/** @var FeedReader */
21			private static $instance;
22
23			/**
24			* Create reader instance
25			*
26			* @return FeedReader
27			*/
28			public static function create()
29			{
30			if (null === self::$instance) {
31			self::$instance = new self;
32			}
33
34			return self::$instance;
35			}
36
37			/**
38			* Constructor
39			*/
40			private function __construct()
41			{
42			$this->accessor = PropertyAccess::createPropertyAccessor();
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function readFromJson($json)
49			{
50			$content = json_decode($json, true);
51			if (!is_array($content)) {
52			throw new InvalidArgumentException('Invalid JSONFeed string');
53			}
54
55			return $this->readFeedNode($content);
56			}
57
58			/**
59			* Browse feed node
60			*
61			* @param array $content
62			* @return Feed
63			*/
64			private function readFeedNode(array $content)
65			{
66			$feed = new Feed('');
67
68			foreach ($content as $key => $value) {
69			if ('version' === $key) {
70			continue;
71			}
72
73			switch ($key) {
74			case 'author':
75			$feed->setAuthor($this->readAuthorNode($value));
76			break;
77
78			case 'hubs':
79			$feed->setHubs(array_map([$this, 'readHubNode'], $value));
80			break;
81
82			case 'items':
83			$feed->setItems(array_map([$this, 'readItemNode'], $value));
84			break;
85
86			default:
87			$this->accessor->setValue($feed, $key, $value);
88			}
89			}
90
91			return $feed;
			0 ignored issues – show Bug Compatibility introduced 2017-05-28 23:27 UTC by Report Bug Copy Issue Report The expression `return $feed;` of type `object\|array` is incompatible with the return type documented by `JDecool\JsonFeed\Reader\...eedReader::readFeedNode` of type `JDecool\JsonFeed\Feed` as it can also be of type `array` which is not included in this return type. Loading history...
92			}
93
94			/**
95			* Browse item node
96			*
97			* @param array $content
98			* @return Item
99			*/
100			private function readItemNode(array $content)
101			{
102			$id = isset($content['id']) ? $content['id'] : '';
103
104			$item = new Item($id);
105			foreach ($content as $key => $value) {
106			if ('id' === $key) {
107			continue;
108			}
109
110			switch ($key) {
111			case 'attachments':
112			$item->setAttachments(array_map([$this, 'readAttachmentNode'], $value));
113			break;
114
115			case 'author':
116			$item->setAuthor($this->readAuthorNode($value));
117			break;
118
119			case 'date_published':
120			case 'date_modified':
121			$this->accessor->setValue($item, $key, new DateTime($value));
122			break;
123
124			default:
125			$this->accessor->setValue($item, $key, $value);
126			}
127			}
128
129			return $item;
			0 ignored issues – show Bug Compatibility introduced 2017-05-28 23:27 UTC by Report Bug Copy Issue Report The expression `return $item;` of type `object\|array` is incompatible with the return type documented by `JDecool\JsonFeed\Reader\...eedReader::readItemNode` of type `JDecool\JsonFeed\Item` as it can also be of type `array` which is not included in this return type. Loading history...
130			}
131
132			/**
133			* Browse author node
134			*
135			* @param array $content
136			* @return Author
137			*/
138			private function readAuthorNode(array $content)
139			{
140			$name = (isset($content['name'])) ? $content['name'] : '';
141
142			$author = new Author($name);
143			foreach ($content as $key => $value) {
144			if ('name' === $key) {
145			continue;
146			}
147
148			$this->accessor->setValue($author, $key, $value);
149			}
150
151			return $author;
			0 ignored issues – show Bug Compatibility introduced 2017-05-28 23:27 UTC by Report Bug Copy Issue Report The expression `return $author;` of type `object\|array` is incompatible with the return type documented by `JDecool\JsonFeed\Reader\...dReader::readAuthorNode` of type `JDecool\JsonFeed\Author` as it can also be of type `array` which is not included in this return type. Loading history...
152			}
153
154			/**
155			* Browse hub node
156			*
157			* @param array $content
158			* @return Hub
159			*/
160			private function readHubNode(array $content)
161			{
162			$type = isset($content['type']) ? $content['type'] : '';
163			$url = isset($content['url']) ? $content['url'] : '';
164
165			return new Hub($type, $url);
166			}
167
168			/**
169			* Browse attachment node
170			*
171			* @param array $content
172			* @return Attachment
173			*/
174			private function readAttachmentNode(array $content)
175			{
176			$url = isset($content['url']) ? $content['url'] : '';
177			$mimeType = isset($content['mime_type']) ? $content['mime_type'] : '';
178
179			$attachment = new Attachment($url, $mimeType);
180			foreach ($content as $key => $value) {
181			switch ($key) {
182			case 'size_in_bytes':
183			$attachment->setSize($value);
184			break;
185
186			case 'duration_in_seconds':
187			$attachment->setDuration($value);
188			break;
189			}
190			}
191
192			return $attachment;
193			}
194			}
195

jdecool / jsonfeed

Push — master ( cf8ab0...30f4d3 )

FeedReader::readFeedNode() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like