TimeEntry::update() - Code Metrics - Inspection of "Time entry API" - jdecool/clockify-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Jérémy

created 2019-09-28 12:53 UTC

TimeEntry::update() A

↳ Parent: TimeEntry

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
c	1
b	0
f	0
dl	0
loc	5
rs	10
cc	1
nc	1
nop	3

<?php

declare(strict_types=1);

namespace JDecool\Clockify\Api\TimeEntry;

use JDecool\Clockify\{
    Client,
    Exception\ClockifyException,
    Model\TimeEntryDtoImpl
};

class TimeEntry
{
    private $http;

    public function __construct(Client $http)
    {
        $this->http = $http;
    }

    public function create(string $workspaceId, TimeEntryRequest $request): TimeEntryDtoImpl
    {
        $data = $this->http->post("/workspaces/$workspaceId/time-entries", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function update(string $workspaceId, string $id, UpdateTimeEntryRequest $request): TimeEntryDtoImpl
filter:
    dependency_paths: ["lib/*"]
    {
        $data = $this->http->put("/workspaces/$workspaceId/time-entries/$id", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function entry(string $workspaceId, string $id, array $params = []): TimeEntryDtoImpl
    {
        if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
            throw new ClockifyException('Invalid "consider-duration-format" parameter (should be a boolean value)');
        }

        if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
            throw new ClockifyException('Invalid "hydrated" parameter (should be a boolean value)');
        }

        $data = $this->http->get("/workspaces/$workspaceId/time-entries/$id", $params);

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function delete(string $workspaceId, string $id): void
    {
        $this->http->delete("/workspaces/$workspaceId/time-entries/$id");
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace JDecool\Clockify\Api\TimeEntry;
6
7			use JDecool\Clockify\{
8			Client,
9			Exception\ClockifyException,
10			Model\TimeEntryDtoImpl
11			};
12
13			class TimeEntry
14			{
15			private $http;
16
17			public function __construct(Client $http)
18			{
19			$this->http = $http;
20			}
21
22			public function create(string $workspaceId, TimeEntryRequest $request): TimeEntryDtoImpl
23			{
24			$data = $this->http->post("/workspaces/$workspaceId/time-entries", $request->toArray());
25
26			return TimeEntryDtoImpl::fromArray($data);
27			}
28
29			public function update(string $workspaceId, string $id, UpdateTimeEntryRequest $request): TimeEntryDtoImpl
			0 ignored issues – show Bug introduced 2019-09-28 12:56 UTC by Report Bug Copy Issue Report The type `JDecool\Clockify\Api\Tim...\UpdateTimeEntryRequest` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
30			{
31			$data = $this->http->put("/workspaces/$workspaceId/time-entries/$id", $request->toArray());
32
33			return TimeEntryDtoImpl::fromArray($data);
34			}
35
36			public function entry(string $workspaceId, string $id, array $params = []): TimeEntryDtoImpl
37			{
38			if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
39			throw new ClockifyException('Invalid "consider-duration-format" parameter (should be a boolean value)');
40			}
41
42			if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
43			throw new ClockifyException('Invalid "hydrated" parameter (should be a boolean value)');
44			}
45
46			$data = $this->http->get("/workspaces/$workspaceId/time-entries/$id", $params);
47
48			return TimeEntryDtoImpl::fromArray($data);
49			}
50
51			public function delete(string $workspaceId, string $id): void
52			{
53			$this->http->delete("/workspaces/$workspaceId/time-entries/$id");
54			}
55			}
56

jdecool / clockify-api

Pull Request — master (#1)

TimeEntry::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like