jdecool /
clockify-api
| Conditions | 11 |
| Paths | 5 |
| Total Lines | 25 |
| Code Lines | 13 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | public function tasks(string $workspaceId, string $projectId, array $params = []): array |
||
| 24 | { |
||
| 25 | if (isset($params['is-active']) && !is_bool($params['is-active'])) { |
||
| 26 | throw new ClockifyException('Invalid "is-active" parameter (should be a boolean value)'); |
||
| 27 | } |
||
| 28 | |||
| 29 | if (isset($params['name']) && empty($params['name'])) { |
||
| 30 | throw new ClockifyException('Invalid "name" parameter'); |
||
| 31 | } |
||
| 32 | |||
| 33 | if (isset($params['page']) && (!is_int($params['page']) || $params['page'] < 1)) { |
||
| 34 | throw new ClockifyException('Invalid "page" parameter'); |
||
| 35 | } |
||
| 36 | |||
| 37 | if (isset($params['page-size']) && (!is_int($params['page-size']) || $params['page-size'] < 1)) { |
||
| 38 | throw new ClockifyException('Invalid "page-size" parameter'); |
||
| 39 | } |
||
| 40 | |||
| 41 | $data = $this->http->get("/workspaces/$workspaceId/projects/$projectId/tasks", $params); |
||
| 42 | |||
| 43 | return array_map( |
||
| 44 | static function(array $task): TaskDto { |
||
| 45 | return TaskDto::fromArray($task); |
||
| 46 | }, |
||
| 47 | $data |
||
| 48 | ); |
||
| 58 |
