TimeEntry::find() - Code Metrics - Inspection of "Merge pull request #1 from jdecool/time-entry-api" - jdecool/clockify-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5cc7cd...19c82c )

by Jérémy

created 2019-09-30 18:22 UTC

TimeEntry::find() D

↳ Parent: TimeEntry

Complexity

Conditions	29
Paths	14

Size

Total Lines	61
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	31
c	1
b	0
f	0
dl	0
loc	61
rs	4.1666
cc	29
nc	14
nop	3

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace JDecool\Clockify\Api\TimeEntry;

use JDecool\Clockify\{
    Client,
    Exception\ClockifyException,
    Model\TimeEntryDtoImpl
};

class TimeEntry
{
    private $http;

    public function __construct(Client $http)
    {
        $this->http = $http;
    }

    public function create(string $workspaceId, TimeEntryRequest $request): TimeEntryDtoImpl
    {
        $data = $this->http->post("/workspaces/$workspaceId/time-entries", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function createForUser(string $workspaceId, string $userId, TimeEntryRequest $request): TimeEntryDtoImpl
    {
        $data = $this->http->post("/workspaces/$workspaceId/user/$userId/time-entries", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function update(string $workspaceId, string $id, UpdateTimeEntryRequest $request): TimeEntryDtoImpl
    {
        $data = $this->http->put("/workspaces/$workspaceId/time-entries/$id", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function entry(string $workspaceId, string $id, array $params = []): TimeEntryDtoImpl
    {
        if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
            throw new ClockifyException('Invalid "consider-duration-format" parameter (should be a boolean value)');
        }

        if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
            throw new ClockifyException('Invalid "hydrated" parameter (should be a boolean value)');
        }

        $data = $this->http->get("/workspaces/$workspaceId/time-entries/$id", $params);

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function delete(string $workspaceId, string $id): void
    {
        $this->http->delete("/workspaces/$workspaceId/time-entries/$id");
    }

    public function stopRunningTime(string $workspaceId, string $userId, StopTimeEntryRequest $request): TimeEntryDtoImpl
    {
        $data = $this->http->patch("/workspaces/$workspaceId/user/$userId/time-entries", $request->toArray());

        return TimeEntryDtoImpl::fromArray($data);
    }

    public function find(string $workspaceId, string $userId, array $params = []): array
    {
        if (isset($params['description']) && !is_string($params['description'])) {
            throw new ClockifyException('Invalid "description" parameter');
        }

        if (isset($params['start']) && !is_string($params['start'])) {
            throw new ClockifyException('Invalid "start" parameter');
        }

        if (isset($params['end']) && !is_string($params['end'])) {
            throw new ClockifyException('Invalid "end" parameter');
        }

        if (isset($params['project']) && !is_string($params['project'])) {
            throw new ClockifyException('Invalid "project" parameter');
        }

        if (isset($params['task']) && !is_string($params['task'])) {
            throw new ClockifyException('Invalid "task" parameter');
        }

        if (isset($params['tags']) && !is_array($params['tags'])) {
            throw new ClockifyException('Invalid "tags" parameter');
        }

        if (isset($params['project-required']) && !is_bool($params['project-required'])) {
            throw new ClockifyException('Invalid "project-required" parameter');
        }

        if (isset($params['task-required']) && !is_bool($params['task-required'])) {
            throw new ClockifyException('Invalid "task-required" parameter');
        }

        if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
            throw new ClockifyException('Invalid "consider-duration-format" parameter');
        }

        if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
            throw new ClockifyException('Invalid "hydrated" parameter');
        }

        if (isset($params['in-progress']) && !is_bool($params['in-progress'])) {
            throw new ClockifyException('Invalid "in-progress" parameter');
        }

        if (isset($params['page']) && (!is_int($params['page']) || $params['page'] < 1)) {
            throw new ClockifyException('Invalid "page" parameter');
        }

        if (isset($params['page-size']) && (!is_int($params['page-size']) || $params['page-size'] < 1)) {
            throw new ClockifyException('Invalid "page-size" parameter');
        }

        $data = $this->http->get("/workspaces/$workspaceId/user/$userId/time-entries", $params);

        return array_map(
            static function(array $timeEntry): TimeEntryDtoImpl {
                return TimeEntryDtoImpl::fromArray($timeEntry);
            },
            $data
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace JDecool\Clockify\Api\TimeEntry;
6
7			use JDecool\Clockify\{
8			Client,
9			Exception\ClockifyException,
10			Model\TimeEntryDtoImpl
11			};
12
13			class TimeEntry
14			{
15			private $http;
16
17			public function __construct(Client $http)
18			{
19			$this->http = $http;
20			}
21
22			public function create(string $workspaceId, TimeEntryRequest $request): TimeEntryDtoImpl
23			{
24			$data = $this->http->post("/workspaces/$workspaceId/time-entries", $request->toArray());
25
26			return TimeEntryDtoImpl::fromArray($data);
27			}
28
29			public function createForUser(string $workspaceId, string $userId, TimeEntryRequest $request): TimeEntryDtoImpl
30			{
31			$data = $this->http->post("/workspaces/$workspaceId/user/$userId/time-entries", $request->toArray());
32
33			return TimeEntryDtoImpl::fromArray($data);
34			}
35
36			public function update(string $workspaceId, string $id, UpdateTimeEntryRequest $request): TimeEntryDtoImpl
37			{
38			$data = $this->http->put("/workspaces/$workspaceId/time-entries/$id", $request->toArray());
39
40			return TimeEntryDtoImpl::fromArray($data);
41			}
42
43			public function entry(string $workspaceId, string $id, array $params = []): TimeEntryDtoImpl
44			{
45			if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
46			throw new ClockifyException('Invalid "consider-duration-format" parameter (should be a boolean value)');
47			}
48
49			if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
50			throw new ClockifyException('Invalid "hydrated" parameter (should be a boolean value)');
51			}
52
53			$data = $this->http->get("/workspaces/$workspaceId/time-entries/$id", $params);
54
55			return TimeEntryDtoImpl::fromArray($data);
56			}
57
58			public function delete(string $workspaceId, string $id): void
59			{
60			$this->http->delete("/workspaces/$workspaceId/time-entries/$id");
61			}
62
63			public function stopRunningTime(string $workspaceId, string $userId, StopTimeEntryRequest $request): TimeEntryDtoImpl
64			{
65			$data = $this->http->patch("/workspaces/$workspaceId/user/$userId/time-entries", $request->toArray());
66
67			return TimeEntryDtoImpl::fromArray($data);
68			}
69
70			public function find(string $workspaceId, string $userId, array $params = []): array
71			{
72			if (isset($params['description']) && !is_string($params['description'])) {
73			throw new ClockifyException('Invalid "description" parameter');
74			}
75
76			if (isset($params['start']) && !is_string($params['start'])) {
77			throw new ClockifyException('Invalid "start" parameter');
78			}
79
80			if (isset($params['end']) && !is_string($params['end'])) {
81			throw new ClockifyException('Invalid "end" parameter');
82			}
83
84			if (isset($params['project']) && !is_string($params['project'])) {
85			throw new ClockifyException('Invalid "project" parameter');
86			}
87
88			if (isset($params['task']) && !is_string($params['task'])) {
89			throw new ClockifyException('Invalid "task" parameter');
90			}
91
92			if (isset($params['tags']) && !is_array($params['tags'])) {
93			throw new ClockifyException('Invalid "tags" parameter');
94			}
95
96			if (isset($params['project-required']) && !is_bool($params['project-required'])) {
97			throw new ClockifyException('Invalid "project-required" parameter');
98			}
99
100			if (isset($params['task-required']) && !is_bool($params['task-required'])) {
101			throw new ClockifyException('Invalid "task-required" parameter');
102			}
103
104			if (isset($params['consider-duration-format']) && !is_bool($params['consider-duration-format'])) {
105			throw new ClockifyException('Invalid "consider-duration-format" parameter');
106			}
107
108			if (isset($params['hydrated']) && !is_bool($params['hydrated'])) {
109			throw new ClockifyException('Invalid "hydrated" parameter');
110			}
111
112			if (isset($params['in-progress']) && !is_bool($params['in-progress'])) {
113			throw new ClockifyException('Invalid "in-progress" parameter');
114			}
115
116			if (isset($params['page']) && (!is_int($params['page']) \|\| $params['page'] < 1)) {
117			throw new ClockifyException('Invalid "page" parameter');
118			}
119
120			if (isset($params['page-size']) && (!is_int($params['page-size']) \|\| $params['page-size'] < 1)) {
121			throw new ClockifyException('Invalid "page-size" parameter');
122			}
123
124			$data = $this->http->get("/workspaces/$workspaceId/user/$userId/time-entries", $params);
125
126			return array_map(
127			static function(array $timeEntry): TimeEntryDtoImpl {
128			return TimeEntryDtoImpl::fromArray($timeEntry);
129			},
130			$data
131			);
132			}
133			}
134

jdecool / clockify-api

Push — master ( 5cc7cd...19c82c )

TimeEntry::find() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like