Project::create() - Code Metrics - Inspection of "Delete suffixes in 'create' and 'delete' methods" - jdecool/clockify-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b6e1f4...929753 )

by Jérémy

created 2019-09-21 15:20 UTC

Project::create() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	2
c	0
b	0
f	0
dl	0
loc	5
rs	10
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

namespace JDecool\Clockify\Api\Project;

use JDecool\Clockify\{
    Client,
    Exception\ClockifyException,
    Model\ProjectDtoImpl
};

class Project
{
    private $http;

    public function __construct(Client $http)
    {
        $this->http = $http;
    }

    /**
     * @return ProjectDtoImpl[]
     */
    public function projects(string $workspaceId, array $params = []): array
    {
        if (isset($params['name']) && empty($params['name'])) {
            throw new ClockifyException('Invalid "name" parameter');
        }

        if (isset($params['page']) && (!is_int($params['page']) || $params['page'] < 1)) {
            throw new ClockifyException('Invalid "page" parameter');
        }

        if (isset($params['page-size']) && (!is_int($params['page-size']) || $params['page-size'] < 1)) {
            throw new ClockifyException('Invalid "page-size" parameter');
        }

        $data = $this->http->get("/workspaces/$workspaceId/projects", $params);

        return array_map(
            static function(array $project): ProjectDtoImpl {
                return ProjectDtoImpl::fromArray($project);
            },
            $data
        );
    }

    public function create(string $workspaceId, ProjectRequest $request): ProjectDtoImpl
    {
        $data = $this->http->post(" /workspaces/$workspaceId/projects", $request->toArray());

        return ProjectDtoImpl::fromArray($data);
    }

    public function delete(string $workspaceId, string $projectId): void
    {
        $this->http->delete("/workspaces/$workspaceId/projects/$projectId");
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace JDecool\Clockify\Api\Project;
6
7			use JDecool\Clockify\{
8			Client,
9			Exception\ClockifyException,
10			Model\ProjectDtoImpl
11			};
12
13			class Project
14			{
15			private $http;
16
17			public function __construct(Client $http)
18			{
19			$this->http = $http;
20			}
21
22			/**
23			* @return ProjectDtoImpl[]
24			*/
25			public function projects(string $workspaceId, array $params = []): array
26			{
27			if (isset($params['name']) && empty($params['name'])) {
28			throw new ClockifyException('Invalid "name" parameter');
29			}
30
31			if (isset($params['page']) && (!is_int($params['page']) \|\| $params['page'] < 1)) {
32			throw new ClockifyException('Invalid "page" parameter');
33			}
34
35			if (isset($params['page-size']) && (!is_int($params['page-size']) \|\| $params['page-size'] < 1)) {
36			throw new ClockifyException('Invalid "page-size" parameter');
37			}
38
39			$data = $this->http->get("/workspaces/$workspaceId/projects", $params);
40
41			return array_map(
42			static function(array $project): ProjectDtoImpl {
43			return ProjectDtoImpl::fromArray($project);
44			},
45			$data
46			);
47			}
48
49			public function create(string $workspaceId, ProjectRequest $request): ProjectDtoImpl
50			{
51			$data = $this->http->post(" /workspaces/$workspaceId/projects", $request->toArray());
52
53			return ProjectDtoImpl::fromArray($data);
54			}
55
56			public function delete(string $workspaceId, string $projectId): void
57			{
58			$this->http->delete("/workspaces/$workspaceId/projects/$projectId");
59			}
60			}
61

jdecool / clockify-api

Push — master ( b6e1f4...929753 )

Project::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like