Preview::toArray() - Code Metrics - Inspection of "template update and bug fix:" - jclyons52/page-preview - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1bccbc...1c724d )

by Joseph

created 2016-04-15 06:45 UTC

Preview::toArray() A

↳ Parent: Preview

Complexity

Conditions	3
Paths	4

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	3

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	20
ccs	15
cts	15
cp	1
rs	9.4285
cc	3
eloc	13
nc	4
nop	0
crap	3

<?php

namespace Jclyons52\PagePreview;

use League\Plates\Engine;

class Preview
{
    public $url;
    
    public $title;
    
    public $description;
    
    public $images;

    public $meta;
    
    public $media = false;
    
    private $viewPath;
    
    public function __construct(Media $mediaObj, $data)
    {
        $this->url = $data['url'];
        
        $this->title = $data['title'];
        
        $this->description = $data['description'];
        
        $this->images = $data['images'];
        
        $this->meta = new Meta($data['meta']);

        $media = $mediaObj->get($data['url']);
        
        if ($media !== []) {
            $this->media = $media;

        }
        
        $this->viewPath = __DIR__ . '/Templates';
    }

    /**
     * @param string $viewPath
     */
    public function setViewPath($viewPath)
    {
        $this->viewPath = $viewPath;
    }

    /**
     * @param string $type
     * @return string
     */
    public function render($type = null)
    {
        $templates = new Engine($this->viewPath);

        if ($type === null) {
            if ($this->media === false) {
                $type = 'media';
            } else {
                $type = 'thumbnail';
            }

        }

        return $templates->render($type, $this->toArray());
    }

    /**
     * @return array
     */
    public function toArray()
    {

        $title = $this->title;

        if (array_key_exists('title', $this->meta)) {
            $title = $this->meta['title'];
        }
        if (count($this->images) < 1) {
            $this->images[0] = null;
        }
        return [
            'title' => $title,
            'images' => $this->images,
            'description' => $this->description,
            'url' => $this->url,
            'meta' => $this->meta,
            'media' => $this->media,
        ];
    }

    /**
     * @return string
     */
    public function toJson()
    {
        return json_encode($this->toArray());
    }
}


1		<?php
2
3		namespace Jclyons52\PagePreview;
4
5		use League\Plates\Engine;
6
7		class Preview
8		{
9		public $url;
10
11		public $title;
12
13		public $description;
14
15		public $images;
16
17		public $meta;
18
19		public $media = false;
20
21		private $viewPath;
22
23	45	public function __construct(Media $mediaObj, $data)
24		{
25	45	$this->url = $data['url'];
26
27	45	$this->title = $data['title'];
28
29	45	$this->description = $data['description'];
30
31	45	$this->images = $data['images'];
32
33	45	$this->meta = new Meta($data['meta']);
34
35	45	$media = $mediaObj->get($data['url']);
36
37	45	if ($media !== []) {
38	3	$this->media = $media;
		0 ignored issues – show Documentation Bug introduced 2016-04-13 01:17 UTC by Report Bug Copy Issue Report It seems like `$media` of type `array` is incompatible with the declared type `boolean` of property `$media`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
39	3	}
40
41	45	$this->viewPath = __DIR__ . '/Templates';
42	45	}
43
44		/**
45		* @param string $viewPath
46		*/
47	3	public function setViewPath($viewPath)
48		{
49	3	$this->viewPath = $viewPath;
50	3	}
51
52		/**
53		* @param string $type
54		* @return string
55		*/
56	15	public function render($type = null)
57	3	{
58	15	$templates = new Engine($this->viewPath);
59
60	15	if ($type === null) {
61	9	if ($this->media === false) {
62	9	$type = 'media';
63	9	} else {
64		$type = 'thumbnail';
65		}
66
67	9	}
68
69	15	return $templates->render($type, $this->toArray());
70		}
71
72		/**
73		* @return array
74		*/
75	18	public function toArray()
76		{
77
78	18	$title = $this->title;
79
80	18	if (array_key_exists('title', $this->meta)) {
81	15	$title = $this->meta['title'];
82	15	}
83	18	if (count($this->images) < 1) {
84	3	$this->images[0] = null;
85	3	}
86		return [
87	18	'title' => $title,
88	18	'images' => $this->images,
89	18	'description' => $this->description,
90	18	'url' => $this->url,
91	18	'meta' => $this->meta,
92	18	'media' => $this->media,
93	18	];
94		}
95
96		/**
97		* @return string
98		*/
99	3	public function toJson()
100		{
101	3	return json_encode($this->toArray());
102		}
103		}
104

jclyons52 / page-preview

Push — master ( 1bccbc...1c724d )

Preview::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like