JClaveau\LogicalFilter\Rule\BelowRule

Complexity

Total Complexity

12

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	hasSolution()	0	12	5
A	__construct()	0	15	4
A	getValues()	0	3	1
A	getUpperLimit()	0	3	1
A	getMaximum()	0	3	1

<?php
namespace JClaveau\LogicalFilter\Rule;

/**
 * a < x
 */
class BelowRule extends AbstractAtomicRule
{
    /** @var string operator */
    const operator = '<';

    /** @var scalar $minimum */
    protected $maximum;

    /**
     * @param string $field The field to apply the rule on.
     * @param array  $value The value the field can below to.
     */
    public function __construct( $field, $maximum )
    {
        if (    !is_scalar($maximum)
            &&  !$maximum instanceof \DateTimeInterface
            &&  null !== $maximum
        ) {
            throw new \InvalidArgumentException(
                 "Maximum parameter must be a scalar or null "
                ."or implements DateTimeInterface instead of: "
                .var_export($maximum, true)
            );
        }

        $this->field   = $field;
        $this->maximum = $maximum;
    }

    /**
     * Checks if the rule do not expect the value to be above infinity.
     *
     * @return bool
     */
    public function hasSolution(array $contextual_options=[])

The parameter $contextual_options is not used and could be removed.

    {
        // if minimum is null, the rule is equivalent to true
        if (is_numeric( $this->maximum )) {
            if (is_nan( $this->maximum ))

It seems like $this->maximum can also be of type string; however, parameter $val of is_nan() does only seem to accept double, maybe add an additional type check?

                return false;

            if (is_infinite( $this->maximum ) && $this->maximum < 0)

It seems like $this->maximum can also be of type string; however, parameter $val of is_infinite() does only seem to accept double, maybe add an additional type check?

                return false;
        }

        return true;
    }

    /**
     * @deprecated getUpperLimit
     */
    public function getMaximum()
    {
        return $this->maximum;
    }

    /**
     */
    public function getUpperLimit()
    {
        return $this->maximum;
    }

    /**
     */
    public function getValues()
    {
        return $this->getMaximum();

The function JClaveau\LogicalFilter\Rule\BelowRule::getMaximum() has been deprecated: getUpperLimit

    }

    /**/
}