BetweenOrEqualUpperRule - Code Metrics - jclaveau/php-logical-filter - Measure and Improve Code Quality continuously with Scrutinizer

BetweenOrEqualUpperRule A
last analyzed 2019-08-15 22:31 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	61
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

95.45%

Importance

Changes

Metric	Value
dl	61
loc	61
ccs	21
cts	22
cp	0.9545
rs	10
c	0
b	0
f	0
wmc	8
lcom	1
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	2
A	getMinimum()	8	8	2
A	getMaximum()	12	12	3
A	getValues()	7	7	1

How to fix Duplicated Code

<?php
/**
 * BetweenOrEqualUpperRule
 *
 * @package php-logical-filter
 * @author  Jean Claveau
 */
namespace JClaveau\LogicalFilter\Rule;

class BetweenOrEqualUpperRule extends BetweenRule

{
    /** @var string operator */
    const operator = '><=';

    /**
     */
    public function __construct( $field, array $limits )
    {
        if ($limits[0] == $limits[1]) {
            // A > 1 && (A = 1 || A < 1) <=> no sens
            // So if the two limits are equal we only consider the equality
            $this->addOperand( new EqualRule($field, $limits[0]) );
            $this->addOperand( new EqualRule($field, $limits[0]) );
        }
        else {
            $this->addOperand( new AboveRule($field, $limits[0]) );
            $this->addOperand( new BelowOrEqualRule($field, $limits[1]) );
        }
    }

    /**
     * @return mixed
     */
    public function getMinimum()
    {
        if ($this->getOperandAt(0) instanceof EqualRule) {
            return $this->getOperandAt(0)->getValue();
        }

        return $this->getOperandAt(0)->getMinimum();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * @return mixed
     */
    public function getMaximum()
    {
        if ( ! $this->getOperandAt(1)) {
            return $this->getOperandAt(0)->getValue();

        }

        if ($this->getOperandAt(1) instanceof EqualRule) {
            return $this->getOperandAt(1)->getValue();
        }

        return $this->getOperandAt(1)->getMaximum();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     */
    public function getValues()
    {
        return [
            $this->getMinimum(),
            $this->getMaximum(),
        ];
    }

    /**/
}


1			<?php
2			/**
3			* BetweenOrEqualUpperRule
4			*
5			* @package php-logical-filter
6			* @author Jean Claveau
7			*/
8			namespace JClaveau\LogicalFilter\Rule;
9
10		View Code Duplication	class BetweenOrEqualUpperRule extends BetweenRule
			0 ignored issues – show Duplication introduced 2018-12-30 16:52 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			/** @var string operator */
13			const operator = '><=';
14
15			/**
16			*/
17	11		public function __construct( $field, array $limits )
18			{
19	11		if ($limits[0] == $limits[1]) {
20			// A > 1 && (A = 1 \|\| A < 1) <=> no sens
21			// So if the two limits are equal we only consider the equality
22	1		$this->addOperand( new EqualRule($field, $limits[0]) );
23	1		$this->addOperand( new EqualRule($field, $limits[0]) );
24	1		}
25			else {
26	10		$this->addOperand( new AboveRule($field, $limits[0]) );
27	10		$this->addOperand( new BelowOrEqualRule($field, $limits[1]) );
28			}
29	11		}
30
31			/**
32			* @return mixed
33			*/
34	11		public function getMinimum()
35			{
36	11		if ($this->getOperandAt(0) instanceof EqualRule) {
37	1		return $this->getOperandAt(0)->getValue();
38			}
39
40	10		return $this->getOperandAt(0)->getMinimum();
			0 ignored issues – show Bug introduced 2018-12-30 16:52 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `JClaveau\LogicalFilter\Rule\AbstractRule` as the method `getMinimum()` does only exist in the following sub-classes of `JClaveau\LogicalFilter\Rule\AbstractRule`: `JClaveau\LogicalFilter\Rule\AboveOrEqualRule`, `JClaveau\LogicalFilter\Rule\AboveRule`, `JClaveau\LogicalFilter\Rule\BetweenOrEqualBothRule`, `JClaveau\LogicalFilter\R...BetweenOrEqualLowerRule`, `JClaveau\LogicalFilter\R...BetweenOrEqualUpperRule`, `JClaveau\LogicalFilter\Rule\BetweenRule`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41			}
42
43			/**
44			* @return mixed
45			*/
46	11		public function getMaximum()
47			{
48	11		if ( ! $this->getOperandAt(1)) {
49	1		return $this->getOperandAt(0)->getValue();
			0 ignored issues – show Bug introduced 2018-12-30 16:52 UTC by Report Bug Copy Issue Report The method `getValue` cannot be called on `$this->getOperandAt(0)` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
50			}
51
52	10		if ($this->getOperandAt(1) instanceof EqualRule) {
53			return $this->getOperandAt(1)->getValue();
54			}
55
56	10		return $this->getOperandAt(1)->getMaximum();
			0 ignored issues – show Bug introduced 2018-12-30 16:52 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `JClaveau\LogicalFilter\Rule\AbstractRule` as the method `getMaximum()` does only exist in the following sub-classes of `JClaveau\LogicalFilter\Rule\AbstractRule`: `JClaveau\LogicalFilter\Rule\BelowOrEqualRule`, `JClaveau\LogicalFilter\Rule\BelowRule`, `JClaveau\LogicalFilter\Rule\BetweenOrEqualBothRule`, `JClaveau\LogicalFilter\R...BetweenOrEqualLowerRule`, `JClaveau\LogicalFilter\R...BetweenOrEqualUpperRule`, `JClaveau\LogicalFilter\Rule\BetweenRule`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
57			}
58
59			/**
60			*/
61	11		public function getValues()
62			{
63			return [
64	11		$this->getMinimum(),
65	11		$this->getMaximum(),
66	11		];
67			}
68
69			/**/
70			}
71

jclaveau / php-logical-filter

BetweenOrEqualUpperRule A last analyzed 2019-08-15 22:31 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

BetweenOrEqualUpperRule A
last analyzed 2019-08-15 22:31 UTC