JClaveau\LogicalFilter\Rule\AboveRule

Complexity

Total Complexity

12

Size/Duplication

Total Lines	75
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	16	16	4
A	getMinimum()	4	4	1
A	getLowerLimit()	4	4	1
A	getValues()	4	4	1
A	hasSolution()	15	15	5

<?php
namespace JClaveau\LogicalFilter\Rule;

/**
 * a > x
 */
class AboveRule extends AbstractAtomicRule

This class seems to be duplicated in your project.

{
    /** @var string operator */
    const operator = '>';

    /** @var scalar $minimum */
    protected $minimum;

    /**
     * @param string $field The field to apply the rule on.
     * @param array  $value The value the field can above to.

There is no parameter named $value. Was it maybe removed?

     */
    public function __construct( $field, $minimum )
    {
        if (   ! is_scalar($minimum)
            && ! $minimum instanceof \DateTimeInterface
            && null !== $minimum
        ) {
            throw new \InvalidArgumentException(
                "Minimum parameter must be a scalar or null "
                ."or implements DateTimeInterface instead of: "
                .var_export($minimum, true)
            );
        }

        $this->field   = $field;
        $this->minimum = $minimum;
    }

    /**
     * @deprecated getLowerLimit
     */
    public function getMinimum()
    {
        return $this->minimum;
    }

    /**
     */
    public function getLowerLimit()
    {
        return $this->minimum;
    }

    /**
     * @return array

Should the return type not be integer|double|string|boolean?

     */
    public function getValues()
    {
        return $this->getMinimum();

The method JClaveau\LogicalFilter\Rule\AboveRule::getMinimum() has been deprecated with message: getLowerLimit

    }

    /**
     * Checks if the rule do not expect the value to be above infinity.
     *
     * @return bool
     */
    public function hasSolution(array $simplification_options=[])
    {
        // if minimum is null, the rule is equivalent to true
        if (is_numeric( $this->minimum )) {
            if (is_nan( $this->minimum )) {
                return false;
            }

            if (is_infinite( $this->minimum ) && $this->minimum > 0) {
                return false;
            }
        }

        return true;
    }

    /**/
}