JClaveau\LogicalFilter\Converter\MinimalConverter

Complexity

Total Complexity

9

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

83.87%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	convert()	0	45	9

<?php
/**
 * MinimalConverter
 *
 * @package php-logical-filter
 * @author  Jean Claveau
 */
namespace JClaveau\LogicalFilter\Converter;

use       JClaveau\LogicalFilter\Converter\ConverterInterface;
use       JClaveau\LogicalFilter\LogicalFilter;

/**
 * Basic tools to implements minimal converters: Converters that can
 * handle simplified filters with or/and/atomic structure.
 */
abstract class MinimalConverter implements ConverterInterface
{
    /**
     * @param LogicalFilter $filter
     */
    public function convert( LogicalFilter $filter )
    {
        $rootOr = $filter->simplify(['force_logical_core' => true])->getRules();

        // TODO remove this once TrueRule implemented https://github.com/jclaveau/php-logical-filter/issues/59
        if (null === $rootOr) {
            return $this;
        }

        if ( ! $rootOr->hasSolution()) {
            return $this;
        }

        foreach ($rootOr->getOperands() as $andOperand) {
            $this->onOpenOr();
            $operandsByFields = $andOperand->groupOperandsByFieldAndOperator();

It seems like you code against a specific sub-type and not the parent class JClaveau\LogicalFilter\Rule\AbstractRule as the method groupOperandsByFieldAndOperator() does only exist in the following sub-classes of JClaveau\LogicalFilter\Rule\AbstractRule: JClaveau\LogicalFilter\Rule\AboveOrEqualRule, JClaveau\LogicalFilter\Rule\AbstractOperationRule, JClaveau\LogicalFilter\Rule\AndRule, JClaveau\LogicalFilter\Rule\BelowOrEqualRule, JClaveau\LogicalFilter\Rule\BetweenOrEqualBothRule, JClaveau\LogicalFilter\Rule\BetweenOrEqualLowerRule, JClaveau\LogicalFilter\Rule\BetweenOrEqualUpperRule, JClaveau\LogicalFilter\Rule\BetweenRule, JClaveau\LogicalFilter\Rule\InRule, JClaveau\LogicalFilter\Rule\NotEqualRule, JClaveau\LogicalFilter\Rule\NotInRule, JClaveau\LogicalFilter\Rule\NotRule, JClaveau\LogicalFilter\Rule\OrRule. Maybe you want to instanceof check for one of these explicitly?

            foreach ($operandsByFields as $field => $operandsByOperator) {
                foreach ($operandsByOperator as $operator => $operandsOfOperator) {
                    if (1 != count($operandsOfOperator)) {
                        throw new \RuntimeException(
                             "Once a logical filter is simplified, there MUST be "
                            ."no more than one operand by operator instead of for '$field' / '$operator': "
                            .var_export($operandsOfOperator, true)
                        );
                    }

                    $operandsByFields[ $field ][ $operator ] = $operandsOfOperator[0];
                }
            }

            foreach ($operandsByFields as $field => $operandsByOperator) {
                foreach ($operandsByOperator as $operator => $operand) {
                    $this->onAndPossibility(
                        $field,
                        $operator,
                        $operand,
                        $operandsByFields
                    );
                }
            }

            $this->onCloseOr();
        }
    }

    /**/
}