@@ -31,8 +31,9 @@ discard block |
||
| 31 | 31 | { |
| 32 | 32 | Arrays::mustBeCountable($data); |
| 33 | 33 | |
| 34 | - if ($data instanceof self) |
|
| 35 | - return $data; |
|
| 34 | + if ($data instanceof self) { |
|
| 35 | + return $data; |
|
| 36 | + } |
|
| 36 | 37 | |
| 37 | 38 | return new static($data, $isConstant); |
| 38 | 39 | } |
@@ -101,8 +102,7 @@ discard block |
||
| 101 | 102 | { |
| 102 | 103 | if ($this->isConstant) { |
| 103 | 104 | return new static($out); |
| 104 | - } |
|
| 105 | - else { |
|
| 105 | + } else { |
|
| 106 | 106 | $this->data = $out; |
| 107 | 107 | return $this; |
| 108 | 108 | } |
@@ -26,8 +26,9 @@ discard block |
||
| 26 | 26 | $out = []; |
| 27 | 27 | foreach ($this->data as $key => &$row) { |
| 28 | 28 | |
| 29 | - if ($index_key) |
|
| 30 | - $key = $row[$index_key]; |
|
| 29 | + if ($index_key) { |
|
| 30 | + $key = $row[$index_key]; |
|
| 31 | + } |
|
| 31 | 32 | |
| 32 | 33 | if (is_array($column_names)) { |
| 33 | 34 | $out[$key] = []; |
@@ -42,20 +43,16 @@ discard block |
||
| 42 | 43 | |
| 43 | 44 | $out[$key][$column_name] = $row[$column_name]; |
| 44 | 45 | } |
| 45 | - } |
|
| 46 | - else { |
|
| 46 | + } else { |
|
| 47 | 47 | // This avoids issues with isset, array_key_exists and |
| 48 | 48 | // null entries on objects and arrays. |
| 49 | 49 | if ($row instanceof static) { |
| 50 | 50 | $keys = $row->copy()->keys(); |
| 51 | - } |
|
| 52 | - elseif (is_array($row)) { |
|
| 51 | + } elseif (is_array($row)) { |
|
| 53 | 52 | $keys = array_keys($row); |
| 54 | - } |
|
| 55 | - elseif (is_scalar($row)) { |
|
| 53 | + } elseif (is_scalar($row)) { |
|
| 56 | 54 | $keys = []; |
| 57 | - } |
|
| 58 | - else { |
|
| 55 | + } else { |
|
| 59 | 56 | // todo : handle other classes supporting ArrayAccess? |
| 60 | 57 | $keys = []; |
| 61 | 58 | } |
@@ -101,16 +98,17 @@ discard block |
||
| 101 | 98 | */ |
| 102 | 99 | public function min($default_value=null) |
| 103 | 100 | { |
| 104 | - if ($this->isEmpty() && $default_value !== null) |
|
| 105 | - return $default_value; |
|
| 101 | + if ($this->isEmpty() && $default_value !== null) { |
|
| 102 | + return $default_value; |
|
| 103 | + } |
|
| 106 | 104 | |
| 107 | 105 | try { |
| 108 | 106 | return min($this->data); |
| 109 | - } |
|
| 110 | - catch (\Exception $e) { |
|
| 107 | + } catch (\Exception $e) { |
|
| 111 | 108 | $message = $e->getMessage(); |
| 112 | - if ($e->getMessage() == 'min(): Array must contain at least one element') |
|
| 113 | - $message .= ' or you can set a default value as parameter'; |
|
| 109 | + if ($e->getMessage() == 'min(): Array must contain at least one element') { |
|
| 110 | + $message .= ' or you can set a default value as parameter'; |
|
| 111 | + } |
|
| 114 | 112 | |
| 115 | 113 | $this->throwUsageException($message); |
| 116 | 114 | } |
@@ -124,16 +122,17 @@ discard block |
||
| 124 | 122 | */ |
| 125 | 123 | public function max($default_value=null) |
| 126 | 124 | { |
| 127 | - if ($this->isEmpty() && $default_value !== null) |
|
| 128 | - return $default_value; |
|
| 125 | + if ($this->isEmpty() && $default_value !== null) { |
|
| 126 | + return $default_value; |
|
| 127 | + } |
|
| 129 | 128 | |
| 130 | 129 | try { |
| 131 | 130 | return max($this->data); |
| 132 | - } |
|
| 133 | - catch (\Exception $e) { |
|
| 131 | + } catch (\Exception $e) { |
|
| 134 | 132 | $message = $e->getMessage(); |
| 135 | - if ($e->getMessage() == 'max(): Array must contain at least one element') |
|
| 136 | - $message .= ' or you can set a default value as parameter'; |
|
| 133 | + if ($e->getMessage() == 'max(): Array must contain at least one element') { |
|
| 134 | + $message .= ' or you can set a default value as parameter'; |
|
| 135 | + } |
|
| 137 | 136 | |
| 138 | 137 | $this->throwUsageException($message); |
| 139 | 138 | } |
@@ -200,16 +199,15 @@ discard block |
||
| 200 | 199 | if (PHP_VERSION_ID >= 50600) { |
| 201 | 200 | $out = array_filter($this->data, $callback, |
| 202 | 201 | ARRAY_FILTER_USE_BOTH); |
| 203 | - } |
|
| 204 | - else { |
|
| 202 | + } else { |
|
| 205 | 203 | $out = $this->data; |
| 206 | 204 | foreach ($out as $key => $value) { |
| 207 | - if (!$callback($value, $key)) |
|
| 208 | - unset( $out[$key] ); |
|
| 205 | + if (!$callback($value, $key)) { |
|
| 206 | + unset( $out[$key] ); |
|
| 207 | + } |
|
| 209 | 208 | } |
| 210 | 209 | } |
| 211 | - } |
|
| 212 | - else { |
|
| 210 | + } else { |
|
| 213 | 211 | $out = array_filter($this->data); |
| 214 | 212 | } |
| 215 | 213 | |
@@ -242,8 +240,9 @@ discard block |
||
| 242 | 240 | $out = []; |
| 243 | 241 | foreach ($this->data as $i => $data_item) { |
| 244 | 242 | |
| 245 | - if ($data_item == $item_to_remove) |
|
| 246 | - continue; |
|
| 243 | + if ($data_item == $item_to_remove) { |
|
| 244 | + continue; |
|
| 245 | + } |
|
| 247 | 246 | |
| 248 | 247 | $out[$i] = $data_item; |
| 249 | 248 | } |
@@ -258,11 +257,13 @@ discard block |
||
| 258 | 257 | */ |
| 259 | 258 | public function intersectKey($intersect_with) |
| 260 | 259 | { |
| 261 | - if (!$this->argumentIsArrayOrArrayObject($intersect_with)) |
|
| 262 | - self::throwUsageException("First argument must be an array or a ".static::class."."); |
|
| 260 | + if (!$this->argumentIsArrayOrArrayObject($intersect_with)) { |
|
| 261 | + self::throwUsageException("First argument must be an array or a ".static::class."."); |
|
| 262 | + } |
|
| 263 | 263 | |
| 264 | - if ($intersect_with instanceof static) |
|
| 265 | - $intersect_with = $intersect_with->getArray(); |
|
| 264 | + if ($intersect_with instanceof static) { |
|
| 265 | + $intersect_with = $intersect_with->getArray(); |
|
| 266 | + } |
|
| 266 | 267 | |
| 267 | 268 | $out = array_intersect_key($this->data, $intersect_with); |
| 268 | 269 | |
@@ -351,8 +352,9 @@ discard block |
||
| 351 | 352 | */ |
| 352 | 353 | public function diff($compare_with, $check_keys=false, $strict_comparison=false) |
| 353 | 354 | { |
| 354 | - if (!$this->argumentIsArrayOrArrayObject($compare_with)) |
|
| 355 | - self::throwUsageException("First argument must be an iterable"); |
|
| 355 | + if (!$this->argumentIsArrayOrArrayObject($compare_with)) { |
|
| 356 | + self::throwUsageException("First argument must be an iterable"); |
|
| 357 | + } |
|
| 356 | 358 | |
| 357 | 359 | $kept_values = $this->data; |
| 358 | 360 | |
@@ -368,21 +370,18 @@ discard block |
||
| 368 | 370 | && $kept_value === $compared_value ) { |
| 369 | 371 | $is_equal = true; |
| 370 | 372 | } |
| 371 | - } |
|
| 372 | - else { |
|
| 373 | + } else { |
|
| 373 | 374 | if ( $kept_key == $compared_key |
| 374 | 375 | && $kept_value == $compared_value ) { |
| 375 | 376 | $is_equal = true; |
| 376 | 377 | } |
| 377 | 378 | } |
| 378 | - } |
|
| 379 | - else { |
|
| 379 | + } else { |
|
| 380 | 380 | if ($strict_comparison) { |
| 381 | 381 | if ($kept_value === $compared_value) { |
| 382 | 382 | $is_equal = true; |
| 383 | 383 | } |
| 384 | - } |
|
| 385 | - else { |
|
| 384 | + } else { |
|
| 386 | 385 | if ($kept_value == $compared_value) { |
| 387 | 386 | $is_equal = true; |
| 388 | 387 | } |
@@ -421,11 +420,13 @@ discard block |
||
| 421 | 420 | */ |
| 422 | 421 | public function fillKeys($keys, $value) |
| 423 | 422 | { |
| 424 | - if (!$this->argumentIsArrayOrArrayObject($keys)) |
|
| 425 | - self::throwUsageException("First argument must be an array or a ".static::class."."); |
|
| 423 | + if (!$this->argumentIsArrayOrArrayObject($keys)) { |
|
| 424 | + self::throwUsageException("First argument must be an array or a ".static::class."."); |
|
| 425 | + } |
|
| 426 | 426 | |
| 427 | - if ($keys instanceof static) |
|
| 428 | - $keys = $keys->getArray(); |
|
| 427 | + if ($keys instanceof static) { |
|
| 428 | + $keys = $keys->getArray(); |
|
| 429 | + } |
|
| 429 | 430 | |
| 430 | 431 | $out = array_fill_keys($keys, $value); |
| 431 | 432 | return $this->returnConstant($out); |
@@ -470,8 +471,9 @@ discard block |
||
| 470 | 471 | callable $step_generator, |
| 471 | 472 | $max_interations_count=1000 |
| 472 | 473 | ){ |
| 473 | - if ($max_interations_count < 0) |
|
| 474 | - throw new \InvalidArgumentException("$maximum_interations_count must be positive"); |
|
| 474 | + if ($max_interations_count < 0) { |
|
| 475 | + throw new \InvalidArgumentException("$maximum_interations_count must be positive"); |
|
| 476 | + } |
|
| 475 | 477 | |
| 476 | 478 | $out = []; |
| 477 | 479 | $previous_step_value = null; |
@@ -488,16 +490,14 @@ discard block |
||
| 488 | 490 | |
| 489 | 491 | if ($current_step_key === null) { |
| 490 | 492 | $out[] = $current_step_value; |
| 491 | - } |
|
| 492 | - elseif (!is_int($current_step_key)) { |
|
| 493 | + } elseif (!is_int($current_step_key)) { |
|
| 493 | 494 | // Set the local as en_US tu have floats formatted with |
| 494 | 495 | // "." as separator |
| 495 | 496 | // TODO : could it be useful for dates to? |
| 496 | 497 | $current_locale = setlocale(LC_NUMERIC, 'en_US'); |
| 497 | 498 | $out[(string) $current_step_key] = $current_step_value; |
| 498 | 499 | setlocale(LC_NUMERIC, $current_locale); |
| 499 | - } |
|
| 500 | - else { |
|
| 500 | + } else { |
|
| 501 | 501 | $out[$current_step_key] = $current_step_value; |
| 502 | 502 | } |
| 503 | 503 | |
@@ -508,8 +508,7 @@ discard block |
||
| 508 | 508 | if ((string) $current_step_key == (string) $end_key) { |
| 509 | 509 | break; |
| 510 | 510 | } |
| 511 | - } |
|
| 512 | - elseif ($current_step_key == $end_key) { |
|
| 511 | + } elseif ($current_step_key == $end_key) { |
|
| 513 | 512 | break; |
| 514 | 513 | } |
| 515 | 514 | |
@@ -529,10 +528,11 @@ discard block |
||
| 529 | 528 | */ |
| 530 | 529 | public function keys($search_value=null, $strict=false) |
| 531 | 530 | { |
| 532 | - if ($search_value) |
|
| 533 | - return array_keys($this->data, $search_value, $strict); |
|
| 534 | - else |
|
| 535 | - return array_keys($this->data); |
|
| 531 | + if ($search_value) { |
|
| 532 | + return array_keys($this->data, $search_value, $strict); |
|
| 533 | + } else { |
|
| 534 | + return array_keys($this->data); |
|
| 535 | + } |
|
| 536 | 536 | } |
| 537 | 537 | |
| 538 | 538 | /** |
@@ -640,8 +640,9 @@ discard block |
||
| 640 | 640 | |
| 641 | 641 | if ($callback === null) { |
| 642 | 642 | $callback = function($a, $b) { |
| 643 | - if ($a == $b) |
|
| 644 | - return 0; |
|
| 643 | + if ($a == $b) { |
|
| 644 | + return 0; |
|
| 645 | + } |
|
| 645 | 646 | |
| 646 | 647 | return $a > $b ? -1 : 1; |
| 647 | 648 | }; |
@@ -649,8 +650,9 @@ discard block |
||
| 649 | 650 | |
| 650 | 651 | $arguments = Arrays::merge( [&$data], [$callback] ); |
| 651 | 652 | |
| 652 | - if ( ! call_user_func_array('uasort', $arguments) ) |
|
| 653 | - throw new \ErrorException('Unable to apply usort'); |
|
| 653 | + if ( ! call_user_func_array('uasort', $arguments) ) { |
|
| 654 | + throw new \ErrorException('Unable to apply usort'); |
|
| 655 | + } |
|
| 654 | 656 | |
| 655 | 657 | return $this->returnConstant($data); |
| 656 | 658 | } |
@@ -672,8 +674,9 @@ discard block |
||
| 672 | 674 | |
| 673 | 675 | $arguments = Arrays::merge( [&$data], [$callback] ); |
| 674 | 676 | |
| 675 | - if ( ! call_user_func_array('uksort', $arguments) ) |
|
| 676 | - throw new \ErrorException('Unable to apply uksort'); |
|
| 677 | + if ( ! call_user_func_array('uksort', $arguments) ) { |
|
| 678 | + throw new \ErrorException('Unable to apply uksort'); |
|
| 679 | + } |
|
| 677 | 680 | |
| 678 | 681 | return $this->returnConstant($data); |
| 679 | 682 | } |
@@ -18,8 +18,7 @@ discard block |
||
| 18 | 18 | { |
| 19 | 19 | if (is_null($offset)) { |
| 20 | 20 | $this->data[] = $value; |
| 21 | - } |
|
| 22 | - else { |
|
| 21 | + } else { |
|
| 23 | 22 | $this->data[$offset] = $value; |
| 24 | 23 | } |
| 25 | 24 | } |
@@ -31,8 +30,7 @@ discard block |
||
| 31 | 30 | { |
| 32 | 31 | try { |
| 33 | 32 | return isset($this->data[$offset]); |
| 34 | - } |
|
| 35 | - catch (\Exception $e) { |
|
| 33 | + } catch (\Exception $e) { |
|
| 36 | 34 | if (property_exists($this, 'defaultRowGenerator')) { |
| 37 | 35 | return true; |
| 38 | 36 | } |
@@ -77,8 +75,7 @@ discard block |
||
| 77 | 75 | // support but wouldn't throw exception if it doesn't exist |
| 78 | 76 | $returnValue = &$this->data[$offset]; |
| 79 | 77 | return $returnValue; |
| 80 | - } |
|
| 81 | - catch (\Exception $e) { |
|
| 78 | + } catch (\Exception $e) { |
|
| 82 | 79 | // here we simply move the Exception location at the one |
| 83 | 80 | // of the caller as the isset() method is called at its |
| 84 | 81 | // location. |
@@ -158,10 +155,11 @@ discard block |
||
| 158 | 155 | */ |
| 159 | 156 | protected function generateDefaultRow($offset) |
| 160 | 157 | { |
| 161 | - if (property_exists($this, 'defaultRow')) |
|
| 162 | - return $this->defaultRow; |
|
| 163 | - elseif (property_exists($this, 'defaultRowGenerator')) |
|
| 164 | - return call_user_func($this->defaultRowGenerator, $offset); |
|
| 158 | + if (property_exists($this, 'defaultRow')) { |
|
| 159 | + return $this->defaultRow; |
|
| 160 | + } elseif (property_exists($this, 'defaultRowGenerator')) { |
|
| 161 | + return call_user_func($this->defaultRowGenerator, $offset); |
|
| 162 | + } |
|
| 165 | 163 | } |
| 166 | 164 | |
| 167 | 165 | /**/ |
@@ -91,8 +91,9 @@ discard block |
||
| 91 | 91 | { |
| 92 | 92 | $column_name = $key_column_names->shift(); |
| 93 | 93 | |
| 94 | - if (!$column_name) |
|
| 95 | - return $rows; |
|
| 94 | + if (!$column_name) { |
|
| 95 | + return $rows; |
|
| 96 | + } |
|
| 96 | 97 | |
| 97 | 98 | // $out = new static; |
| 98 | 99 | $out = []; |
@@ -107,10 +108,10 @@ discard block |
||
| 107 | 108 | |
| 108 | 109 | foreach ($sub_rows as $row) { |
| 109 | 110 | try { |
| 110 | - if (is_array($row)) |
|
| 111 | - $row[$column_name] = $key; |
|
| 112 | - } |
|
| 113 | - catch (\Exception $e) { |
|
| 111 | + if (is_array($row)) { |
|
| 112 | + $row[$column_name] = $key; |
|
| 113 | + } |
|
| 114 | + } catch (\Exception $e) { |
|
| 114 | 115 | echo json_encode($column_name); |
| 115 | 116 | echo json_encode($key); |
| 116 | 117 | echo json_encode($e); |
@@ -118,13 +119,12 @@ discard block |
||
| 118 | 119 | } |
| 119 | 120 | $out[] = $row; |
| 120 | 121 | } |
| 121 | - } |
|
| 122 | - else { |
|
| 122 | + } else { |
|
| 123 | 123 | try { |
| 124 | - if (is_array($sub_rows)) |
|
| 125 | - $sub_rows[$column_name] = $key; |
|
| 126 | - } |
|
| 127 | - catch (\Exception $e) { |
|
| 124 | + if (is_array($sub_rows)) { |
|
| 125 | + $sub_rows[$column_name] = $key; |
|
| 126 | + } |
|
| 127 | + } catch (\Exception $e) { |
|
| 128 | 128 | echo json_encode($sub_rows); |
| 129 | 129 | echo json_encode($column_name); |
| 130 | 130 | echo json_encode($key); |
@@ -299,8 +299,9 @@ discard block |
||
| 299 | 299 | ), |
| 300 | 300 | ); |
| 301 | 301 | |
| 302 | - if ($expected != $tableized->getArray()) |
|
| 303 | - throw new \Exception("test failed"); |
|
| 302 | + if ($expected != $tableized->getArray()) { |
|
| 303 | + throw new \Exception("test failed"); |
|
| 304 | + } |
|
| 304 | 305 | |
| 305 | 306 | echo 'Helper_Tabe->tableize tested successfully'; |
| 306 | 307 | } |
@@ -327,13 +328,15 @@ discard block |
||
| 327 | 328 | */ |
| 328 | 329 | private function piramidize_aux($key_column_names, $rows) |
| 329 | 330 | { |
| 330 | - if (!is_array($rows)) |
|
| 331 | - return $rows; |
|
| 331 | + if (!is_array($rows)) { |
|
| 332 | + return $rows; |
|
| 333 | + } |
|
| 332 | 334 | |
| 333 | 335 | $column_name = $key_column_names->shift(); |
| 334 | 336 | |
| 335 | - if (!$column_name) |
|
| 336 | - return $rows; |
|
| 337 | + if (!$column_name) { |
|
| 338 | + return $rows; |
|
| 339 | + } |
|
| 337 | 340 | |
| 338 | 341 | // $out = new static; |
| 339 | 342 | $out = []; |
@@ -348,12 +351,12 @@ discard block |
||
| 348 | 351 | unset($row[$column_name]); |
| 349 | 352 | |
| 350 | 353 | if ($key_column_names->count()) { |
| 351 | - if (!isset($out[$key])) |
|
| 352 | - $out[$key] = []; |
|
| 354 | + if (!isset($out[$key])) { |
|
| 355 | + $out[$key] = []; |
|
| 356 | + } |
|
| 353 | 357 | |
| 354 | 358 | $out[$key][] = $row; |
| 355 | - } |
|
| 356 | - else { |
|
| 359 | + } else { |
|
| 357 | 360 | $out[$key] = $row; |
| 358 | 361 | } |
| 359 | 362 | } |
@@ -529,8 +532,9 @@ discard block |
||
| 529 | 532 | // echo var_export($values->getArray()); |
| 530 | 533 | // $values->dumpJson(true); |
| 531 | 534 | |
| 532 | - if ($expected != $values->getArray()) |
|
| 533 | - throw new \Exception("test failed"); |
|
| 535 | + if ($expected != $values->getArray()) { |
|
| 536 | + throw new \Exception("test failed"); |
|
| 537 | + } |
|
| 534 | 538 | |
| 535 | 539 | echo 'Helper_Tabe->piramidize tested successfully'; |
| 536 | 540 | } |
@@ -26,18 +26,19 @@ discard block |
||
| 26 | 26 | $out = []; |
| 27 | 27 | foreach ($this->data as $key => $row) { |
| 28 | 28 | |
| 29 | - if (!$row) |
|
| 30 | - continue; |
|
| 29 | + if (!$row) { |
|
| 30 | + continue; |
|
| 31 | + } |
|
| 31 | 32 | |
| 32 | 33 | $newIndexes = call_user_func($indexGenerator, $key, $row); |
| 33 | - if (!is_array($newIndexes)) |
|
| 34 | - $newIndexes = [$newIndexes]; |
|
| 34 | + if (!is_array($newIndexes)) { |
|
| 35 | + $newIndexes = [$newIndexes]; |
|
| 36 | + } |
|
| 35 | 37 | |
| 36 | 38 | foreach ($newIndexes as $newIndex) { |
| 37 | 39 | if (!isset($out[$newIndex])) { |
| 38 | 40 | $out[$newIndex] = $row; |
| 39 | - } |
|
| 40 | - else { |
|
| 41 | + } else { |
|
| 41 | 42 | if ($conflictResolver === null) { |
| 42 | 43 | self::throwUsageException( |
| 43 | 44 | "A 'group by' provoking a conflict" |
@@ -74,20 +75,21 @@ discard block |
||
| 74 | 75 | $out = []; |
| 75 | 76 | foreach ($this->data as $key => $row) { |
| 76 | 77 | |
| 77 | - if (!$row) |
|
| 78 | - continue; |
|
| 78 | + if (!$row) { |
|
| 79 | + continue; |
|
| 80 | + } |
|
| 79 | 81 | |
| 80 | 82 | $new_keys = call_user_func($indexGenerator, $row, $key); |
| 81 | - if (!is_array($new_keys)) |
|
| 82 | - $new_keys = [$new_keys]; |
|
| 83 | + if (!is_array($new_keys)) { |
|
| 84 | + $new_keys = [$new_keys]; |
|
| 85 | + } |
|
| 83 | 86 | |
| 84 | 87 | foreach ($new_keys as $new_key) { |
| 85 | 88 | if (!isset($out[ $new_key ])) { |
| 86 | 89 | $out[ $new_key ] = [ |
| 87 | 90 | $key => $row |
| 88 | 91 | ]; |
| 89 | - } |
|
| 90 | - else { |
|
| 92 | + } else { |
|
| 91 | 93 | $out[ $new_key ][ $key ] = $row; |
| 92 | 94 | } |
| 93 | 95 | } |
@@ -125,8 +127,9 @@ discard block |
||
| 125 | 127 | $out = []; |
| 126 | 128 | foreach ($this->data as $key => $row) { |
| 127 | 129 | |
| 128 | - if (!$row) |
|
| 129 | - continue; |
|
| 130 | + if (!$row) { |
|
| 131 | + continue; |
|
| 132 | + } |
|
| 130 | 133 | |
| 131 | 134 | $newIndex = call_user_func($indexGenerator, $key, $row); |
| 132 | 135 | |
@@ -136,8 +139,7 @@ discard block |
||
| 136 | 139 | |
| 137 | 140 | if (!isset($out[$newIndex])) { |
| 138 | 141 | $out[$newIndex] = $transformedRow; |
| 139 | - } |
|
| 140 | - else { |
|
| 142 | + } else { |
|
| 141 | 143 | $out[$newIndex] = call_user_func( |
| 142 | 144 | $conflictResolver, |
| 143 | 145 | $newIndex, |
@@ -161,8 +163,9 @@ discard block |
||
| 161 | 163 | */ |
| 162 | 164 | public function mergeWith( $otherTable, callable $conflictResolver=null ) |
| 163 | 165 | { |
| 164 | - if (is_array($otherTable)) |
|
| 165 | - $otherTable = new static($otherTable); |
|
| 166 | + if (is_array($otherTable)) { |
|
| 167 | + $otherTable = new static($otherTable); |
|
| 168 | + } |
|
| 166 | 169 | |
| 167 | 170 | if (!$otherTable instanceof static) { |
| 168 | 171 | self::throwUsageException( |
@@ -176,10 +179,10 @@ discard block |
||
| 176 | 179 | |
| 177 | 180 | if (!isset($out[$key])) { |
| 178 | 181 | $out[$key] = $row; |
| 179 | - } |
|
| 180 | - else { |
|
| 181 | - if ($conflictResolver === null) |
|
| 182 | - self::throwUsageException('No conflict resolver for a merge provoking one'); |
|
| 182 | + } else { |
|
| 183 | + if ($conflictResolver === null) { |
|
| 184 | + self::throwUsageException('No conflict resolver for a merge provoking one'); |
|
| 185 | + } |
|
| 183 | 186 | |
| 184 | 187 | $arguments = [ |
| 185 | 188 | &$key, |
@@ -265,8 +268,7 @@ discard block |
||
| 265 | 268 | $row[$new_name] = $row[$old_name]; |
| 266 | 269 | unset($row[$old_name]); |
| 267 | 270 | } |
| 268 | - } |
|
| 269 | - catch (\Exception $e) { |
|
| 271 | + } catch (\Exception $e) { |
|
| 270 | 272 | self::throwUsageException( $e->getMessage() ); |
| 271 | 273 | } |
| 272 | 274 | |
@@ -287,17 +289,19 @@ discard block |
||
| 287 | 289 | public function limit() |
| 288 | 290 | { |
| 289 | 291 | $arguments = func_get_args(); |
| 290 | - if (count($arguments) == 1 && is_numeric($arguments[0])) |
|
| 291 | - $max = $arguments[0]; |
|
| 292 | - else |
|
| 293 | - self::throwUsageException("Bad arguments type and count for limit()"); |
|
| 292 | + if (count($arguments) == 1 && is_numeric($arguments[0])) { |
|
| 293 | + $max = $arguments[0]; |
|
| 294 | + } else { |
|
| 295 | + self::throwUsageException("Bad arguments type and count for limit()"); |
|
| 296 | + } |
|
| 294 | 297 | |
| 295 | 298 | $out = []; |
| 296 | 299 | $count = 0; |
| 297 | 300 | foreach ($this->data as $key => $row) { |
| 298 | 301 | |
| 299 | - if ($max <= $count) |
|
| 300 | - break; |
|
| 302 | + if ($max <= $count) { |
|
| 303 | + break; |
|
| 304 | + } |
|
| 301 | 305 | |
| 302 | 306 | $out[$key] = $row; |
| 303 | 307 | |
@@ -321,8 +325,9 @@ discard block |
||
| 321 | 325 | */ |
| 322 | 326 | public function append($new_rows, callable $conflict_resolver=null) |
| 323 | 327 | { |
| 324 | - if ($new_rows instanceof static) |
|
| 325 | - $new_rows = $new_rows->getArray(); |
|
| 328 | + if ($new_rows instanceof static) { |
|
| 329 | + $new_rows = $new_rows->getArray(); |
|
| 330 | + } |
|
| 326 | 331 | |
| 327 | 332 | if (!is_array($new_rows)) { |
| 328 | 333 | $this->throwUsageException( |
@@ -347,8 +352,7 @@ discard block |
||
| 347 | 352 | ]; |
| 348 | 353 | |
| 349 | 354 | call_user_func_array($conflict_resolver, $arguments); |
| 350 | - } |
|
| 351 | - else { |
|
| 355 | + } else { |
|
| 352 | 356 | $this->data[$key] = $new_row; |
| 353 | 357 | } |
| 354 | 358 | } |
@@ -458,8 +462,7 @@ discard block |
||
| 458 | 462 | foreach ($rows as $row_id => $joined_row) { |
| 459 | 463 | $out[$row_id] = $joined_row; |
| 460 | 464 | } |
| 461 | - } |
|
| 462 | - else { |
|
| 465 | + } else { |
|
| 463 | 466 | |
| 464 | 467 | if (!isset($rows)) { |
| 465 | 468 | echo json_encode([ |
@@ -469,8 +472,9 @@ discard block |
||
| 469 | 472 | exit; |
| 470 | 473 | } |
| 471 | 474 | |
| 472 | - foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue) |
|
| 473 | - $row[$rowIdPartName] = $rowIdPartValue; |
|
| 475 | + foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue) { |
|
| 476 | + $row[$rowIdPartName] = $rowIdPartValue; |
|
| 477 | + } |
|
| 474 | 478 | |
| 475 | 479 | $indexParts = []; |
| 476 | 480 | foreach ($rowIdParts as $name => $value) { |
@@ -492,12 +496,12 @@ discard block |
||
| 492 | 496 | public function first($strict=false) |
| 493 | 497 | { |
| 494 | 498 | if (!$this->count()) { |
| 495 | - if ($strict) |
|
| 496 | - throw new \ErrorException("No first element found in this array"); |
|
| 497 | - else |
|
| 498 | - $first = null; |
|
| 499 | - } |
|
| 500 | - else { |
|
| 499 | + if ($strict) { |
|
| 500 | + throw new \ErrorException("No first element found in this array"); |
|
| 501 | + } else { |
|
| 502 | + $first = null; |
|
| 503 | + } |
|
| 504 | + } else { |
|
| 501 | 505 | $key = key($this->data); |
| 502 | 506 | $first = reset($this->data); |
| 503 | 507 | $this->move($key); |
@@ -514,12 +518,12 @@ discard block |
||
| 514 | 518 | public function last($strict=false) |
| 515 | 519 | { |
| 516 | 520 | if (!$this->count()) { |
| 517 | - if ($strict) |
|
| 518 | - throw new \ErrorException("No last element found in this array"); |
|
| 519 | - else |
|
| 520 | - $last = null; |
|
| 521 | - } |
|
| 522 | - else { |
|
| 521 | + if ($strict) { |
|
| 522 | + throw new \ErrorException("No last element found in this array"); |
|
| 523 | + } else { |
|
| 524 | + $last = null; |
|
| 525 | + } |
|
| 526 | + } else { |
|
| 523 | 527 | $key = key($this->data); |
| 524 | 528 | $last = end($this->data); |
| 525 | 529 | $this->move($key); |
@@ -534,12 +538,12 @@ discard block |
||
| 534 | 538 | public function firstKey($strict=false) |
| 535 | 539 | { |
| 536 | 540 | if (!$this->count()) { |
| 537 | - if ($strict) |
|
| 538 | - throw new \ErrorException("No last element found in this array"); |
|
| 539 | - else |
|
| 540 | - $firstKey = null; |
|
| 541 | - } |
|
| 542 | - else { |
|
| 541 | + if ($strict) { |
|
| 542 | + throw new \ErrorException("No last element found in this array"); |
|
| 543 | + } else { |
|
| 544 | + $firstKey = null; |
|
| 545 | + } |
|
| 546 | + } else { |
|
| 543 | 547 | $key = key($this->data); |
| 544 | 548 | reset($this->data); |
| 545 | 549 | $firstKey = key($this->data); |
@@ -555,12 +559,12 @@ discard block |
||
| 555 | 559 | public function lastKey($strict=false) |
| 556 | 560 | { |
| 557 | 561 | if (!$this->count()) { |
| 558 | - if ($strict) |
|
| 559 | - throw new \ErrorException("No last element found in this array"); |
|
| 560 | - else |
|
| 561 | - $lastKey = null; |
|
| 562 | - } |
|
| 563 | - else { |
|
| 562 | + if ($strict) { |
|
| 563 | + throw new \ErrorException("No last element found in this array"); |
|
| 564 | + } else { |
|
| 565 | + $lastKey = null; |
|
| 566 | + } |
|
| 567 | + } else { |
|
| 564 | 568 | $key = key($this->data); |
| 565 | 569 | end($this->data); |
| 566 | 570 | $lastKey = key($this->data); |
@@ -582,8 +586,7 @@ discard block |
||
| 582 | 586 | break; |
| 583 | 587 | } |
| 584 | 588 | } |
| 585 | - } |
|
| 586 | - elseif ($strict) { |
|
| 589 | + } elseif ($strict) { |
|
| 587 | 590 | throw new \ErrorException("Unable to move the internal pointer to a key that doesn't exist."); |
| 588 | 591 | } |
| 589 | 592 | |
@@ -650,8 +653,9 @@ discard block |
||
| 650 | 653 | 'data' => $this->data, |
| 651 | 654 | ]); |
| 652 | 655 | |
| 653 | - if ($exit) |
|
| 654 | - exit; |
|
| 656 | + if ($exit) { |
|
| 657 | + exit; |
|
| 658 | + } |
|
| 655 | 659 | |
| 656 | 660 | return $this; |
| 657 | 661 | } |
@@ -54,11 +54,13 @@ |
||
| 54 | 54 | // var_export($caller); |
| 55 | 55 | |
| 56 | 56 | // TODO How to handle perfectly the missing fields of the backtrace? |
| 57 | - if (isset($caller['file'])) |
|
| 58 | - $this->file = $caller['file']; |
|
| 57 | + if (isset($caller['file'])) { |
|
| 58 | + $this->file = $caller['file']; |
|
| 59 | + } |
|
| 59 | 60 | |
| 60 | - if (isset($caller['line'])) |
|
| 61 | - $this->line = $caller['line']; |
|
| 61 | + if (isset($caller['line'])) { |
|
| 62 | + $this->line = $caller['line']; |
|
| 63 | + } |
|
| 62 | 64 | |
| 63 | 65 | // var_export($this->stack); |
| 64 | 66 | } |
@@ -65,14 +65,12 @@ discard block |
||
| 65 | 65 | ) |
| 66 | 66 | { |
| 67 | 67 | $array1[$key] = self::merge($array1[$key], $value); |
| 68 | - } |
|
| 69 | - else |
|
| 68 | + } else |
|
| 70 | 69 | { |
| 71 | 70 | $array1[$key] = $value; |
| 72 | 71 | } |
| 73 | 72 | } |
| 74 | - } |
|
| 75 | - else |
|
| 73 | + } else |
|
| 76 | 74 | { |
| 77 | 75 | foreach ($array2 as $value) |
| 78 | 76 | { |
@@ -97,14 +95,12 @@ discard block |
||
| 97 | 95 | ) |
| 98 | 96 | { |
| 99 | 97 | $array1[$key] = self::merge($array1[$key], $value); |
| 100 | - } |
|
| 101 | - else |
|
| 98 | + } else |
|
| 102 | 99 | { |
| 103 | 100 | $array1[$key] = $value; |
| 104 | 101 | } |
| 105 | 102 | } |
| 106 | - } |
|
| 107 | - else |
|
| 103 | + } else |
|
| 108 | 104 | { |
| 109 | 105 | foreach ($array2 as $value) |
| 110 | 106 | { |
@@ -174,8 +170,7 @@ discard block |
||
| 174 | 170 | $column, |
| 175 | 171 | ] |
| 176 | 172 | ); |
| 177 | - } |
|
| 178 | - else { |
|
| 173 | + } else { |
|
| 179 | 174 | // same resolution as array_merge_recursive |
| 180 | 175 | if (!is_array($existing_value)) { |
| 181 | 176 | $existing_row[$column] = [$existing_value]; |
@@ -246,15 +241,18 @@ discard block |
||
| 246 | 241 | ; |
| 247 | 242 | |
| 248 | 243 | foreach ($row as $column => &$values) { |
| 249 | - if ( ! $values instanceof MergeBucket) |
|
| 250 | - continue; |
|
| 244 | + if ( ! $values instanceof MergeBucket) { |
|
| 245 | + continue; |
|
| 246 | + } |
|
| 251 | 247 | |
| 252 | - if (in_array($column, $excluded_columns)) |
|
| 253 | - continue; |
|
| 248 | + if (in_array($column, $excluded_columns)) { |
|
| 249 | + continue; |
|
| 250 | + } |
|
| 254 | 251 | |
| 255 | 252 | $values = Arrays::unique($values); |
| 256 | - if (count($values) == 1) |
|
| 257 | - $values = $values[0]; |
|
| 253 | + if (count($values) == 1) { |
|
| 254 | + $values = $values[0]; |
|
| 255 | + } |
|
| 258 | 256 | } |
| 259 | 257 | |
| 260 | 258 | return $row; |
@@ -279,11 +277,13 @@ discard block |
||
| 279 | 277 | ; |
| 280 | 278 | |
| 281 | 279 | foreach ($row as $column => &$values) { |
| 282 | - if (in_array($column, $excluded_columns)) |
|
| 283 | - continue; |
|
| 280 | + if (in_array($column, $excluded_columns)) { |
|
| 281 | + continue; |
|
| 282 | + } |
|
| 284 | 283 | |
| 285 | - if ($values instanceof MergeBucket) |
|
| 286 | - $values = $values->toArray(); |
|
| 284 | + if ($values instanceof MergeBucket) { |
|
| 285 | + $values = $values->toArray(); |
|
| 286 | + } |
|
| 287 | 287 | } |
| 288 | 288 | |
| 289 | 289 | return $row; |
@@ -305,8 +305,7 @@ discard block |
||
| 305 | 305 | foreach ($array as $key => $value) { |
| 306 | 306 | if (is_scalar($value)) { |
| 307 | 307 | $id = $value; |
| 308 | - } |
|
| 309 | - else { |
|
| 308 | + } else { |
|
| 310 | 309 | $id = serialize($value); |
| 311 | 310 | } |
| 312 | 311 | |
@@ -330,11 +329,9 @@ discard block |
||
| 330 | 329 | |
| 331 | 330 | if (is_array($array)) { |
| 332 | 331 | return array_key_exists($key, $array); |
| 333 | - } |
|
| 334 | - elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) { |
|
| 332 | + } elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) { |
|
| 335 | 333 | return $array->keyExists($key); |
| 336 | - } |
|
| 337 | - else { |
|
| 334 | + } else { |
|
| 338 | 335 | throw new \InvalidArgumentException( |
| 339 | 336 | "keyExists() method missing on :\n". var_export($array, true) |
| 340 | 337 | ); |
@@ -360,16 +357,13 @@ discard block |
||
| 360 | 357 | foreach ($array as $key => &$value) { // &for optimization |
| 361 | 358 | if (is_scalar($value)) { |
| 362 | 359 | $sum += $value; |
| 363 | - } |
|
| 364 | - elseif (is_null($value)) { |
|
| 360 | + } elseif (is_null($value)) { |
|
| 365 | 361 | continue; |
| 366 | - } |
|
| 367 | - elseif (is_array($value)) { |
|
| 362 | + } elseif (is_array($value)) { |
|
| 368 | 363 | throw new \InvalidArgumentException( |
| 369 | 364 | "Trying to sum an array with '$sum': ".var_export($value, true) |
| 370 | 365 | ); |
| 371 | - } |
|
| 372 | - elseif (is_object($value)) { |
|
| 366 | + } elseif (is_object($value)) { |
|
| 373 | 367 | if ( ! method_exists($value, 'toNumber')) { |
| 374 | 368 | throw new \InvalidArgumentEXception( |
| 375 | 369 | "Trying to sum a ".get_class($value)." object which cannot be casted as a number. " |
@@ -396,17 +390,21 @@ discard block |
||
| 396 | 390 | */ |
| 397 | 391 | public static function weightedMean($values, $weights) |
| 398 | 392 | { |
| 399 | - if ($values instanceof ChainableArray) |
|
| 400 | - $values = $values->toArray(); |
|
| 393 | + if ($values instanceof ChainableArray) { |
|
| 394 | + $values = $values->toArray(); |
|
| 395 | + } |
|
| 401 | 396 | |
| 402 | - if ($weights instanceof ChainableArray) |
|
| 403 | - $weights = $weights->toArray(); |
|
| 397 | + if ($weights instanceof ChainableArray) { |
|
| 398 | + $weights = $weights->toArray(); |
|
| 399 | + } |
|
| 404 | 400 | |
| 405 | - if ( ! is_array($values)) |
|
| 406 | - $values = [$values]; |
|
| 401 | + if ( ! is_array($values)) { |
|
| 402 | + $values = [$values]; |
|
| 403 | + } |
|
| 407 | 404 | |
| 408 | - if ( ! is_array($weights)) |
|
| 409 | - $weights = [$weights]; |
|
| 405 | + if ( ! is_array($weights)) { |
|
| 406 | + $weights = [$weights]; |
|
| 407 | + } |
|
| 410 | 408 | |
| 411 | 409 | if (count($values) != count($weights)) { |
| 412 | 410 | throw new \InvalidArgumentException( |
@@ -417,12 +415,14 @@ discard block |
||
| 417 | 415 | ); |
| 418 | 416 | } |
| 419 | 417 | |
| 420 | - if (!$values) |
|
| 421 | - return null; |
|
| 418 | + if (!$values) { |
|
| 419 | + return null; |
|
| 420 | + } |
|
| 422 | 421 | |
| 423 | 422 | $weights_sum = array_sum($weights); |
| 424 | - if (!$weights_sum) |
|
| 425 | - return 0; |
|
| 423 | + if (!$weights_sum) { |
|
| 424 | + return 0; |
|
| 425 | + } |
|
| 426 | 426 | |
| 427 | 427 | $weighted_sum = 0; |
| 428 | 428 | foreach ($values as $i => $value) { |
@@ -461,8 +461,9 @@ discard block |
||
| 461 | 461 | */ |
| 462 | 462 | public static function mustBeCountable($value) |
| 463 | 463 | { |
| 464 | - if (static::isCountable($value)) |
|
| 465 | - return true; |
|
| 464 | + if (static::isCountable($value)) { |
|
| 465 | + return true; |
|
| 466 | + } |
|
| 466 | 467 | |
| 467 | 468 | $exception = new \InvalidArgumentException( |
| 468 | 469 | "A value must be Countable instead of: \n" |
@@ -499,8 +500,9 @@ discard block |
||
| 499 | 500 | */ |
| 500 | 501 | public static function mustBeTraversable($value) |
| 501 | 502 | { |
| 502 | - if (static::isTraversable($value)) |
|
| 503 | - return true; |
|
| 503 | + if (static::isTraversable($value)) { |
|
| 504 | + return true; |
|
| 505 | + } |
|
| 504 | 506 | |
| 505 | 507 | $exception = new \InvalidArgumentException( |
| 506 | 508 | "A value must be Traversable instead of: \n" |
@@ -584,8 +586,7 @@ discard block |
||
| 584 | 586 | |
| 585 | 587 | $part_name .= $group_definition_value; |
| 586 | 588 | $group_result_value = $row[ $group_definition_value ]; |
| 587 | - } |
|
| 588 | - elseif (is_int($group_definition_value)) { |
|
| 589 | + } elseif (is_int($group_definition_value)) { |
|
| 589 | 590 | if ( (is_array($row) && ! array_key_exists($group_definition_value, $row)) |
| 590 | 591 | || ($row instanceof \ArrayAcces && ! $row->offsetExists($group_definition_value)) |
| 591 | 592 | ) { |
@@ -598,8 +599,7 @@ discard block |
||
| 598 | 599 | |
| 599 | 600 | $part_name .= $group_definition_value ? : '0'; |
| 600 | 601 | $group_result_value = $row[ $group_definition_value ]; |
| 601 | - } |
|
| 602 | - elseif (is_callable($group_definition_value)) { |
|
| 602 | + } elseif (is_callable($group_definition_value)) { |
|
| 603 | 603 | |
| 604 | 604 | if (is_string($group_definition_value)) { |
| 605 | 605 | $part_name .= $group_definition_value; |
@@ -608,16 +608,14 @@ discard block |
||
| 608 | 608 | elseif (is_object($group_definition_value) && ($group_definition_value instanceof \Closure)) { |
| 609 | 609 | $part_name .= 'unnamed-closure-' |
| 610 | 610 | . hash('crc32b', var_export($group_definition_value, true)); |
| 611 | - } |
|
| 612 | - elseif (is_array($group_definition_value)) { |
|
| 611 | + } elseif (is_array($group_definition_value)) { |
|
| 613 | 612 | $part_name .= implode('::', $group_definition_value); |
| 614 | 613 | } |
| 615 | 614 | |
| 616 | 615 | $group_result_value = call_user_func_array($group_definition_value, [ |
| 617 | 616 | $row, &$part_name |
| 618 | 617 | ]); |
| 619 | - } |
|
| 620 | - else { |
|
| 618 | + } else { |
|
| 621 | 619 | throw new UsageException( |
| 622 | 620 | 'Bad value provided for group id generation: ' |
| 623 | 621 | .var_export($group_definition_value, true) |
@@ -625,8 +623,9 @@ discard block |
||
| 625 | 623 | ); |
| 626 | 624 | } |
| 627 | 625 | |
| 628 | - if (!is_null($part_name)) |
|
| 629 | - $group_parts[ $part_name ] = $group_result_value; |
|
| 626 | + if (!is_null($part_name)) { |
|
| 627 | + $group_parts[ $part_name ] = $group_result_value; |
|
| 628 | + } |
|
| 630 | 629 | } |
| 631 | 630 | |
| 632 | 631 | // sort the groups by names (without it the same group could have multiple ids) |
@@ -639,8 +638,7 @@ discard block |
||
| 639 | 638 | $group_value = get_class($group_value) |
| 640 | 639 | . '_' |
| 641 | 640 | . hash( 'crc32b', var_export($group_value, true) ); |
| 642 | - } |
|
| 643 | - elseif (is_array($group_value)) { |
|
| 641 | + } elseif (is_array($group_value)) { |
|
| 644 | 642 | $group_value = 'array_' . hash( 'crc32b', var_export($group_value, true) ); |
| 645 | 643 | } |
| 646 | 644 | |