Issues in HtmlGrid.php (master) - Issues in master - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (277)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Ajax/semantic/html/collections/HtmlGrid.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ajax\semantic\html\collections;

use Ajax\common\html\HtmlCollection;
use Ajax\semantic\html\content\HtmlGridRow;
use Ajax\semantic\html\base\constants\Wide;
use Ajax\semantic\html\base\constants\VerticalAlignment;
use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\semantic\html\base\traits\TextAlignmentTrait;
use Ajax\semantic\html\content\HtmlGridCol;

/**
 * Semantic Grid component
 * @see http://semantic-ui.com/collections/grid.html
 * @author jc
 * @version 1.001
 */
class HtmlGrid extends HtmlSemCollection {
	use TextAlignmentTrait;
	private $_createCols;
	private $_colSizing=true;
	private $_implicitRows=false;

	public function __construct($identifier, $numRows=1, $numCols=NULL, $createCols=true, $implicitRows=false) {
		parent::__construct($identifier, "div", "ui grid");
		$this->_implicitRows=$implicitRows;
		$this->_createCols=$createCols;
		if (isset($numCols)) {
			// if($this->_createCols){

			$this->_colSizing=false;
			// }
			$this->setWide($numCols);
		}
		$this->setRowsCount($numRows, $numCols);
	}

	public function asSegment() {
		return $this->addToPropertyCtrl("class", "segment", array ("segment" ));
	}

	public function asContainer() {
		return $this->addToPropertyCtrl("class", "container", array ("container" ));
	}

	/**
	 * Defines the grid width (alias for setWidth)
	 * @param int $wide
	 */
	public function setWide($wide) {
		$wide=Wide::getConstants()["W" . $wide];
		$this->addToPropertyCtrl("class", $wide, Wide::getConstants());
		return $this->addToPropertyCtrl("class", "column", array ("column" ));
	}

	/**
	 * Defines the grid width
	 * @param int $width
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setWidth($width) {
		return $this->setWide($width);
	}

	/**
	 * Adds a row with $colsCount columns
	 * @param int $colsCount number of columns to create
	 * @return mixed
	 */
	public function addRow($colsCount=NULL) {
		$rowCount=$this->rowCount() + 1;
		$this->setRowsCount($rowCount, $colsCount, true);
		return $this->content[$rowCount - 1];
	}

	/**
	 * Adds a col
	 * @param int $width with of the column to add
	 * @return mixed|\Ajax\semantic\html\collections\HtmlGrid
	 */
	public function addCol($width=NULL) {
		$colCount=$this->colCount() + 1;
		$this->setColsCount($colCount, true, $width);
		if ($this->hasOnlyCols($this->count()))
			return $this->content[$colCount - 1];
		return $this;
	}

	/**
	 *
	 * @param array $sizes array of width of the columns to create
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function addCols($sizes=array()) {
		foreach ( $sizes as $size ) {
			$this->addCol($size);
		}
		return $this;
	}

	/**
	 * Create $rowsCount rows
	 * @param int $rowsCount
	 * @param int $colsCount
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setRowsCount($rowsCount, $colsCount=NULL, $force=false) {
		$count=$this->count();
		if ($rowsCount < 2 && $force === false) {
			for($i=$count; $i < $colsCount; $i++) {

				$this->addItem(new HtmlGridCol("col-" . $this->identifier . "-" . $i));
			}
		} else {
			if ($this->hasOnlyCols($count)) {
				$tmpContent=$this->content;
				$item=$this->addItem($colsCount);
				$item->setContent($tmpContent);
				$this->content=array ();
				$count=1;
			}
			for($i=$count; $i < $rowsCount; $i++) {
				$this->addItem($colsCount);
			}
		}
		return $this;
	}

	protected function hasOnlyCols($count) {
		return $count > 0 && $this->content[0] instanceof HtmlGridCol;
	}

	/**
	 * Defines the number of columns in the grid
	 * @param int $numCols
	 * @param boolean $toCreate
	 * @param int $width
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setColsCount($numCols, $toCreate=true, $width=NULL) {
		/*if (isset($width)==false) {

			$this->setWide($numCols);
		}*/
		if ($toCreate == true) {

			$count=$this->count();
			if ($count == 0 || $this->hasOnlyCols($count)) {
				for($i=$count; $i < $numCols; $i++) {

					$this->addItem(new HtmlGridCol("col-" . $this->identifier . "-" . $i, $width));
				}
			} else {
				for($i=0; $i < $count; $i++) {
					$this->getItem($i)->setColsCount($numCols);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
				}
			}
		}
		return $this;
	}

	/**
	 * return the row at $index
	 * @param int $index
	 * @return \Ajax\semantic\html\collections\HtmlGridRow
	 */
	public function getRow($index) {
		return $this->getItem($index);
	}

	/**
	 * Returns the row count
	 * @return int
	 */
	public function rowCount() {
		$count=$this->count();
		if ($this->hasOnlyCols($count))
			return 0;
		return $count;
	}

	/**
	 * Returns the column count
	 * @return int
	 */
	public function colCount() {
		$count=$this->count();
		if ($this->hasOnlyCols($count))
			return $count;
		if ($count > 0)
			return $this->getItem(0)->count();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		return 0;
	}

	/**
	 * Returns the cell (HtmlGridCol) at position rrow,$col
	 * @param int $row
	 * @param int $col
	 * @return \Ajax\semantic\html\collections\HtmlGridCol
	 */
	public function getCell($row, $col) {
		if ($row < 2 && $this->hasOnlyCols($this->count()))
			return $this->getItem($col);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		$row=$this->getItem($row);
		if (isset($row)) {
			$col=$row->getItem($col);
		}
		return $col;
	}

	/**
	 * Adds dividers between columns ($vertically=false) or between rows ($vertically=true)
	 * @param boolean $vertically
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setDivided($vertically=false) {
		$value=($vertically === true) ? "vertically divided" : "divided";
		return $this->addToPropertyCtrl("class", $value, array ("divided" ));
	}

	/**
	 * Divides rows into cells
	 * @param boolean $internally true for internal cells
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setCelled($internally=false) {
		$value=($internally === true) ? "internally celled" : "celled";
		return $this->addToPropertyCtrl("class", $value, array ("celled","internally celled" ));
	}

	/**
	 * A grid can have its columns centered
	 */
	public function setCentered() {
		return $this->addToPropertyCtrl("class", "centered", array ("centered" ));
	}

	/**
	 * automatically resize all elements to split the available width evenly
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setEqualWidth() {
		return $this->addToProperty("class", "equal width");
	}

	/**
	 * Adds vertical or/and horizontal gutters
	 * @param string $value
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setPadded($value=NULL) {
		if (isset($value))
			$this->addToPropertyCtrl("class", $value, array ("vertically","horizontally" ));
		return $this->addToProperty("class", "padded");
	}

	/**
	 *
	 * @param boolean $very
	 * @return \Ajax\semantic\html\collections\HtmlGrid
	 */
	public function setRelaxed($very=false) {
		$value=($very === true) ? "very relaxed" : "relaxed";
		return $this->addToPropertyCtrl("class", $value, array ("relaxed","very relaxed" ));
	}

	public function setVerticalAlignment($value=VerticalAlignment::MIDDLE) {
		return $this->addToPropertyCtrl("class", $value . " aligned", VerticalAlignment::getConstantValues("aligned"));
	}

	/**
	 *
	 * {@inheritDoc}
	 *
	 * @see \Ajax\common\html\HtmlCollection::createItem()
	 */
	protected function createItem($value) {
		if ($this->_createCols === false)
			$value=null;
		$item=new HtmlGridRow($this->identifier . "-row-" . ($this->count() + 1), $value, $this->_colSizing, $this->_implicitRows);
		return $item;
	}

	/**
	 * Sets $values to the grid
	 * @param array $values
	 */
	public function setValues($values, $force=true) {
		$count=$this->count();
		if ($this->_createCols === false || $force === true) {
			for($i=$count; $i < \sizeof($values); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
				$colSize=\sizeof($values[$i]);
				$this->addItem(new HtmlGridRow($this->identifier . "-row-" . ($this->count() + 1), $colSize, $this->_colSizing, $this->_implicitRows));
			}
		}
		$count=\min(array ($this->count(),\sizeof($values) ));
		for($i=0; $i < $count; $i++) {
			$this->content[$i]->setValues($values[$i], $this->_createCols === false);
		}
	}

	/**
	 * stretch the row contents to take up the entire column height
	 * @return \Ajax\semantic\html\content\HtmlGridRow
	 */
	public function setStretched() {
		return $this->addToProperty("class", "stretched");
	}

	public function addDivider($afterColIndex, $vertical=true, $content=NULL) {
		$col=$this->getCell(0, $afterColIndex);
		return $col->addDivider($vertical, $content);
	}
}

Issues (277)

Security Analysis not enabled

Ajax/semantic/html/collections/HtmlGrid.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1		<?php
2
3		namespace Ajax\semantic\html\collections;
4
5		use Ajax\common\html\HtmlCollection;
6		use Ajax\semantic\html\content\HtmlGridRow;
7		use Ajax\semantic\html\base\constants\Wide;
8		use Ajax\semantic\html\base\constants\VerticalAlignment;
9		use Ajax\semantic\html\base\HtmlSemCollection;
10		use Ajax\semantic\html\base\traits\TextAlignmentTrait;
11		use Ajax\semantic\html\content\HtmlGridCol;
12
13		/**
14		* Semantic Grid component
15		* @see http://semantic-ui.com/collections/grid.html
16		* @author jc
17		* @version 1.001
18		*/
19		class HtmlGrid extends HtmlSemCollection {
20		use TextAlignmentTrait;
21		private $_createCols;
22		private $_colSizing=true;
23		private $_implicitRows=false;
24
25		public function __construct($identifier, $numRows=1, $numCols=NULL, $createCols=true, $implicitRows=false) {
26		parent::__construct($identifier, "div", "ui grid");
27		$this->_implicitRows=$implicitRows;
28		$this->_createCols=$createCols;
29		if (isset($numCols)) {
30		// if($this->_createCols){
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-06 14:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
31		$this->_colSizing=false;
32		// }
33		$this->setWide($numCols);
34		}
35		$this->setRowsCount($numRows, $numCols);
36		}
37
38		public function asSegment() {
39		return $this->addToPropertyCtrl("class", "segment", array ("segment" ));
40		}
41
42		public function asContainer() {
43		return $this->addToPropertyCtrl("class", "container", array ("container" ));
44		}
45
46		/**
47		* Defines the grid width (alias for setWidth)
48		* @param int $wide
49		*/
50		public function setWide($wide) {
51		$wide=Wide::getConstants()["W" . $wide];
52		$this->addToPropertyCtrl("class", $wide, Wide::getConstants());
53		return $this->addToPropertyCtrl("class", "column", array ("column" ));
54		}
55
56		/**
57		* Defines the grid width
58		* @param int $width
59		* @return \Ajax\semantic\html\collections\HtmlGrid
60		*/
61		public function setWidth($width) {
62		return $this->setWide($width);
63		}
64
65		/**
66		* Adds a row with $colsCount columns
67		* @param int $colsCount number of columns to create
68		* @return mixed
69		*/
70		public function addRow($colsCount=NULL) {
71		$rowCount=$this->rowCount() + 1;
72		$this->setRowsCount($rowCount, $colsCount, true);
73		return $this->content[$rowCount - 1];
74		}
75
76		/**
77		* Adds a col
78		* @param int $width with of the column to add
79		* @return mixed\|\Ajax\semantic\html\collections\HtmlGrid
80		*/
81		public function addCol($width=NULL) {
82		$colCount=$this->colCount() + 1;
83		$this->setColsCount($colCount, true, $width);
84		if ($this->hasOnlyCols($this->count()))
85		return $this->content[$colCount - 1];
86		return $this;
87		}
88
89		/**
90		*
91		* @param array $sizes array of width of the columns to create
92		* @return \Ajax\semantic\html\collections\HtmlGrid
93		*/
94		public function addCols($sizes=array()) {
95		foreach ( $sizes as $size ) {
96		$this->addCol($size);
97		}
98		return $this;
99		}
100
101		/**
102		* Create $rowsCount rows
103		* @param int $rowsCount
104		* @param int $colsCount
105		* @return \Ajax\semantic\html\collections\HtmlGrid
106		*/
107		public function setRowsCount($rowsCount, $colsCount=NULL, $force=false) {
108		$count=$this->count();
109		if ($rowsCount < 2 && $force === false) {
110	View Code Duplication	for($i=$count; $i < $colsCount; $i++) {
		0 ignored issues – show Duplication introduced 2016-04-21 01:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		$this->addItem(new HtmlGridCol("col-" . $this->identifier . "-" . $i));
112		}
113		} else {
114		if ($this->hasOnlyCols($count)) {
115		$tmpContent=$this->content;
116		$item=$this->addItem($colsCount);
117		$item->setContent($tmpContent);
118		$this->content=array ();
119		$count=1;
120		}
121		for($i=$count; $i < $rowsCount; $i++) {
122		$this->addItem($colsCount);
123		}
124		}
125		return $this;
126		}
127
128		protected function hasOnlyCols($count) {
129		return $count > 0 && $this->content[0] instanceof HtmlGridCol;
130		}
131
132		/**
133		* Defines the number of columns in the grid
134		* @param int $numCols
135		* @param boolean $toCreate
136		* @param int $width
137		* @return \Ajax\semantic\html\collections\HtmlGrid
138		*/
139		public function setColsCount($numCols, $toCreate=true, $width=NULL) {
140		/*if (isset($width)==false) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
141		$this->setWide($numCols);
142		}*/
143		if ($toCreate == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-04-21 01:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
144		$count=$this->count();
145		if ($count == 0 \|\| $this->hasOnlyCols($count)) {
146	View Code Duplication	for($i=$count; $i < $numCols; $i++) {
		0 ignored issues – show Duplication introduced 2016-04-21 01:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		$this->addItem(new HtmlGridCol("col-" . $this->identifier . "-" . $i, $width));
148		}
149		} else {
150		for($i=0; $i < $count; $i++) {
151		$this->getItem($i)->setColsCount($numCols);
		0 ignored issues – show Bug introduced 2016-04-22 00:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `setColsCount()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\collections\HtmlGrid`, `Ajax\semantic\html\content\HtmlGridRow`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
152		}
153		}
154		}
155		return $this;
156		}
157
158		/**
159		* return the row at $index
160		* @param int $index
161		* @return \Ajax\semantic\html\collections\HtmlGridRow
162		*/
163		public function getRow($index) {
164		return $this->getItem($index);
165		}
166
167		/**
168		* Returns the row count
169		* @return int
170		*/
171		public function rowCount() {
172		$count=$this->count();
173		if ($this->hasOnlyCols($count))
174		return 0;
175		return $count;
176		}
177
178		/**
179		* Returns the column count
180		* @return int
181		*/
182		public function colCount() {
183		$count=$this->count();
184		if ($this->hasOnlyCols($count))
185		return $count;
186		if ($count > 0)
187		return $this->getItem(0)->count();
		0 ignored issues – show Bug introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `count()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\common\html\HtmlCollection`, `Ajax\common\html\html5\HtmlList`, `Ajax\semantic\html\base\HtmlSemCollection`, `Ajax\semantic\html\base\HtmlSemNavElement`, `Ajax\semantic\html\collections\HtmlBreadcrumb`, `Ajax\semantic\html\collections\HtmlGrid`, `Ajax\semantic\html\collections\form\HtmlForm`, `Ajax\semantic\html\collections\form\HtmlFormFields`, `Ajax\semantic\html\colle...menus\HtmlAccordionMenu`, `Ajax\semantic\html\collections\menus\HtmlIconMenu`, `Ajax\semantic\html\colle...nus\HtmlLabeledIconMenu`, `Ajax\semantic\html\collections\menus\HtmlMenu`, `Ajax\semantic\html\colle...enus\HtmlPaginationMenu`, `Ajax\semantic\html\content\HtmlGridRow`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`, `Ajax\semantic\html\elements\HtmlIconGroups`, `Ajax\semantic\html\elements\HtmlLabelGroups`, `Ajax\semantic\html\elements\HtmlList`, `Ajax\semantic\html\elements\HtmlSegmentGroups`, `Ajax\semantic\html\elements\HtmlStep`, `Ajax\semantic\html\modules\HtmlAccordion`, `Ajax\semantic\html\modules\HtmlDropdown`, `Ajax\semantic\html\views\HtmlCardGroups`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
188		return 0;
189		}
190
191		/**
192		* Returns the cell (HtmlGridCol) at position rrow,$col
193		* @param int $row
194		* @param int $col
195		* @return \Ajax\semantic\html\collections\HtmlGridCol
196		*/
197		public function getCell($row, $col) {
198		if ($row < 2 && $this->hasOnlyCols($this->count()))
199		return $this->getItem($col);
		0 ignored issues – show Bug Best Practice introduced 2016-04-21 01:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->getItem($col);` (`Ajax\common\html\HtmlDoubleElement`) is incompatible with the return type documented by `Ajax\semantic\html\collections\HtmlGrid::getCell` of type `Ajax\semantic\html\collections\HtmlGridCol`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
200		$row=$this->getItem($row);
201		if (isset($row)) {
202		$col=$row->getItem($col);
203		}
204		return $col;
205		}
206
207		/**
208		* Adds dividers between columns ($vertically=false) or between rows ($vertically=true)
209		* @param boolean $vertically
210		* @return \Ajax\semantic\html\collections\HtmlGrid
211		*/
212		public function setDivided($vertically=false) {
213		$value=($vertically === true) ? "vertically divided" : "divided";
214		return $this->addToPropertyCtrl("class", $value, array ("divided" ));
215		}
216
217		/**
218		* Divides rows into cells
219		* @param boolean $internally true for internal cells
220		* @return \Ajax\semantic\html\collections\HtmlGrid
221		*/
222		public function setCelled($internally=false) {
223		$value=($internally === true) ? "internally celled" : "celled";
224		return $this->addToPropertyCtrl("class", $value, array ("celled","internally celled" ));
225		}
226
227		/**
228		* A grid can have its columns centered
229		*/
230		public function setCentered() {
231		return $this->addToPropertyCtrl("class", "centered", array ("centered" ));
232		}
233
234		/**
235		* automatically resize all elements to split the available width evenly
236		* @return \Ajax\semantic\html\collections\HtmlGrid
237		*/
238		public function setEqualWidth() {
239		return $this->addToProperty("class", "equal width");
240		}
241
242		/**
243		* Adds vertical or/and horizontal gutters
244		* @param string $value
245		* @return \Ajax\semantic\html\collections\HtmlGrid
246		*/
247		public function setPadded($value=NULL) {
248		if (isset($value))
249		$this->addToPropertyCtrl("class", $value, array ("vertically","horizontally" ));
250		return $this->addToProperty("class", "padded");
251		}
252
253		/**
254		*
255		* @param boolean $very
256		* @return \Ajax\semantic\html\collections\HtmlGrid
257		*/
258		public function setRelaxed($very=false) {
259		$value=($very === true) ? "very relaxed" : "relaxed";
260		return $this->addToPropertyCtrl("class", $value, array ("relaxed","very relaxed" ));
261		}
262
263		public function setVerticalAlignment($value=VerticalAlignment::MIDDLE) {
264		return $this->addToPropertyCtrl("class", $value . " aligned", VerticalAlignment::getConstantValues("aligned"));
265		}
266
267		/**
268		*
269		* {@inheritDoc}
270		*
271		* @see \Ajax\common\html\HtmlCollection::createItem()
272		*/
273		protected function createItem($value) {
274		if ($this->_createCols === false)
275		$value=null;
276		$item=new HtmlGridRow($this->identifier . "-row-" . ($this->count() + 1), $value, $this->_colSizing, $this->_implicitRows);
277		return $item;
278		}
279
280		/**
281		* Sets $values to the grid
282		* @param array $values
283		*/
284		public function setValues($values, $force=true) {
285		$count=$this->count();
286		if ($this->_createCols === false \|\| $force === true) {
287		for($i=$count; $i < \sizeof($values); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2016-04-06 14:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are calling the size function `sizeof()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
288		$colSize=\sizeof($values[$i]);
289		$this->addItem(new HtmlGridRow($this->identifier . "-row-" . ($this->count() + 1), $colSize, $this->_colSizing, $this->_implicitRows));
290		}
291		}
292		$count=\min(array ($this->count(),\sizeof($values) ));
293		for($i=0; $i < $count; $i++) {
294		$this->content[$i]->setValues($values[$i], $this->_createCols === false);
295		}
296		}
297
298		/**
299		* stretch the row contents to take up the entire column height
300		* @return \Ajax\semantic\html\content\HtmlGridRow
301		*/
302		public function setStretched() {
303		return $this->addToProperty("class", "stretched");
304		}
305
306		public function addDivider($afterColIndex, $vertical=true, $content=NULL) {
307		$col=$this->getCell(0, $afterColIndex);
308		return $col->addDivider($vertical, $content);
309		}
310		}

jcheron / phalcon-jquery

Issues (277)

Security Analysis not enabled

Ajax/semantic/html/collections/HtmlGrid.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like