Issues in Modal.php (master) - Issues in master - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (277)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Ajax/bootstrap/components/Modal.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ajax\bootstrap\components;

use Ajax\JsUtils;
use Ajax\bootstrap\components\js\Draggable;
use Ajax\common\components\SimpleExtComponent;

/**
 * Composant Twitter Bootstrap Modal
 * @author jc
 * @version 1.001
 */
class Modal extends SimpleExtComponent {

	public function __construct(JsUtils $js) {
		parent::__construct($js);
		$this->uiName="modal";
	}

	public function attach($identifier) {
		parent::attach($identifier);
		$this->js->addClass($identifier, "modal", true);
		$this->js->attr($identifier, "role", "dialog", true);
		$this->js->attr($identifier, "aria-labelledby", "myModalLabel", true);
		$this->js->attr($identifier, "aria-hidden", true, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	 * Shows the modal when initialized.
	 * @param Boolean $value default : true
	 * @return $this
	 */
	public function setShow($value) {
		return $this->setParam("show", $value);
	}

	/**
	 * Includes a modal-backdrop element.
	 * Alternatively, specify static for a backdrop which doesn't close the modal on click.
	 * @param Boolean $value default : true
	 * @return $this
	 */
	public function setBackdrop($value) {
		return $this->setParam("backdrop", $value);
	}

	/**
	 * Closes the modal when escape key is pressed.
	 * @param Boolean $value default : false
	 * @return $this
	 */
	public function setKeyboard($value) {
		return $this->setParam("keyboard", $value);
	}

	public function setDraggable($value) {
		if ($value) {
			$this->jsCodes ["draggable"]=new Draggable();
			$this->setBackdrop(false);
		} else if (array_key_exists("draggable", $this->jsCodes)) {
			unset($this->jsCodes ["draggable"]);
			unset($this->params ["backdrop"]);
		}
	}

	/**
	 * This event fires immediately when the show instance method is called.
	 * If caused by a click, the clicked element is available as the relatedTarget property of the event.
	 * @param string $jsCode
	 * @return $this
	 */
	public function onShow($jsCode) {
		return $this->addEvent("show.bs.modal", $jsCode);
	}

	/**
	 * This event is fired when the modal has been made visible to the user (will wait for CSS transitions to complete).
	 * If caused by a click, the clicked element is available as the relatedTarget property of the event.
	 * @param string $jsCode
	 * @return $this
	 */
	public function onShown($jsCode) {
		return $this->addEvent("shown.bs.modal", $jsCode);
	}

	/**
	 * This event is fired immediately when the hide instance method has been called.
	 * @param string $jsCode
	 * @return $this
	 */
	public function onHide($jsCode) {
		return $this->addEvent("hide.bs.modal", $jsCode);
	}

	/**
	 * This event is fired when the modal has finished being hidden from the user (will wait for CSS transitions to complete).
	 * @param string $jsCode
	 * @return $this
	 */
	public function onHidden($jsCode) {
		return $this->addEvent("hidden.bs.modal", $jsCode);
	}

	/**
	 * This event is fired when the modal has loaded content using the remote option.
	 * @param string $jsCode
	 * @return $this
	 */
	public function onLoaded($jsCode) {
		return $this->addEvent("loaded.bs.modal", $jsCode);
	}
}

1			<?php
2
3			namespace Ajax\bootstrap\components;
4
5			use Ajax\JsUtils;
6			use Ajax\bootstrap\components\js\Draggable;
7			use Ajax\common\components\SimpleExtComponent;
8
9			/**
10			* Composant Twitter Bootstrap Modal
11			* @author jc
12			* @version 1.001
13			*/
14			class Modal extends SimpleExtComponent {
15
16			public function __construct(JsUtils $js) {
17			parent::__construct($js);
18			$this->uiName="modal";
19			}
20
21			public function attach($identifier) {
22			parent::attach($identifier);
23			$this->js->addClass($identifier, "modal", true);
24			$this->js->attr($identifier, "role", "dialog", true);
25			$this->js->attr($identifier, "aria-labelledby", "myModalLabel", true);
26			$this->js->attr($identifier, "aria-hidden", true, true);
			0 ignored issues – show Documentation introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			}
28
29			/**
30			* Shows the modal when initialized.
31			* @param Boolean $value default : true
32			* @return $this
33			*/
34			public function setShow($value) {
35			return $this->setParam("show", $value);
36			}
37
38			/**
39			* Includes a modal-backdrop element.
40			* Alternatively, specify static for a backdrop which doesn't close the modal on click.
41			* @param Boolean $value default : true
42			* @return $this
43			*/
44			public function setBackdrop($value) {
45			return $this->setParam("backdrop", $value);
46			}
47
48			/**
49			* Closes the modal when escape key is pressed.
50			* @param Boolean $value default : false
51			* @return $this
52			*/
53			public function setKeyboard($value) {
54			return $this->setParam("keyboard", $value);
55			}
56
57			public function setDraggable($value) {
58			if ($value) {
59			$this->jsCodes ["draggable"]=new Draggable();
60			$this->setBackdrop(false);
61			} else if (array_key_exists("draggable", $this->jsCodes)) {
62			unset($this->jsCodes ["draggable"]);
63			unset($this->params ["backdrop"]);
64			}
65			}
66
67			/**
68			* This event fires immediately when the show instance method is called.
69			* If caused by a click, the clicked element is available as the relatedTarget property of the event.
70			* @param string $jsCode
71			* @return $this
72			*/
73			public function onShow($jsCode) {
74			return $this->addEvent("show.bs.modal", $jsCode);
75			}
76
77			/**
78			* This event is fired when the modal has been made visible to the user (will wait for CSS transitions to complete).
79			* If caused by a click, the clicked element is available as the relatedTarget property of the event.
80			* @param string $jsCode
81			* @return $this
82			*/
83			public function onShown($jsCode) {
84			return $this->addEvent("shown.bs.modal", $jsCode);
85			}
86
87			/**
88			* This event is fired immediately when the hide instance method has been called.
89			* @param string $jsCode
90			* @return $this
91			*/
92			public function onHide($jsCode) {
93			return $this->addEvent("hide.bs.modal", $jsCode);
94			}
95
96			/**
97			* This event is fired when the modal has finished being hidden from the user (will wait for CSS transitions to complete).
98			* @param string $jsCode
99			* @return $this
100			*/
101			public function onHidden($jsCode) {
102			return $this->addEvent("hidden.bs.modal", $jsCode);
103			}
104
105			/**
106			* This event is fired when the modal has loaded content using the remote option.
107			* @param string $jsCode
108			* @return $this
109			*/
110			public function onLoaded($jsCode) {
111			return $this->addEvent("loaded.bs.modal", $jsCode);
112			}
113			}

jcheron / phalcon-jquery

Issues (277)

Security Analysis not enabled

Ajax/bootstrap/components/Modal.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like