JsUtils::getUrl() - Code Metrics - Inspection of "Laravel forward for accordion, breadcrumb" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 94aea7...5914b8 )

by Jean-Christophe

created 2016-06-04 02:10 UTC

JsUtils::getUrl() A

↳ Parent: JsUtils

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Ajax\php\laravel;

use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\Route;
class JsUtils extends \Ajax\JsUtils{
	public function getUrl($url){
		return \url($url);
	}
	public function addViewElement($identifier,$content,$view){

		$controls=$view->__get("q");
		if (isset($controls) === false) {
			$controls=array ();
		}
		$controls[$identifier]=$content;
		$view->__set("q", $controls);
	}

	public function createScriptVariable($view,$view_var, $output){
		$view->__set($view_var,$output);
	}

	public function forward($initialController,$controller,$action){
		//\request()->attributes->all()

		$url=\action($controller.'@'.$action, [],false);
		$request = Request::create($url, 'GET');
		// handle the response
		return Route::dispatch($request)->getContent();
		//return App::make($controller)->{$action}(\request()->attributes->all());

		//return "Accordion content";//
		//return \redirect()->action($controller.'@'.$action,\request()->attributes->all())->getContent();

	}

	public function renderContent($view, $controller, $action, $params=NULL) {
		$template=$view->getRender($controller, $action, $params, function ($view) {
			$view->setRenderLevel(View::LEVEL_ACTION_VIEW);
		});
		return $template;
	}

	public function fromDispatcher($dispatcher){
		return $dispatcher->segments();
	}
}

1		<?php
2
3		namespace Ajax\php\laravel;
4
5		use Illuminate\Support\Facades\Request;
6		use Illuminate\Support\Facades\App;
7		use Illuminate\Support\Facades\Route;
8		class JsUtils extends \Ajax\JsUtils{
9		public function getUrl($url){
10		return \url($url);
11		}
12	View Code Duplication	public function addViewElement($identifier,$content,$view){
		0 ignored issues – show Duplication introduced 2016-06-02 00:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		$controls=$view->__get("q");
14		if (isset($controls) === false) {
15		$controls=array ();
16		}
17		$controls[$identifier]=$content;
18		$view->__set("q", $controls);
19		}
20
21		public function createScriptVariable($view,$view_var, $output){
22		$view->__set($view_var,$output);
23		}
24
25		public function forward($initialController,$controller,$action){
26		//\request()->attributes->all()
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-04 02:15 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27		$url=\action($controller.'@'.$action, [],false);
28		$request = Request::create($url, 'GET');
29		// handle the response
30		return Route::dispatch($request)->getContent();
31		//return App::make($controller)->{$action}(\request()->attributes->all());
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-04 02:15 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32		//return "Accordion content";//
33		//return \redirect()->action($controller.'@'.$action,\request()->attributes->all())->getContent();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-04 02:15 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
34		}
35
36		public function renderContent($view, $controller, $action, $params=NULL) {
37		$template=$view->getRender($controller, $action, $params, function ($view) {
38		$view->setRenderLevel(View::LEVEL_ACTION_VIEW);
39		});
40		return $template;
41		}
42
43		public function fromDispatcher($dispatcher){
44		return $dispatcher->segments();
45		}
46		}

jcheron / phalcon-jquery

Push — master ( 94aea7...5914b8 )

JsUtils::getUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like