CheckboxTrait - Code Metrics - Inspection of "Checkbox refactoring" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 916f6f...ea2a7d )

by Jean-Christophe

created 2016-04-29 17:35 UTC

CheckboxTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	0
cbo	1
dl	0
loc	27
rs	10

4 Methods

Rating	Name	Size	Complexity
	addToPropertyCtrl()	1	?
A	setType()	3	1
A	attachEvent()	3	1
A	attachEvents()	3	1

<?php

namespace Ajax\semantic\html\collections\form\traits;

use Ajax\semantic\html\base\constants\CheckboxType;

trait CheckboxTrait {

	public abstract function addToPropertyCtrl($name, $value, $typeCtrl);

	public function setType($checkboxType) {
		return $this->addToPropertyCtrl("class", $checkboxType, CheckboxType::getConstants());
	}

	/**
	 * Attach $this to $selector and fire $action
	 * @param string $selector jquery selector of the associated element
	 * @param string $action action to execute : check, uncheck or NULL for toggle
	 * @return \Ajax\semantic\html\collections\form\AbstractHtmlFormRadioCheckbox
	 */
	public function attachEvent($selector, $action=NULL) {
		return $this->getField()->attachEvent($selector, $action);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * Attach $this to an array of $action=>$selector
	 * @param array $events associative array of events to attach ex : ["#bt-toggle","check"=>"#bt-check","uncheck"=>"#bt-uncheck"]
	 * @return \Ajax\semantic\html\collections\form\AbstractHtmlFormRadioCheckbox
	 */
	public function attachEvents($events=array()) {
		return $this->getField()->attachEvents($events);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}
}

1			<?php
2
3			namespace Ajax\semantic\html\collections\form\traits;
4
5			use Ajax\semantic\html\base\constants\CheckboxType;
6
7			trait CheckboxTrait {
8
9			public abstract function addToPropertyCtrl($name, $value, $typeCtrl);
10
11			public function setType($checkboxType) {
12			return $this->addToPropertyCtrl("class", $checkboxType, CheckboxType::getConstants());
13			}
14
15			/**
16			* Attach $this to $selector and fire $action
17			* @param string $selector jquery selector of the associated element
18			* @param string $action action to execute : check, uncheck or NULL for toggle
19			* @return \Ajax\semantic\html\collections\form\AbstractHtmlFormRadioCheckbox
20			*/
21			public function attachEvent($selector, $action=NULL) {
22			return $this->getField()->attachEvent($selector, $action);
			0 ignored issues – show Bug introduced 2016-04-29 17:38 UTC by Report Bug Copy Issue Report It seems like `getField()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			/**
26			* Attach $this to an array of $action=>$selector
27			* @param array $events associative array of events to attach ex : ["#bt-toggle","check"=>"#bt-check","uncheck"=>"#bt-uncheck"]
28			* @return \Ajax\semantic\html\collections\form\AbstractHtmlFormRadioCheckbox
29			*/
30			public function attachEvents($events=array()) {
31			return $this->getField()->attachEvents($events);
			0 ignored issues – show Bug introduced 2016-04-29 17:38 UTC by Report Bug Copy Issue Report It seems like `getField()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33			}

jcheron / phalcon-jquery

Push — master ( 916f6f...ea2a7d )

CheckboxTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like