HtmlListItem::initContent() - Code Metrics - Inspection of "php framework dependencies removed" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 73e21a...085edf )

by Jean-Christophe

created 2016-06-01 01:17 UTC

HtmlListItem::initContent() C

↳ Parent: HtmlListItem

Complexity

Conditions	8
Paths	49

Size

Total Lines	32
Code Lines	25

Duplication

Lines	12
Ratio	37.5 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	12
loc	32
rs	5.3846
cc	8
eloc	25
nc	49
nop	1

<?php

namespace Ajax\semantic\html\content;


use Ajax\service\JArray;
use Ajax\semantic\html\elements\HtmlList;
class HtmlListItem extends HtmlAbsractItem {
	protected $image;

	public function __construct($identifier, $content=NULL) {
		parent::__construct($identifier,"item",$content);
	}
	protected function initContent($content){
		if(\is_array($content)){
			if(JArray::isAssociative($content)===false){

				$icon=@$content[0];
				$title=@$content[1];
				$desc=@$content[2];
			}else{
				$icon=@$content["icon"];
				$image=@$content["image"];
				$title=@$content["title"];
				$header=@$content["header"];
				$desc=@$content["description"];
				$items=@$content["items"];
			}
			if(isset($icon)===true){
				$this->setIcon($icon);
			}
			if(isset($image)===true){
				$this->setImage($image);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
			if(isset($title)===true){
				$this->setTitle($title,$desc);
			}elseif (isset($header)===true){
				$this->setTitle($header,$desc,"header");
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
			if(isset($items)===true){
				$this->addList($items);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
		}else{
			$this->setContent($content);
		}
	}
	public function addList($items=array()) {
		$list=new HtmlList("", $items);
		$list->setClass("list");
		$this->content["list"]=$list;
		return $list;
	}

	public function getList(){
		return $this->content["list"];
	}

	public function getItem($index){
		return $this->getList()->getItem($index);
	}
}

Push — master ( 73e21a...085edf )

HtmlListItem::initContent() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Ajax\semantic\html\content;
4
5
6		use Ajax\service\JArray;
7		use Ajax\semantic\html\elements\HtmlList;
8		class HtmlListItem extends HtmlAbsractItem {
9		protected $image;
10
11		public function __construct($identifier, $content=NULL) {
12		parent::__construct($identifier,"item",$content);
13		}
14		protected function initContent($content){
15		if(\is_array($content)){
16	View Code Duplication	if(JArray::isAssociative($content)===false){
		0 ignored issues – show Duplication introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		$icon=@$content[0];
18		$title=@$content[1];
19		$desc=@$content[2];
20		}else{
21		$icon=@$content["icon"];
22		$image=@$content["image"];
23		$title=@$content["title"];
24		$header=@$content["header"];
25		$desc=@$content["description"];
26		$items=@$content["items"];
27		}
28		if(isset($icon)===true){
29		$this->setIcon($icon);
30		}
31		if(isset($image)===true){
32		$this->setImage($image);
		0 ignored issues – show Bug introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report The variable `$image` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
33		}
34		if(isset($title)===true){
35		$this->setTitle($title,$desc);
36		}elseif (isset($header)===true){
37		$this->setTitle($header,$desc,"header");
		0 ignored issues – show Bug introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report The variable `$header` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
38		}
39		if(isset($items)===true){
40		$this->addList($items);
		0 ignored issues – show Bug introduced 2016-06-01 01:21 UTC by Report Bug Copy Issue Report The variable `$items` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
41		}
42		}else{
43		$this->setContent($content);
44		}
45		}
46		public function addList($items=array()) {
47		$list=new HtmlList("", $items);
48		$list->setClass("list");
49		$this->content["list"]=$list;
50		return $list;
51		}
52
53		public function getList(){
54		return $this->content["list"];
55		}
56
57		public function getItem($index){
58		return $this->getList()->getItem($index);
59		}
60		}

jcheron / phalcon-jquery

Push — master ( 73e21a...085edf )

HtmlListItem::initContent() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like