HtmlTableContent::addColVariations() - Code Metrics - Inspection of "HtmlProgress +Table ended" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9bdcb...b0560a )

by Jean-Christophe

created 2016-05-03 01:04 UTC

HtmlTableContent::addColVariations() A

↳ Parent: HtmlTableContent

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	2
eloc	5
nc	2
nop	2

<?php

namespace Ajax\semantic\html\content\table;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\service\JArray;

/**
 * a table content (thead, tbody or tfoot)
 * @author jc
 *
 */
class HtmlTableContent extends HtmlSemCollection {
	protected $_tdTagNames=[ "thead" => "th","tbody" => "td","tfoot" => "th" ];

	/**
	 *
	 * @param string $identifier
	 * @param string $tagName
	 * @param int $rowCount
	 * @param int $colCount
	 */
	public function __construct($identifier, $tagName="tbody", $rowCount=NULL, $colCount=NULL) {
		parent::__construct($identifier, $tagName, "");
		if (isset($rowCount) && isset($colCount))
			$this->setRowCount($rowCount, $colCount);
	}

	/**
	 *
	 * @param int $rowCount
	 * @param int $colCount
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function setRowCount($rowCount, $colCount) {
		$count=$this->count();
		for($i=$count; $i < $rowCount; $i++) {
			$this->addItem($colCount);
		}
		/*

		 * for($i=0; $i < $rowCount; $i++) {
		 * $item=$this->content[$i];
		 * $item->setTdTagName($this->_tdTagNames[$this->tagName]);
		 * $this->content[$i]->setColCount($colCount);
		 * }
		 */
		return $this;
	}

	public function getTdTagName($tagName) {

		return $this->_tdTagNames[$this->tagName];
	}

	/**
	 *
	 * {@inheritDoc}
	 *
	 * @see \Ajax\common\html\HtmlCollection::createItem()
	 */
	protected function createItem($value) {
		$count=$this->count();
		$tr=new HtmlTR("", $value);

		$tr->setContainer($this, $count);
		$tr->setTdTagName($this->_tdTagNames[$this->tagName]);
		if (isset($value) === true) {
			$tr->setColCount($value);
		}
		return $tr;
	}

	public function newRow($value) {
		return $this->createItem($value);
	}

	public function addRow($colCount) {
		return $this->addItem($colCount);
	}

	public function _addRow($row) {
		$this->addItem($row);
	}

	/**
	 * Returns the cell (HtmlTD) at position $row,$col
	 * @param int $row
	 * @param int $col
	 * @return \Ajax\semantic\html\content\HtmlTD
	 */
	public function getCell($row, $col) {
		$row=$this->getItem($row);
		if (isset($row)) {
			$col=$row->getItem($col);
		}
		return $col;
	}

	/**
	 *
	 * @param int $index
	 * @return \Ajax\semantic\html\content\HtmlTR
	 */
	public function getRow($index) {
		return $this->getItem($index);
	}

	/**
	 *
	 * @param int $row
	 * @param int $col
	 * @param mixed $value
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function setCellValue($row, $col, $value="") {
		$cell=$this->getCell($row, $col);
		if (isset($cell) === true) {
			$cell->setValue($value);
		}
		return $this;
	}

	/**
	 * Sets the cells values
	 * @param mixed $values
	 */
	public function setValues($values=array()) {
		$count=$this->count();
		$isArray=true;
		if (\is_array($values) === false) {
			$values=\array_fill(0, $count, $values);
			$isArray=false;
		}
		if (JArray::dimension($values) == 1 && $isArray)
			$values=[ $values ];

		$count=\min(\sizeof($values), $count);

		for($i=0; $i < $count; $i++) {
			$row=$this->content[$i];
			$row->setValues($values[$i]);
		}
		return $this;
	}

	public function setColValues($colIndex, $values=array()) {
		$count=$this->count();
		if (\is_array($values) === false) {
			$values=\array_fill(0, $count, $values);
		}
		$count=\min(\sizeof($values), $count);
		for($i=0; $i < $count; $i++) {
			$this->getCell($i, $colIndex)->setValue($values[$i]);
		}
		return $this;
	}

	public function addColVariations($colIndex, $variations=array()) {
		$count=$this->count();
		for($i=0; $i < $count; $i++) {
			$this->getCell($i, $colIndex)->addVariations($variations);
		}
		return $this;
	}

	public function setRowValues($rowIndex, $values=array()) {
		$count=$this->count();
		if (\is_array($values) === false) {
			$values=\array_fill(0, $count, $values);
		}
		$this->getItem($rowIndex)->setValues($values);

		return $this;
	}

	private function colAlign($colIndex, $function) {
		$count=$this->count();
		for($i=0; $i < $count; $i++) {
			$index=$this->content[$i]->getColPosition($colIndex);
			if ($index !== NULL)
				$this->getCell($i, $index)->$function();
		}
		return $this;
	}

	public function colCenter($colIndex) {
		return $this->colAlign($colIndex, "textCenterAligned");
	}

	public function colRight($colIndex) {
		return $this->colAlign($colIndex, "textRightAligned");
	}

	public function colLeft($colIndex) {
		return $this->colAlign($colIndex, "textLeftAligned");
	}

	/**
	 * Returns the number of rows (TR)
	 * @return int
	 */
	public function getRowCount() {
		return $this->count();
	}

	/**
	 * Returns the number of columns (TD)
	 * @return int
	 */
	public function getColCount() {
		$result=0;
		if ($this->count() > 0)
			$result=$this->getItem(0)->getColCount();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		return $result;
	}

	/**
	 * Removes the cell at position $rowIndex,$colIndex
	 * @param int $rowIndex
	 * @param int $colIndex
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function delete($rowIndex, $colIndex=NULL) {
		if (isset($colIndex)) {
			$row=$this->getItem($rowIndex);
			if (isset($row) === true) {
				$row->delete($colIndex);
			}
		} else {
			$this->removeItem($rowIndex);
		}
		return $this;
	}

	public function mergeCol($rowIndex=0, $colIndex=0) {
		return $this->getItem($rowIndex)->mergeCol($colIndex);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function mergeRow($rowIndex=0, $colIndex=0) {
		return $this->getItem($rowIndex)->mergeRow($colIndex);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function setFullWidth() {
		return $this->addToProperty("class", "full-width");
	}

	public function sort($colIndex) {
		$this->content[0]->getItem($colIndex)->addToProperty("class", "sorted ascending");
	}

	/**
	 * @param mixed $callback
	 * @param string $format
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function conditionalCellFormat($callback, $format) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->conditionalCellFormat($callback, $format);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @param string $format
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function conditionalRowFormat($callback, $format) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->conditionalRowFormat($callback, $format);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function applyCells($callback) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->applyCells($callback);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function applyRows($callback) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->apply($callback);
		}
		return $this;
	}
}

Push — master ( e9bdcb...b0560a )

HtmlTableContent::addColVariations() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Ajax\semantic\html\content\table;
4
5			use Ajax\semantic\html\base\HtmlSemCollection;
6			use Ajax\service\JArray;
7
8			/**
9			* a table content (thead, tbody or tfoot)
10			* @author jc
11			*
12			*/
13			class HtmlTableContent extends HtmlSemCollection {
14			protected $_tdTagNames=[ "thead" => "th","tbody" => "td","tfoot" => "th" ];
15
16			/**
17			*
18			* @param string $identifier
19			* @param string $tagName
20			* @param int $rowCount
21			* @param int $colCount
22			*/
23			public function __construct($identifier, $tagName="tbody", $rowCount=NULL, $colCount=NULL) {
24			parent::__construct($identifier, $tagName, "");
25			if (isset($rowCount) && isset($colCount))
26			$this->setRowCount($rowCount, $colCount);
27			}
28
29			/**
30			*
31			* @param int $rowCount
32			* @param int $colCount
33			* @return \Ajax\semantic\html\content\table\HtmlTableContent
34			*/
35			public function setRowCount($rowCount, $colCount) {
36			$count=$this->count();
37			for($i=$count; $i < $rowCount; $i++) {
38			$this->addItem($colCount);
39			}
40			/*
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-03 01:08 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41			* for($i=0; $i < $rowCount; $i++) {
42			* $item=$this->content[$i];
43			* $item->setTdTagName($this->_tdTagNames[$this->tagName]);
44			* $this->content[$i]->setColCount($colCount);
45			* }
46			*/
47			return $this;
48			}
49
50			public function getTdTagName($tagName) {
			0 ignored issues – show Unused Code introduced 2016-04-30 01:24 UTC by Report Bug Copy Issue Report The parameter `$tagName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51			return $this->_tdTagNames[$this->tagName];
52			}
53
54			/**
55			*
56			* {@inheritDoc}
57			*
58			* @see \Ajax\common\html\HtmlCollection::createItem()
59			*/
60			protected function createItem($value) {
61			$count=$this->count();
62			$tr=new HtmlTR("", $value);
			0 ignored issues – show Unused Code introduced 2016-04-30 01:24 UTC by Report Bug Copy Issue Report The call to `HtmlTR::__construct()` has too many arguments starting with `$value`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
63			$tr->setContainer($this, $count);
64			$tr->setTdTagName($this->_tdTagNames[$this->tagName]);
65			if (isset($value) === true) {
66			$tr->setColCount($value);
67			}
68			return $tr;
69			}
70
71			public function newRow($value) {
72			return $this->createItem($value);
73			}
74
75			public function addRow($colCount) {
76			return $this->addItem($colCount);
77			}
78
79			public function _addRow($row) {
80			$this->addItem($row);
81			}
82
83			/**
84			* Returns the cell (HtmlTD) at position $row,$col
85			* @param int $row
86			* @param int $col
87			* @return \Ajax\semantic\html\content\HtmlTD
88			*/
89			public function getCell($row, $col) {
90			$row=$this->getItem($row);
91			if (isset($row)) {
92			$col=$row->getItem($col);
93			}
94			return $col;
95			}
96
97			/**
98			*
99			* @param int $index
100			* @return \Ajax\semantic\html\content\HtmlTR
101			*/
102			public function getRow($index) {
103			return $this->getItem($index);
104			}
105
106			/**
107			*
108			* @param int $row
109			* @param int $col
110			* @param mixed $value
111			* @return \Ajax\semantic\html\content\table\HtmlTableContent
112			*/
113			public function setCellValue($row, $col, $value="") {
114			$cell=$this->getCell($row, $col);
115			if (isset($cell) === true) {
116			$cell->setValue($value);
117			}
118			return $this;
119			}
120
121			/**
122			* Sets the cells values
123			* @param mixed $values
124			*/
125			public function setValues($values=array()) {
126			$count=$this->count();
127			$isArray=true;
128			if (\is_array($values) === false) {
129			$values=\array_fill(0, $count, $values);
130			$isArray=false;
131			}
132			if (JArray::dimension($values) == 1 && $isArray)
133			$values=[ $values ];
134
135			$count=\min(\sizeof($values), $count);
136
137			for($i=0; $i < $count; $i++) {
138			$row=$this->content[$i];
139			$row->setValues($values[$i]);
140			}
141			return $this;
142			}
143
144			public function setColValues($colIndex, $values=array()) {
145			$count=$this->count();
146			if (\is_array($values) === false) {
147			$values=\array_fill(0, $count, $values);
148			}
149			$count=\min(\sizeof($values), $count);
150			for($i=0; $i < $count; $i++) {
151			$this->getCell($i, $colIndex)->setValue($values[$i]);
152			}
153			return $this;
154			}
155
156			public function addColVariations($colIndex, $variations=array()) {
157			$count=$this->count();
158			for($i=0; $i < $count; $i++) {
159			$this->getCell($i, $colIndex)->addVariations($variations);
160			}
161			return $this;
162			}
163
164			public function setRowValues($rowIndex, $values=array()) {
165			$count=$this->count();
166			if (\is_array($values) === false) {
167			$values=\array_fill(0, $count, $values);
168			}
169			$this->getItem($rowIndex)->setValues($values);
			0 ignored issues – show Bug introduced 2016-04-29 00:43 UTC by Report Bug Copy Issue Report The method `setValues()` does not exist on `Ajax\common\html\HtmlDoubleElement`. Did you maybe mean `setValue()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
170			return $this;
171			}
172
173			private function colAlign($colIndex, $function) {
174			$count=$this->count();
175			for($i=0; $i < $count; $i++) {
176			$index=$this->content[$i]->getColPosition($colIndex);
177			if ($index !== NULL)
178			$this->getCell($i, $index)->$function();
179			}
180			return $this;
181			}
182
183			public function colCenter($colIndex) {
184			return $this->colAlign($colIndex, "textCenterAligned");
185			}
186
187			public function colRight($colIndex) {
188			return $this->colAlign($colIndex, "textRightAligned");
189			}
190
191			public function colLeft($colIndex) {
192			return $this->colAlign($colIndex, "textLeftAligned");
193			}
194
195			/**
196			* Returns the number of rows (TR)
197			* @return int
198			*/
199			public function getRowCount() {
200			return $this->count();
201			}
202
203			/**
204			* Returns the number of columns (TD)
205			* @return int
206			*/
207			public function getColCount() {
208			$result=0;
209			if ($this->count() > 0)
210			$result=$this->getItem(0)->getColCount();
			0 ignored issues – show Bug introduced 2016-04-27 00:48 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `getColCount()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
211			return $result;
212			}
213
214			/**
215			* Removes the cell at position $rowIndex,$colIndex
216			* @param int $rowIndex
217			* @param int $colIndex
218			* @return \Ajax\semantic\html\content\table\HtmlTableContent
219			*/
220			public function delete($rowIndex, $colIndex=NULL) {
221			if (isset($colIndex)) {
222			$row=$this->getItem($rowIndex);
223			if (isset($row) === true) {
224			$row->delete($colIndex);
225			}
226			} else {
227			$this->removeItem($rowIndex);
228			}
229			return $this;
230			}
231
232			public function mergeCol($rowIndex=0, $colIndex=0) {
233			return $this->getItem($rowIndex)->mergeCol($colIndex);
			0 ignored issues – show Bug introduced 2016-04-28 00:37 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeCol()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
234			}
235
236			public function mergeRow($rowIndex=0, $colIndex=0) {
237			return $this->getItem($rowIndex)->mergeRow($colIndex);
			0 ignored issues – show Bug introduced 2016-04-28 00:37 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeRow()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
238			}
239
240			public function setFullWidth() {
241			return $this->addToProperty("class", "full-width");
242			}
243
244			public function sort($colIndex) {
245			$this->content[0]->getItem($colIndex)->addToProperty("class", "sorted ascending");
246			}
247
248			/**
249			* @param mixed $callback
250			* @param string $format
251			* @return \Ajax\semantic\html\content\table\HtmlTableContent
252			*/
253			public function conditionalCellFormat($callback, $format) {
254			$rows=$this->content;
255			foreach ( $rows as $row ) {
256			$row->conditionalCellFormat($callback, $format);
257			}
258			return $this;
259			}
260
261			/**
262			* @param mixed $callback
263			* @param string $format
264			* @return \Ajax\semantic\html\content\table\HtmlTableContent
265			*/
266			public function conditionalRowFormat($callback, $format) {
267			$rows=$this->content;
268			foreach ( $rows as $row ) {
269			$row->conditionalRowFormat($callback, $format);
270			}
271			return $this;
272			}
273
274			/**
275			* @param mixed $callback
276			* @return \Ajax\semantic\html\content\table\HtmlTableContent
277			*/
278			public function applyCells($callback) {
279			$rows=$this->content;
280			foreach ( $rows as $row ) {
281			$row->applyCells($callback);
282			}
283			return $this;
284			}
285
286			/**
287			* @param mixed $callback
288			* @return \Ajax\semantic\html\content\table\HtmlTableContent
289			*/
290			public function applyRows($callback) {
291			$rows=$this->content;
292			foreach ( $rows as $row ) {
293			$row->apply($callback);
294			}
295			return $this;
296			}
297			}

jcheron / phalcon-jquery

Push — master ( e9bdcb...b0560a )

HtmlTableContent::addColVariations() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like