HtmlFormFields::setGrouped() - Code Metrics - Inspection of "Semantic form fields" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3cf661...c0f044 )

by Jean-Christophe

created 2016-04-16 01:19 UTC

HtmlFormFields::setGrouped() A

↳ Parent: HtmlFormFields

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Ajax\semantic\html\collections\form;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\semantic\html\base\constants\Wide;
use Ajax\JsUtils;
use Phalcon\Mvc\View;
use Ajax\semantic\html\base\HtmlSemDoubleElement;

class HtmlFormFields extends HtmlSemCollection {

	use FieldsTrait;
	protected $_equalWidth;
	protected $_name;

	public function __construct($identifier, $fields=array(),$equalWidth=true) {
		parent::__construct($identifier, "div");
		$this->_equalWidth=$equalWidth;
		$this->addItems($fields);
	}

	/**
	 * @param string|HtmlSemDoubleElement $label
	 * @return \Ajax\semantic\html\base\HtmlSemDoubleElement
	 */
	public function setLabel($label){
		$labelO=$label;
		if(\is_string($label)){
			$labelO=new HtmlSemDoubleElement("","label","",$label);
		}
		$this->insertItem($labelO,0);
		return $labelO;

	}

	public function compile(JsUtils $js=NULL,View $view=NULL){
		if($this->_equalWidth){
			$count=$this->count();
			$this->addToProperty("class", Wide::getConstants()["W".$count]." fields");
		}else
			$this->addToProperty("class","fields");
		return parent::compile($js,$view);
	}

	public function setWidth($index,$width){
		$this->_equalWidth=false;
		return $this->getItem($index)->setWidth($width);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function setInline(){
		$this->_equalWidth=false;
		$this->addToProperty("class", "inline");
	}

	public function setGrouped(){
		$this->_equalWidth=false;
		$this->addToProperty("class", "grouped");
	}

	public function getName() {
		return $this->_name;
	}

	public function setName($_name) {
		$this->_name=$_name;
		return $this;
	}

	public static function radios($name,$items=array(),$label=NULL){
		$fields=array();
		$i=0;
		foreach ($items as $item){
			$fields[]=new HtmlFormRadio($name."-".$i++,$name,$item,$item);
		}
		$radios=new HtmlFormFields("fields-".$name,$fields);
		if(isset($label))
			$radios->setLabel($label)->setProperty("for", $name);
		return $radios;
	}

}

1			<?php
2
3			namespace Ajax\semantic\html\collections\form;
4
5			use Ajax\semantic\html\base\HtmlSemCollection;
6			use Ajax\semantic\html\base\constants\Wide;
7			use Ajax\JsUtils;
8			use Phalcon\Mvc\View;
9			use Ajax\semantic\html\base\HtmlSemDoubleElement;
10
11			class HtmlFormFields extends HtmlSemCollection {
12
13			use FieldsTrait;
14			protected $_equalWidth;
15			protected $_name;
16
17			public function __construct($identifier, $fields=array(),$equalWidth=true) {
18			parent::__construct($identifier, "div");
19			$this->_equalWidth=$equalWidth;
20			$this->addItems($fields);
21			}
22
23			/**
24			* @param string\|HtmlSemDoubleElement $label
25			* @return \Ajax\semantic\html\base\HtmlSemDoubleElement
26			*/
27			public function setLabel($label){
28			$labelO=$label;
29			if(\is_string($label)){
30			$labelO=new HtmlSemDoubleElement("","label","",$label);
31			}
32			$this->insertItem($labelO,0);
33			return $labelO;
			0 ignored issues – show Bug Compatibility introduced 2016-04-16 01:22 UTC by Report Bug Copy Issue Report The expression `return $labelO;` of type `string\|Ajax\semantic\htm...se\HtmlSemDoubleElement` is incompatible with the return type documented by `Ajax\semantic\html\colle...tmlFormFields::setLabel` of type `Ajax\semantic\html\base\HtmlSemDoubleElement` as it can also be of type `string` which is not included in this return type. Loading history...
34			}
35
36			public function compile(JsUtils $js=NULL,View $view=NULL){
37			if($this->_equalWidth){
38			$count=$this->count();
39			$this->addToProperty("class", Wide::getConstants()["W".$count]." fields");
40			}else
41			$this->addToProperty("class","fields");
42			return parent::compile($js,$view);
43			}
44
45			public function setWidth($index,$width){
46			$this->_equalWidth=false;
47			return $this->getItem($index)->setWidth($width);
			0 ignored issues – show Bug introduced 2016-04-16 01:22 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `setWidth()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\bootstrap\html\content\HtmlGridCol`, `Ajax\semantic\html\colle...s\form\HtmlFormCheckbox`, `Ajax\semantic\html\colle...s\form\HtmlFormDropdown`, `Ajax\semantic\html\collections\form\HtmlFormField`, `Ajax\semantic\html\collections\form\HtmlFormFields`, `Ajax\semantic\html\collections\form\HtmlFormInput`, `Ajax\semantic\html\collections\form\HtmlFormRadio`, `Ajax\semantic\html\colle...s\form\HtmlFormTextarea`, `Ajax\semantic\html\content\HtmlGridCol`, `Ajax\semantic\html\content\HtmlGridRow`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
48			}
49
50			public function setInline(){
51			$this->_equalWidth=false;
52			$this->addToProperty("class", "inline");
53			}
54
55			public function setGrouped(){
56			$this->_equalWidth=false;
57			$this->addToProperty("class", "grouped");
58			}
59
60			public function getName() {
61			return $this->_name;
62			}
63
64			public function setName($_name) {
65			$this->_name=$_name;
66			return $this;
67			}
68
69			public static function radios($name,$items=array(),$label=NULL){
70			$fields=array();
71			$i=0;
72			foreach ($items as $item){
73			$fields[]=new HtmlFormRadio($name."-".$i++,$name,$item,$item);
74			}
75			$radios=new HtmlFormFields("fields-".$name,$fields);
76			if(isset($label))
77			$radios->setLabel($label)->setProperty("for", $name);
78			return $radios;
79			}
80
81			}

jcheron / phalcon-jquery

Push — master ( 3cf661...c0f044 )

HtmlFormFields::setGrouped() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like