LabeledIconTrait::addIcon() - Code Metrics - Inspection of "semantic htmlInput" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ba4b1...2affe6 )

by Jean-Christophe

created 2016-04-08 01:27 UTC

LabeledIconTrait::addIcon() A

↳ Parent: LabeledIconTrait

Complexity

Conditions	4
Paths	6

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.2
cc	4
eloc	10
nc	6
nop	3

<?php

namespace Ajax\semantic\html\base\traits;

use Ajax\semantic\html\elements\HtmlIcon;
use Ajax\semantic\html\base\constants\Direction;
trait LabeledIconTrait {

	/**
	 * Adds an icon before or after
	 * @param string|HtmlIcon $icon
	 * @param boolean $before
	 * @param boolean $labeled
	 * @return \Ajax\semantic\html\elements\HtmlIcon
	 */
	public function addIcon($icon,$before=true,$labeled=false){
		$iconO=$icon;
		if(\is_string($icon)){
			$iconO=new HtmlIcon("icon-".$this->identifier, $icon);
class MyClass { }

$x = new MyClass();
$x->foo = true;
		}
		if($labeled!==false){
			$direction=($before===true)?Direction::RIGHT:Direction::LEFT;
			$this->addToProperty("class", $direction." labeled icon");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
			$this->tagName="div";
class MyClass { }

$x = new MyClass();
$x->foo = true;
		}
		$this->addContent($iconO,$before);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		return $iconO;
	}
}

1			<?php
2
3			namespace Ajax\semantic\html\base\traits;
4
5			use Ajax\semantic\html\elements\HtmlIcon;
6			use Ajax\semantic\html\base\constants\Direction;
7			trait LabeledIconTrait {
8
9			/**
10			* Adds an icon before or after
11			* @param string\|HtmlIcon $icon
12			* @param boolean $before
13			* @param boolean $labeled
14			* @return \Ajax\semantic\html\elements\HtmlIcon
15			*/
16			public function addIcon($icon,$before=true,$labeled=false){
17			$iconO=$icon;
18			if(\is_string($icon)){
19			$iconO=new HtmlIcon("icon-".$this->identifier, $icon);
			0 ignored issues – show Bug introduced 2016-04-08 01:30 UTC by Report Bug Copy Issue Report The property `identifier` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21			if($labeled!==false){
22			$direction=($before===true)?Direction::RIGHT:Direction::LEFT;
23			$this->addToProperty("class", $direction." labeled icon");
			0 ignored issues – show Bug introduced 2016-04-08 01:30 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			$this->tagName="div";
			0 ignored issues – show Bug introduced 2016-04-08 01:30 UTC by Report Bug Copy Issue Report The property `tagName` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26			$this->addContent($iconO,$before);
			0 ignored issues – show Bug introduced 2016-04-08 01:30 UTC by Report Bug Copy Issue Report It seems like `addContent()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			return $iconO;
28			}
29			}

jcheron / phalcon-jquery

Push — master ( 0ba4b1...2affe6 )

LabeledIconTrait::addIcon() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like