HtmlLabel - Code Metrics - Inspection of "semantic htmlInput" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ba4b1...2affe6 )

by Jean-Christophe

created 2016-04-08 01:27 UTC

HtmlLabel A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	10.77 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
wmc	8
c	5
b	0
f	0
lcom	1
cbo	5
dl	7
loc	65
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	toCorner()	0	3	1
A	asTag()	0	3	1
A	__construct()	0	4	1
A	setPointing()	0	3	1
A	asLink()	0	3	1
A	setBasic()	0	3	1
A	addImage()	0	4	1
A	addDetail()	7	7	1

How to fix Duplicated Code

<?php

namespace Ajax\semantic\html\elements;

use Ajax\semantic\html\base\HtmlSemDoubleElement;
use Ajax\common\html\html5\HtmlImg;
use Ajax\common\html\HtmlDoubleElement;
use Ajax\semantic\html\base\constants\Direction;
use Ajax\semantic\html\base\traits\LabeledIconTrait;

class HtmlLabel extends HtmlSemDoubleElement {
	use LabeledIconTrait;
	public function __construct($identifier,$caption="",$tagName="div") {
		parent::__construct($identifier,$tagName,"ui label");
		$this->content=$caption;
	}

	/**
	 * @param string $side
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return \Ajax\semantic\html\elements\HtmlLabel
	 */
	public function setPointing($value=Direction::NONE){
		return $this->addToPropertyCtrl("class", $value." pointing",Direction::getConstantValues("pointing"));
	}

	/**
	 * @param string $side
	 * @return \Ajax\semantic\html\elements\HtmlLabel
	 */
	public function toCorner($side="left"){
		return $this->addToPropertyCtrl("class", $side." corner",array("right corner","left corner"));
	}

	/**
	 * @return \Ajax\semantic\html\elements\HtmlLabel
	 */
	public function asTag(){
		return $this->addToProperty("class", "tag");
	}

	/**
	 * @return \Ajax\semantic\html\elements\HtmlLabel
	 */
	public function asLink(){
		return $this->setTagName("a");
	}

	public function setBasic(){
		return $this->addToProperty("class", "basic");
	}

	/**
	 * Adds an image to emphasize
	 * @param string $src
	 * @param string $alt
	 * @param string $before
	 * @return \Ajax\semantic\html\elements\HtmlLabel
	 */
	public function addImage($src,$alt="",$before=true){
		$this->addToProperty("class", "image");
		return $this->addContent(new HtmlImg("image-".$this->identifier,$src,$alt),$before);

	}

	/**
	 * @param string $detail
	 * @return \Ajax\common\html\HtmlDoubleElement
	 */
	public function addDetail($detail){

		$div=new HtmlDoubleElement("detail-".$this->identifier,$this->tagName);
		$div->setClass("detail");
		$div->setContent($detail);
		$this->addContent($div);
		return $div;
	}
}

1		<?php
2
3		namespace Ajax\semantic\html\elements;
4
5		use Ajax\semantic\html\base\HtmlSemDoubleElement;
6		use Ajax\common\html\html5\HtmlImg;
7		use Ajax\common\html\HtmlDoubleElement;
8		use Ajax\semantic\html\base\constants\Direction;
9		use Ajax\semantic\html\base\traits\LabeledIconTrait;
10
11		class HtmlLabel extends HtmlSemDoubleElement {
12		use LabeledIconTrait;
13		public function __construct($identifier,$caption="",$tagName="div") {
14		parent::__construct($identifier,$tagName,"ui label");
15		$this->content=$caption;
16		}
17
18		/**
19		* @param string $side
		0 ignored issues – show Bug introduced 2016-04-07 00:32 UTC by Report Bug Copy Issue Report There is no parameter named `$side`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
20		* @return \Ajax\semantic\html\elements\HtmlLabel
21		*/
22		public function setPointing($value=Direction::NONE){
23		return $this->addToPropertyCtrl("class", $value." pointing",Direction::getConstantValues("pointing"));
24		}
25
26		/**
27		* @param string $side
28		* @return \Ajax\semantic\html\elements\HtmlLabel
29		*/
30		public function toCorner($side="left"){
31		return $this->addToPropertyCtrl("class", $side." corner",array("right corner","left corner"));
32		}
33
34		/**
35		* @return \Ajax\semantic\html\elements\HtmlLabel
36		*/
37		public function asTag(){
38		return $this->addToProperty("class", "tag");
39		}
40
41		/**
42		* @return \Ajax\semantic\html\elements\HtmlLabel
43		*/
44		public function asLink(){
45		return $this->setTagName("a");
46		}
47
48		public function setBasic(){
49		return $this->addToProperty("class", "basic");
50		}
51
52		/**
53		* Adds an image to emphasize
54		* @param string $src
55		* @param string $alt
56		* @param string $before
57		* @return \Ajax\semantic\html\elements\HtmlLabel
58		*/
59		public function addImage($src,$alt="",$before=true){
60		$this->addToProperty("class", "image");
61		return $this->addContent(new HtmlImg("image-".$this->identifier,$src,$alt),$before);
		0 ignored issues – show Bug introduced 2016-04-04 01:15 UTC by Report Bug Copy Issue Report It seems like `$before` defined by parameter `$before` on line 59 can also be of type `string`; however, `Ajax\common\html\HtmlDoubleElement::addContent()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
62		}
63
64		/**
65		* @param string $detail
66		* @return \Ajax\common\html\HtmlDoubleElement
67		*/
68	View Code Duplication	public function addDetail($detail){
		0 ignored issues – show Duplication introduced 2016-04-05 01:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		$div=new HtmlDoubleElement("detail-".$this->identifier,$this->tagName);
70		$div->setClass("detail");
71		$div->setContent($detail);
72		$this->addContent($div);
73		return $div;
74		}
75		}

jcheron / phalcon-jquery

Push — master ( 0ba4b1...2affe6 )

HtmlLabel A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like