Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class HtmlFormField extends HtmlSemDoubleElement { |
||
9 | public function __construct($identifier, $field,$label=NULL) { |
||
16 | |||
17 | public function setLabel($label){ |
||
26 | |||
27 | public function setField($field){ |
||
30 | |||
31 | /** |
||
32 | * Returns the label or null |
||
33 | * @return mixed |
||
34 | */ |
||
35 | public function getLabel(){ |
||
39 | |||
40 | /** |
||
41 | * Return the field |
||
42 | * @return mixed |
||
43 | */ |
||
44 | public function getField(){ |
||
47 | |||
48 | /** |
||
49 | * puts the label before or behind |
||
50 | */ |
||
51 | public function swapLabel(){ |
||
56 | |||
57 | /** |
||
58 | * Defines the field width |
||
59 | * @param int $width |
||
60 | * @return \Ajax\semantic\html\collections\form\HtmlFormField |
||
61 | */ |
||
62 | View Code Duplication | public function setWidth($width){ |
|
69 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.