Ajax\semantic\html\collections\form\HtmlFormFields

Complexity

Total Complexity

26

Size/Duplication

Total Lines	121
Duplicated Lines	33.06 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes	5
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	addFields()	10	18	6
A	setLabel()	0	8	2
A	addItem()	0	5	1
A	compile()	0	8	2
A	setWidth()	0	4	1
A	setInline()	0	5	1
A	setGrouped()	0	4	1
A	getName()	0	3	1
A	setName()	0	4	1
A	radios()	15	15	4
A	checkeds()	15	15	4
A	setEqualWidth()	0	4	1

<?php

namespace Ajax\semantic\html\collections\form;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\semantic\html\base\constants\Wide;
use Ajax\JsUtils;
use Phalcon\Mvc\View;
use Ajax\semantic\html\base\HtmlSemDoubleElement;
use Ajax\semantic\html\collections\form\traits\FieldsTrait;

class HtmlFormFields extends HtmlSemCollection {

	use FieldsTrait;
	protected $_equalWidth;
	protected $_name;

	public function __construct($identifier, $fields=array(),$equalWidth=true) {
		parent::__construct($identifier, "div");
		$this->_equalWidth=$equalWidth;
		$this->addItems($fields);
	}

	public function addFields($fields=NULL,$label=NULL){
		if(!$fields instanceof HtmlFormFields){

This code seems to be duplicated across your project.

			if(\is_array($fields)===false){
				$fields = \func_get_args();
				$end=\end($fields);
				if(\is_string($end)){
					$label=$end;
					\array_pop($fields);
				}else $label=NULL;
			}
		}
		if(isset($label))
			$this->setLabel($label);
		foreach ($fields as $field){

The expression $fields of type array|object<Ajax\semantic\html\collections\form\HtmlFormFields> is not guaranteed to be traversable. How about adding an additional type check?

			$this->addItem($field);
		}
		return $this;
	}

	/**
	 * @param string|HtmlSemDoubleElement $label
	 * @return \Ajax\semantic\html\base\HtmlSemDoubleElement
	 */
	public function setLabel($label){
		$labelO=$label;
		if(\is_string($label)){
			$labelO=new HtmlSemDoubleElement("","label","",$label);
		}
		$this->insertItem($labelO,0);
		return $labelO;

The expression return $labelO; of type string|Ajax\semantic\html\base\HtmlSemDoubleElement is incompatible with the return type documented by Ajax\semantic\html\collections\form\HtmlFormFields::setLabel of type Ajax\semantic\html\base\HtmlSemDoubleElement as it can also be of type string which is not included in this return type.

	}
	public function addItem($item){
		$item=parent::addItem($item);
		$item->setContainer($this);
		return $item;
	}
	public function compile(JsUtils $js=NULL,View $view=NULL){
		if($this->_equalWidth){
			$count=$this->count();
			$this->addToProperty("class", Wide::getConstants()["W".$count]." fields");
		}else
			$this->addToProperty("class","fields");
		return parent::compile($js,$view);
	}

	public function setWidth($index,$width){
		$this->_equalWidth=false;
		return $this->getItem($index)->setWidth($width);

It seems like you code against a specific sub-type and not the parent class Ajax\common\html\HtmlDoubleElement as the method setWidth() does only exist in the following sub-classes of Ajax\common\html\HtmlDoubleElement: Ajax\bootstrap\html\content\HtmlGridCol, Ajax\semantic\html\collections\HtmlGrid, Ajax\semantic\html\collections\form\AbstractHtmlFormRadioCheckbox, Ajax\semantic\html\collections\form\HtmlFormCheckbox, Ajax\semantic\html\collections\form\HtmlFormDropdown, Ajax\semantic\html\collections\form\HtmlFormField, Ajax\semantic\html\collections\form\HtmlFormFields, Ajax\semantic\html\collections\form\HtmlFormInput, Ajax\semantic\html\collections\form\HtmlFormRadio, Ajax\semantic\html\collections\form\HtmlFormTextarea, Ajax\semantic\html\collections\menus\HtmlAccordionMenu, Ajax\semantic\html\collections\menus\HtmlIconMenu, Ajax\semantic\html\collections\menus\HtmlLabeledIconMenu, Ajax\semantic\html\collections\menus\HtmlMenu, Ajax\semantic\html\content\HtmlGridCol, Ajax\semantic\html\content\HtmlGridRow. Maybe you want to instanceof check for one of these explicitly?

	}

	public function setInline(){
		$this->_equalWidth=false;
		$this->addToProperty("class", "inline");
		return $this;
	}

	public function setGrouped(){
		$this->_equalWidth=false;
		$this->addToProperty("class", "grouped");
	}

	public function getName() {
		return $this->_name;
	}

	public function setName($_name) {
		$this->_name=$_name;
		return $this;
	}

	public static function radios($name,$items=array(),$label=NULL,$value=null,$type=NULL){

This method seems to be duplicated in your project.

		$fields=array();
		$i=0;
		foreach ($items as $val=>$caption){
			$itemO=new HtmlFormRadio($name."-".$i++,$name,$caption,$val,$type);
			if($val===$value){
				$itemO->getInput()->getField()->setProperty("checked", "");
			}
			$fields[]=$itemO;
		}
		$radios=new HtmlFormFields("fields-".$name,$fields);
		if(isset($label))
			$radios->setLabel($label)->setProperty("for", $name);
		return $radios;
	}

	public static function checkeds($name,$items=array(),$label=NULL,$values=array(),$type=NULL){

This method seems to be duplicated in your project.

		$fields=array();
		$i=0;
		foreach ($items as $val=>$caption){
			$itemO=new HtmlFormCheckbox($name."-".$i++,$name,$caption,$val,$type);

The call to HtmlFormCheckbox::__construct() has too many arguments starting with $type.

			if(\array_search($val, $values)!==false){
				$itemO->getInput()->getField()->setProperty("checked", "");
			}
			$fields[]=$itemO;
		}
		$radios=new HtmlFormFields("fields-".$name,$fields);
		if(isset($label))
			$radios->setLabel($label)->setProperty("for", $name);
			return $radios;
	}

	public function setEqualWidth($_equalWidth) {
		$this->_equalWidth=$_equalWidth;
		return $this;
	}


}