jcheron /
phalcon-jquery
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like HtmlGrid often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HtmlGrid, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class HtmlGrid extends HtmlSemCollection{ |
||
| 20 | use TextAlignmentTrait; |
||
| 21 | private $_createCols; |
||
| 22 | private $_colSizing=true; |
||
| 23 | private $_implicitRows=false; |
||
| 24 | |||
| 25 | public function __construct( $identifier,$numRows=1,$numCols=NULL,$createCols=true,$implicitRows=false){ |
||
| 37 | |||
| 38 | public function asSegment(){ |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Defines the grid width (alias for setWidth) |
||
| 44 | * @param int $wide |
||
| 45 | */ |
||
| 46 | public function setWide($wide){ |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Defines the grid width |
||
| 54 | * @param int $width |
||
| 55 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 56 | */ |
||
| 57 | public function setWidth($width){ |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Adds a row with $colsCount columns |
||
| 63 | * @param int $colsCount number of columns to create |
||
| 64 | * @return mixed |
||
| 65 | */ |
||
| 66 | public function addRow($colsCount=NULL){ |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Adds a col |
||
| 74 | * @param int $width with of the column to add |
||
| 75 | * @return mixed|\Ajax\semantic\html\collections\HtmlGrid |
||
| 76 | */ |
||
| 77 | public function addCol($width=NULL){ |
||
| 84 | |||
| 85 | /** |
||
| 86 | * @param array $sizes array of width of the columns to create |
||
| 87 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 88 | */ |
||
| 89 | public function addCols($sizes=array()){ |
||
| 95 | |||
| 96 | /** |
||
| 97 | * Create $rowsCount rows |
||
| 98 | * @param int $rowsCount |
||
| 99 | * @param int $colsCount |
||
| 100 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 101 | */ |
||
| 102 | public function setRowsCount($rowsCount,$colsCount=NULL,$force=false){ |
||
| 122 | |||
| 123 | protected function hasOnlyCols($count){ |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Defines the number of columns in the grid |
||
| 129 | * @param int $numCols |
||
| 130 | * @param boolean $toCreate |
||
| 131 | * @param int $width |
||
| 132 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 133 | */ |
||
| 134 | public function setColsCount($numCols,$toCreate=true,$width=NULL){ |
||
| 151 | |||
| 152 | /** |
||
| 153 | * return the row at $index |
||
| 154 | * @param int $index |
||
| 155 | * @return \Ajax\semantic\html\collections\HtmlGridRow |
||
| 156 | */ |
||
| 157 | public function getRow($index){ |
||
| 160 | |||
| 161 | /** |
||
| 162 | * Returns the row count |
||
| 163 | * @return int |
||
| 164 | */ |
||
| 165 | public function rowCount(){ |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Returns the column count |
||
| 174 | * @return int |
||
| 175 | */ |
||
| 176 | public function colCount(){ |
||
| 184 | |||
| 185 | /** |
||
| 186 | * Returns the cell (HtmlGridCol) at position rrow,$col |
||
| 187 | * @param int $row |
||
| 188 | * @param int $col |
||
| 189 | * @return \Ajax\semantic\html\collections\HtmlGridCol |
||
| 190 | */ |
||
| 191 | public function getCell($row,$col){ |
||
| 200 | |||
| 201 | /** |
||
| 202 | * Adds dividers between columns ($vertically=false) or between rows ($vertically=true) |
||
| 203 | * @param boolean $vertically |
||
| 204 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 205 | */ |
||
| 206 | public function setDivided($vertically=false){ |
||
| 210 | |||
| 211 | /** |
||
| 212 | * Divides rows into cells |
||
| 213 | * @param boolean $internally true for internal cells |
||
| 214 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 215 | */ |
||
| 216 | public function setCelled($internally=false){ |
||
| 220 | |||
| 221 | /** |
||
| 222 | * A grid can have its columns centered |
||
| 223 | */ |
||
| 224 | public function setCentered(){ |
||
| 227 | |||
| 228 | /** |
||
| 229 | * automatically resize all elements to split the available width evenly |
||
| 230 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 231 | */ |
||
| 232 | public function setEqualWidth(){ |
||
| 235 | |||
| 236 | /** |
||
| 237 | * Adds vertical or/and horizontal gutters |
||
| 238 | * @param string $value |
||
| 239 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 240 | */ |
||
| 241 | public function setPadded($value=NULL){ |
||
| 246 | |||
| 247 | /** |
||
| 248 | * @param boolean $very |
||
| 249 | * @return \Ajax\semantic\html\collections\HtmlGrid |
||
| 250 | */ |
||
| 251 | public function setRelaxed($very=false){ |
||
| 255 | |||
| 256 | public function setVerticalAlignment($value=VerticalAlignment::MIDDLE){ |
||
| 259 | |||
| 260 | /** |
||
| 261 | * {@inheritDoc} |
||
| 262 | * @see \Ajax\common\html\HtmlCollection::createItem() |
||
| 263 | */ |
||
| 264 | protected function createItem($value){ |
||
| 270 | |||
| 271 | /** |
||
| 272 | * Sets $values to the grid |
||
| 273 | * @param array $values |
||
| 274 | */ |
||
| 275 | public function setValues($values,$force=true){ |
||
| 288 | |||
| 289 | /** |
||
| 290 | * stretch the row contents to take up the entire column height |
||
| 291 | * @return \Ajax\semantic\html\content\HtmlGridRow |
||
| 292 | */ |
||
| 293 | public function setStretched(){ |
||
| 296 | |||
| 297 | } |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.