SemanticComponentsTrait::popup() - Code Metrics - Inspection of "JsUtils & Jquery refactoring with traits" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 79b035...e37d9a )

by Jean-Christophe

created 2016-04-17 22:36 UTC

SemanticComponentsTrait::popup() A

↳ Parent: SemanticComponentsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php

namespace Ajax\semantic\traits;
use Ajax\common\components\GenericComponent;
use Ajax\semantic\components\Popup;
use Ajax\semantic\components\Dropdown;
use Ajax\semantic\components\Accordion;
trait SemanticComponentsTrait {
	/**
	 *
	 * @param string $attachTo
	 * @param string|array $params
	 * @return $this
	 */
	public function generic($attachTo=NULL, $params=NULL) {
		return $this->addComponent(new GenericComponent($this->js), $attachTo, $params);
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}
	/**
	 *
	 * @param string $attachTo
	 * @param string|array $params
	 * @return $this
	 */
	public function popup($attachTo=NULL, $params=NULL) {
		return $this->addComponent(new Popup($this->js), $attachTo, $params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function dropdown($attachTo=NULL, $params=NULL) {
		return $this->addComponent(new Dropdown($this->js), $attachTo, $params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function accordion($attachTo=NULL, $params=NULL) {
		return $this->addComponent(new Accordion($this->js), $attachTo, $params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

}

1			<?php
2
3			namespace Ajax\semantic\traits;
4			use Ajax\common\components\GenericComponent;
5			use Ajax\semantic\components\Popup;
6			use Ajax\semantic\components\Dropdown;
7			use Ajax\semantic\components\Accordion;
8			trait SemanticComponentsTrait {
9			/**
10			*
11			* @param string $attachTo
12			* @param string\|array $params
13			* @return $this
14			*/
15			public function generic($attachTo=NULL, $params=NULL) {
16			return $this->addComponent(new GenericComponent($this->js), $attachTo, $params);
			0 ignored issues – show Bug introduced 2016-04-17 22:39 UTC by Report Bug Copy Issue Report The property `js` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2016-04-17 22:39 UTC by Report Bug Copy Issue Report It seems like `addComponent()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18			/**
19			*
20			* @param string $attachTo
21			* @param string\|array $params
22			* @return $this
23			*/
24			public function popup($attachTo=NULL, $params=NULL) {
25			return $this->addComponent(new Popup($this->js), $attachTo, $params);
			0 ignored issues – show Bug introduced 2016-04-17 22:39 UTC by Report Bug Copy Issue Report It seems like `addComponent()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27
28			public function dropdown($attachTo=NULL, $params=NULL) {
29			return $this->addComponent(new Dropdown($this->js), $attachTo, $params);
			0 ignored issues – show Bug introduced 2016-04-17 22:39 UTC by Report Bug Copy Issue Report It seems like `addComponent()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			}
31
32			public function accordion($attachTo=NULL, $params=NULL) {
33			return $this->addComponent(new Accordion($this->js), $attachTo, $params);
			0 ignored issues – show Bug introduced 2016-04-17 22:39 UTC by Report Bug Copy Issue Report It seems like `addComponent()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			}

jcheron / phalcon-jquery

Push — master ( 79b035...e37d9a )

SemanticComponentsTrait::popup() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like