Ajax\bootstrap\html\HtmlBreadcrumbs

Complexity

Total Complexity

29

Size/Duplication

Total Lines	195
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	0	Features	0

17 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	addElement()	0	18	4
A	setActive()	0	9	2
A	addElements()	0	6	2
A	fromArray()	0	5	1
A	getHref()	0	10	3
A	compile()	0	6	2
A	fromDatabaseObject()	0	3	1
A	on()	0	6	2
A	setAutoActive()	0	4	1
A	_ajaxOn()	0	6	2
A	autoGetOnClick()	0	3	1
A	contentAsString()	0	6	2
A	getElement()	0	3	1
A	addGlyph()	0	4	1
A	fromDispatcher()	0	5	1
A	setHrefFunction()	0	4	1

<?php
namespace Ajax\bootstrap\html;

use Ajax\bootstrap\html\base\HtmlDoubleElement;
use Ajax\bootstrap\html\HtmlLink;
use Ajax\JsUtils;
use Phalcon\Mvc\View;
use Phalcon\Mvc\Dispatcher;
use Ajax\bootstrap\html\base\HtmlNavElement;

As per PSR2, there should be exactly one blank line after the last USE statement, 0 were found though.

/**
 * Twitter Bootstrap Breadcrumbs component
 * @see http://getbootstrap.com/components/#breadcrumbs
 * @author jc
 * @version 1.001
 */
class HtmlBreadcrumbs extends HtmlNavElement {

As per PSR2, the opening brace for this class should be on a new line.

	/**
	 * @var boolean $autoActive sets the last element's class to <b>active</b> if true
	 */
	protected $autoActive;
	
	/**
	 * @var boolean if set to true, the path of the elements is absolute
	 */
	protected $absolutePaths;
	
	/**
	 * @var function the function who generates the href elements. default : function($e){return $e->getContent()}
	 */
	protected $_hrefFunction;

Please declare explicit visibility instead of using a prefixed underscore.

		
	/**
	 * @param string $identifier
	 * @param array $elements
	 * @param boolean $autoActive sets the last element's class to <b>active</b> if true
	 * @param function $hrefFunction the function who generates the href elements. default : function($e){return $e->getContent()}
	 */
	public function __construct($identifier,$elements=array(),$autoActive=true,$hrefFunction=NULL){
		parent::__construct($identifier,"ol");
		$this->setProperty("class", "breadcrumb");
		$this->content=array();
		$this->autoActive=$autoActive;
		$this->absolutePaths;
		$this->_hrefFunction=function ($e){return $e->getContent();};

It seems like function ($e) { return $e->getContent(); } of type object<Closure> is incompatible with the declared type object<Ajax\bootstrap\html\function> of property $_hrefFunction.

		if(isset($hrefFunction)){
			$this->_hrefFunction=$hrefFunction;
		}
		$this->addElements($elements);
	}
	
	/**
	 * @param mixed $element
	 * @param string $href
	 * @return \Ajax\bootstrap\html\HtmlLink
	 */
	public function addElement($element,$href="",$glyph=NULL){
		$size=sizeof($this->content);

As per coding-style, the use of the aliased function sizeof() should be avoided; please use count() instead.

		if(is_array($element)){
			$elm=new HtmlLink("lnk-".$this->identifier."-".$size);
			$elm->fromArray($element);
		}else if($element instanceof HtmlLink){
			$elm=$element;
		}else{
			$elm=new HtmlLink("lnk-".$this->identifier."-".$size,$href,$element);
			if(isset($glyph)){
				$elm->wrapContentWithGlyph($glyph);
			}
		}
		$elm->wrap("<li>","</li>");
		$this->content[]=$elm;
		$elm->setProperty($this->attr, $this->getHref($size));
		return $elm;
	}
	
	public function setActive($index=null){
		if(!isset($index)){
			$index=sizeof($this->content)-1;

As per coding-style, the use of the aliased function sizeof() should be avoided; please use count() instead.

		}
		$li=new HtmlDoubleElement("","li");
		$li->setClass("active");
		$li->setContent($this->content[$index]->getContent());
		$this->content[$index]=$li;
	}
	
	public function addElements($elements){
		foreach ( $elements as $element ) {
			$this->addElement($element);
		}
		return $this;
	}
	
	public function fromArray($array){
		$array=parent::fromArray($array);
		$this->addElements($array);
		return $array;
	}
	
	/**
	 * Return the url of the element at $index or the breadcrumbs url if $index is ommited
	 * @param int $index
	 * @param string $separator
	 * @return string
	 */
	public function getHref($index=null,$separator="/"){
		if(!isset($index)){
			$index=sizeof($this->content);

As per coding-style, the use of the aliased function sizeof() should be avoided; please use count() instead.

		}
		if($this->absolutePaths===true){
			return $this->_hrefFunction($this->content[$index]);

The method _hrefFunction does not exist on object<Ajax\bootstrap\html\HtmlBreadcrumbs>? Since you implemented __call, maybe consider adding a @method annotation.

		}else{
			return $this->root.implode($separator, array_slice(array_map(function($e){return $this->_hrefFunction($e);}, $this->content),0,$index+1));

The method _hrefFunction does not exist on object<Ajax\bootstrap\html\HtmlBreadcrumbs>? Since you implemented __call, maybe consider adding a @method annotation.

		}
	}
	
	/*
	 * (non-PHPdoc)
	 * @see \Ajax\bootstrap\html\BaseHtml::compile()
	 */
	public function compile(JsUtils $js=NULL, View $view=NULL) {
		if($this->autoActive){
			$this->setActive();
		}
		return parent::compile($js, $view);
	}
	
	/* (non-PHPdoc)
	 * @see \Ajax\bootstrap\html\base\BaseHtml::fromDatabaseObject()
	 */
	public function fromDatabaseObject($object, $function) {
		return $this->addElement($function($object));
	}
	
		/*
	 * (non-PHPdoc)
	 * @see \Ajax\bootstrap\html\base\BaseHtml::on()
	 */
	public function on($event, $jsCode, $stopPropagation=false, $preventDefault=false) {
		foreach ($this->content as $element){
			$element->on($event,$jsCode,$stopPropagation,$preventDefault);
		}
		return $this;
	}
	
	public function setAutoActive($autoActive) {
		$this->autoActive = $autoActive;
		return $this;
	}
	
	public function _ajaxOn($operation, $event, $url, $responseElement="", $parameters=array()) {

Method name "_ajaxOn" should not be prefixed with an underscore to indicate visibility

		foreach ($this->content as $element){
			$element->_ajaxOn($operation, $event, $url, $responseElement, $parameters);
		}
		return $this;
	}
	
	/**
	 * Associate an ajax get to the breadcrumbs elements, displayed in $targetSelector
	 * $attr member is used to build each element url
	 * @param string $targetSelector the target of the get
	 * @param string $attr the html attribute used to build the elements url 

There is no parameter named $attr. Was it maybe removed?

	 * @return HtmlBreadcrumbs
	 */
	public function autoGetOnClick($targetSelector){
		return $this->getOnClick($this->root, $targetSelector,array("attr"=>$this->attr));
	}
	
	public function contentAsString(){
		if($this->autoActive){
			$this->setActive();
		}	
		return parent::contentAsString();
	}
	
	public function getElement($index){
		return $this->content[$index];
	}
	
	/**
	 * Add a glyphicon to the element at index $index
	 * @param mixed $glyph
	 * @param int $index
	 */
	public function addGlyph($glyph,$index){
		$elm=$this->getElement($index);
		return $elm->wrapContentWithGlyph($glyph);
	}
	
	/**
	 * Add new elements in breadcrumbs corresponding to request dispatcher : controllerName, actionName, parameters
	 * @param Dispatcher $dispatcher the request dispatcher
	 * @return \Ajax\bootstrap\html\HtmlBreadcrumbs
	 */
	public function fromDispatcher($dispatcher){
		$items=array($dispatcher->getControllerName(),$dispatcher->getActionName());
		$items=array_merge($items,$dispatcher->getParams());
		return $this->addElements($items);
	}
	
	
	/**
	 * sets the function who generates the href elements. default : function($element){return $element->getContent()}
	 * @param function $_hrefFunction
	 * @return \Ajax\bootstrap\html\HtmlBreadcrumbs
	 */
	public function setHrefFunction($_hrefFunction) {
		$this->_hrefFunction = $_hrefFunction;
		return $this;
	}	
	
}

According to PSR2, the closing brace of classes should be placed on the next line directly after the body.