BaseTrait - Code Metrics - Inspection of "constants refactoring" - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db82f0...0ba4b1 )

by Jean-Christophe

created 2016-04-07 19:31 UTC

BaseTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	9
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	58
rs	10

9 Methods

Rating	Name	Size	Complexity
A	addVariation()	3	1
A	addState()	3	1
A	setVariation()	4	1
A	setState()	4	1
A	setSize()	3	1
A	setDisabled()	3	1
A	setColor()	3	1
A	setFluid()	3	1
A	setInverted()	3	1

<?php

namespace Ajax\semantic\html\base\traits;

use Ajax\semantic\html\base\constants\Size;
use Ajax\semantic\html\base\constants\Color;
trait BaseTrait {
	protected $_variations=[];
	protected $_states=[];
	protected $_baseClass;

	public function addVariation($variation){
		return $this->addToPropertyCtrl("class", $variation, $this->_variations);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function addState($state){
		return $this->addToPropertyCtrl("class", $state, $this->_states);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function setVariation($variation){
		$this->setPropertyCtrl("class", $variation, $this->_variations);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		return $this->addToProperty("class", $this->_baseClass);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function setState($state){
		$this->setPropertyCtrl("class", $state, $this->_states);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		return $this->addToProperty("class", $this->_baseClass);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * {@inheritDoc}
	 * @see \Ajax\common\html\HtmlSingleElement::setSize()
	 */
	public function setSize($size){
		return $this->addToPropertyCtrl("class", $size, Size::getConstants());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * show it is currently unable to be interacted with
	 * @return \Ajax\semantic\html\elements\HtmlSemDoubleElement
	 */
	public function setDisabled(){
		return $this->addToProperty("class", "disabled");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * @param string $color
	 * @return \Ajax\semantic\html\base\HtmlSemDoubleElement
	 */
	public function setColor($color){
		return $this->addToPropertyCtrl("class", $color,Color::getConstants());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	public function setFluid(){
		$this->addToProperty("class", "fluid");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * can be formatted to appear on dark backgrounds
	 */
	public function setInverted(){
		$this->addToProperty("class", "inverted");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}
}

1			<?php
2
3			namespace Ajax\semantic\html\base\traits;
4
5			use Ajax\semantic\html\base\constants\Size;
6			use Ajax\semantic\html\base\constants\Color;
7			trait BaseTrait {
8			protected $_variations=[];
9			protected $_states=[];
10			protected $_baseClass;
11
12			public function addVariation($variation){
13			return $this->addToPropertyCtrl("class", $variation, $this->_variations);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			}
15
16			public function addState($state){
17			return $this->addToPropertyCtrl("class", $state, $this->_states);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			}
19
20			public function setVariation($variation){
21			$this->setPropertyCtrl("class", $variation, $this->_variations);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `setPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			return $this->addToProperty("class", $this->_baseClass);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			public function setState($state){
26			$this->setPropertyCtrl("class", $state, $this->_states);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `setPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			return $this->addToProperty("class", $this->_baseClass);
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			}
29
30			/**
31			* {@inheritDoc}
32			* @see \Ajax\common\html\HtmlSingleElement::setSize()
33			*/
34			public function setSize($size){
35			return $this->addToPropertyCtrl("class", $size, Size::getConstants());
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37
38			/**
39			* show it is currently unable to be interacted with
40			* @return \Ajax\semantic\html\elements\HtmlSemDoubleElement
41			*/
42			public function setDisabled(){
43			return $this->addToProperty("class", "disabled");
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			}
45
46			/**
47			* @param string $color
48			* @return \Ajax\semantic\html\base\HtmlSemDoubleElement
49			*/
50			public function setColor($color){
51			return $this->addToPropertyCtrl("class", $color,Color::getConstants());
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToPropertyCtrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52			}
53
54			public function setFluid(){
55			$this->addToProperty("class", "fluid");
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56			}
57
58			/**
59			* can be formatted to appear on dark backgrounds
60			*/
61			public function setInverted(){
62			$this->addToProperty("class", "inverted");
			0 ignored issues – show Bug introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report It seems like `addToProperty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
63			}
64			}

jcheron / phalcon-jquery

Push — master ( db82f0...0ba4b1 )

BaseTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like