jcheron /
phalcon-jquery
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class Button extends SimpleComponent { |
||
| 15 | |||
| 16 | public function __construct(JsUtils $js) { |
||
| 17 | parent::__construct($js); |
||
| 18 | $this->uiName="button"; |
||
| 19 | } |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Disables the button if set to true. |
||
| 23 | * @param Boolean $value default : false |
||
| 24 | * @return $this |
||
| 25 | */ |
||
| 26 | public function setDisabled($value) { |
||
| 27 | return $this->setParamCtrl("disabled", $value, "is_bool"); |
||
| 28 | } |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Icons to display, with or without text (see text option). |
||
| 32 | * By default, the primary icon is displayed on the left of the label text and the secondary is displayed on the right. |
||
| 33 | * The positioning can be controlled via CSS. |
||
| 34 | * The value for the primary and secondary properties must match an icon class name, e.g., "ui-icon-gear". |
||
| 35 | * For using only one icon: icons: { primary: "ui-icon-locked" }. For using two icons: icons: { primary: "ui-icon-gear", secondary: "ui-icon-triangle-1-s" }. |
||
| 36 | * @param String $value default : { primary: null, secondary: null } |
||
| 37 | * @return $this |
||
| 38 | */ |
||
| 39 | View Code Duplication | public function setIcons($value) { |
|
|
|
|||
| 40 | if (is_string($value)) { |
||
| 41 | if (Text::startsWith($value, "{")) |
||
| 42 | ; |
||
| 43 | $value="%".$value."%"; |
||
| 44 | } |
||
| 45 | return $this->setParam("icons", $value); |
||
| 46 | } |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Whether to show the label. |
||
| 50 | * When set to false no text will be displayed, but the icons option must be enabled, otherwise the text option will be ignored. |
||
| 51 | * @param Boolean $value default : false |
||
| 52 | * @return $this |
||
| 53 | */ |
||
| 54 | public function setText($value) { |
||
| 55 | return $this->setParamCtrl("text", $value, "is_bool"); |
||
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Text to show in the button. |
||
| 60 | * When not specified (null), the element's HTML content is used, or its value attribute if the element is an input element of type submit or reset, |
||
| 61 | * or the HTML content of the associated label element if the element is an input of type radio or checkbox. |
||
| 62 | * @param string $value default : null |
||
| 63 | * @return $this |
||
| 64 | */ |
||
| 65 | public function setLabel($value) { |
||
| 68 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.