HtmlButtontoolbar - Code Metrics - jcheron/phalcon-jquery - Measure and Improve Code Quality continuously with Scrutinizer

HtmlButtontoolbar A
last analyzed 2017-03-26 14:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	15
c	0
b	0
f	0
lcom	1
cbo	1
dl	0
loc	85
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	addElement()	7	2
A	addGroup()	6	1
A	getLastButtonGroup()	10	2
A	getGroup()	3	1
A	getLastGroup()	7	2
B	getElement()	19	6

<?php

namespace Ajax\bootstrap\html;

/**
 * Twitter Bootstrap HTML Button toolbar
 * @see http://getbootstrap.com/components/#btn-groups-toolbar
 * @author jc
 * @version 1.001
 */
use Ajax\bootstrap\html\HtmlButtongroups;

class HtmlButtontoolbar extends HtmlButtongroups {

	public function __construct($identifier, $elements=array(), $cssStyle=NULL, $size=NULL, $tagName="div") {
		parent::__construct($identifier, $elements, $cssStyle, $size, $tagName);
		$this->setClass("btn-toolbar");
	}

	/*
	 * (non-PHPdoc)
	 * @see \Ajax\bootstrap\html\HtmlButtongroups::addElement()
	 */
	public function addElement($element) {
		if ($element instanceof HtmlButtongroups) {
			$this->elements []=$element;
		} else {
			$this->getLastButtonGroup()->addElement($element);
		}
	}

	/**
	 * Add and return a new buttongroup
	 * @return \Ajax\bootstrap\html\HtmlButtongroups
	 */
	public function addGroup() {
		$nb=sizeof($this->elements);
		$bg=new HtmlButtongroups($this->identifier."-buttongroups-".$nb);
		$this->elements []=$bg;
		return $bg;
	}

	/**
	 *
	 * @return HtmlButtongroups
	 */
	private function getLastButtonGroup() {
		$nb=sizeof($this->elements);
		if ($nb>0)
			$bg=$this->elements [$nb-1];

		else {
			$bg=new HtmlButtongroups($this->identifier."-buttongroups-".$nb);
			$this->elements []=$bg;
		}
		return $bg;
	}

	/**
	 * return the Buttongroups at position $index
	 * @return \Ajax\bootstrap\html\HtmlButtongroups
	 */
	public function getGroup($index) {
		return parent::getElement($index);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}

	public function getLastGroup() {
		$bg=null;
		$nb=sizeof($this->elements);
		if ($nb>0)
			$bg=$this->elements [$nb-1];
		return $bg;
	}

	/*
	 * (non-PHPdoc)
	 * @see \Ajax\bootstrap\html\HtmlButtongroups::getElement()
	 */
	public function getElement($index) {
		$element=null;
		$i=0;
		if (is_int($index)) {
			$elements=array ();
			foreach ( $this->elements as $group ) {
				$elements=array_merge($elements, $group->getElements());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			}
			if ($index<sizeof($elements)) {
				$element=$elements [$index];
			}
		} else {
			while ( $element==null&&$i<sizeof($this->elements) ) {
				$element=$this->elements [$i]->getElement($index);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
				$i++;
			}
		}
		return $element;
	}
}

1			<?php
2
3			namespace Ajax\bootstrap\html;
4
5			/**
6			* Twitter Bootstrap HTML Button toolbar
7			* @see http://getbootstrap.com/components/#btn-groups-toolbar
8			* @author jc
9			* @version 1.001
10			*/
11			use Ajax\bootstrap\html\HtmlButtongroups;
12
13			class HtmlButtontoolbar extends HtmlButtongroups {
14
15			public function __construct($identifier, $elements=array(), $cssStyle=NULL, $size=NULL, $tagName="div") {
16			parent::__construct($identifier, $elements, $cssStyle, $size, $tagName);
17			$this->setClass("btn-toolbar");
18			}
19
20			/*
21			* (non-PHPdoc)
22			* @see \Ajax\bootstrap\html\HtmlButtongroups::addElement()
23			*/
24			public function addElement($element) {
25			if ($element instanceof HtmlButtongroups) {
26			$this->elements []=$element;
27			} else {
28			$this->getLastButtonGroup()->addElement($element);
29			}
30			}
31
32			/**
33			* Add and return a new buttongroup
34			* @return \Ajax\bootstrap\html\HtmlButtongroups
35			*/
36			public function addGroup() {
37			$nb=sizeof($this->elements);
38			$bg=new HtmlButtongroups($this->identifier."-buttongroups-".$nb);
39			$this->elements []=$bg;
40			return $bg;
41			}
42
43			/**
44			*
45			* @return HtmlButtongroups
46			*/
47			private function getLastButtonGroup() {
48			$nb=sizeof($this->elements);
49			if ($nb>0)
50			$bg=$this->elements [$nb-1];
			0 ignored issues – show Bug Compatibility introduced 2016-02-12 01:01 UTC by Report Bug Copy Issue Report The expression `$this->elements[$nb - 1];` of type `Ajax\bootstrap\html\Html...p\html\HtmlButtongroups` adds the type `Ajax\bootstrap\html\HtmlButton` to the return on line 55 which is incompatible with the return type documented by `Ajax\bootstrap\html\Html...bar::getLastButtonGroup` of type `Ajax\bootstrap\html\HtmlButtongroups`. Loading history...
51			else {
52			$bg=new HtmlButtongroups($this->identifier."-buttongroups-".$nb);
53			$this->elements []=$bg;
54			}
55			return $bg;
56			}
57
58			/**
59			* return the Buttongroups at position $index
60			* @return \Ajax\bootstrap\html\HtmlButtongroups
61			*/
62			public function getGroup($index) {
63			return parent::getElement($index);
			0 ignored issues – show Comprehensibility Bug introduced 2015-11-21 00:23 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getElement()` instead of `getGroup()`). Are you sure this is correct? If so, you might want to change this to `$this->getElement()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
64			}
65
66			public function getLastGroup() {
67			$bg=null;
68			$nb=sizeof($this->elements);
69			if ($nb>0)
70			$bg=$this->elements [$nb-1];
71			return $bg;
72			}
73
74			/*
75			* (non-PHPdoc)
76			* @see \Ajax\bootstrap\html\HtmlButtongroups::getElement()
77			*/
78			public function getElement($index) {
79			$element=null;
80			$i=0;
81			if (is_int($index)) {
82			$elements=array ();
83			foreach ( $this->elements as $group ) {
84			$elements=array_merge($elements, $group->getElements());
			0 ignored issues – show Bug introduced 2015-11-21 00:23 UTC by Report Bug Copy Issue Report The method `getElements` does only exist in `Ajax\bootstrap\html\HtmlButtongroups`, but not in `Ajax\bootstrap\html\HtmlButton`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
85			}
86			if ($index<sizeof($elements)) {
87			$element=$elements [$index];
88			}
89			} else {
90			while ( $element==null&&$i<sizeof($this->elements) ) {
91			$element=$this->elements [$i]->getElement($index);
			0 ignored issues – show Bug introduced 2015-11-21 00:23 UTC by Report Bug Copy Issue Report The method `getElement` does only exist in `Ajax\bootstrap\html\HtmlButtongroups`, but not in `Ajax\bootstrap\html\HtmlButton`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
92			$i++;
93			}
94			}
95			return $element;
96			}
97			}

jcheron / phalcon-jquery

HtmlButtontoolbar A last analyzed 2017-03-26 14:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

HtmlButtontoolbar A
last analyzed 2017-03-26 14:06 UTC