Issues in KeyboardTrait.php (master) - Issues in master - jcalderonzumba/MinkPhantomJSDriver - Measure and Improve Code Quality continuously with Scrutinizer

Issues (39)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/KeyboardTrait.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Zumba\Mink\Driver;

use Behat\Mink\Exception\DriverException;

/**
 * Class KeyboardTrait
 * @package Zumba\Mink\Driver
 */
trait KeyboardTrait {

  /**
   * Does some normalization for the char we want to do keyboard events with.
   * @param $char
   * @throws DriverException
   * @return string
   */
  protected function normalizeCharForKeyEvent($char) {
    if (!is_int($char) && !is_string($char)) {
      throw new DriverException("Unsupported key type, can only be integer or string");
    }

    if (is_string($char) && strlen($char) !== 1) {
      throw new DriverException("Key can only have ONE character");
    }

    $key = $char;
    if (is_int($char)) {
      $key = chr($char);
    }
    return $key;
  }

  /**
   * Does some control and normalization for the key event modifier
   * @param $modifier
   * @return string
   * @throws DriverException
   */
  protected function keyEventModifierControl($modifier) {
    if ($modifier === null) {
      $modifier = "none";
    }

    if (!in_array($modifier, array("none", "alt", "ctrl", "shift", "meta"))) {
      throw new DriverException("Unsupported key modifier $modifier");
    }
    return $modifier;
  }

  /**
   * Send a key-down event to the browser element
   * @param        $xpath
   * @param        $char
   * @param string $modifier
   * @throws DriverException
   */
  public function keyDown($xpath, $char, $modifier = null) {
    $element = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $key = $this->normalizeCharForKeyEvent($char);
    $modifier = $this->keyEventModifierControl($modifier);
    return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keydown", $key, $modifier);
class MyClass { }

$x = new MyClass();
$x->foo = true;
  }

  /**
   * @param string $xpath
   * @param string $char
   * @param string $modifier
   * @throws DriverException
   */
  public function keyPress($xpath, $char, $modifier = null) {
    $element = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $key = $this->normalizeCharForKeyEvent($char);
    $modifier = $this->keyEventModifierControl($modifier);
    return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keypress", $key, $modifier);
  }

  /**
   * Pressed up specific keyboard key.
   *
   * @param string         $xpath
   * @param string|integer $char could be either char ('b') or char-code (98)
   * @param string         $modifier keyboard modifier (could be 'ctrl', 'alt', 'shift' or 'meta')
   *
   * @throws DriverException                  When the operation cannot be done
   */
  public function keyUp($xpath, $char, $modifier = null) {
    $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $element = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $key = $this->normalizeCharForKeyEvent($char);
    $modifier = $this->keyEventModifierControl($modifier);
    return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keyup", $key, $modifier);
  }
}


1		<?php
2
3		namespace Zumba\Mink\Driver;
4
5		use Behat\Mink\Exception\DriverException;
6
7		/**
8		* Class KeyboardTrait
9		* @package Zumba\Mink\Driver
10		*/
11		trait KeyboardTrait {
12
13		/**
14		* Does some normalization for the char we want to do keyboard events with.
15		* @param $char
16		* @throws DriverException
17		* @return string
18		*/
19		protected function normalizeCharForKeyEvent($char) {
20		if (!is_int($char) && !is_string($char)) {
21		throw new DriverException("Unsupported key type, can only be integer or string");
22		}
23
24		if (is_string($char) && strlen($char) !== 1) {
25		throw new DriverException("Key can only have ONE character");
26		}
27
28		$key = $char;
29		if (is_int($char)) {
30		$key = chr($char);
31		}
32		return $key;
33		}
34
35		/**
36		* Does some control and normalization for the key event modifier
37		* @param $modifier
38		* @return string
39		* @throws DriverException
40		*/
41		protected function keyEventModifierControl($modifier) {
42		if ($modifier === null) {
43		$modifier = "none";
44		}
45
46		if (!in_array($modifier, array("none", "alt", "ctrl", "shift", "meta"))) {
47		throw new DriverException("Unsupported key modifier $modifier");
48		}
49		return $modifier;
50		}
51
52		/**
53		* Send a key-down event to the browser element
54		* @param $xpath
55		* @param $char
56		* @param string $modifier
57		* @throws DriverException
58		*/
59	View Code Duplication	public function keyDown($xpath, $char, $modifier = null) {
60		$element = $this->findElement($xpath, 1);
		0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61		$key = $this->normalizeCharForKeyEvent($char);
62		$modifier = $this->keyEventModifierControl($modifier);
63		return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keydown", $key, $modifier);
		0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `browser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
64		}
65
66		/**
67		* @param string $xpath
68		* @param string $char
69		* @param string $modifier
70		* @throws DriverException
71		*/
72	View Code Duplication	public function keyPress($xpath, $char, $modifier = null) {
73		$element = $this->findElement($xpath, 1);
		0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
74		$key = $this->normalizeCharForKeyEvent($char);
75		$modifier = $this->keyEventModifierControl($modifier);
76		return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keypress", $key, $modifier);
77		}
78
79		/**
80		* Pressed up specific keyboard key.
81		*
82		* @param string $xpath
83		* @param string\|integer $char could be either char ('b') or char-code (98)
84		* @param string $modifier keyboard modifier (could be 'ctrl', 'alt', 'shift' or 'meta')
85		*
86		* @throws DriverException When the operation cannot be done
87		*/
88	View Code Duplication	public function keyUp($xpath, $char, $modifier = null) {
89		$this->findElement($xpath, 1);
		0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
90		$element = $this->findElement($xpath, 1);
		0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
91		$key = $this->normalizeCharForKeyEvent($char);
92		$modifier = $this->keyEventModifierControl($modifier);
93		return $this->browser->keyEvent($element["page_id"], $element["ids"][0], "keyup", $key, $modifier);
94		}
95		}
96

jcalderonzumba / MinkPhantomJSDriver

Issues (39)

Security Analysis no request data

src/KeyboardTrait.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like