MouseTrait - Code Metrics - Inspection of "Merge pull request #49 from stof/patch-1" - jcalderonzumba/MinkPhantomJSDriver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 782892...5bf53f )

by Juan Francisco

created 2015-12-10 15:23 UTC

MouseTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	4
c	2
b	0
f	0
lcom	1
cbo	0
dl	0
loc	47
rs	10

4 Methods

Rating	Name	Size	Complexity
A	mouseOver()	4	1
A	click()	4	1
A	doubleClick()	4	1
A	rightClick()	4	1

<?php

namespace Zumba\Mink\Driver;

use Behat\Mink\Exception\DriverException;

/**
 * Class MouseTrait
 * @package Zumba\Mink\Driver
 */
trait MouseTrait {

  /**
   * Generates a mouseover event on the given element by xpath
   * @param string $xpath
   * @throws DriverException
   */
  public function mouseOver($xpath) {
    $element = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $this->browser->hover($element["page_id"], $element["ids"][0]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
  }

  /**
   * Clicks if possible on an element given by xpath
   * @param string $xpath
   * @return mixed
   * @throws DriverException
   */
  public function click($xpath) {
    $elements = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $this->browser->click($elements["page_id"], $elements["ids"][0]);
  }

  /**
   * {@inheritdoc}
   */
  /**
   * Double click on element found via xpath
   * @param string $xpath
   * @throws DriverException
   */
  public function doubleClick($xpath) {
    $elements = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $this->browser->doubleClick($elements["page_id"], $elements["ids"][0]);
  }

  /**
   * Right click on element found via xpath
   * @param string $xpath
   * @throws DriverException
   */
  public function rightClick($xpath) {
    $elements = $this->findElement($xpath, 1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $this->browser->rightClick($elements["page_id"], $elements["ids"][0]);
  }

}


1			<?php
2
3			namespace Zumba\Mink\Driver;
4
5			use Behat\Mink\Exception\DriverException;
6
7			/**
8			* Class MouseTrait
9			* @package Zumba\Mink\Driver
10			*/
11			trait MouseTrait {
12
13			/**
14			* Generates a mouseover event on the given element by xpath
15			* @param string $xpath
16			* @throws DriverException
17			*/
18			public function mouseOver($xpath) {
19			$element = $this->findElement($xpath, 1);
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			$this->browser->hover($element["page_id"], $element["ids"][0]);
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report The property `browser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			}
22
23			/**
24			* Clicks if possible on an element given by xpath
25			* @param string $xpath
26			* @return mixed
27			* @throws DriverException
28			*/
29			public function click($xpath) {
30			$elements = $this->findElement($xpath, 1);
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			$this->browser->click($elements["page_id"], $elements["ids"][0]);
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37			/**
38			* Double click on element found via xpath
39			* @param string $xpath
40			* @throws DriverException
41			*/
42			public function doubleClick($xpath) {
43			$elements = $this->findElement($xpath, 1);
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			$this->browser->doubleClick($elements["page_id"], $elements["ids"][0]);
45			}
46
47			/**
48			* Right click on element found via xpath
49			* @param string $xpath
50			* @throws DriverException
51			*/
52			public function rightClick($xpath) {
53			$elements = $this->findElement($xpath, 1);
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `findElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			$this->browser->rightClick($elements["page_id"], $elements["ids"][0]);
55			}
56
57			}
58

jcalderonzumba / MinkPhantomJSDriver

Push — master ( 782892...5bf53f )

MouseTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like