SessionTrait - Code Metrics - jcalderonzumba/MinkPhantomJSDriver - Measure and Improve Code Quality continuously with Scrutinizer

SessionTrait A
last analyzed 2017-08-24 07:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	4
c	2
b	0
f	0
lcom	1
cbo	0
dl	0
loc	42
rs	10

4 Methods

Rating	Name	Size	Complexity
A	start()	3	1
A	isStarted()	3	1
A	stop()	7	1
A	reset()	5	1

<?php


namespace Zumba\Mink\Driver;

/**
 * Trait SessionTrait
 * @package Zumba\Mink\Driver
 */
trait SessionTrait {

  /** @var  bool */
  protected $started;

  /**
   * Starts a session to be used by the driver client
   */
  public function start() {
    $this->started = true;
  }

  /**
   * Tells if the session is started or not
   * @return bool
   */
  public function isStarted() {
    return $this->started;
  }

  /**
   * Stops the session completely, clean slate for the browser
   * @return bool
   */
  public function stop() {
    //Since we are using a remote browser "API", stopping is just like resetting, say good bye to cookies
    //TODO: In the future we may want to control a start / stop of the remove browser
    $this->reset();
    $this->started = false;
    return true;
  }

  /**
   * Clears the cookies in the browser, all of them
   * @return bool
   */
  public function reset() {
    $this->getBrowser()->clearCookies();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $this->getBrowser()->reset();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    return true;
  }
}


1			<?php
2
3
4			namespace Zumba\Mink\Driver;
5
6			/**
7			* Trait SessionTrait
8			* @package Zumba\Mink\Driver
9			*/
10			trait SessionTrait {
11
12			/** @var bool */
13			protected $started;
14
15			/**
16			* Starts a session to be used by the driver client
17			*/
18			public function start() {
19			$this->started = true;
20			}
21
22			/**
23			* Tells if the session is started or not
24			* @return bool
25			*/
26			public function isStarted() {
27			return $this->started;
28			}
29
30			/**
31			* Stops the session completely, clean slate for the browser
32			* @return bool
33			*/
34			public function stop() {
35			//Since we are using a remote browser "API", stopping is just like resetting, say good bye to cookies
36			//TODO: In the future we may want to control a start / stop of the remove browser
37			$this->reset();
38			$this->started = false;
39			return true;
40			}
41
42			/**
43			* Clears the cookies in the browser, all of them
44			* @return bool
45			*/
46			public function reset() {
47			$this->getBrowser()->clearCookies();
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `getBrowser()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
48			$this->getBrowser()->reset();
			0 ignored issues – show Bug introduced 2015-12-03 17:46 UTC by Report Bug Copy Issue Report It seems like `getBrowser()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49			return true;
50			}
51			}
52

jcalderonzumba / MinkPhantomJSDriver

SessionTrait A last analyzed 2017-08-24 07:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

SessionTrait A
last analyzed 2017-08-24 07:36 UTC