jbtronics / StuRa-Finanzsoftware

src/Controller/Admin/DepartmentCrudController.php

Spacing +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
         ]);
 
         $generateTokenAction = Action::new('generateSkipToken', 'department.action.generate_skip_token', 'fas fa-award')
-            ->displayIf(function (Department $paymentOrder) {
+            ->displayIf(function(Department $paymentOrder) {
                 return $this->isGranted('ROLE_EDIT_ORGANISATIONS');
             })
             ->setCssClass('btn btn-secondary')
@@ -114,7 +114,7 @@ 
     {
         $choices = [];
         foreach (Department::ALLOWED_TYPES as $type) {
-            $choices['department.type.'.$type] = $type;
+            $choices['department.type.' . $type] = $type;
         }
 
         return [

src/Controller/PaymentOrderController.php

Spacing +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
      */
     public function confirmation(?PaymentOrder $paymentOrder, Request $request, EntityManagerInterface $em): Response
     {
-        if($paymentOrder === null) {
+        if ($paymentOrder === null) {
             $this->addFlash('error', 'payment_order.can_not_be_found');
             return $this->redirectToRoute('homepage');
         }

src/Controller/Admin/PaymentOrderCrudController.php

Spacing +12 added lines, -12 removed lines

@@ -119,7 +119,7 @@ 
 
             if ($payment_order->getDepartment() !== null && $payment_order->getDepartment()->getBankAccount() !== null) {
                 //First folder for each bank account
-                $prefix = $payment_order->getDepartment()->getBankAccount()->getName() . ' [' . $payment_order->getDepartment()->getBankAccount()->getIban() .']' . '/';
+                $prefix = $payment_order->getDepartment()->getBankAccount()->getName() . ' [' . $payment_order->getDepartment()->getBankAccount()->getIban() . ']' . '/';
 
                 //A sub folder for each department
                 $prefix .= $payment_order->getDepartment()->getName() . '/';
@@ -131,7 +131,7 @@ 
             $project_name = mb_ereg_replace("([^\w\s\d\-_~,;\[\]\(\).])", '', $project_name);
             $project_name = mb_ereg_replace("([\.]{2,})", '', $project_name);
             //Format: "ZA000001 Project Name.pdf"
-            $filename = $prefix.$payment_order->getIDString().' '.$project_name.'.'.$extension;
+            $filename = $prefix . $payment_order->getIDString() . ' ' . $project_name . '.' . $extension;
 
             $data[$filename] = $path;
 
@@ -148,7 +148,7 @@ 
 
         return ZIPBinaryFileResponseFacade::createZIPResponseFromFiles(
             $data,
-            'Belege_'.date('Y-m-d_H-i-s').'.zip');
+            'Belege_' . date('Y-m-d_H-i-s') . '.zip');
     }
 
     public function configureCrud(Crud $crud): Crud
@@ -317,32 +317,32 @@ 
         ]);
 
         $emailAction = Action::new('sendEmail', 'payment_order.action.email', 'fas fa-envelope')
-            ->linkToUrl(function (PaymentOrder $paymentOrder) {
+            ->linkToUrl(function(PaymentOrder $paymentOrder) {
                 return $this->mailToGenerator->generateContactMailLink($paymentOrder);
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         //Hide action if no contact emails are associated with department
-        $emailAction->displayIf(function (PaymentOrder $paymentOrder) {
+        $emailAction->displayIf(function(PaymentOrder $paymentOrder) {
             return null !== $this->mailToGenerator->generateContactMailLink($paymentOrder);
         });
 
         $hhv_action = Action::new('contactHHV', 'payment_order.action.contact_hhv', 'fas fa-comment-dots')
-            ->linkToUrl(function (PaymentOrder $paymentOrder) {
+            ->linkToUrl(function(PaymentOrder $paymentOrder) {
                 return $this->mailToGenerator->getHHVMailLink($paymentOrder);
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         $resend_confirmation_action = Action::new('resendConfirmation', 'payment_order.action.resend_confirmation', 'fas fa-redo')
             ->linkToCrudAction('resendConfirmationEmail')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_EDIT_PAYMENT_ORDERS') && !$paymentOrder->isConfirmed();
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         $mathematically_correct_action = Action::new('mathematicallyCorrect', 'payment_order.action.mathematically_correct', 'fas fa-check')
             ->linkToCrudAction('checkMathematicallyCorrect')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_PO_MATHEMATICALLY')
                     && $paymentOrder->isConfirmed()
                     && !$paymentOrder->isMathematicallyCorrect();
@@ -351,7 +351,7 @@ 
 
         $factually_correct_action = Action::new('factuallyCorrect', 'payment_order.action.factually_correct', 'fas fa-check')
             ->linkToCrudAction('checkFactuallyCorrect')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_PO_FACTUALLY')
                     && $paymentOrder->isConfirmed()
                     && !$paymentOrder->isFactuallyCorrect()
@@ -361,12 +361,12 @@ 
 
         $manual_confirmation = Action::new('manual_confirmation', 'payment_order.action.manual_confirmation', 'fas fa-exclamation-triangle')
             ->setCssClass('btn btn-secondary')
-            ->linkToRoute('payment_order_manual_confirm', function (PaymentOrder $paymentOrder) {
+            ->linkToRoute('payment_order_manual_confirm', function(PaymentOrder $paymentOrder) {
                 return [
                     'id' => $paymentOrder->getId(),
                 ];
             })
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_MANUAL_CONFIRMATION')
                     && !$paymentOrder->isConfirmed();
             });
@@ -379,7 +379,7 @@ 
 
         $actions->disable(Crud::PAGE_NEW);
 
-        if(!$this->isGranted('ROLE_EDIT_PAYMENT_ORDERS')) {
+        if (!$this->isGranted('ROLE_EDIT_PAYMENT_ORDERS')) {
             $actions->disable('batchDelete');
         }
 

src/Services/Upload/SEPAExportFileNamer.php

Spacing +3 added lines, -3 removed lines

@@ -58,12 +58,12 @@
         //TODO: Improve this
         $filename = sprintf("XML%06d", $object->getId());
 
-        $filename .= '_'.date('ymd-His');
+        $filename .= '_' . date('ymd-His');
 
-        $filename .= '_'.bin2hex(random_bytes(5));
+        $filename .= '_' . bin2hex(random_bytes(5));
 
         //Add original extension
-        $filename .= '.'.$originalExtension;
+        $filename .= '.' . $originalExtension;
 
         return $filename;
     }

src/Helpers/SEPAXML/SEPAXMLParser.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         return [
             'msg_id' => (string) ($group_header->MsgId),
             'number_of_payments' => (int) ($group_header->NbOfTxs),
-            'total_sum' => (int) str_replace('.','',$group_header->CtrlSum),
+            'total_sum' => (int) str_replace('.', '', $group_header->CtrlSum),
             'initiator_iban' => (string) $payment_info->DbtrAcct->Id->IBAN,
             'initiator_bic' => (string) $payment_info->DbtrAgt->FinInstnId->BIC,
         ];

src/Helpers/SEPAXML/SEPAXMLExportResult.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
         }
 
         //Perform some checks on the sepa exports
-        foreach($sepa_exports as $sepa_export) {
+        foreach ($sepa_exports as $sepa_export) {
             if (!$sepa_export instanceof SEPAExport) {
                 throw new \InvalidArgumentException('$sepa_exports must all be of type SEPAExport!');
             }
@@ -151,7 +151,7 @@ 
      */
     public function persistSEPAExports(EntityManagerInterface $entityManager): void
     {
-        foreach($this->sepa_exports as $sepa_export) {
+        foreach ($this->sepa_exports as $sepa_export) {
             $entityManager->persist($sepa_export);
         }
     }

src/Entity/SEPAExport.php

Spacing +1 added lines, -1 removed lines

@@ -277,7 +277,7 @@
     public function setXmlFile(\Symfony\Component\HttpFoundation\File\File $xml_file): SEPAExport
     {
         //Check if $xml_file was changed
-        if($this->xml_file === null || $xml_file->getPathname() !== $this->xml_file->getPathname()) {
+        if ($this->xml_file === null || $xml_file->getPathname() !== $this->xml_file->getPathname()) {
             $this->xml_file = $xml_file;
             $this->updateFromFile();
         } else {

src/Services/PaymentOrdersSEPAExporter_old.php

Indentation +4 added lines, -4 removed lines

@@ -216,10 +216,10 @@
     protected function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setRequired([
-                                   'iban', //The IBAN of the sender
-                                   'bic', //The BIC of the sender
-                                   'name', //The name of the sender
-                               ]);
+                                    'iban', //The IBAN of the sender
+                                    'bic', //The BIC of the sender
+                                    'name', //The name of the sender
+                                ]);
 
         $resolver->setAllowedTypes('iban', ['string', 'null']);
         $resolver->setAllowedTypes('bic', ['string', 'null']);

Spacing +5 added lines, -5 removed lines

@@ -92,7 +92,7 @@ 
 
             // A single payment info where all PaymentOrders are added as transactions
             $payment = new PaymentInformation(
-                static::PAYMENT_PREFIX.' '.uniqid('', false),
+                static::PAYMENT_PREFIX . ' ' . uniqid('', false),
                 $account_info['iban'],
                 $account_info['bic'],
                 $account_info['name']
@@ -144,7 +144,7 @@ 
 
         // A single payment info where all PaymentOrders are added as transactions
         $payment = new PaymentInformation(
-            $paymentOrder->getIDString().' '.uniqid('', false),
+            $paymentOrder->getIDString() . ' ' . uniqid('', false),
             $iban,
             $bic,
             $account_name
@@ -171,7 +171,7 @@ 
     protected function getGroupHeader(): GroupHeader
     {
         return new GroupHeader(
-            static::ID_PREFIX.' '.uniqid('', false),
+            static::ID_PREFIX . ' ' . uniqid('', false),
             static::PARTY_NAME
         );
     }
@@ -182,7 +182,7 @@ 
      */
     protected function getPaymentInfoID(PaymentOrder $paymentOrder): string
     {
-        return $paymentOrder->getIDString().' '.uniqid('', false);
+        return $paymentOrder->getIDString() . ' ' . uniqid('', false);
     }
 
     /**
@@ -286,7 +286,7 @@ 
         $resolver->setDefault('mode', 'manual');
         $resolver->setAllowedValues('mode', ['auto', 'manual', 'auto_single']);
 
-        $resolver->setNormalizer('iban', function (Options $options, $value) {
+        $resolver->setNormalizer('iban', function(Options $options, $value) {
             if (null === $value) {
                 return null;
             }

src/Services/SEPAExport/SEPAExportGroupAndSplitHelper.php

Indentation +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
     public function sortPaymentOrderArrayByAmount(array $payment_orders, bool $ascending = true): array
     {
         usort($payment_orders, function (PaymentOrder $a, PaymentOrder $b) {
-           return $a->getAmount() <=> $b->getAmount();
+            return $a->getAmount() <=> $b->getAmount();
         });
 
         if (!$ascending) {

Spacing +5 added lines, -5 removed lines

@@ -83,7 +83,7 @@ 
             }
 
             //If no array object is existing yet, create the array
-            if(!isset($grouped[$bank_account])) {
+            if (!isset($grouped[$bank_account])) {
                 $grouped[$bank_account] = [];
             }
 
@@ -128,7 +128,7 @@ 
         //Limit the sum amount of each group
         $groups_exceeding_limit = $tmp;
         $output = [];
-        while(!empty($groups_exceeding_limit)) {
+        while (!empty($groups_exceeding_limit)) {
             foreach ($groups_exceeding_limit as $key => $group) {
                 /** @var PaymentOrder[] $group */
                 //If the group does not exceed the limit, then remove it from the bad list and put it to output array
@@ -146,7 +146,7 @@ 
                     $part = array_slice($group, 0, $n + 1);
                     if ($this->calculateSumAmountOfPaymentOrders($part) > $limit_max_amount) {
                         //If our group contains just a single element which exceed the limit, then throw an exception, as we can not split it further.
-                        if(count($part) === 1) {
+                        if (count($part) === 1) {
                             throw new SinglePaymentOrderExceedsLimit($part[0], $limit_max_amount);
                         }
 
@@ -156,7 +156,7 @@ 
                 }
 
                 //Split group into our two subgroups of which at least one is below the limit
-                $a = array_slice($group, 0 , $split_index);
+                $a = array_slice($group, 0, $split_index);
                 $b = array_slice($group, $split_index);
 
                 //Remove the old group from list and add the new split groups
@@ -193,7 +193,7 @@ 
      */
     public function sortPaymentOrderArrayByAmount(array $payment_orders, bool $ascending = true): array
     {
-        usort($payment_orders, function (PaymentOrder $a, PaymentOrder $b) {
+        usort($payment_orders, function(PaymentOrder $a, PaymentOrder $b) {
            return $a->getAmount() <=> $b->getAmount();
         });