jbtronics / StuRa-Finanzsoftware

src/Twig/AppExtension.php

Spacing +1 added lines, -1 removed lines

@@ -40,6 +40,6 @@
         $size = ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
         $factor = floor((strlen($bytes) - 1) / 3);
 
-        return sprintf("%.{$precision}f", $bytes / (1024 ** $factor)).@$size[$factor];
+        return sprintf("%.{$precision}f", $bytes / (1024 ** $factor)) . @$size[$factor];
     }
 }

src/DataFixtures/PaymentOrderFixture.php

Spacing +2 added lines, -2 removed lines

@@ -130,7 +130,7 @@ 
 
     private function addFiles(PaymentOrder $paymentOrder): void
     {
-        $source_file = realpath(__DIR__.'/../../tests/data/form/upload.pdf');
+        $source_file = realpath(__DIR__ . '/../../tests/data/form/upload.pdf');
         //We have to create a copy of our source, or the file will be deleted when the files are uploaded...
         $target_file = tempnam(sys_get_temp_dir(), 'stura');
         copy($source_file, $target_file);
@@ -140,7 +140,7 @@ 
 
         //Do the same thing for References
 
-        $source_file = realpath(__DIR__.'/../../tests/data/form/upload.pdf');
+        $source_file = realpath(__DIR__ . '/../../tests/data/form/upload.pdf');
         //We have to create a copy of our source, or the file will be deleted when the files are uploaded...
         $target_file = tempnam(sys_get_temp_dir(), 'stura');
         copy($source_file, $target_file);

src/Services/EmailConfirmation/ManualConfirmationHelper.php

Spacing +2 added lines, -2 removed lines

@@ -132,7 +132,7 @@
         $date = Carbon::now()->toDateTimeLocalString();
 
         return '<h4>Manuelle Bestätigung</h4>'
-            .'durch '.$user->getFullName().' ('.$user->getUsername().'), '.$date.'<br>'
-            .'<b>Begründung: </b>'.$reason;
+            .'durch ' . $user->getFullName() . ' (' . $user->getUsername() . '), ' . $date . '<br>'
+            .'<b>Begründung: </b>' . $reason;
     }
 }

src/Services/PDF/PaymentOrderPDFGenerator.php

Spacing +6 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
 
         $pdf = new SturaPDF();
         $pdf->setAuthor('StuRa FSU Jena');
-        $pdf->setTitle('Zahlungsauftrag #'.$paymentOrder->getId());
+        $pdf->setTitle('Zahlungsauftrag #' . $paymentOrder->getId());
         $pdf->setSubject('Zahlungsauftrag');
         $pdf->SetAutoPageBreak(false);
 
@@ -49,12 +49,12 @@ 
         $pdf->setY(80);
         $pdf->setMargins(25, 10);
 
-        $pdf->writeHTML('<h1>Zahlungsauftrag '.$paymentOrder->getIDString().'</h1><br>');
+        $pdf->writeHTML('<h1>Zahlungsauftrag ' . $paymentOrder->getIDString() . '</h1><br>');
 
         $this->writeRow($pdf, 'Name Auftraggeber*in', $paymentOrder->getFullName());
         $this->writeRow($pdf, 'Struktur / Organisation', $paymentOrder->getDepartment()->getName());
         $this->writeRow($pdf, 'Projektbezeichnung', $paymentOrder->getProjectName());
-        $this->writeRow($pdf, 'Betrag', $paymentOrder->getAmountString().' €');
+        $this->writeRow($pdf, 'Betrag', $paymentOrder->getAmountString() . ' €');
         $this->writeRow($pdf, 'Mittelfreigabe / Finanzantrag', !empty($paymentOrder->getFundingId()) ? $paymentOrder->getFundingId() : '<i>Nicht angegeben</i>');
         $this->writeRow($pdf, 'FSR-Kom Umbuchung', $paymentOrder->isFsrKomResolution() ? 'Ja' : 'Nein');
         $formatter = new IntlDateFormatter('de_DE', IntlDateFormatter::MEDIUM, IntlDateFormatter::NONE);
@@ -64,7 +64,7 @@ 
 
         $this->writeRow($pdf, 'Kontoinhaber*in', $paymentOrder->getBankInfo()->getAccountOwner());
         $this->writeRow($pdf, 'Straße/Nr.', $paymentOrder->getBankInfo()->getStreet());
-        $this->writeRow($pdf, 'PLZ/Ort', $paymentOrder->getBankInfo()->getZipCode().' '.$paymentOrder->getBankInfo()->getCity());
+        $this->writeRow($pdf, 'PLZ/Ort', $paymentOrder->getBankInfo()->getZipCode() . ' ' . $paymentOrder->getBankInfo()->getCity());
         $this->writeRow($pdf, 'IBAN', $paymentOrder->getBankInfo()->getIban());
         $this->writeRow($pdf, 'BIC', $paymentOrder->getBankInfo()->getBic());
         $this->writeRow($pdf, 'Bank', $paymentOrder->getBankInfo()->getBankName());
@@ -89,12 +89,12 @@ 
 
     private function addSignatureField(TCPDF $pdf, string $content, bool $ln = true, string $align = 'L'): void
     {
-        $pdf->writeHTML('_____________________________________________<br><small>'.$content.'</small>', $ln, false, false, false, $align);
+        $pdf->writeHTML('_____________________________________________<br><small>' . $content . '</small>', $ln, false, false, false, $align);
     }
 
     private function writeRow(TCPDF $pdf, string $property, string $value): void
     {
-        $pdf->MultiCell(80, 5, '<b>'.$property.':</b>', 0, 'L', 0, 0, '', '', true, 0, true);
+        $pdf->MultiCell(80, 5, '<b>' . $property . ':</b>', 0, 'L', 0, 0, '', '', true, 0, true);
         $pdf->MultiCell(0, 5, $value, 0, 'L', 0, 1, '', '', true, 0, true);
     }
 }

src/Services/PDF/SturaPDF.php

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
 {
     public function Header()
     {
-        $image_file = dirname(__DIR__, 3).'/assets/StuRa.png';
+        $image_file = dirname(__DIR__, 3) . '/assets/StuRa.png';
 
         //$image_file = 'C:\Users\janhb\Documents\Projekte\PHP\stura\assets\StuRa.png';
 
@@ -53,10 +53,10 @@ 
 
         $this->SetFont('helvetica', 'I', 8);
         // Page number
-        $this->Cell(0, 10, 'Seite '.$this->getAliasNumPage().'/'.$this->getAliasNbPages(), 0, false, 'L');
+        $this->Cell(0, 10, 'Seite ' . $this->getAliasNumPage() . '/' . $this->getAliasNbPages(), 0, false, 'L');
 
         $formatter = new IntlDateFormatter('de-DE', IntlDateFormatter::SHORT, IntlDateFormatter::MEDIUM);
 
-        $this->Cell(0, 10, 'Erzeugt '.$formatter->format(new DateTime()), 0, false, 'R');
+        $this->Cell(0, 10, 'Erzeugt ' . $formatter->format(new DateTime()), 0, false, 'R');
     }
 }

src/Controller/Admin/DashboardController.php

Spacing +8 added lines, -8 removed lines

@@ -75,10 +75,10 @@ 
         foreach ($filters as $filter => $value) {
             if (is_array($value)) {
                 foreach ($value as $subfilter => $subvalue) {
-                    $menuItem->setQueryParameter('filters['.$filter.']['.$subfilter.']', $subvalue);
+                    $menuItem->setQueryParameter('filters[' . $filter . '][' . $subfilter . ']', $subvalue);
                 }
             } else {
-                $menuItem->setQueryParameter('filters['.$filter.']', $value);
+                $menuItem->setQueryParameter('filters[' . $filter . ']', $value);
             }
         }
 
@@ -92,11 +92,11 @@ 
         $actions = parent::configureActions();
 
         $showLog = Action::new('showLog', 'action.show_logs', 'fas fa-binoculars')
-            ->displayIf(function (DBElementInterface $entity) {
+            ->displayIf(function(DBElementInterface $entity) {
                 return $this->isGranted('ROLE_VIEW_AUDITS');
             })
             ->setCssClass('btn btn-secondary')
-            ->linkToRoute('dh_auditor_show_entity_history', function (DBElementInterface $entity) {
+            ->linkToRoute('dh_auditor_show_entity_history', function(DBElementInterface $entity) {
                 return [
                     'entity' => str_replace('\\', '-', get_class($entity)),
                     'id' => $entity->getId(),
@@ -242,8 +242,8 @@ 
         yield MenuItem::linkToCrud('user.labelp', 'fas fa-user', User::class)
             ->setPermission('ROLE_READ_USER');
 
-        $version = $this->app_version.'-'.$this->gitVersionInfo->getGitCommitHash() ?? '';
-        yield MenuItem::section('Version '.$version, 'fas fa-info');
+        $version = $this->app_version . '-' . $this->gitVersionInfo->getGitCommitHash() ?? '';
+        yield MenuItem::section('Version ' . $version, 'fas fa-info');
         yield MenuItem::linktoRoute('dashboard.menu.audits', 'fas fa-binoculars', 'dh_auditor_list_audits')
             ->setPermission('ROLE_VIEW_AUDITS');
         yield MenuItem::linktoRoute('dashboard.menu.homepage', 'fas fa-home', 'homepage');
@@ -261,8 +261,8 @@ 
             ->addMenuItems([
                 MenuItem::linktoRoute('user.settings.title', 'fas fa-user-cog', 'user_settings'),
                 //It is important to use LinkToUrl here. LinkToCrud will put the route name into a param, but does not change the prefix
-                MenuItem::linkToUrl(Languages::getName('de', 'de').' (DE)', '', '/de/admin'),
-                MenuItem::linkToUrl(Languages::getName('en', 'en').' (EN)', '', '/en/admin'),
+                MenuItem::linkToUrl(Languages::getName('de', 'de') . ' (DE)', '', '/de/admin'),
+                MenuItem::linkToUrl(Languages::getName('en', 'en') . ' (EN)', '', '/en/admin'),
             ]);
     }
 

src/Controller/Admin/DepartmentCrudController.php

Spacing +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
         ]);
 
         $generateTokenAction = Action::new('generateSkipToken', 'department.action.generate_skip_token', 'fas fa-award')
-            ->displayIf(function (Department $paymentOrder) {
+            ->displayIf(function(Department $paymentOrder) {
                 return $this->isGranted('ROLE_EDIT_ORGANISATIONS');
             })
             ->setCssClass('btn btn-secondary')
@@ -114,7 +114,7 @@ 
     {
         $choices = [];
         foreach (Department::ALLOWED_TYPES as $type) {
-            $choices['department.type.'.$type] = $type;
+            $choices['department.type.' . $type] = $type;
         }
 
         return [

src/Controller/PaymentOrderController.php

Spacing +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
      */
     public function confirmation(?PaymentOrder $paymentOrder, Request $request, EntityManagerInterface $em): Response
     {
-        if($paymentOrder === null) {
+        if ($paymentOrder === null) {
             $this->addFlash('error', 'payment_order.can_not_be_found');
             return $this->redirectToRoute('homepage');
         }

src/Controller/Admin/PaymentOrderCrudController.php

Spacing +12 added lines, -12 removed lines

@@ -119,7 +119,7 @@ 
 
             if ($payment_order->getDepartment() !== null && $payment_order->getDepartment()->getBankAccount() !== null) {
                 //First folder for each bank account
-                $prefix = $payment_order->getDepartment()->getBankAccount()->getName() . ' [' . $payment_order->getDepartment()->getBankAccount()->getIban() .']' . '/';
+                $prefix = $payment_order->getDepartment()->getBankAccount()->getName() . ' [' . $payment_order->getDepartment()->getBankAccount()->getIban() . ']' . '/';
 
                 //A sub folder for each department
                 $prefix .= $payment_order->getDepartment()->getName() . '/';
@@ -131,7 +131,7 @@ 
             $project_name = mb_ereg_replace("([^\w\s\d\-_~,;\[\]\(\).])", '', $project_name);
             $project_name = mb_ereg_replace("([\.]{2,})", '', $project_name);
             //Format: "ZA000001 Project Name.pdf"
-            $filename = $prefix.$payment_order->getIDString().' '.$project_name.'.'.$extension;
+            $filename = $prefix . $payment_order->getIDString() . ' ' . $project_name . '.' . $extension;
 
             $data[$filename] = $path;
 
@@ -148,7 +148,7 @@ 
 
         return ZIPBinaryFileResponseFacade::createZIPResponseFromFiles(
             $data,
-            'Belege_'.date('Y-m-d_H-i-s').'.zip');
+            'Belege_' . date('Y-m-d_H-i-s') . '.zip');
     }
 
     public function configureCrud(Crud $crud): Crud
@@ -317,32 +317,32 @@ 
         ]);
 
         $emailAction = Action::new('sendEmail', 'payment_order.action.email', 'fas fa-envelope')
-            ->linkToUrl(function (PaymentOrder $paymentOrder) {
+            ->linkToUrl(function(PaymentOrder $paymentOrder) {
                 return $this->mailToGenerator->generateContactMailLink($paymentOrder);
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         //Hide action if no contact emails are associated with department
-        $emailAction->displayIf(function (PaymentOrder $paymentOrder) {
+        $emailAction->displayIf(function(PaymentOrder $paymentOrder) {
             return null !== $this->mailToGenerator->generateContactMailLink($paymentOrder);
         });
 
         $hhv_action = Action::new('contactHHV', 'payment_order.action.contact_hhv', 'fas fa-comment-dots')
-            ->linkToUrl(function (PaymentOrder $paymentOrder) {
+            ->linkToUrl(function(PaymentOrder $paymentOrder) {
                 return $this->mailToGenerator->getHHVMailLink($paymentOrder);
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         $resend_confirmation_action = Action::new('resendConfirmation', 'payment_order.action.resend_confirmation', 'fas fa-redo')
             ->linkToCrudAction('resendConfirmationEmail')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_EDIT_PAYMENT_ORDERS') && !$paymentOrder->isConfirmed();
             })
             ->setCssClass('btn btn-secondary text-dark');
 
         $mathematically_correct_action = Action::new('mathematicallyCorrect', 'payment_order.action.mathematically_correct', 'fas fa-check')
             ->linkToCrudAction('checkMathematicallyCorrect')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_PO_MATHEMATICALLY')
                     && $paymentOrder->isConfirmed()
                     && !$paymentOrder->isMathematicallyCorrect();
@@ -351,7 +351,7 @@ 
 
         $factually_correct_action = Action::new('factuallyCorrect', 'payment_order.action.factually_correct', 'fas fa-check')
             ->linkToCrudAction('checkFactuallyCorrect')
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_PO_FACTUALLY')
                     && $paymentOrder->isConfirmed()
                     && !$paymentOrder->isFactuallyCorrect()
@@ -361,12 +361,12 @@ 
 
         $manual_confirmation = Action::new('manual_confirmation', 'payment_order.action.manual_confirmation', 'fas fa-exclamation-triangle')
             ->setCssClass('btn btn-secondary')
-            ->linkToRoute('payment_order_manual_confirm', function (PaymentOrder $paymentOrder) {
+            ->linkToRoute('payment_order_manual_confirm', function(PaymentOrder $paymentOrder) {
                 return [
                     'id' => $paymentOrder->getId(),
                 ];
             })
-            ->displayIf(function (PaymentOrder $paymentOrder) {
+            ->displayIf(function(PaymentOrder $paymentOrder) {
                 return $this->isGranted('ROLE_MANUAL_CONFIRMATION')
                     && !$paymentOrder->isConfirmed();
             });
@@ -379,7 +379,7 @@ 
 
         $actions->disable(Crud::PAGE_NEW);
 
-        if(!$this->isGranted('ROLE_EDIT_PAYMENT_ORDERS')) {
+        if (!$this->isGranted('ROLE_EDIT_PAYMENT_ORDERS')) {
             $actions->disable('batchDelete');
         }