App\Services\Upload\SEPAExportFileNamer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	name()	0	28	3

<?php
/*
 * Copyright (C) 2020  Jan Böhmer
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

namespace App\Services\Upload;

use App\Entity\PaymentOrder;
use App\Entity\SEPAExport;
use InvalidArgumentException;
use function pathinfo;
use function strtolower;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\String\Slugger\AsciiSlugger;
use Vich\UploaderBundle\Mapping\PropertyMapping;
use Vich\UploaderBundle\Naming\NamerInterface;

/**
 * Use a custom namer to create file names which are useful when viewing the directory structure.
 * It contains the department, current date and the project name all in slugged form.
 */
class SEPAExportFileNamer implements NamerInterface
{
    public function name($object, PropertyMapping $mapping): string
    {
        if (!$object instanceof SEPAExport) {
            throw new InvalidArgumentException('$object must be an PaymentOrder!');
        }

        $file = $mapping->getFile($object);
        if ($file instanceof UploadedFile) {
            $originalName = $file->getClientOriginalName();
        } else {
            throw new InvalidArgumentException('$file must be an UploadedFile instance!');
        }
        $originalExtension = strtolower(pathinfo($originalName, PATHINFO_EXTENSION));

It seems like pathinfo($originalName, App\Services\Upload\PATHINFO_EXTENSION) can also be of type array; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

        $originalBasename = pathinfo($originalName, PATHINFO_FILENAME);

The assignment to $originalBasename is dead and can be removed.

        $slugger = new AsciiSlugger();

The assignment to $slugger is dead and can be removed.

        //TODO: Improve this
        $filename = sprintf("XML%06d", $object->getId());

        $filename .= '_'.date('ymd-His');

        $filename .= '_'.bin2hex(random_bytes(5));

        //Add original extension
        $filename .= '.'.$originalExtension;

        return $filename;
    }
}