@@ -43,7 +43,7 @@ discard block |
||
43 | 43 | public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) { |
44 | 44 | $tokens = $phpcsFile->getTokens(); |
45 | 45 | |
46 | - $content = $tokens[ $stackPtr ]['content']; |
|
46 | + $content = $tokens[ $stackPtr ][ 'content' ]; |
|
47 | 47 | $expected = str_replace( ' ', '', $content ); |
48 | 48 | $expected = str_replace( "\t", '', $expected ); |
49 | 49 | |
@@ -56,12 +56,12 @@ discard block |
||
56 | 56 | $phpcsFile->addWarning( $error, $stackPtr, 'ContainsWhiteSpace', $data ); |
57 | 57 | } |
58 | 58 | |
59 | - if ( T_WHITESPACE !== $tokens[ ( $stackPtr - 1 ) ]['code'] ) { |
|
59 | + if ( T_WHITESPACE !== $tokens[ ( $stackPtr - 1 ) ][ 'code' ] ) { |
|
60 | 60 | $error = 'No space before opening casting parenthesis is prohibited'; |
61 | 61 | $phpcsFile->addWarning( $error, $stackPtr, 'NoSpaceBeforeOpenParenthesis' ); |
62 | 62 | } |
63 | 63 | |
64 | - if ( T_WHITESPACE !== $tokens[ ( $stackPtr + 1 ) ]['code'] ) { |
|
64 | + if ( T_WHITESPACE !== $tokens[ ( $stackPtr + 1 ) ][ 'code' ] ) { |
|
65 | 65 | $error = 'No space after closing casting parenthesis is prohibited'; |
66 | 66 | $phpcsFile->addWarning( $error, $stackPtr, 'NoSpaceAfterCloseParenthesis' ); |
67 | 67 | } |
@@ -41,11 +41,11 @@ discard block |
||
41 | 41 | */ |
42 | 42 | public function register() { |
43 | 43 | $comparison = PHP_CodeSniffer_Tokens::$comparisonTokens; |
44 | - $operators = PHP_CodeSniffer_Tokens::$operators; |
|
44 | + $operators = PHP_CodeSniffer_Tokens::$operators; |
|
45 | 45 | $assignment = PHP_CodeSniffer_Tokens::$assignmentTokens; |
46 | 46 | |
47 | 47 | $tokens = array_unique( array_merge( $comparison, $operators, $assignment ) ); |
48 | - $tokens[] = T_BOOLEAN_NOT; |
|
48 | + $tokens[ ] = T_BOOLEAN_NOT; |
|
49 | 49 | |
50 | 50 | return $tokens; |
51 | 51 | |
@@ -63,25 +63,25 @@ discard block |
||
63 | 63 | public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) { |
64 | 64 | $tokens = $phpcsFile->getTokens(); |
65 | 65 | |
66 | - if ( T_EQUAL === $tokens[ $stackPtr ]['code'] ) { |
|
66 | + if ( T_EQUAL === $tokens[ $stackPtr ][ 'code' ] ) { |
|
67 | 67 | // Skip for '=&' case. |
68 | - if ( isset( $tokens[ ( $stackPtr + 1 ) ] ) && T_BITWISE_AND === $tokens[ ( $stackPtr + 1 ) ]['code'] ) { |
|
68 | + if ( isset( $tokens[ ( $stackPtr + 1 ) ] ) && T_BITWISE_AND === $tokens[ ( $stackPtr + 1 ) ][ 'code' ] ) { |
|
69 | 69 | return; |
70 | 70 | } |
71 | 71 | |
72 | 72 | // Skip default values in function declarations. |
73 | - if ( isset( $tokens[ $stackPtr ]['nested_parenthesis'] ) ) { |
|
74 | - $bracket = end( $tokens[ $stackPtr ]['nested_parenthesis'] ); |
|
75 | - if ( isset( $tokens[ $bracket ]['parenthesis_owner'] ) ) { |
|
76 | - $function = $tokens[ $bracket ]['parenthesis_owner']; |
|
77 | - if ( T_FUNCTION === $tokens[ $function ]['code'] ) { |
|
73 | + if ( isset( $tokens[ $stackPtr ][ 'nested_parenthesis' ] ) ) { |
|
74 | + $bracket = end( $tokens[ $stackPtr ][ 'nested_parenthesis' ] ); |
|
75 | + if ( isset( $tokens[ $bracket ][ 'parenthesis_owner' ] ) ) { |
|
76 | + $function = $tokens[ $bracket ][ 'parenthesis_owner' ]; |
|
77 | + if ( T_FUNCTION === $tokens[ $function ][ 'code' ] ) { |
|
78 | 78 | return; |
79 | 79 | } |
80 | 80 | } |
81 | 81 | } |
82 | 82 | } |
83 | 83 | |
84 | - if ( T_BITWISE_AND === $tokens[ $stackPtr ]['code'] ) { |
|
84 | + if ( T_BITWISE_AND === $tokens[ $stackPtr ][ 'code' ] ) { |
|
85 | 85 | /* |
86 | 86 | // If it's not a reference, then we expect one space either side of the |
87 | 87 | // bitwise operator. |
@@ -92,21 +92,21 @@ discard block |
||
92 | 92 | return; |
93 | 93 | |
94 | 94 | } else { |
95 | - if ( T_MINUS === $tokens[ $stackPtr ]['code'] ) { |
|
95 | + if ( T_MINUS === $tokens[ $stackPtr ][ 'code' ] ) { |
|
96 | 96 | // Check minus spacing, but make sure we aren't just assigning |
97 | 97 | // a minus value or returning one. |
98 | 98 | $prev = $phpcsFile->findPrevious( T_WHITESPACE, ( $stackPtr - 1 ), null, true ); |
99 | - if ( T_RETURN === $tokens[ $prev ]['code'] ) { |
|
99 | + if ( T_RETURN === $tokens[ $prev ][ 'code' ] ) { |
|
100 | 100 | // Just returning a negative value; eg. return -1. |
101 | 101 | return; |
102 | 102 | } |
103 | 103 | |
104 | - if ( in_array( $tokens[ $prev ]['code'], PHP_CodeSniffer_Tokens::$operators, true ) ) { |
|
104 | + if ( in_array( $tokens[ $prev ][ 'code' ], PHP_CodeSniffer_Tokens::$operators, true ) ) { |
|
105 | 105 | // Just trying to operate on a negative value; eg. ($var * -1). |
106 | 106 | return; |
107 | 107 | } |
108 | 108 | |
109 | - if ( in_array( $tokens[ $prev ]['code'], PHP_CodeSniffer_Tokens::$comparisonTokens, true ) ) { |
|
109 | + if ( in_array( $tokens[ $prev ][ 'code' ], PHP_CodeSniffer_Tokens::$comparisonTokens, true ) ) { |
|
110 | 110 | // Just trying to compare a negative value; eg. ($var === -1). |
111 | 111 | return; |
112 | 112 | } |
@@ -119,16 +119,16 @@ discard block |
||
119 | 119 | T_OPEN_SQUARE_BRACKET, |
120 | 120 | ); |
121 | 121 | |
122 | - if ( in_array( $tokens[ $prev ]['code'], $invalidTokens, true ) ) { |
|
122 | + if ( in_array( $tokens[ $prev ][ 'code' ], $invalidTokens, true ) ) { |
|
123 | 123 | // Just trying to use a negative value; eg. myFunction($var, -2). |
124 | 124 | return; |
125 | 125 | } |
126 | 126 | |
127 | 127 | $number = $phpcsFile->findNext( T_WHITESPACE, ( $stackPtr + 1 ), null, true ); |
128 | - if ( T_LNUMBER === $tokens[ $number ]['code'] ) { |
|
128 | + if ( T_LNUMBER === $tokens[ $number ][ 'code' ] ) { |
|
129 | 129 | $semi = $phpcsFile->findNext( T_WHITESPACE, ( $number + 1 ), null, true ); |
130 | - if ( T_SEMICOLON === $tokens[ $semi ]['code'] ) { |
|
131 | - if ( false !== $prev && in_array( $tokens[ $prev ]['code'], PHP_CodeSniffer_Tokens::$assignmentTokens, true ) ) { |
|
130 | + if ( T_SEMICOLON === $tokens[ $semi ][ 'code' ] ) { |
|
131 | + if ( false !== $prev && in_array( $tokens[ $prev ][ 'code' ], PHP_CodeSniffer_Tokens::$assignmentTokens, true ) ) { |
|
132 | 132 | // This is a negative assignment. |
133 | 133 | return; |
134 | 134 | } |
@@ -136,9 +136,9 @@ discard block |
||
136 | 136 | } |
137 | 137 | } // end if |
138 | 138 | |
139 | - $operator = $tokens[ $stackPtr ]['content']; |
|
139 | + $operator = $tokens[ $stackPtr ][ 'content' ]; |
|
140 | 140 | |
141 | - if ( T_WHITESPACE !== $tokens[ ( $stackPtr - 1 ) ]['code'] ) { |
|
141 | + if ( T_WHITESPACE !== $tokens[ ( $stackPtr - 1 ) ][ 'code' ] ) { |
|
142 | 142 | $error = 'Expected 1 space before "%s"; 0 found'; |
143 | 143 | $data = array( $operator ); |
144 | 144 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -151,11 +151,11 @@ discard block |
||
151 | 151 | } else { |
152 | 152 | $phpcsFile->addError( $error, $stackPtr, 'NoSpaceBefore', $data ); |
153 | 153 | } |
154 | - } elseif ( 1 !== strlen( $tokens[ ( $stackPtr - 1 ) ]['content'] ) && 1 !== $tokens[ ( $stackPtr - 1 ) ]['column'] ) { |
|
154 | + } elseif ( 1 !== strlen( $tokens[ ( $stackPtr - 1 ) ][ 'content' ] ) && 1 !== $tokens[ ( $stackPtr - 1 ) ][ 'column' ] ) { |
|
155 | 155 | // Don't throw an error for assignments, because other standards allow |
156 | 156 | // multiple spaces there to align multiple assignments. |
157 | - if ( false === in_array( $tokens[ $stackPtr ]['code'], PHP_CodeSniffer_Tokens::$assignmentTokens, true ) ) { |
|
158 | - $found = strlen( $tokens[ ( $stackPtr - 1 ) ]['content'] ); |
|
157 | + if ( false === in_array( $tokens[ $stackPtr ][ 'code' ], PHP_CodeSniffer_Tokens::$assignmentTokens, true ) ) { |
|
158 | + $found = strlen( $tokens[ ( $stackPtr - 1 ) ][ 'content' ] ); |
|
159 | 159 | $error = 'Expected 1 space before "%s"; %s found'; |
160 | 160 | $data = array( |
161 | 161 | $operator, |
@@ -175,7 +175,7 @@ discard block |
||
175 | 175 | } // end if |
176 | 176 | |
177 | 177 | if ( '-' !== $operator ) { |
178 | - if ( T_WHITESPACE !== $tokens[ ( $stackPtr + 1 ) ]['code'] ) { |
|
178 | + if ( T_WHITESPACE !== $tokens[ ( $stackPtr + 1 ) ][ 'code' ] ) { |
|
179 | 179 | $error = 'Expected 1 space after "%s"; 0 found'; |
180 | 180 | $data = array( $operator ); |
181 | 181 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -188,8 +188,8 @@ discard block |
||
188 | 188 | } else { |
189 | 189 | $phpcsFile->addError( $error, $stackPtr, 'NoSpaceAfter', $data ); |
190 | 190 | } |
191 | - } elseif ( 1 !== strlen( $tokens[ ( $stackPtr + 1 ) ]['content'] ) ) { |
|
192 | - $found = strlen( $tokens[ ( $stackPtr + 1 ) ]['content'] ); |
|
191 | + } elseif ( 1 !== strlen( $tokens[ ( $stackPtr + 1 ) ][ 'content' ] ) ) { |
|
192 | + $found = strlen( $tokens[ ( $stackPtr + 1 ) ][ 'content' ] ); |
|
193 | 193 | $error = 'Expected 1 space after "%s"; %s found'; |
194 | 194 | $data = array( |
195 | 195 | $operator, |
@@ -93,15 +93,15 @@ discard block |
||
93 | 93 | * @return void |
94 | 94 | */ |
95 | 95 | public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) { |
96 | - $this->blank_line_check = (bool) $this->blank_line_check; |
|
96 | + $this->blank_line_check = (bool) $this->blank_line_check; |
|
97 | 97 | $this->blank_line_after_check = (bool) $this->blank_line_after_check; |
98 | 98 | |
99 | 99 | $this->init( $phpcsFile ); |
100 | 100 | |
101 | - if ( isset( $this->tokens[ ( $stackPtr + 1 ) ] ) && T_WHITESPACE !== $this->tokens[ ( $stackPtr + 1 ) ]['code'] |
|
102 | - && ! ( T_ELSE === $this->tokens[ $stackPtr ]['code'] && T_COLON === $this->tokens[ ( $stackPtr + 1 ) ]['code'] ) |
|
101 | + if ( isset( $this->tokens[ ( $stackPtr + 1 ) ] ) && T_WHITESPACE !== $this->tokens[ ( $stackPtr + 1 ) ][ 'code' ] |
|
102 | + && ! ( T_ELSE === $this->tokens[ $stackPtr ][ 'code' ] && T_COLON === $this->tokens[ ( $stackPtr + 1 ) ][ 'code' ] ) |
|
103 | 103 | && ! ( |
104 | - T_CLOSURE === $this->tokens[ $stackPtr ]['code'] |
|
104 | + T_CLOSURE === $this->tokens[ $stackPtr ][ 'code' ] |
|
105 | 105 | && ( |
106 | 106 | 0 === (int) $this->spaces_before_closure_open_paren |
107 | 107 | || -1 === (int) $this->spaces_before_closure_open_paren |
@@ -121,25 +121,25 @@ discard block |
||
121 | 121 | } |
122 | 122 | } |
123 | 123 | |
124 | - if ( ! isset( $this->tokens[ $stackPtr ]['scope_closer'] ) ) { |
|
124 | + if ( ! isset( $this->tokens[ $stackPtr ][ 'scope_closer' ] ) ) { |
|
125 | 125 | |
126 | - if ( T_USE === $this->tokens[ $stackPtr ]['code'] && 'closure' === $this->get_use_type( $stackPtr ) ) { |
|
126 | + if ( T_USE === $this->tokens[ $stackPtr ][ 'code' ] && 'closure' === $this->get_use_type( $stackPtr ) ) { |
|
127 | 127 | $scopeOpener = $phpcsFile->findNext( T_OPEN_CURLY_BRACKET, ( $stackPtr + 1 ) ); |
128 | - $scopeCloser = $this->tokens[ $scopeOpener ]['scope_closer']; |
|
128 | + $scopeCloser = $this->tokens[ $scopeOpener ][ 'scope_closer' ]; |
|
129 | 129 | } else { |
130 | 130 | return; |
131 | 131 | } |
132 | 132 | } else { |
133 | - $scopeOpener = $this->tokens[ $stackPtr ]['scope_opener']; |
|
134 | - $scopeCloser = $this->tokens[ $stackPtr ]['scope_closer']; |
|
133 | + $scopeOpener = $this->tokens[ $stackPtr ][ 'scope_opener' ]; |
|
134 | + $scopeCloser = $this->tokens[ $stackPtr ][ 'scope_closer' ]; |
|
135 | 135 | } |
136 | 136 | |
137 | 137 | // Alternative syntax. |
138 | - if ( T_COLON === $this->tokens[ $scopeOpener ]['code'] ) { |
|
138 | + if ( T_COLON === $this->tokens[ $scopeOpener ][ 'code' ] ) { |
|
139 | 139 | |
140 | 140 | if ( 'required' === $this->space_before_colon ) { |
141 | 141 | |
142 | - if ( T_WHITESPACE !== $this->tokens[ ( $scopeOpener - 1 ) ]['code'] ) { |
|
142 | + if ( T_WHITESPACE !== $this->tokens[ ( $scopeOpener - 1 ) ][ 'code' ] ) { |
|
143 | 143 | $error = 'Space between opening control structure and T_COLON is required'; |
144 | 144 | |
145 | 145 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -156,7 +156,7 @@ discard block |
||
156 | 156 | } |
157 | 157 | } elseif ( 'forbidden' === $this->space_before_colon ) { |
158 | 158 | |
159 | - if ( T_WHITESPACE === $this->tokens[ ( $scopeOpener - 1 ) ]['code'] ) { |
|
159 | + if ( T_WHITESPACE === $this->tokens[ ( $scopeOpener - 1 ) ][ 'code' ] ) { |
|
160 | 160 | $error = 'Extra space between opening control structure and T_COLON found'; |
161 | 161 | |
162 | 162 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -177,13 +177,13 @@ discard block |
||
177 | 177 | $parenthesisOpener = $phpcsFile->findNext( PHP_CodeSniffer_Tokens::$emptyTokens, ( $stackPtr + 1 ), null, true ); |
178 | 178 | |
179 | 179 | // If this is a function declaration. |
180 | - if ( T_FUNCTION === $this->tokens[ $stackPtr ]['code'] ) { |
|
180 | + if ( T_FUNCTION === $this->tokens[ $stackPtr ][ 'code' ] ) { |
|
181 | 181 | |
182 | - if ( T_STRING === $this->tokens[ $parenthesisOpener ]['code'] ) { |
|
182 | + if ( T_STRING === $this->tokens[ $parenthesisOpener ][ 'code' ] ) { |
|
183 | 183 | |
184 | 184 | $function_name_ptr = $parenthesisOpener; |
185 | 185 | |
186 | - } elseif ( T_BITWISE_AND === $this->tokens[ $parenthesisOpener ]['code'] ) { |
|
186 | + } elseif ( T_BITWISE_AND === $this->tokens[ $parenthesisOpener ][ 'code' ] ) { |
|
187 | 187 | |
188 | 188 | // This function returns by reference (function &function_name() {}). |
189 | 189 | $function_name_ptr = $parenthesisOpener = $phpcsFile->findNext( |
@@ -209,7 +209,7 @@ discard block |
||
209 | 209 | $error, |
210 | 210 | $stackPtr, |
211 | 211 | 'SpaceBeforeFunctionOpenParenthesis', |
212 | - $this->tokens[ ( $function_name_ptr + 1 ) ]['content'] |
|
212 | + $this->tokens[ ( $function_name_ptr + 1 ) ][ 'content' ] |
|
213 | 213 | ); |
214 | 214 | |
215 | 215 | if ( true === $fix ) { |
@@ -218,14 +218,14 @@ discard block |
||
218 | 218 | $phpcsFile->fixer->endChangeset(); |
219 | 219 | } |
220 | 220 | } |
221 | - } elseif ( T_CLOSURE === $this->tokens[ $stackPtr ]['code'] ) { |
|
221 | + } elseif ( T_CLOSURE === $this->tokens[ $stackPtr ][ 'code' ] ) { |
|
222 | 222 | |
223 | 223 | // Check if there is a use () statement. |
224 | - if ( isset( $this->tokens[ $parenthesisOpener ]['parenthesis_closer'] ) ) { |
|
224 | + if ( isset( $this->tokens[ $parenthesisOpener ][ 'parenthesis_closer' ] ) ) { |
|
225 | 225 | |
226 | 226 | $usePtr = $phpcsFile->findNext( |
227 | 227 | PHP_CodeSniffer_Tokens::$emptyTokens, |
228 | - ( $this->tokens[ $parenthesisOpener ]['parenthesis_closer'] + 1 ), |
|
228 | + ( $this->tokens[ $parenthesisOpener ][ 'parenthesis_closer' ] + 1 ), |
|
229 | 229 | null, |
230 | 230 | true, |
231 | 231 | null, |
@@ -233,23 +233,23 @@ discard block |
||
233 | 233 | ); |
234 | 234 | |
235 | 235 | // If it is, we set that as the "scope opener". |
236 | - if ( T_USE === $this->tokens[ $usePtr ]['code'] ) { |
|
236 | + if ( T_USE === $this->tokens[ $usePtr ][ 'code' ] ) { |
|
237 | 237 | $scopeOpener = $usePtr; |
238 | 238 | } |
239 | 239 | } |
240 | 240 | } |
241 | 241 | |
242 | 242 | if ( |
243 | - T_COLON !== $this->tokens[ $parenthesisOpener ]['code'] |
|
244 | - && T_FUNCTION !== $this->tokens[ $stackPtr ]['code'] |
|
243 | + T_COLON !== $this->tokens[ $parenthesisOpener ][ 'code' ] |
|
244 | + && T_FUNCTION !== $this->tokens[ $stackPtr ][ 'code' ] |
|
245 | 245 | ) { |
246 | 246 | |
247 | 247 | if ( |
248 | - T_CLOSURE === $this->tokens[ $stackPtr ]['code'] |
|
248 | + T_CLOSURE === $this->tokens[ $stackPtr ][ 'code' ] |
|
249 | 249 | && 0 === (int) $this->spaces_before_closure_open_paren |
250 | 250 | ) { |
251 | 251 | |
252 | - if ( ( $stackPtr + 1) !== $parenthesisOpener ) { |
|
252 | + if ( ( $stackPtr + 1 ) !== $parenthesisOpener ) { |
|
253 | 253 | // Checking this: function[*](...) {}. |
254 | 254 | $error = 'Space before closure opening parenthesis is prohibited'; |
255 | 255 | $fix = $phpcsFile->addFixableError( $error, $stackPtr, 'SpaceBeforeClosureOpenParenthesis' ); |
@@ -261,7 +261,7 @@ discard block |
||
261 | 261 | } |
262 | 262 | } elseif ( |
263 | 263 | ( |
264 | - T_CLOSURE !== $this->tokens[ $stackPtr ]['code'] |
|
264 | + T_CLOSURE !== $this->tokens[ $stackPtr ][ 'code' ] |
|
265 | 265 | || 1 === (int) $this->spaces_before_closure_open_paren |
266 | 266 | ) |
267 | 267 | && ( $stackPtr + 1 ) === $parenthesisOpener |
@@ -283,8 +283,8 @@ discard block |
||
283 | 283 | } |
284 | 284 | |
285 | 285 | if ( |
286 | - T_WHITESPACE === $this->tokens[ ( $stackPtr + 1 ) ]['code'] |
|
287 | - && ' ' !== $this->tokens[ ( $stackPtr + 1 ) ]['content'] |
|
286 | + T_WHITESPACE === $this->tokens[ ( $stackPtr + 1 ) ][ 'code' ] |
|
287 | + && ' ' !== $this->tokens[ ( $stackPtr + 1 ) ][ 'content' ] |
|
288 | 288 | ) { |
289 | 289 | // Checking this: if [*](...) {}. |
290 | 290 | $error = 'Expected exactly one space before opening parenthesis; "%s" found.'; |
@@ -292,7 +292,7 @@ discard block |
||
292 | 292 | $error, |
293 | 293 | $stackPtr, |
294 | 294 | 'ExtraSpaceBeforeOpenParenthesis', |
295 | - $this->tokens[ ( $stackPtr + 1 ) ]['content'] |
|
295 | + $this->tokens[ ( $stackPtr + 1 ) ][ 'content' ] |
|
296 | 296 | ); |
297 | 297 | |
298 | 298 | if ( true === $fix ) { |
@@ -302,8 +302,8 @@ discard block |
||
302 | 302 | } |
303 | 303 | } |
304 | 304 | |
305 | - if ( T_WHITESPACE !== $this->tokens[ ( $parenthesisOpener + 1) ]['code'] |
|
306 | - && T_CLOSE_PARENTHESIS !== $this->tokens[ ( $parenthesisOpener + 1) ]['code'] |
|
305 | + if ( T_WHITESPACE !== $this->tokens[ ( $parenthesisOpener + 1 ) ][ 'code' ] |
|
306 | + && T_CLOSE_PARENTHESIS !== $this->tokens[ ( $parenthesisOpener + 1 ) ][ 'code' ] |
|
307 | 307 | ) { |
308 | 308 | // Checking this: $value = my_function([*]...). |
309 | 309 | $error = 'No space after opening parenthesis is prohibited'; |
@@ -319,13 +319,13 @@ discard block |
||
319 | 319 | } |
320 | 320 | } |
321 | 321 | |
322 | - if ( isset( $this->tokens[ $parenthesisOpener ]['parenthesis_closer'] ) ) { |
|
322 | + if ( isset( $this->tokens[ $parenthesisOpener ][ 'parenthesis_closer' ] ) ) { |
|
323 | 323 | |
324 | - $parenthesisCloser = $this->tokens[ $parenthesisOpener ]['parenthesis_closer']; |
|
324 | + $parenthesisCloser = $this->tokens[ $parenthesisOpener ][ 'parenthesis_closer' ]; |
|
325 | 325 | |
326 | - if ( T_CLOSE_PARENTHESIS !== $this->tokens[ ( $parenthesisOpener + 1 ) ]['code'] ) { |
|
326 | + if ( T_CLOSE_PARENTHESIS !== $this->tokens[ ( $parenthesisOpener + 1 ) ][ 'code' ] ) { |
|
327 | 327 | |
328 | - if ( T_WHITESPACE !== $this->tokens[ ( $parenthesisCloser - 1 ) ]['code'] ) { |
|
328 | + if ( T_WHITESPACE !== $this->tokens[ ( $parenthesisCloser - 1 ) ][ 'code' ] ) { |
|
329 | 329 | $error = 'No space before closing parenthesis is prohibited'; |
330 | 330 | if ( isset( $phpcsFile->fixer ) ) { |
331 | 331 | $fix = $phpcsFile->addFixableError( $error, $parenthesisCloser, 'NoSpaceBeforeCloseParenthesis' ); |
@@ -340,8 +340,8 @@ discard block |
||
340 | 340 | } |
341 | 341 | |
342 | 342 | if ( |
343 | - T_WHITESPACE !== $this->tokens[ ( $parenthesisCloser + 1 ) ]['code'] |
|
344 | - && T_COLON !== $this->tokens[ $scopeOpener ]['code'] |
|
343 | + T_WHITESPACE !== $this->tokens[ ( $parenthesisCloser + 1 ) ][ 'code' ] |
|
344 | + && T_COLON !== $this->tokens[ $scopeOpener ][ 'code' ] |
|
345 | 345 | ) { |
346 | 346 | $error = 'Space between opening control structure and closing parenthesis is required'; |
347 | 347 | |
@@ -359,8 +359,8 @@ discard block |
||
359 | 359 | } |
360 | 360 | } |
361 | 361 | |
362 | - if ( isset( $this->tokens[ $parenthesisOpener ]['parenthesis_owner'] ) |
|
363 | - && $this->tokens[ $parenthesisCloser ]['line'] !== $this->tokens[ $scopeOpener ]['line'] |
|
362 | + if ( isset( $this->tokens[ $parenthesisOpener ][ 'parenthesis_owner' ] ) |
|
363 | + && $this->tokens[ $parenthesisCloser ][ 'line' ] !== $this->tokens[ $scopeOpener ][ 'line' ] |
|
364 | 364 | ) { |
365 | 365 | $error = 'Opening brace should be on the same line as the declaration'; |
366 | 366 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -381,8 +381,8 @@ discard block |
||
381 | 381 | return; |
382 | 382 | |
383 | 383 | } elseif ( |
384 | - T_WHITESPACE === $this->tokens[ ( $parenthesisCloser + 1 ) ]['code'] |
|
385 | - && ' ' !== $this->tokens[ ( $parenthesisCloser + 1 ) ]['content'] |
|
384 | + T_WHITESPACE === $this->tokens[ ( $parenthesisCloser + 1 ) ][ 'code' ] |
|
385 | + && ' ' !== $this->tokens[ ( $parenthesisCloser + 1 ) ][ 'content' ] |
|
386 | 386 | ) { |
387 | 387 | |
388 | 388 | // Checking this: if (...) [*]{}. |
@@ -391,7 +391,7 @@ discard block |
||
391 | 391 | $error, |
392 | 392 | $stackPtr, |
393 | 393 | 'ExtraSpaceAfterCloseParenthesis', |
394 | - $this->tokens[ ( $parenthesisCloser + 1 ) ]['content'] |
|
394 | + $this->tokens[ ( $parenthesisCloser + 1 ) ][ 'content' ] |
|
395 | 395 | ); |
396 | 396 | |
397 | 397 | if ( true === $fix ) { |
@@ -404,8 +404,8 @@ discard block |
||
404 | 404 | |
405 | 405 | if ( true === $this->blank_line_check ) { |
406 | 406 | $firstContent = $phpcsFile->findNext( T_WHITESPACE, ( $scopeOpener + 1 ), null, true ); |
407 | - if ( $this->tokens[ $firstContent ]['line'] > ( $this->tokens[ $scopeOpener ]['line'] + 1 ) |
|
408 | - && false === in_array( $this->tokens[ $firstContent ]['code'], array( T_CLOSE_TAG, T_COMMENT ), true ) |
|
407 | + if ( $this->tokens[ $firstContent ][ 'line' ] > ( $this->tokens[ $scopeOpener ][ 'line' ] + 1 ) |
|
408 | + && false === in_array( $this->tokens[ $firstContent ][ 'code' ], array( T_CLOSE_TAG, T_COMMENT ), true ) |
|
409 | 409 | ) { |
410 | 410 | $error = 'Blank line found at start of control structure'; |
411 | 411 | if ( isset( $phpcsFile->fixer ) ) { |
@@ -426,11 +426,11 @@ discard block |
||
426 | 426 | } |
427 | 427 | |
428 | 428 | $lastContent = $phpcsFile->findPrevious( T_WHITESPACE, ( $scopeCloser - 1 ), null, true ); |
429 | - if ( ( $this->tokens[ $scopeCloser ]['line'] - 1 ) !== $this->tokens[ $lastContent ]['line'] ) { |
|
429 | + if ( ( $this->tokens[ $scopeCloser ][ 'line' ] - 1 ) !== $this->tokens[ $lastContent ][ 'line' ] ) { |
|
430 | 430 | $errorToken = $scopeCloser; |
431 | 431 | for ( $i = ( $scopeCloser - 1 ); $i > $lastContent; $i-- ) { |
432 | - if ( $this->tokens[ $i ]['line'] < $this->tokens[ $scopeCloser ]['line'] |
|
433 | - && T_OPEN_TAG !== $this->tokens[ $firstContent ]['code'] |
|
432 | + if ( $this->tokens[ $i ][ 'line' ] < $this->tokens[ $scopeCloser ][ 'line' ] |
|
433 | + && T_OPEN_TAG !== $this->tokens[ $firstContent ][ 'code' ] |
|
434 | 434 | ) { |
435 | 435 | // TODO: Reporting error at empty line won't highlight it in IDE. |
436 | 436 | $error = 'Blank line found at end of control structure'; |
@@ -456,44 +456,44 @@ discard block |
||
456 | 456 | } // end if |
457 | 457 | |
458 | 458 | $trailingContent = $phpcsFile->findNext( T_WHITESPACE, ( $scopeCloser + 1 ), null, true ); |
459 | - if ( T_ELSE === $this->tokens[ $trailingContent ]['code'] ) { |
|
460 | - if ( T_IF === $this->tokens[ $stackPtr ]['code'] ) { |
|
459 | + if ( T_ELSE === $this->tokens[ $trailingContent ][ 'code' ] ) { |
|
460 | + if ( T_IF === $this->tokens[ $stackPtr ][ 'code' ] ) { |
|
461 | 461 | // IF with ELSE. |
462 | 462 | return; |
463 | 463 | } |
464 | 464 | } |
465 | 465 | |
466 | - if ( T_COMMENT === $this->tokens[ $trailingContent ]['code'] ) { |
|
467 | - if ( $this->tokens[ $trailingContent ]['line'] === $this->tokens[ $scopeCloser ]['line'] ) { |
|
468 | - if ( '//end' === substr( $this->tokens[ $trailingContent ]['content'], 0, 5 ) ) { |
|
466 | + if ( T_COMMENT === $this->tokens[ $trailingContent ][ 'code' ] ) { |
|
467 | + if ( $this->tokens[ $trailingContent ][ 'line' ] === $this->tokens[ $scopeCloser ][ 'line' ] ) { |
|
468 | + if ( '//end' === substr( $this->tokens[ $trailingContent ][ 'content' ], 0, 5 ) ) { |
|
469 | 469 | // There is an end comment, so we have to get the next piece |
470 | 470 | // of content. |
471 | - $trailingContent = $phpcsFile->findNext( T_WHITESPACE, ( $trailingContent + 1), null, true ); |
|
471 | + $trailingContent = $phpcsFile->findNext( T_WHITESPACE, ( $trailingContent + 1 ), null, true ); |
|
472 | 472 | } |
473 | 473 | } |
474 | 474 | } |
475 | 475 | |
476 | - if ( T_BREAK === $this->tokens[ $trailingContent ]['code'] ) { |
|
476 | + if ( T_BREAK === $this->tokens[ $trailingContent ][ 'code' ] ) { |
|
477 | 477 | // If this BREAK is closing a CASE, we don't need the |
478 | 478 | // blank line after this control structure. |
479 | - if ( isset( $this->tokens[ $trailingContent ]['scope_condition'] ) ) { |
|
480 | - $condition = $this->tokens[ $trailingContent ]['scope_condition']; |
|
481 | - if ( T_CASE === $this->tokens[ $condition ]['code'] || T_DEFAULT === $this->tokens[ $condition ]['code'] ) { |
|
479 | + if ( isset( $this->tokens[ $trailingContent ][ 'scope_condition' ] ) ) { |
|
480 | + $condition = $this->tokens[ $trailingContent ][ 'scope_condition' ]; |
|
481 | + if ( T_CASE === $this->tokens[ $condition ][ 'code' ] || T_DEFAULT === $this->tokens[ $condition ][ 'code' ] ) { |
|
482 | 482 | return; |
483 | 483 | } |
484 | 484 | } |
485 | 485 | } |
486 | 486 | |
487 | - if ( T_CLOSE_TAG === $this->tokens[ $trailingContent ]['code'] ) { |
|
487 | + if ( T_CLOSE_TAG === $this->tokens[ $trailingContent ][ 'code' ] ) { |
|
488 | 488 | // At the end of the script or embedded code. |
489 | 489 | return; |
490 | 490 | } |
491 | 491 | |
492 | - if ( T_CLOSE_CURLY_BRACKET === $this->tokens[ $trailingContent ]['code'] ) { |
|
492 | + if ( T_CLOSE_CURLY_BRACKET === $this->tokens[ $trailingContent ][ 'code' ] ) { |
|
493 | 493 | // Another control structure's closing brace. |
494 | - if ( isset( $this->tokens[ $trailingContent ]['scope_condition'] ) ) { |
|
495 | - $owner = $this->tokens[ $trailingContent ]['scope_condition']; |
|
496 | - if ( in_array( $this->tokens[ $owner ]['code'], array( T_FUNCTION, T_CLASS, T_INTERFACE, T_TRAIT ), true ) ) { |
|
494 | + if ( isset( $this->tokens[ $trailingContent ][ 'scope_condition' ] ) ) { |
|
495 | + $owner = $this->tokens[ $trailingContent ][ 'scope_condition' ]; |
|
496 | + if ( in_array( $this->tokens[ $owner ][ 'code' ], array( T_FUNCTION, T_CLASS, T_INTERFACE, T_TRAIT ), true ) ) { |
|
497 | 497 | // The next content is the closing brace of a function, class, interface or trait |
498 | 498 | // so normal function/class rules apply and we can ignore it. |
499 | 499 | return; |
@@ -501,7 +501,7 @@ discard block |
||
501 | 501 | } |
502 | 502 | |
503 | 503 | if ( true === $this->blank_line_after_check |
504 | - && ( $this->tokens[ $scopeCloser ]['line'] + 1 ) !== $this->tokens[ $trailingContent ]['line'] |
|
504 | + && ( $this->tokens[ $scopeCloser ][ 'line' ] + 1 ) !== $this->tokens[ $trailingContent ][ 'line' ] |
|
505 | 505 | ) { |
506 | 506 | // TODO: Won't cover following case: "} echo 'OK';". |
507 | 507 | $error = 'Blank line found after control structure'; |
@@ -92,7 +92,7 @@ discard block |
||
92 | 92 | $this->mergeWhiteList(); |
93 | 93 | |
94 | 94 | $tokens = $phpcs_file->getTokens(); |
95 | - $var_name = ltrim( $tokens[ $stack_ptr ]['content'], '$' ); |
|
95 | + $var_name = ltrim( $tokens[ $stack_ptr ][ 'content' ], '$' ); |
|
96 | 96 | |
97 | 97 | // If it's a php reserved var, then its ok. |
98 | 98 | if ( in_array( $var_name, $this->php_reserved_vars, true ) ) { |
@@ -100,13 +100,13 @@ discard block |
||
100 | 100 | } |
101 | 101 | |
102 | 102 | $obj_operator = $phpcs_file->findNext( array( T_WHITESPACE ), ( $stack_ptr + 1 ), null, true ); |
103 | - if ( T_OBJECT_OPERATOR === $tokens[ $obj_operator ]['code'] ) { |
|
103 | + if ( T_OBJECT_OPERATOR === $tokens[ $obj_operator ][ 'code' ] ) { |
|
104 | 104 | // Check to see if we are using a variable from an object. |
105 | 105 | $var = $phpcs_file->findNext( array( T_WHITESPACE ), ( $obj_operator + 1 ), null, true ); |
106 | - if ( T_STRING === $tokens[ $var ]['code'] ) { |
|
106 | + if ( T_STRING === $tokens[ $var ][ 'code' ] ) { |
|
107 | 107 | $bracket = $phpcs_file->findNext( array( T_WHITESPACE ), ( $var + 1 ), null, true ); |
108 | - if ( T_OPEN_PARENTHESIS !== $tokens[ $bracket ]['code'] ) { |
|
109 | - $obj_var_name = $tokens[ $var ]['content']; |
|
108 | + if ( T_OPEN_PARENTHESIS !== $tokens[ $bracket ][ 'code' ] ) { |
|
109 | + $obj_var_name = $tokens[ $var ][ 'content' ]; |
|
110 | 110 | |
111 | 111 | // There is no way for us to know if the var is public or |
112 | 112 | // private, so we have to ignore a leading underscore if there is |
@@ -127,7 +127,7 @@ discard block |
||
127 | 127 | |
128 | 128 | $in_class = false; |
129 | 129 | $obj_operator = $phpcs_file->findPrevious( array( T_WHITESPACE ), ( $stack_ptr - 1 ), null, true ); |
130 | - if ( T_DOUBLE_COLON === $tokens[ $obj_operator ]['code'] || T_OBJECT_OPERATOR === $tokens[ $obj_operator ]['code'] ) { |
|
130 | + if ( T_DOUBLE_COLON === $tokens[ $obj_operator ][ 'code' ] || T_OBJECT_OPERATOR === $tokens[ $obj_operator ][ 'code' ] ) { |
|
131 | 131 | // The variable lives within a class, and is referenced like |
132 | 132 | // this: MyClass::$_variable or $class->variable. |
133 | 133 | $in_class = true; |
@@ -151,7 +151,7 @@ discard block |
||
151 | 151 | } |
152 | 152 | |
153 | 153 | if ( isset( $error, $error_name ) ) { |
154 | - $data = array( $original_var_name ); |
|
154 | + $data = array( $original_var_name ); |
|
155 | 155 | $phpcs_file->addError( $error, $stack_ptr, $error_name, $data ); |
156 | 156 | } |
157 | 157 | } |
@@ -174,7 +174,7 @@ discard block |
||
174 | 174 | |
175 | 175 | $tokens = $phpcs_file->getTokens(); |
176 | 176 | |
177 | - $var_name = ltrim( $tokens[ $stack_ptr ]['content'], '$' ); |
|
177 | + $var_name = ltrim( $tokens[ $stack_ptr ][ 'content' ], '$' ); |
|
178 | 178 | $member_props = $phpcs_file->getMemberProperties( $stack_ptr ); |
179 | 179 | if ( empty( $member_props ) ) { |
180 | 180 | // Couldn't get any info about this variable, which |
@@ -205,8 +205,8 @@ discard block |
||
205 | 205 | |
206 | 206 | $tokens = $phpcs_file->getTokens(); |
207 | 207 | |
208 | - if ( preg_match_all( '|[^\\\]\${?([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)|', $tokens[ $stack_ptr ]['content'], $matches ) > 0 ) { |
|
209 | - foreach ( $matches[1] as $var_name ) { |
|
208 | + if ( preg_match_all( '|[^\\\]\${?([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)|', $tokens[ $stack_ptr ][ 'content' ], $matches ) > 0 ) { |
|
209 | + foreach ( $matches[ 1 ] as $var_name ) { |
|
210 | 210 | // If it's a php reserved var, then its ok. |
211 | 211 | if ( in_array( $var_name, $this->php_reserved_vars, true ) ) { |
212 | 212 | continue; |
@@ -117,7 +117,7 @@ discard block |
||
117 | 117 | return; |
118 | 118 | } |
119 | 119 | |
120 | - $className = $phpcsFile->getDeclarationName( $currScope ); |
|
120 | + $className = $phpcsFile->getDeclarationName( $currScope ); |
|
121 | 121 | |
122 | 122 | // Ignore special functions. |
123 | 123 | if ( '' === ltrim( $methodName, '_' ) ) { |
@@ -195,13 +195,13 @@ discard block |
||
195 | 195 | if ( ! isset( $tokens[ $stackPtr ] ) ) { |
196 | 196 | return false; |
197 | 197 | } |
198 | - if ( T_CLASS !== $tokens[ $stackPtr ]['code'] ) { |
|
198 | + if ( T_CLASS !== $tokens[ $stackPtr ][ 'code' ] ) { |
|
199 | 199 | return false; |
200 | 200 | } |
201 | - if ( ! isset( $tokens[ $stackPtr ]['scope_closer'] ) ) { |
|
201 | + if ( ! isset( $tokens[ $stackPtr ][ 'scope_closer' ] ) ) { |
|
202 | 202 | return false; |
203 | 203 | } |
204 | - $classOpenerIndex = $tokens[ $stackPtr ]['scope_opener']; |
|
204 | + $classOpenerIndex = $tokens[ $stackPtr ][ 'scope_opener' ]; |
|
205 | 205 | $extendsIndex = $phpcsFile->findNext( T_IMPLEMENTS, $stackPtr, $classOpenerIndex ); |
206 | 206 | if ( false === $extendsIndex ) { |
207 | 207 | return false; |
@@ -53,23 +53,23 @@ discard block |
||
53 | 53 | $tokens = $phpcsFile->getTokens(); |
54 | 54 | $scope_identifier = $phpcsFile->findNext( T_STRING, ( $stackPtr + 1 ) ); |
55 | 55 | $errorData = array( |
56 | - strtolower( $tokens[ $stackPtr ]['content'] ) . ' ' . $tokens[ $scope_identifier ]['content'] |
|
56 | + strtolower( $tokens[ $stackPtr ][ 'content' ] ) . ' ' . $tokens[ $scope_identifier ][ 'content' ] |
|
57 | 57 | ); |
58 | 58 | |
59 | - if ( ! isset( $tokens[ $stackPtr ]['scope_opener'] ) ) { |
|
59 | + if ( ! isset( $tokens[ $stackPtr ][ 'scope_opener' ] ) ) { |
|
60 | 60 | $error = 'Possible parse error: %s missing opening or closing brace'; |
61 | 61 | $phpcsFile->addWarning( $error, $stackPtr, 'MissingBrace', $errorData ); |
62 | 62 | return; |
63 | 63 | } |
64 | 64 | |
65 | - $openingBrace = $tokens[ $stackPtr ]['scope_opener']; |
|
65 | + $openingBrace = $tokens[ $stackPtr ][ 'scope_opener' ]; |
|
66 | 66 | |
67 | 67 | /* |
68 | 68 | * Is the brace on the same line as the class/interface/trait declaration ? |
69 | 69 | */ |
70 | 70 | $lastClassLineToken = $phpcsFile->findPrevious( T_STRING, ( $openingBrace - 1 ), $stackPtr ); |
71 | - $lastClassLine = $tokens[ $lastClassLineToken ]['line']; |
|
72 | - $braceLine = $tokens[ $openingBrace ]['line']; |
|
71 | + $lastClassLine = $tokens[ $lastClassLineToken ][ 'line' ]; |
|
72 | + $braceLine = $tokens[ $openingBrace ][ 'line' ]; |
|
73 | 73 | $lineDifference = ( $braceLine - $lastClassLine ); |
74 | 74 | |
75 | 75 | if ( $lineDifference > 0 ) { |
@@ -90,8 +90,8 @@ discard block |
||
90 | 90 | * Is the opening brace the last thing on the line ? |
91 | 91 | */ |
92 | 92 | $next = $phpcsFile->findNext( T_WHITESPACE, ( $openingBrace + 1 ), null, true ); |
93 | - if ( $tokens[ $next ]['line'] === $tokens[ $openingBrace ]['line'] ) { |
|
94 | - if ( $next === $tokens[ $stackPtr ]['scope_closer'] ) { |
|
93 | + if ( $tokens[ $next ][ 'line' ] === $tokens[ $openingBrace ][ 'line' ] ) { |
|
94 | + if ( $next === $tokens[ $stackPtr ][ 'scope_closer' ] ) { |
|
95 | 95 | // Ignore empty classes. |
96 | 96 | return; |
97 | 97 | } |
@@ -111,12 +111,12 @@ discard block |
||
111 | 111 | /* |
112 | 112 | * Is there precisely one space before the opening brace ? |
113 | 113 | */ |
114 | - if ( T_WHITESPACE !== $tokens[ ( $openingBrace - 1 ) ]['code'] ) { |
|
114 | + if ( T_WHITESPACE !== $tokens[ ( $openingBrace - 1 ) ][ 'code' ] ) { |
|
115 | 115 | $length = 0; |
116 | - } elseif ( "\t" === $tokens[ ( $openingBrace - 1 ) ]['content'] ) { |
|
116 | + } elseif ( "\t" === $tokens[ ( $openingBrace - 1 ) ][ 'content' ] ) { |
|
117 | 117 | $length = '\t'; |
118 | 118 | } else { |
119 | - $length = strlen( $tokens[ ( $openingBrace - 1 ) ]['content'] ); |
|
119 | + $length = strlen( $tokens[ ( $openingBrace - 1 ) ][ 'content' ] ); |
|
120 | 120 | } |
121 | 121 | |
122 | 122 | if ( 1 !== $length ) { |
@@ -114,7 +114,7 @@ discard block |
||
114 | 114 | $items = array_map( array( $this, 'prepare_name_for_regex' ), $group[ $key ] ); |
115 | 115 | $items = implode( '|', $items ); |
116 | 116 | |
117 | - $this->groups[ $groupName ]['regex'] = sprintf( $this->regex_pattern, $items ); |
|
117 | + $this->groups[ $groupName ][ 'regex' ] = sprintf( $this->regex_pattern, $items ); |
|
118 | 118 | } |
119 | 119 | } |
120 | 120 | |
@@ -140,21 +140,21 @@ discard block |
||
140 | 140 | |
141 | 141 | // Exclude function definitions, class methods, and namespaced calls. |
142 | 142 | if ( |
143 | - T_STRING === $token['code'] |
|
143 | + T_STRING === $token[ 'code' ] |
|
144 | 144 | && |
145 | 145 | ( $prev = $phpcsFile->findPrevious( T_WHITESPACE, ( $stackPtr - 1 ), null, true ) ) |
146 | 146 | && |
147 | 147 | ( |
148 | 148 | // Skip sniffing if calling a method, or on function definitions. |
149 | - in_array( $tokens[ $prev ]['code'], array( T_FUNCTION, T_DOUBLE_COLON, T_OBJECT_OPERATOR ), true ) |
|
149 | + in_array( $tokens[ $prev ][ 'code' ], array( T_FUNCTION, T_DOUBLE_COLON, T_OBJECT_OPERATOR ), true ) |
|
150 | 150 | || |
151 | 151 | ( |
152 | 152 | // Skip namespaced functions, ie: \foo\bar() not \bar(). |
153 | - T_NS_SEPARATOR === $tokens[ $prev ]['code'] |
|
153 | + T_NS_SEPARATOR === $tokens[ $prev ][ 'code' ] |
|
154 | 154 | && |
155 | 155 | ( $pprev = $phpcsFile->findPrevious( T_WHITESPACE, ( $prev - 1 ), null, true ) ) |
156 | 156 | && |
157 | - T_STRING === $tokens[ $pprev ]['code'] |
|
157 | + T_STRING === $tokens[ $pprev ][ 'code' ] |
|
158 | 158 | ) |
159 | 159 | ) |
160 | 160 | ) { |
@@ -169,15 +169,15 @@ discard block |
||
169 | 169 | continue; |
170 | 170 | } |
171 | 171 | |
172 | - if ( isset( $group['whitelist'][ $token['content'] ] ) ) { |
|
172 | + if ( isset( $group[ 'whitelist' ][ $token[ 'content' ] ] ) ) { |
|
173 | 173 | continue; |
174 | 174 | } |
175 | 175 | |
176 | - if ( preg_match( $group['regex'], $token['content'] ) < 1 ) { |
|
176 | + if ( preg_match( $group[ 'regex' ], $token[ 'content' ] ) < 1 ) { |
|
177 | 177 | continue; |
178 | 178 | } |
179 | 179 | |
180 | - if ( 'warning' === $group['type'] ) { |
|
180 | + if ( 'warning' === $group[ 'type' ] ) { |
|
181 | 181 | $addWhat = array( $phpcsFile, 'addWarning' ); |
182 | 182 | } else { |
183 | 183 | $addWhat = array( $phpcsFile, 'addError' ); |
@@ -185,10 +185,10 @@ discard block |
||
185 | 185 | |
186 | 186 | call_user_func( |
187 | 187 | $addWhat, |
188 | - $group['message'], |
|
188 | + $group[ 'message' ], |
|
189 | 189 | $stackPtr, |
190 | 190 | $groupName, |
191 | - array( $token['content'] ) |
|
191 | + array( $token[ 'content' ] ) |
|
192 | 192 | ); |
193 | 193 | |
194 | 194 | } |
@@ -206,7 +206,7 @@ discard block |
||
206 | 206 | * @return string Regex escaped function name. |
207 | 207 | */ |
208 | 208 | protected function prepare_name_for_regex( $function ) { |
209 | - $function = str_replace( array( '.*', '*' ) , '#', $function ); // Replace wildcards with placeholder. |
|
209 | + $function = str_replace( array( '.*', '*' ), '#', $function ); // Replace wildcards with placeholder. |
|
210 | 210 | $function = preg_quote( $function, '`' ); |
211 | 211 | $function = str_replace( '#', '.*', $function ); // Replace placeholder with regex wildcard. |
212 | 212 |
@@ -113,19 +113,19 @@ discard block |
||
113 | 113 | */ |
114 | 114 | public function __construct( $config, $object_id = 0 ) { |
115 | 115 | |
116 | - if ( empty( $config['id'] ) ) { |
|
116 | + if ( empty( $config[ 'id' ] ) ) { |
|
117 | 117 | wp_die( esc_html__( 'Metabox configuration is required to have an ID parameter.', 'cmb2' ) ); |
118 | 118 | } |
119 | 119 | |
120 | 120 | $this->meta_box = wp_parse_args( $config, $this->mb_defaults ); |
121 | - $this->meta_box['fields'] = array(); |
|
121 | + $this->meta_box[ 'fields' ] = array(); |
|
122 | 122 | |
123 | 123 | $this->object_id( $object_id ); |
124 | 124 | $this->mb_object_type(); |
125 | - $this->cmb_id = $config['id']; |
|
125 | + $this->cmb_id = $config[ 'id' ]; |
|
126 | 126 | |
127 | - if ( ! empty( $config['fields'] ) && is_array( $config['fields'] ) ) { |
|
128 | - $this->add_fields( $config['fields'] ); |
|
127 | + if ( ! empty( $config[ 'fields' ] ) && is_array( $config[ 'fields' ] ) ) { |
|
128 | + $this->add_fields( $config[ 'fields' ] ); |
|
129 | 129 | } |
130 | 130 | |
131 | 131 | CMB2_Boxes::add( $this ); |
@@ -294,22 +294,22 @@ discard block |
||
294 | 294 | * @return mixed CMB2_Field object if successful. |
295 | 295 | */ |
296 | 296 | public function render_field( $field_args ) { |
297 | - $field_args['context'] = $this->prop( 'context' ); |
|
297 | + $field_args[ 'context' ] = $this->prop( 'context' ); |
|
298 | 298 | |
299 | - if ( 'group' == $field_args['type'] ) { |
|
299 | + if ( 'group' == $field_args[ 'type' ] ) { |
|
300 | 300 | |
301 | - if ( ! isset( $field_args['show_names'] ) ) { |
|
302 | - $field_args['show_names'] = $this->prop( 'show_names' ); |
|
301 | + if ( ! isset( $field_args[ 'show_names' ] ) ) { |
|
302 | + $field_args[ 'show_names' ] = $this->prop( 'show_names' ); |
|
303 | 303 | } |
304 | 304 | $field = $this->render_group( $field_args ); |
305 | 305 | |
306 | - } elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) { |
|
306 | + } elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) { |
|
307 | 307 | // Save rendering for after the metabox |
308 | 308 | $field = $this->add_hidden_field( $field_args ); |
309 | 309 | |
310 | 310 | } else { |
311 | 311 | |
312 | - $field_args['show_names'] = $this->prop( 'show_names' ); |
|
312 | + $field_args[ 'show_names' ] = $this->prop( 'show_names' ); |
|
313 | 313 | |
314 | 314 | // Render default fields |
315 | 315 | $field = $this->get_field( $field_args )->render_field(); |
@@ -325,7 +325,7 @@ discard block |
||
325 | 325 | */ |
326 | 326 | public function render_group( $args ) { |
327 | 327 | |
328 | - if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) { |
|
328 | + if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) { |
|
329 | 329 | return; |
330 | 330 | } |
331 | 331 | |
@@ -435,15 +435,15 @@ discard block |
||
435 | 435 | <div class="inside cmb-td cmb-nested cmb-field-list">'; |
436 | 436 | // Loop and render repeatable group fields |
437 | 437 | foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) { |
438 | - if ( 'hidden' == $field_args['type'] ) { |
|
438 | + if ( 'hidden' == $field_args[ 'type' ] ) { |
|
439 | 439 | |
440 | 440 | // Save rendering for after the metabox |
441 | 441 | $this->add_hidden_field( $field_args, $field_group ); |
442 | 442 | |
443 | 443 | } else { |
444 | 444 | |
445 | - $field_args['show_names'] = $field_group->args( 'show_names' ); |
|
446 | - $field_args['context'] = $field_group->args( 'context' ); |
|
445 | + $field_args[ 'show_names' ] = $field_group->args( 'show_names' ); |
|
446 | + $field_args[ 'context' ] = $field_group->args( 'context' ); |
|
447 | 447 | |
448 | 448 | $field = $this->get_field( $field_args, $field_group )->render_field(); |
449 | 449 | } |
@@ -472,7 +472,7 @@ discard block |
||
472 | 472 | * @param CMB2_Field|null $field_group CMB2_Field group field object |
473 | 473 | */ |
474 | 474 | public function add_hidden_field( $field_args, $field_group = null ) { |
475 | - if ( isset( $field_args['field_args'] ) ) { |
|
475 | + if ( isset( $field_args[ 'field_args' ] ) ) { |
|
476 | 476 | // For back-compatibility. |
477 | 477 | $field = new CMB2_Field( $field_args ); |
478 | 478 | } else { |
@@ -485,7 +485,7 @@ discard block |
||
485 | 485 | $type->iterator = $field_group->index; |
486 | 486 | } |
487 | 487 | |
488 | - $this->hidden_fields[] = $type; |
|
488 | + $this->hidden_fields[ ] = $type; |
|
489 | 489 | |
490 | 490 | return $field; |
491 | 491 | } |
@@ -582,11 +582,11 @@ discard block |
||
582 | 582 | */ |
583 | 583 | public function process_field( $field_args ) { |
584 | 584 | |
585 | - switch ( $field_args['type'] ) { |
|
585 | + switch ( $field_args[ 'type' ] ) { |
|
586 | 586 | |
587 | 587 | case 'group': |
588 | 588 | if ( $this->save_group( $field_args ) ) { |
589 | - $this->updated[] = $field_args['id']; |
|
589 | + $this->updated[ ] = $field_args[ 'id' ]; |
|
590 | 590 | } |
591 | 591 | |
592 | 592 | break; |
@@ -600,7 +600,7 @@ discard block |
||
600 | 600 | $field = $this->get_new_field( $field_args ); |
601 | 601 | |
602 | 602 | if ( $field->save_field_from_data( $this->data_to_save ) ) { |
603 | - $this->updated[] = $field->id(); |
|
603 | + $this->updated[ ] = $field->id(); |
|
604 | 604 | } |
605 | 605 | |
606 | 606 | break; |
@@ -667,7 +667,7 @@ discard block |
||
667 | 667 | * @return mixed Return of CMB2_Field::update_data() |
668 | 668 | */ |
669 | 669 | public function save_group( $args ) { |
670 | - if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) { |
|
670 | + if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) { |
|
671 | 671 | return; |
672 | 672 | } |
673 | 673 | |
@@ -715,16 +715,16 @@ discard block |
||
715 | 715 | $_new_val = array(); |
716 | 716 | foreach ( $new_val as $group_index => $grouped_data ) { |
717 | 717 | // Add the supporting data to the $saved array stack |
718 | - $saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value']; |
|
718 | + $saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ]; |
|
719 | 719 | // Reset var to the actual value |
720 | - $_new_val[ $group_index ] = $grouped_data['value']; |
|
720 | + $_new_val[ $group_index ] = $grouped_data[ 'value' ]; |
|
721 | 721 | } |
722 | 722 | $new_val = $_new_val; |
723 | 723 | } else { |
724 | 724 | // Add the supporting data to the $saved array stack |
725 | - $saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value']; |
|
725 | + $saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ]; |
|
726 | 726 | // Reset var to the actual value |
727 | - $new_val = $new_val['value']; |
|
727 | + $new_val = $new_val[ 'value' ]; |
|
728 | 728 | } |
729 | 729 | } |
730 | 730 | |
@@ -738,7 +738,7 @@ discard block |
||
738 | 738 | |
739 | 739 | // Compare values and add to `$updated` array |
740 | 740 | if ( $is_updated || $is_removed ) { |
741 | - $this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id; |
|
741 | + $this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id; |
|
742 | 742 | } |
743 | 743 | |
744 | 744 | // Add to `$saved` array |
@@ -775,22 +775,22 @@ discard block |
||
775 | 775 | // Try to get our object ID from the global space |
776 | 776 | switch ( $this->object_type() ) { |
777 | 777 | case 'user': |
778 | - $object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id; |
|
779 | - $object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id; |
|
778 | + $object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id; |
|
779 | + $object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id; |
|
780 | 780 | break; |
781 | 781 | |
782 | 782 | case 'comment': |
783 | - $object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id; |
|
784 | - $object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id; |
|
783 | + $object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id; |
|
784 | + $object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id; |
|
785 | 785 | break; |
786 | 786 | |
787 | 787 | case 'term': |
788 | - $object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id; |
|
788 | + $object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id; |
|
789 | 789 | break; |
790 | 790 | |
791 | 791 | default: |
792 | - $object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id; |
|
793 | - $object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id; |
|
792 | + $object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id; |
|
793 | + $object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id; |
|
794 | 794 | break; |
795 | 795 | } |
796 | 796 | |
@@ -861,7 +861,7 @@ discard block |
||
861 | 861 | * @return boolean True/False |
862 | 862 | */ |
863 | 863 | public function is_options_page_mb() { |
864 | - return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) ); |
|
864 | + return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) ); |
|
865 | 865 | } |
866 | 866 | |
867 | 867 | /** |
@@ -948,7 +948,7 @@ discard block |
||
948 | 948 | return $field; |
949 | 949 | } |
950 | 950 | |
951 | - $field_id = is_string( $field ) ? $field : $field['id']; |
|
951 | + $field_id = is_string( $field ) ? $field : $field[ 'id' ]; |
|
952 | 952 | |
953 | 953 | $parent_field_id = ! empty( $field_group ) ? $field_group->id() : ''; |
954 | 954 | $ids = $this->get_field_ids( $field_id, $parent_field_id, true ); |
@@ -984,16 +984,16 @@ discard block |
||
984 | 984 | if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) { |
985 | 985 | |
986 | 986 | // Update the fields array w/ any modified properties inherited from the group field |
987 | - $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args; |
|
987 | + $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args; |
|
988 | 988 | |
989 | 989 | return $this->get_default_args( $field_args, $field_group ); |
990 | 990 | } |
991 | 991 | |
992 | 992 | if ( is_array( $field_args ) ) { |
993 | - $this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] ); |
|
993 | + $this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] ); |
|
994 | 994 | } |
995 | 995 | |
996 | - return $this->get_default_args( $this->meta_box['fields'][ $field_id ] ); |
|
996 | + return $this->get_default_args( $this->meta_box[ 'fields' ][ $field_id ] ); |
|
997 | 997 | } |
998 | 998 | |
999 | 999 | /** |
@@ -1043,8 +1043,8 @@ discard block |
||
1043 | 1043 | |
1044 | 1044 | $sub_fields = false; |
1045 | 1045 | if ( array_key_exists( 'fields', $field ) ) { |
1046 | - $sub_fields = $field['fields']; |
|
1047 | - unset( $field['fields'] ); |
|
1046 | + $sub_fields = $field[ 'fields' ]; |
|
1047 | + unset( $field[ 'fields' ] ); |
|
1048 | 1048 | } |
1049 | 1049 | |
1050 | 1050 | $field_id = $parent_field_id |
@@ -1069,26 +1069,26 @@ discard block |
||
1069 | 1069 | return false; |
1070 | 1070 | } |
1071 | 1071 | |
1072 | - if ( 'oembed' === $field['type'] ) { |
|
1072 | + if ( 'oembed' === $field[ 'type' ] ) { |
|
1073 | 1073 | // Initiate oembed Ajax hooks |
1074 | 1074 | cmb2_ajax(); |
1075 | 1075 | } |
1076 | 1076 | |
1077 | - if ( isset( $field['column'] ) && false !== $field['column'] ) { |
|
1077 | + if ( isset( $field[ 'column' ] ) && false !== $field[ 'column' ] ) { |
|
1078 | 1078 | $field = $this->define_field_column( $field ); |
1079 | 1079 | } |
1080 | 1080 | |
1081 | - if ( isset( $field['taxonomy'] ) && ! empty( $field['remove_default'] ) ) { |
|
1082 | - $this->tax_metaboxes_to_remove[ $field['taxonomy'] ] = $field['taxonomy']; |
|
1081 | + if ( isset( $field[ 'taxonomy' ] ) && ! empty( $field[ 'remove_default' ] ) ) { |
|
1082 | + $this->tax_metaboxes_to_remove[ $field[ 'taxonomy' ] ] = $field[ 'taxonomy' ]; |
|
1083 | 1083 | } |
1084 | 1084 | |
1085 | 1085 | $this->_add_field_to_array( |
1086 | 1086 | $field, |
1087 | - $this->meta_box['fields'], |
|
1087 | + $this->meta_box[ 'fields' ], |
|
1088 | 1088 | $position |
1089 | 1089 | ); |
1090 | 1090 | |
1091 | - return $field['id']; |
|
1091 | + return $field[ 'id' ]; |
|
1092 | 1092 | } |
1093 | 1093 | |
1094 | 1094 | /** |
@@ -1100,10 +1100,10 @@ discard block |
||
1100 | 1100 | protected function define_field_column( array $field ) { |
1101 | 1101 | $this->has_columns = true; |
1102 | 1102 | |
1103 | - $column = is_array( $field['column'] ) ? $field['column'] : array(); |
|
1103 | + $column = is_array( $field[ 'column' ] ) ? $field[ 'column' ] : array(); |
|
1104 | 1104 | |
1105 | - $field['column'] = wp_parse_args( $column, array( |
|
1106 | - 'name' => isset( $field['name'] ) ? $field['name'] : '', |
|
1105 | + $field[ 'column' ] = wp_parse_args( $column, array( |
|
1106 | + 'name' => isset( $field[ 'name' ] ) ? $field[ 'name' ] : '', |
|
1107 | 1107 | 'position' => false, |
1108 | 1108 | ) ); |
1109 | 1109 | |
@@ -1119,27 +1119,27 @@ discard block |
||
1119 | 1119 | * @return mixed Array of parent/field ids or false |
1120 | 1120 | */ |
1121 | 1121 | public function add_group_field( $parent_field_id, array $field, $position = 0 ) { |
1122 | - if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) { |
|
1122 | + if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) { |
|
1123 | 1123 | return false; |
1124 | 1124 | } |
1125 | 1125 | |
1126 | - $parent_field = $this->meta_box['fields'][ $parent_field_id ]; |
|
1126 | + $parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ]; |
|
1127 | 1127 | |
1128 | - if ( 'group' !== $parent_field['type'] ) { |
|
1128 | + if ( 'group' !== $parent_field[ 'type' ] ) { |
|
1129 | 1129 | return false; |
1130 | 1130 | } |
1131 | 1131 | |
1132 | - if ( ! isset( $parent_field['fields'] ) ) { |
|
1133 | - $this->meta_box['fields'][ $parent_field_id ]['fields'] = array(); |
|
1132 | + if ( ! isset( $parent_field[ 'fields' ] ) ) { |
|
1133 | + $this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array(); |
|
1134 | 1134 | } |
1135 | 1135 | |
1136 | 1136 | $this->_add_field_to_array( |
1137 | 1137 | $field, |
1138 | - $this->meta_box['fields'][ $parent_field_id ]['fields'], |
|
1138 | + $this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ], |
|
1139 | 1139 | $position |
1140 | 1140 | ); |
1141 | 1141 | |
1142 | - return array( $parent_field_id, $field['id'] ); |
|
1142 | + return array( $parent_field_id, $field[ 'id' ] ); |
|
1143 | 1143 | } |
1144 | 1144 | |
1145 | 1145 | /** |
@@ -1151,9 +1151,9 @@ discard block |
||
1151 | 1151 | */ |
1152 | 1152 | protected function _add_field_to_array( $field, &$fields, $position = 0 ) { |
1153 | 1153 | if ( $position ) { |
1154 | - CMB2_Utils::array_insert( $fields, array( $field['id'] => $field ), $position ); |
|
1154 | + CMB2_Utils::array_insert( $fields, array( $field[ 'id' ] => $field ), $position ); |
|
1155 | 1155 | } else { |
1156 | - $fields[ $field['id'] ] = $field; |
|
1156 | + $fields[ $field[ 'id' ] ] = $field; |
|
1157 | 1157 | } |
1158 | 1158 | } |
1159 | 1159 | |
@@ -1176,15 +1176,15 @@ discard block |
||
1176 | 1176 | unset( $this->fields[ implode( '', $ids ) ] ); |
1177 | 1177 | |
1178 | 1178 | if ( ! $sub_field_id ) { |
1179 | - unset( $this->meta_box['fields'][ $field_id ] ); |
|
1179 | + unset( $this->meta_box[ 'fields' ][ $field_id ] ); |
|
1180 | 1180 | return true; |
1181 | 1181 | } |
1182 | 1182 | |
1183 | - if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) { |
|
1184 | - unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ); |
|
1183 | + if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) { |
|
1184 | + unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ); |
|
1185 | 1185 | } |
1186 | - if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) { |
|
1187 | - unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ); |
|
1186 | + if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) { |
|
1187 | + unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ); |
|
1188 | 1188 | } |
1189 | 1189 | return true; |
1190 | 1190 | } |
@@ -1208,11 +1208,11 @@ discard block |
||
1208 | 1208 | list( $field_id, $sub_field_id ) = $ids; |
1209 | 1209 | |
1210 | 1210 | if ( ! $sub_field_id ) { |
1211 | - $this->meta_box['fields'][ $field_id ][ $property ] = $value; |
|
1211 | + $this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value; |
|
1212 | 1212 | return $field_id; |
1213 | 1213 | } |
1214 | 1214 | |
1215 | - $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value; |
|
1215 | + $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value; |
|
1216 | 1216 | return $field_id; |
1217 | 1217 | } |
1218 | 1218 | |
@@ -1226,7 +1226,7 @@ discard block |
||
1226 | 1226 | public function get_field_ids( $field_id, $parent_field_id = '' ) { |
1227 | 1227 | $sub_field_id = $parent_field_id ? $field_id : ''; |
1228 | 1228 | $field_id = $parent_field_id ? $parent_field_id : $field_id; |
1229 | - $fields =& $this->meta_box['fields']; |
|
1229 | + $fields = & $this->meta_box[ 'fields' ]; |
|
1230 | 1230 | |
1231 | 1231 | if ( ! array_key_exists( $field_id, $fields ) ) { |
1232 | 1232 | $field_id = $this->search_old_school_array( $field_id, $fields ); |
@@ -1240,12 +1240,12 @@ discard block |
||
1240 | 1240 | return array( $field_id, $sub_field_id ); |
1241 | 1241 | } |
1242 | 1242 | |
1243 | - if ( 'group' !== $fields[ $field_id ]['type'] ) { |
|
1243 | + if ( 'group' !== $fields[ $field_id ][ 'type' ] ) { |
|
1244 | 1244 | return false; |
1245 | 1245 | } |
1246 | 1246 | |
1247 | - if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) { |
|
1248 | - $sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] ); |
|
1247 | + if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) { |
|
1248 | + $sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] ); |
|
1249 | 1249 | } |
1250 | 1250 | |
1251 | 1251 | return false === $sub_field_id ? false : array( $field_id, $sub_field_id ); |
@@ -90,18 +90,18 @@ discard block |
||
90 | 90 | $oembed = cmb2_ajax()->get_oembed_no_edit( $args ); |
91 | 91 | |
92 | 92 | // Send back our embed |
93 | - if ( $oembed['embed'] && $oembed['embed'] != $oembed['fallback'] ) { |
|
94 | - return '<div class="cmb2-oembed">' . $oembed['embed'] . '</div>'; |
|
93 | + if ( $oembed[ 'embed' ] && $oembed[ 'embed' ] != $oembed[ 'fallback' ] ) { |
|
94 | + return '<div class="cmb2-oembed">' . $oembed[ 'embed' ] . '</div>'; |
|
95 | 95 | } |
96 | 96 | |
97 | 97 | $error = sprintf( |
98 | 98 | /* translators: 1: results for. 2: link to codex.wordpress.org/Embeds */ |
99 | 99 | esc_html__( 'No oEmbed Results Found for %1$s. View more info at %2$s.', 'cmb2' ), |
100 | - $oembed['fallback'], |
|
100 | + $oembed[ 'fallback' ], |
|
101 | 101 | '<a href="https://codex.wordpress.org/Embeds" target="_blank">codex.wordpress.org/Embeds</a>' |
102 | 102 | ); |
103 | 103 | |
104 | - if ( isset( $args['wp_error'] ) && $args['wp_error'] ) { |
|
104 | + if ( isset( $args[ 'wp_error' ] ) && $args[ 'wp_error' ] ) { |
|
105 | 105 | return new WP_Error( 'cmb2_get_oembed_result', $error, compact( 'oembed', 'args' ) ); |
106 | 106 | } |
107 | 107 | |
@@ -216,7 +216,7 @@ discard block |
||
216 | 216 | $cmb = CMB2_Boxes::get( $meta_box ); |
217 | 217 | } else { |
218 | 218 | // See if we already have an instance of this metabox |
219 | - $cmb = CMB2_Boxes::get( $meta_box['id'] ); |
|
219 | + $cmb = CMB2_Boxes::get( $meta_box[ 'id' ] ); |
|
220 | 220 | // If not, we'll initate a new metabox |
221 | 221 | $cmb = $cmb ? $cmb : new CMB2( $meta_box, $object_id ); |
222 | 222 | } |
@@ -292,7 +292,7 @@ discard block |
||
292 | 292 | ) ); |
293 | 293 | |
294 | 294 | // Set object type explicitly (rather than trying to guess from context) |
295 | - $cmb->object_type( $args['object_type'] ); |
|
295 | + $cmb->object_type( $args[ 'object_type' ] ); |
|
296 | 296 | |
297 | 297 | // Save the metabox if it's been submitted |
298 | 298 | // check permissions |
@@ -300,32 +300,32 @@ discard block |
||
300 | 300 | if ( |
301 | 301 | $cmb->prop( 'save_fields' ) |
302 | 302 | // check nonce |
303 | - && isset( $_POST['submit-cmb'], $_POST['object_id'], $_POST[ $cmb->nonce() ] ) |
|
303 | + && isset( $_POST[ 'submit-cmb' ], $_POST[ 'object_id' ], $_POST[ $cmb->nonce() ] ) |
|
304 | 304 | && wp_verify_nonce( $_POST[ $cmb->nonce() ], $cmb->nonce() ) |
305 | - && $object_id && $_POST['object_id'] == $object_id |
|
305 | + && $object_id && $_POST[ 'object_id' ] == $object_id |
|
306 | 306 | ) { |
307 | 307 | $cmb->save_fields( $object_id, $cmb->object_type(), $_POST ); |
308 | 308 | } |
309 | 309 | |
310 | 310 | // Enqueue JS/CSS |
311 | - if ( $args['cmb_styles'] ) { |
|
311 | + if ( $args[ 'cmb_styles' ] ) { |
|
312 | 312 | CMB2_hookup::enqueue_cmb_css(); |
313 | 313 | } |
314 | 314 | |
315 | - if ( $args['enqueue_js'] ) { |
|
315 | + if ( $args[ 'enqueue_js' ] ) { |
|
316 | 316 | CMB2_hookup::enqueue_cmb_js(); |
317 | 317 | } |
318 | 318 | |
319 | - $form_format = apply_filters( 'cmb2_get_metabox_form_format', $args['form_format'], $object_id, $cmb ); |
|
319 | + $form_format = apply_filters( 'cmb2_get_metabox_form_format', $args[ 'form_format' ], $object_id, $cmb ); |
|
320 | 320 | |
321 | 321 | $format_parts = explode( '%3$s', $form_format ); |
322 | 322 | |
323 | 323 | // Show cmb form |
324 | - printf( $format_parts[0], $cmb->cmb_id, $object_id ); |
|
324 | + printf( $format_parts[ 0 ], $cmb->cmb_id, $object_id ); |
|
325 | 325 | $cmb->show_form(); |
326 | 326 | |
327 | - if ( isset( $format_parts[1] ) && $format_parts[1] ) { |
|
328 | - printf( str_ireplace( '%4$s', '%1$s', $format_parts[1] ), $args['save_button'] ); |
|
327 | + if ( isset( $format_parts[ 1 ] ) && $format_parts[ 1 ] ) { |
|
328 | + printf( str_ireplace( '%4$s', '%1$s', $format_parts[ 1 ] ), $args[ 'save_button' ] ); |
|
329 | 329 | } |
330 | 330 | |
331 | 331 | } |
@@ -338,7 +338,7 @@ discard block |
||
338 | 338 | * @param array $args Optional arguments array |
339 | 339 | */ |
340 | 340 | function cmb2_metabox_form( $meta_box, $object_id = 0, $args = array() ) { |
341 | - if ( ! isset( $args['echo'] ) || $args['echo'] ) { |
|
341 | + if ( ! isset( $args[ 'echo' ] ) || $args[ 'echo' ] ) { |
|
342 | 342 | cmb2_print_metabox_form( $meta_box, $object_id, $args ); |
343 | 343 | } else { |
344 | 344 | return cmb2_get_metabox_form( $meta_box, $object_id, $args ); |
@@ -360,7 +360,7 @@ discard block |
||
360 | 360 | |
361 | 361 | $schedule_format = str_replace( |
362 | 362 | array( 'M', 'Y', 'm', 'd', 'H', 'i', 'a' ), |
363 | - array('%b', '%Y', '%m', '%d', '%H', '%M', '%p' ), |
|
363 | + array( '%b', '%Y', '%m', '%d', '%H', '%M', '%p' ), |
|
364 | 364 | $date_format |
365 | 365 | ); |
366 | 366 | |
@@ -377,14 +377,14 @@ discard block |
||
377 | 377 | * 4 or 2 characters, as needed |
378 | 378 | */ |
379 | 379 | '%04d-%02d-%02d %02d:%02d:%02d', |
380 | - $parsed_time['tm_year'] + 1900, // This will be "111", so we need to add 1900. |
|
381 | - $parsed_time['tm_mon'] + 1, // This will be the month minus one, so we add one. |
|
382 | - $parsed_time['tm_mday'], |
|
383 | - $parsed_time['tm_hour'], |
|
384 | - $parsed_time['tm_min'], |
|
385 | - $parsed_time['tm_sec'] |
|
380 | + $parsed_time[ 'tm_year' ] + 1900, // This will be "111", so we need to add 1900. |
|
381 | + $parsed_time[ 'tm_mon' ] + 1, // This will be the month minus one, so we add one. |
|
382 | + $parsed_time[ 'tm_mday' ], |
|
383 | + $parsed_time[ 'tm_hour' ], |
|
384 | + $parsed_time[ 'tm_min' ], |
|
385 | + $parsed_time[ 'tm_sec' ] |
|
386 | 386 | ); |
387 | 387 | |
388 | - return new DateTime($ymd); |
|
388 | + return new DateTime( $ymd ); |
|
389 | 389 | } |
390 | 390 | } |