jazzsequence / games-collector

vendor/extended-cpts/tests/phpunit/test-setup.php

Spacing +49 added lines, -49 removed lines

@@ -19,40 +19,40 @@ 
 
 	public function testPostTypeArgsAreCorrect() {
 
-		$this->assertEquals( 'hello',  $this->cpts['hello']->post_type );
-		$this->assertEquals( 'hellos', $this->cpts['hello']->post_slug );
-		$this->assertEquals( 'Hello',  $this->cpts['hello']->post_singular );
-		$this->assertEquals( 'Hellos', $this->cpts['hello']->post_plural );
-		$this->assertEquals( 'hello',  $this->cpts['hello']->post_singular_low );
-		$this->assertEquals( 'hellos', $this->cpts['hello']->post_plural_low );
-
-		$this->assertEquals( 'person', $this->cpts['person']->post_type );
-		$this->assertEquals( 'people', $this->cpts['person']->post_slug );
-		$this->assertEquals( 'Person', $this->cpts['person']->post_singular );
-		$this->assertEquals( 'People', $this->cpts['person']->post_plural );
-		$this->assertEquals( 'person', $this->cpts['person']->post_singular_low );
-		$this->assertEquals( 'people', $this->cpts['person']->post_plural_low );
-
-		$this->assertEquals( 'nice-thing',  $this->cpts['nice-thing']->post_type );
-		$this->assertEquals( 'things',      $this->cpts['nice-thing']->post_slug );
-		$this->assertEquals( 'Nice Thing',  $this->cpts['nice-thing']->post_singular );
-		$this->assertEquals( 'Nice Things', $this->cpts['nice-thing']->post_plural );
-		$this->assertEquals( 'nice thing',  $this->cpts['nice-thing']->post_singular_low );
-		$this->assertEquals( 'nice things', $this->cpts['nice-thing']->post_plural_low );
-
-		$this->assertEquals( 'foo',  $this->cpts['foo']->post_type );
-		$this->assertEquals( 'foos', $this->cpts['foo']->post_slug );
-		$this->assertEquals( 'Bar',  $this->cpts['foo']->post_singular );
-		$this->assertEquals( 'Bars', $this->cpts['foo']->post_plural );
-		$this->assertEquals( 'bar',  $this->cpts['foo']->post_singular_low );
-		$this->assertEquals( 'bars', $this->cpts['foo']->post_plural_low );
-
-		$this->assertEquals( 'bar',      $this->cpts['bar']->post_type );
-		$this->assertEquals( 'slug',     $this->cpts['bar']->post_slug );
-		$this->assertEquals( 'Singular', $this->cpts['bar']->post_singular );
-		$this->assertEquals( 'Plural',   $this->cpts['bar']->post_plural );
-		$this->assertEquals( 'singular', $this->cpts['bar']->post_singular_low );
-		$this->assertEquals( 'plural',   $this->cpts['bar']->post_plural_low );
+		$this->assertEquals( 'hello', $this->cpts[ 'hello' ]->post_type );
+		$this->assertEquals( 'hellos', $this->cpts[ 'hello' ]->post_slug );
+		$this->assertEquals( 'Hello', $this->cpts[ 'hello' ]->post_singular );
+		$this->assertEquals( 'Hellos', $this->cpts[ 'hello' ]->post_plural );
+		$this->assertEquals( 'hello', $this->cpts[ 'hello' ]->post_singular_low );
+		$this->assertEquals( 'hellos', $this->cpts[ 'hello' ]->post_plural_low );
+
+		$this->assertEquals( 'person', $this->cpts[ 'person' ]->post_type );
+		$this->assertEquals( 'people', $this->cpts[ 'person' ]->post_slug );
+		$this->assertEquals( 'Person', $this->cpts[ 'person' ]->post_singular );
+		$this->assertEquals( 'People', $this->cpts[ 'person' ]->post_plural );
+		$this->assertEquals( 'person', $this->cpts[ 'person' ]->post_singular_low );
+		$this->assertEquals( 'people', $this->cpts[ 'person' ]->post_plural_low );
+
+		$this->assertEquals( 'nice-thing', $this->cpts[ 'nice-thing' ]->post_type );
+		$this->assertEquals( 'things', $this->cpts[ 'nice-thing' ]->post_slug );
+		$this->assertEquals( 'Nice Thing', $this->cpts[ 'nice-thing' ]->post_singular );
+		$this->assertEquals( 'Nice Things', $this->cpts[ 'nice-thing' ]->post_plural );
+		$this->assertEquals( 'nice thing', $this->cpts[ 'nice-thing' ]->post_singular_low );
+		$this->assertEquals( 'nice things', $this->cpts[ 'nice-thing' ]->post_plural_low );
+
+		$this->assertEquals( 'foo', $this->cpts[ 'foo' ]->post_type );
+		$this->assertEquals( 'foos', $this->cpts[ 'foo' ]->post_slug );
+		$this->assertEquals( 'Bar', $this->cpts[ 'foo' ]->post_singular );
+		$this->assertEquals( 'Bars', $this->cpts[ 'foo' ]->post_plural );
+		$this->assertEquals( 'bar', $this->cpts[ 'foo' ]->post_singular_low );
+		$this->assertEquals( 'bars', $this->cpts[ 'foo' ]->post_plural_low );
+
+		$this->assertEquals( 'bar', $this->cpts[ 'bar' ]->post_type );
+		$this->assertEquals( 'slug', $this->cpts[ 'bar' ]->post_slug );
+		$this->assertEquals( 'Singular', $this->cpts[ 'bar' ]->post_singular );
+		$this->assertEquals( 'Plural', $this->cpts[ 'bar' ]->post_plural );
+		$this->assertEquals( 'singular', $this->cpts[ 'bar' ]->post_singular_low );
+		$this->assertEquals( 'plural', $this->cpts[ 'bar' ]->post_plural_low );
 
 	}
 
@@ -63,7 +63,7 @@ 
 		$this->assertTrue( $hello->public );
 		$this->assertTrue( $hello->hierarchical );
 		$this->assertTrue( $hello->has_archive );
-		$this->assertEquals( 'hi',   $hello->query_var );
+		$this->assertEquals( 'hi', $hello->query_var );
 		$this->assertEquals( 'page', $hello->capability_type );
 
 		$bar = get_post_type_object( 'bar' );
@@ -73,7 +73,7 @@ 
 		$this->assertFalse( $bar->has_archive );
 		$this->assertFalse( $bar->rewrite );
 		// This should be boolean false, but it's not:
-		$this->assertEquals( 'bar',  $bar->query_var );
+		$this->assertEquals( 'bar', $bar->query_var );
 		$this->assertEquals( 'page', $bar->capability_type );
 
 		$baz = get_post_type_object( 'baz' );
@@ -82,7 +82,7 @@ 
 		$this->assertTrue( $baz->hierarchical );
 		$this->assertFalse( $baz->has_archive );
 		$this->assertEquals( 'page', $baz->capability_type );
-		$this->assertEquals( 'baz',  $baz->query_var );
+		$this->assertEquals( 'baz', $baz->query_var );
 
 	}
 
@@ -126,49 +126,49 @@ 
 
 	public function testArchiveLinksAreCorrect() {
 
-		$link = get_post_type_archive_link( $this->cpts['hello']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'hello' ]->post_type );
 		$this->assertEquals( user_trailingslashit( home_url( 'hellos' ) ), $link );
 
-		$link = get_post_type_archive_link( $this->cpts['person']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'person' ]->post_type );
 		$this->assertEquals( user_trailingslashit( home_url( 'team' ) ), $link );
 
-		$link = get_post_type_archive_link( $this->cpts['nice-thing']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'nice-thing' ]->post_type );
 		$this->assertEquals( user_trailingslashit( home_url( 'things' ) ), $link );
 
-		$link = get_post_type_archive_link( $this->cpts['foo']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'foo' ]->post_type );
 		$this->assertEquals( user_trailingslashit( home_url( 'foos' ) ), $link );
 
-		$link = get_post_type_archive_link( $this->cpts['bar']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'bar' ]->post_type );
 		$this->assertFalse( $link );
 
-		$link = get_post_type_archive_link( $this->cpts['baz']->post_type );
+		$link = get_post_type_archive_link( $this->cpts[ 'baz' ]->post_type );
 		$this->assertFalse( $link );
 
 	}
 
 	public function testPermalinksAreCorrect() {
 
-		$post = get_post( $this->posts['hello'][0] );
+		$post = get_post( $this->posts[ 'hello' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( user_trailingslashit( home_url( sprintf( 'hellos/%s', $post->post_name ) ) ), $link );
 
-		$post = get_post( $this->posts['person'][0] );
+		$post = get_post( $this->posts[ 'person' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( user_trailingslashit( home_url( sprintf( 'people/%s', $post->post_name ) ) ), $link );
 
-		$post = get_post( $this->posts['nice-thing'][0] );
+		$post = get_post( $this->posts[ 'nice-thing' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( user_trailingslashit( home_url( sprintf( 'things/%s', $post->post_name ) ) ), $link );
 
-		$post = get_post( $this->posts['foo'][0] );
+		$post = get_post( $this->posts[ 'foo' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( user_trailingslashit( home_url( sprintf( 'foo/admin/delta/%s', $post->post_name ) ) ), $link );
 
-		$post = get_post( $this->posts['bar'][0] );
+		$post = get_post( $this->posts[ 'bar' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( add_query_arg( 'bar', $post->post_name, user_trailingslashit( home_url() ) ), $link );
 
-		$post = get_post( $this->posts['baz'][0] );
+		$post = get_post( $this->posts[ 'baz' ][ 0 ] );
 		$link = get_permalink( $post );
 		$this->assertEquals( user_trailingslashit( home_url( sprintf( 'baz/%s', $post->post_name ) ) ), $link );
 

vendor/extended-cpts/tests/phpunit/test-admin-queries.php

Spacing +51 added lines, -51 removed lines

@@ -10,13 +10,13 @@ 
 
 		$this->assertEquals( 1, $query->found_posts );
 
-		$this->assertSame( '',     $query->get( 'orderby' ) ); // date
+		$this->assertSame( '', $query->get( 'orderby' ) ); // date
 		$this->assertSame( 'DESC', $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['post'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'post' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -26,15 +26,15 @@ 
 			'post_type' => 'hello',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'menu_order title', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',              $query->get( 'order' ) );
-		$this->assertSame( '',                 $query->get( 'meta_key' ) );
-		$this->assertSame( '',                 $query->get( 'meta_value' ) );
-		$this->assertSame( '',                 $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['hello'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'hello' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -46,19 +46,19 @@ 
 			'order'     => 'ASC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'post_name', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',       $query->get( 'order' ) );
-		$this->assertSame( '',          $query->get( 'meta_key' ) );
-		$this->assertSame( '',          $query->get( 'meta_value' ) );
-		$this->assertSame( '',          $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
-			$this->posts['hello'][3],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 3 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -73,16 +73,16 @@ 
 
 		$this->assertEquals( 3, $query->found_posts );
 
-		$this->assertSame( 'meta_value',    $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',           $query->get( 'order' ) );
+		$this->assertSame( 'meta_value', $query->get( 'orderby' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
 		$this->assertSame( 'test_meta_key', $query->get( 'meta_key' ) );
-		$this->assertSame( '',              $query->get( 'meta_value' ) );
-		$this->assertSame( '',              $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][1],
-			$this->posts['hello'][2],
-			$this->posts['hello'][0],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 0 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -95,19 +95,19 @@ 
 			'order'     => 'ASC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'name', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',  $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
-			$this->posts['hello'][3],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 3 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -120,19 +120,19 @@ 
 			'order'     => 'DESC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'test_admin_cols_taxonomy', $query->get( 'orderby' ) );
-		$this->assertSame( 'DESC',                     $query->get( 'order' ) );
-		$this->assertSame( '',                         $query->get( 'meta_key' ) );
-		$this->assertSame( '',                         $query->get( 'meta_value' ) );
-		$this->assertSame( '',                         $query->get( 'meta_query' ) );
+		$this->assertSame( 'DESC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][3],
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
+			$this->posts[ 'hello' ][ 3 ],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -143,15 +143,15 @@ 
 			'post_type' => 'person',
 		) );
 
-		$this->assertEquals( count( $this->posts['person'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'person' ] ), $query->found_posts );
 
 		$this->assertSame( 'menu_order title', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',  $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['person'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'person' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 

vendor/extended-cpts/tests/phpunit/test-site-queries.php

Spacing +82 added lines, -82 removed lines

@@ -10,13 +10,13 @@ 
 
 		$this->assertEquals( 1, $query->found_posts );
 
-		$this->assertSame( '',     $query->get( 'orderby' ) ); // date
+		$this->assertSame( '', $query->get( 'orderby' ) ); // date
 		$this->assertSame( 'DESC', $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['post'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'post' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -26,15 +26,15 @@ 
 			'post_type' => 'hello',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
-		$this->assertSame( '',     $query->get( 'orderby' ) ); // date
+		$this->assertSame( '', $query->get( 'orderby' ) ); // date
 		$this->assertSame( 'DESC', $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['hello'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'hello' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -46,19 +46,19 @@ 
 			'order'     => 'ASC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'post_name', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',       $query->get( 'order' ) );
-		$this->assertSame( '',          $query->get( 'meta_key' ) );
-		$this->assertSame( '',          $query->get( 'meta_value' ) );
-		$this->assertSame( '',          $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
-			$this->posts['hello'][3],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 3 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -73,16 +73,16 @@ 
 
 		$this->assertEquals( 3, $query->found_posts );
 
-		$this->assertSame( 'meta_value',    $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',           $query->get( 'order' ) );
+		$this->assertSame( 'meta_value', $query->get( 'orderby' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
 		$this->assertSame( 'test_meta_key', $query->get( 'meta_key' ) );
-		$this->assertSame( '',              $query->get( 'meta_value' ) );
-		$this->assertSame( '',              $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][1],
-			$this->posts['hello'][2],
-			$this->posts['hello'][0],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 0 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -95,19 +95,19 @@ 
 			'order'     => 'ASC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'name', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',  $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
-			$this->posts['hello'][3],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 3 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -120,19 +120,19 @@ 
 			'order'     => 'DESC',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
 		$this->assertSame( 'test_site_sortables_taxonomy', $query->get( 'orderby' ) );
-		$this->assertSame( 'DESC',                         $query->get( 'order' ) );
-		$this->assertSame( '',                             $query->get( 'meta_key' ) );
-		$this->assertSame( '',                             $query->get( 'meta_value' ) );
-		$this->assertSame( '',                             $query->get( 'meta_query' ) );
+		$this->assertSame( 'DESC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][3],
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
-			$this->posts['hello'][1],
+			$this->posts[ 'hello' ][ 3 ],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
+			$this->posts[ 'hello' ][ 1 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -148,13 +148,13 @@ 
 
 		$this->assertEquals( 1, $query->found_posts );
 
-		$this->assertSame( '',              $query->get( 'meta_key' ) );
-		$this->assertSame( '',              $query->get( 'meta_value' ) );
-		$this->assertSame( 'test_meta_key', $meta_query[0]['key'] );
-		$this->assertSame( 'Alpha',         $meta_query[0]['value'] );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( 'test_meta_key', $meta_query[ 0 ][ 'key' ] );
+		$this->assertSame( 'Alpha', $meta_query[ 0 ][ 'value' ] );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][1],
+			$this->posts[ 'hello' ][ 1 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -177,11 +177,11 @@ 
 			'value'   => 'B',
 			'compare' => '>=',
 			'type'    => 'CHAR',
-		), $meta_query[0] );
+		), $meta_query[ 0 ] );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -199,7 +199,7 @@ 
 		$this->assertSame( '', $query->get( 'meta_value' ) );
 		$this->assertEmpty( $meta_query );
 
-		$this->assertEquals( $this->posts['hello'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'hello' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -214,15 +214,15 @@ 
 
 		$this->assertEquals( 2, $query->found_posts );
 
-		$this->assertSame( '',              $query->get( 'meta_key' ) );
-		$this->assertSame( '',              $query->get( 'meta_value' ) );
-		$this->assertSame( 'test_meta_key', $meta_query[0]['key'] );
-		$this->assertSame( 'ta',            $meta_query[0]['value'] );
-		$this->assertSame( 'LIKE',          $meta_query[0]['compare'] );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( 'test_meta_key', $meta_query[ 0 ][ 'key' ] );
+		$this->assertSame( 'ta', $meta_query[ 0 ][ 'value' ] );
+		$this->assertSame( 'LIKE', $meta_query[ 0 ][ 'compare' ] );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][2],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 2 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -238,17 +238,17 @@ 
 
 		$this->assertEquals( 3, $query->found_posts );
 
-		$this->assertSame( '',              $query->get( 'meta_key' ) );
-		$this->assertSame( '',              $query->get( 'meta_value' ) );
-		$this->assertSame( 'test_meta_key', $meta_query[0]['key'] );
-		$this->assertSame( 'NOT IN',        $meta_query[0]['compare'] );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( 'test_meta_key', $meta_query[ 0 ][ 'key' ] );
+		$this->assertSame( 'NOT IN', $meta_query[ 0 ][ 'compare' ] );
 
-		$this->assertEquals( array( '', '0', 'false', 'null' ), $meta_query[0]['value'] );
+		$this->assertEquals( array( '', '0', 'false', 'null' ), $meta_query[ 0 ][ 'value' ] );
 
 		$this->assertEquals( array(
-			$this->posts['hello'][0],
-			$this->posts['hello'][1],
-			$this->posts['hello'][2],
+			$this->posts[ 'hello' ][ 0 ],
+			$this->posts[ 'hello' ][ 1 ],
+			$this->posts[ 'hello' ][ 2 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
@@ -260,15 +260,15 @@ 
 			'test_site_filters_with_cap' => 'Alpha',
 		) );
 
-		$this->assertEquals( count( $this->posts['hello'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'hello' ] ), $query->found_posts );
 
-		$this->assertSame( '',     $query->get( 'orderby' ) ); // date
+		$this->assertSame( '', $query->get( 'orderby' ) ); // date
 		$this->assertSame( 'DESC', $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
-		$this->assertEquals( $this->posts['hello'], wp_list_pluck( $query->posts, 'ID' ) );
+		$this->assertEquals( $this->posts[ 'hello' ], wp_list_pluck( $query->posts, 'ID' ) );
 
 	}
 
@@ -278,17 +278,17 @@ 
 			'post_type' => 'person',
 		) );
 
-		$this->assertEquals( count( $this->posts['person'] ), $query->found_posts );
+		$this->assertEquals( count( $this->posts[ 'person' ] ), $query->found_posts );
 
 		$this->assertSame( 'name', $query->get( 'orderby' ) );
-		$this->assertSame( 'ASC',  $query->get( 'order' ) );
-		$this->assertSame( '',     $query->get( 'meta_key' ) );
-		$this->assertSame( '',     $query->get( 'meta_value' ) );
-		$this->assertSame( '',     $query->get( 'meta_query' ) );
+		$this->assertSame( 'ASC', $query->get( 'order' ) );
+		$this->assertSame( '', $query->get( 'meta_key' ) );
+		$this->assertSame( '', $query->get( 'meta_value' ) );
+		$this->assertSame( '', $query->get( 'meta_query' ) );
 
 		$this->assertEquals( array(
-			$this->posts['person'][1],
-			$this->posts['person'][0],
+			$this->posts[ 'person' ][ 1 ],
+			$this->posts[ 'person' ][ 0 ],
 		), wp_list_pluck( $query->posts, 'ID' ) );
 
 	}

vendor/extended-cpts/extended-cpts.php

Spacing +265 added lines, -265 removed lines

@@ -97,11 +97,11 @@ 
 		'capability_type' => 'page',
 		'hierarchical'    => true,
 		'supports'        => array( 'title', 'editor', 'thumbnail' ),
-		'site_filters'    => null,  # Custom arg
-		'site_sortables'  => null,  # Custom arg
+		'site_filters'    => null, # Custom arg
+		'site_sortables'  => null, # Custom arg
 		'show_in_feed'    => false, # Custom arg
-		'archive'         => null,  # Custom arg
-		'featured_image'  => null,  # Custom arg
+		'archive'         => null, # Custom arg
+		'featured_image'  => null, # Custom arg
 	);
 
 	/**
@@ -133,7 +133,7 @@ 
 		 *
 		 * @param array $args The post type arguments.
 		 */
-		$args  = apply_filters( "ext-cpts/{$post_type}/args", $args );
+		$args = apply_filters( "ext-cpts/{$post_type}/args", $args );
 		/**
 		 * Filter the names for this post type.
 		 *
@@ -143,22 +143,22 @@ 
 		 */
 		$names = apply_filters( "ext-cpts/{$post_type}/names", $names );
 
-		if ( isset( $names['singular'] ) ) {
-			$this->post_singular = $names['singular'];
+		if ( isset( $names[ 'singular' ] ) ) {
+			$this->post_singular = $names[ 'singular' ];
 		} else {
 			$this->post_singular = ucwords( str_replace( array( '-', '_' ), ' ', $post_type ) );
 		}
 
-		if ( isset( $names['slug'] ) ) {
-			$this->post_slug = $names['slug'];
-		} else if ( isset( $names['plural'] ) ) {
-			$this->post_slug = $names['plural'];
+		if ( isset( $names[ 'slug' ] ) ) {
+			$this->post_slug = $names[ 'slug' ];
+		} else if ( isset( $names[ 'plural' ] ) ) {
+			$this->post_slug = $names[ 'plural' ];
 		} else {
 			$this->post_slug = $post_type . 's';
 		}
 
-		if ( isset( $names['plural'] ) ) {
-			$this->post_plural = $names['plural'];
+		if ( isset( $names[ 'plural' ] ) ) {
+			$this->post_plural = $names[ 'plural' ];
 		} else {
 			$this->post_plural = $this->post_singular . 's';
 		}
@@ -173,7 +173,7 @@ 
 		# Build our labels:
 		# Why aren't these translatable?
 		# Answer: https://github.com/johnbillion/extended-cpts/pull/5#issuecomment-33756474
-		$this->defaults['labels'] = array(
+		$this->defaults[ 'labels' ] = array(
 			'name'                  => $this->post_plural,
 			'singular_name'         => $this->post_singular,
 			'menu_name'             => $this->post_plural,
@@ -197,19 +197,19 @@ 
 		);
 
 		# Build the featured image labels:
-		if ( isset( $args['featured_image'] ) ) {
-			$featured_image_low = strtolower( $args['featured_image'] );
-			$this->defaults['labels']['featured_image']        = $args['featured_image'];
-			$this->defaults['labels']['set_featured_image']    = sprintf( 'Set %s', $featured_image_low );
-			$this->defaults['labels']['remove_featured_image'] = sprintf( 'Remove %s', $featured_image_low );
-			$this->defaults['labels']['use_featured_image']    = sprintf( 'Use as %s', $featured_image_low );
+		if ( isset( $args[ 'featured_image' ] ) ) {
+			$featured_image_low = strtolower( $args[ 'featured_image' ] );
+			$this->defaults[ 'labels' ][ 'featured_image' ]        = $args[ 'featured_image' ];
+			$this->defaults[ 'labels' ][ 'set_featured_image' ]    = sprintf( 'Set %s', $featured_image_low );
+			$this->defaults[ 'labels' ][ 'remove_featured_image' ] = sprintf( 'Remove %s', $featured_image_low );
+			$this->defaults[ 'labels' ][ 'use_featured_image' ]    = sprintf( 'Use as %s', $featured_image_low );
 		}
 
 		# Only set default rewrites if we need them
-		if ( isset( $args['public'] ) && ! $args['public'] ) {
-			$this->defaults['rewrite'] = false;
+		if ( isset( $args[ 'public' ] ) && ! $args[ 'public' ] ) {
+			$this->defaults[ 'rewrite' ] = false;
 		} else {
-			$this->defaults['rewrite'] = array(
+			$this->defaults[ 'rewrite' ] = array(
 				'slug'       => $this->post_slug,
 				'with_front' => false,
 			);
@@ -226,40 +226,40 @@ 
 		}
 
 		# Enable post type archives by default
-		if ( ! isset( $this->args['has_archive'] ) ) {
-			$this->args['has_archive'] = $this->args['public'];
+		if ( ! isset( $this->args[ 'has_archive' ] ) ) {
+			$this->args[ 'has_archive' ] = $this->args[ 'public' ];
 		}
 
 		# Front-end sortables:
-		if ( $this->args['site_sortables'] && ! is_admin() ) {
+		if ( $this->args[ 'site_sortables' ] && ! is_admin() ) {
 			add_filter( 'pre_get_posts', array( $this, 'maybe_sort_by_fields' ) );
 			add_filter( 'posts_clauses', array( $this, 'maybe_sort_by_taxonomy' ), 10, 2 );
 		}
 
 		# Front-end filters:
-		if ( $this->args['site_filters'] && ! is_admin() ) {
+		if ( $this->args[ 'site_filters' ] && ! is_admin() ) {
 			add_action( 'pre_get_posts', array( $this, 'maybe_filter' ) );
-			add_filter( 'query_vars',    array( $this, 'add_query_vars' ) );
+			add_filter( 'query_vars', array( $this, 'add_query_vars' ) );
 		}
 
 		# Post type in the site's main feed:
-		if ( $this->args['show_in_feed'] ) {
+		if ( $this->args[ 'show_in_feed' ] ) {
 			add_filter( 'request', array( $this, 'add_to_feed' ) );
 		}
 
 		# Post type archive query vars:
-		if ( $this->args['archive'] && ! is_admin() ) {
+		if ( $this->args[ 'archive' ] && ! is_admin() ) {
 			add_filter( 'parse_request', array( $this, 'override_private_query_vars' ), 1 );
 		}
 
 		# Custom post type permastruct:
-		if ( $this->args['rewrite'] && ! empty( $this->args['rewrite']['permastruct'] ) ) {
+		if ( $this->args[ 'rewrite' ] && ! empty( $this->args[ 'rewrite' ][ 'permastruct' ] ) ) {
 			add_action( 'registered_post_type', array( $this, 'registered_post_type' ), 1, 2 );
-			add_filter( 'post_type_link',       array( $this, 'post_type_link' ), 1, 4 );
+			add_filter( 'post_type_link', array( $this, 'post_type_link' ), 1, 4 );
 		}
 
 		# Rewrite testing:
-		if ( $this->args['rewrite'] ) {
+		if ( $this->args[ 'rewrite' ] ) {
 			add_filter( 'rewrite_testing_tests', array( $this, 'rewrite_testing_tests' ), 1 );
 		}
 
@@ -281,11 +281,11 @@ 
 	 */
 	public function maybe_filter( WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return;
 		}
 
-		$vars = Extended_CPT::get_filter_vars( $wp_query->query, $this->args['site_filters'] );
+		$vars = Extended_CPT::get_filter_vars( $wp_query->query, $this->args[ 'site_filters' ] );
 
 		if ( empty( $vars ) ) {
 			return;
@@ -311,25 +311,25 @@ 
 	 */
 	public function maybe_sort_by_fields( WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return;
 		}
 
 		// If we've not specified an order:
-		if ( empty( $wp_query->query['orderby'] ) ) {
+		if ( empty( $wp_query->query[ 'orderby' ] ) ) {
 
 			// Loop over our sortables to find the default sort field (if there is one):
-			foreach ( $this->args['site_sortables'] as $id => $col ) {
-				if ( is_array( $col ) && isset( $col['default'] ) ) {
+			foreach ( $this->args[ 'site_sortables' ] as $id => $col ) {
+				if ( is_array( $col ) && isset( $col[ 'default' ] ) ) {
 					// @TODO Don't set 'order' if 'orderby' is an array (WP 4.0+)
-					$wp_query->query['orderby'] = $id;
-					$wp_query->query['order']   = ( 'desc' === strtolower( $col['default'] ) ? 'desc' : 'asc' );
+					$wp_query->query[ 'orderby' ] = $id;
+					$wp_query->query[ 'order' ]   = ( 'desc' === strtolower( $col[ 'default' ] ) ? 'desc' : 'asc' );
 					break;
 				}
 			}
 		}
 
-		$sort = Extended_CPT::get_sort_field_vars( $wp_query->query, $this->args['site_sortables'] );
+		$sort = Extended_CPT::get_sort_field_vars( $wp_query->query, $this->args[ 'site_sortables' ] );
 
 		if ( empty( $sort ) ) {
 			return;
@@ -350,11 +350,11 @@ 
 	 */
 	public function maybe_sort_by_taxonomy( array $clauses, WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return $clauses;
 		}
 
-		$sort = Extended_CPT::get_sort_taxonomy_clauses( $clauses, $wp_query->query, $this->args['site_sortables'] );
+		$sort = Extended_CPT::get_sort_taxonomy_clauses( $clauses, $wp_query->query, $this->args[ 'site_sortables' ] );
 
 		if ( empty( $sort ) ) {
 			return $clauses;
@@ -382,22 +382,22 @@ 
 			if ( ! isset( $query[ $filter_key ] ) || ( '' === $query[ $filter_key ] ) ) {
 				continue;
 			}
-			if ( isset( $filter['cap'] ) && ! current_user_can( $filter['cap'] ) ) {
+			if ( isset( $filter[ 'cap' ] ) && ! current_user_can( $filter[ 'cap' ] ) ) {
 				continue;
 			}
 
-			if ( isset( $filter['meta_key'] ) ) {
+			if ( isset( $filter[ 'meta_key' ] ) ) {
 				$meta_query = array(
-					'key'   => $filter['meta_key'],
+					'key'   => $filter[ 'meta_key' ],
 					'value' => wp_unslash( $query[ $filter_key ] ),
 				);
-			} else if ( isset( $filter['meta_search_key'] ) ) {
+			} else if ( isset( $filter[ 'meta_search_key' ] ) ) {
 				$meta_query = array(
-					'key'     => $filter['meta_search_key'],
+					'key'     => $filter[ 'meta_search_key' ],
 					'value'   => wp_unslash( $query[ $filter_key ] ),
 					'compare' => 'LIKE',
 				);
-			} else if ( isset( $filter['meta_exists'] ) ) {
+			} else if ( isset( $filter[ 'meta_exists' ] ) ) {
 				$meta_query = array(
 					'key'     => wp_unslash( $query[ $filter_key ] ),
 					'compare' => 'NOT IN',
@@ -407,12 +407,12 @@ 
 				continue;
 			}
 
-			if ( isset( $filter['meta_query'] ) ) {
-				$meta_query = array_merge( $meta_query, $filter['meta_query'] );
+			if ( isset( $filter[ 'meta_query' ] ) ) {
+				$meta_query = array_merge( $meta_query, $filter[ 'meta_query' ] );
 			}
 
 			if ( ! empty( $meta_query ) ) {
-				$return['meta_query'][] = $meta_query;
+				$return[ 'meta_query' ][ ] = $meta_query;
 			}
 		}
 
@@ -431,35 +431,35 @@ 
 	 */
 	public static function get_sort_field_vars( array $vars, array $sortables ) {
 
-		if ( ! isset( $vars['orderby'] ) ) {
+		if ( ! isset( $vars[ 'orderby' ] ) ) {
 			return array();
 		}
-		if ( ! isset( $sortables[ $vars['orderby'] ] ) ) {
+		if ( ! isset( $sortables[ $vars[ 'orderby' ] ] ) ) {
 			return array();
 		}
 
-		$orderby = $sortables[ $vars['orderby'] ];
+		$orderby = $sortables[ $vars[ 'orderby' ] ];
 
 		if ( ! is_array( $orderby ) ) {
 			return array();
 		}
-		if ( isset( $orderby['sortable'] ) && ! $orderby['sortable'] ) {
+		if ( isset( $orderby[ 'sortable' ] ) && ! $orderby[ 'sortable' ] ) {
 			return array();
 		}
 
 		$return = array();
 
-		if ( isset( $orderby['meta_key'] ) ) {
-			$return['meta_key'] = $orderby['meta_key'];
-			$return['orderby']  = 'meta_value';
+		if ( isset( $orderby[ 'meta_key' ] ) ) {
+			$return[ 'meta_key' ] = $orderby[ 'meta_key' ];
+			$return[ 'orderby' ]  = 'meta_value';
 			// @TODO meta_value_num
-		} else if ( isset( $orderby['post_field'] ) ) {
-			$field = str_replace( 'post_', '', $orderby['post_field'] );
-			$return['orderby'] = $field;
+		} else if ( isset( $orderby[ 'post_field' ] ) ) {
+			$field = str_replace( 'post_', '', $orderby[ 'post_field' ] );
+			$return[ 'orderby' ] = $field;
 		}
 
-		if ( isset( $vars['order'] ) ) {
-			$return['order'] = $vars['order'];
+		if ( isset( $vars[ 'order' ] ) ) {
+			$return[ 'order' ] = $vars[ 'order' ];
 		}
 
 		return $return;
@@ -480,27 +480,27 @@ 
 
 		global $wpdb;
 
-		if ( ! isset( $vars['orderby'] ) ) {
+		if ( ! isset( $vars[ 'orderby' ] ) ) {
 			return array();
 		}
-		if ( ! isset( $sortables[ $vars['orderby'] ] ) ) {
+		if ( ! isset( $sortables[ $vars[ 'orderby' ] ] ) ) {
 			return array();
 		}
 
-		$orderby = $sortables[ $vars['orderby'] ];
+		$orderby = $sortables[ $vars[ 'orderby' ] ];
 
 		if ( ! is_array( $orderby ) ) {
 			return array();
 		}
-		if ( isset( $orderby['sortable'] ) && ! $orderby['sortable'] ) {
+		if ( isset( $orderby[ 'sortable' ] ) && ! $orderby[ 'sortable' ] ) {
 			return array();
 		}
-		if ( ! isset( $orderby['taxonomy'] ) ) {
+		if ( ! isset( $orderby[ 'taxonomy' ] ) ) {
 			return array();
 		}
 
 		# Taxonomy term ordering courtesy of http://scribu.net/wordpress/sortable-taxonomy-columns.html
-		$clauses['join'] .= "
+		$clauses[ 'join' ] .= "
 			LEFT OUTER JOIN {$wpdb->term_relationships} as ext_cpts_tr
 			ON ( {$wpdb->posts}.ID = ext_cpts_tr.object_id )
 			LEFT OUTER JOIN {$wpdb->term_taxonomy} as ext_cpts_tt
@@ -508,10 +508,10 @@ 
 			LEFT OUTER JOIN {$wpdb->terms} as ext_cpts_t
 			ON ( ext_cpts_tt.term_id = ext_cpts_t.term_id )
 		";
-		$clauses['where'] .= $wpdb->prepare( ' AND ( taxonomy = %s OR taxonomy IS NULL )', $orderby['taxonomy'] );
-		$clauses['groupby'] = 'ext_cpts_tr.object_id';
-		$clauses['orderby'] = 'GROUP_CONCAT( ext_cpts_t.name ORDER BY name ASC ) ';
-		$clauses['orderby'] .= ( isset( $vars['order'] ) && ( 'ASC' === strtoupper( $vars['order'] ) ) ) ? 'ASC' : 'DESC';
+		$clauses[ 'where' ] .= $wpdb->prepare( ' AND ( taxonomy = %s OR taxonomy IS NULL )', $orderby[ 'taxonomy' ] );
+		$clauses[ 'groupby' ] = 'ext_cpts_tr.object_id';
+		$clauses[ 'orderby' ] = 'GROUP_CONCAT( ext_cpts_t.name ORDER BY name ASC ) ';
+		$clauses[ 'orderby' ] .= ( isset( $vars[ 'order' ] ) && ( 'ASC' === strtoupper( $vars[ 'order' ] ) ) ) ? 'ASC' : 'DESC';
 
 		return $clauses;
 
@@ -525,7 +525,7 @@ 
 	 */
 	public function add_query_vars( array $vars ) {
 
-		$filters = array_keys( $this->args['site_filters'] );
+		$filters = array_keys( $this->args[ 'site_filters' ] );
 
 		return array_merge( $vars, $filters );
 
@@ -540,14 +540,14 @@ 
 	public function add_to_feed( array $vars ) {
 
 		# If it's not a feed, we're not interested:
-		if ( ! isset( $vars['feed'] ) ) {
+		if ( ! isset( $vars[ 'feed' ] ) ) {
 			return $vars;
 		}
 
-		if ( ! isset( $vars['post_type'] ) ) {
-			$vars['post_type'] = array( 'post', $this->post_type );
-		} else if ( is_array( $vars['post_type'] ) && ( count( $vars['post_type'] ) > 1 ) ) {
-			$vars['post_type'][] = $this->post_type;
+		if ( ! isset( $vars[ 'post_type' ] ) ) {
+			$vars[ 'post_type' ] = array( 'post', $this->post_type );
+		} else if ( is_array( $vars[ 'post_type' ] ) && ( count( $vars[ 'post_type' ] ) > 1 ) ) {
+			$vars[ 'post_type' ][ ] = $this->post_type;
 		}
 
 		return $vars;
@@ -563,17 +563,17 @@ 
 	public function override_private_query_vars( WP $wp ) {
 
 		# If it's not our post type, bail out:
-		if ( ! isset( $wp->query_vars['post_type'] ) || ( $this->post_type !== $wp->query_vars['post_type'] ) ) {
+		if ( ! isset( $wp->query_vars[ 'post_type' ] ) || ( $this->post_type !== $wp->query_vars[ 'post_type' ] ) ) {
 			return $wp;
 		}
 
 		# If it's a single post, bail out:
-		if ( isset( $wp->query_vars['name'] ) ) {
+		if ( isset( $wp->query_vars[ 'name' ] ) ) {
 			return $wp;
 		}
 
 		# Set the vars:
-		foreach ( $this->args['archive'] as $var => $value ) {
+		foreach ( $this->args[ 'archive' ] as $var => $value ) {
 			$wp->query_vars[ $var ] = $value;
 		}
 
@@ -591,7 +591,7 @@ 
 		if ( $post_type !== $this->post_type ) {
 			return;
 		}
-		$struct = str_replace( "%{$this->post_type}_slug%", $this->post_slug, $args->rewrite['permastruct'] );
+		$struct = str_replace( "%{$this->post_type}_slug%", $this->post_slug, $args->rewrite[ 'permastruct' ] );
 		$struct = str_replace( '%postname%', "%{$this->post_type}%", $struct );
 		add_permastruct( $this->post_type, $struct, $args->rewrite );
 	}
@@ -614,17 +614,17 @@ 
 
 		$date = explode( ' ', mysql2date( 'Y m d H i s', $post->post_date ) );
 		$replacements = array(
-			'%year%'     => $date[0],
-			'%monthnum%' => $date[1],
-			'%day%'      => $date[2],
-			'%hour%'     => $date[3],
-			'%minute%'   => $date[4],
-			'%second%'   => $date[5],
+			'%year%'     => $date[ 0 ],
+			'%monthnum%' => $date[ 1 ],
+			'%day%'      => $date[ 2 ],
+			'%hour%'     => $date[ 3 ],
+			'%minute%'   => $date[ 4 ],
+			'%second%'   => $date[ 5 ],
 			'%post_id%'  => $post->ID,
 		);
 
 		if ( false !== strpos( $post_link, '%author%' ) ) {
-			$replacements['%author%'] = get_userdata( $post->post_author )->user_nicename;
+			$replacements[ '%author%' ] = get_userdata( $post->post_author )->user_nicename;
 		}
 
 		foreach ( get_object_taxonomies( $post ) as $tax ) {
@@ -699,10 +699,10 @@ 
 	 */
 	public function register_post_type() {
 
-		if ( ! isset( $this->args['query_var'] ) || ( true === $this->args['query_var'] ) ) {
+		if ( ! isset( $this->args[ 'query_var' ] ) || ( true === $this->args[ 'query_var' ] ) ) {
 			$query_var = $this->post_type;
 		} else {
-			$query_var = $this->args['query_var'];
+			$query_var = $this->args[ 'query_var' ];
 		}
 
 		$existing = get_post_type_object( $this->post_type );
@@ -746,9 +746,9 @@ 
 	public function extend( $pto ) {
 
 		# Merge core with overridden labels
-		$this->args['labels'] = array_merge( (array) get_post_type_labels( $pto ), $this->args['labels'] );
+		$this->args[ 'labels' ] = array_merge( (array) get_post_type_labels( $pto ), $this->args[ 'labels' ] );
 
-		$GLOBALS['wp_post_types'][ $pto->name ]->labels = (object) $this->args['labels'];
+		$GLOBALS[ 'wp_post_types' ][ $pto->name ]->labels = (object) $this->args[ 'labels' ];
 
 	}
 
@@ -794,11 +794,11 @@ 
 	 * @var array
 	 */
 	protected $defaults = array(
-		'quick_edit'           => true,  # Custom arg
-		'dashboard_glance'     => true,  # Custom arg
-		'admin_cols'           => null,  # Custom arg
-		'admin_filters'        => null,  # Custom arg
-		'enter_title_here'     => null,  # Custom arg
+		'quick_edit'           => true, # Custom arg
+		'dashboard_glance'     => true, # Custom arg
+		'admin_cols'           => null, # Custom arg
+		'admin_filters'        => null, # Custom arg
+		'enter_title_here'     => null, # Custom arg
 	);
 	public $cpt;
 	public $args;
@@ -819,48 +819,48 @@ 
 		$this->args = array_merge( $this->defaults, $args );
 
 		# Admin columns:
-		if ( $this->args['admin_cols'] ) {
-			add_filter( 'manage_posts_columns',                                 array( $this, '_log_default_cols' ), 0 );
-			add_filter( 'manage_pages_columns',                                 array( $this, '_log_default_cols' ), 0 );
+		if ( $this->args[ 'admin_cols' ] ) {
+			add_filter( 'manage_posts_columns', array( $this, '_log_default_cols' ), 0 );
+			add_filter( 'manage_pages_columns', array( $this, '_log_default_cols' ), 0 );
 			add_filter( "manage_edit-{$this->cpt->post_type}_sortable_columns", array( $this, 'sortables' ) );
-			add_filter( "manage_{$this->cpt->post_type}_posts_columns",         array( $this, 'cols' ) );
-			add_action( "manage_{$this->cpt->post_type}_posts_custom_column",   array( $this, 'col' ) );
-			add_action( 'load-edit.php',                                        array( $this, 'default_sort' ) );
-			add_filter( 'pre_get_posts',                                        array( $this, 'maybe_sort_by_fields' ) );
-			add_filter( 'posts_clauses',                                        array( $this, 'maybe_sort_by_taxonomy' ), 10, 2 );
+			add_filter( "manage_{$this->cpt->post_type}_posts_columns", array( $this, 'cols' ) );
+			add_action( "manage_{$this->cpt->post_type}_posts_custom_column", array( $this, 'col' ) );
+			add_action( 'load-edit.php', array( $this, 'default_sort' ) );
+			add_filter( 'pre_get_posts', array( $this, 'maybe_sort_by_fields' ) );
+			add_filter( 'posts_clauses', array( $this, 'maybe_sort_by_taxonomy' ), 10, 2 );
 		}
 
 		# Admin filters:
-		if ( $this->args['admin_filters'] ) {
-			add_filter( 'pre_get_posts',         array( $this, 'maybe_filter' ) );
-			add_filter( 'query_vars',            array( $this, 'add_query_vars' ) );
+		if ( $this->args[ 'admin_filters' ] ) {
+			add_filter( 'pre_get_posts', array( $this, 'maybe_filter' ) );
+			add_filter( 'query_vars', array( $this, 'add_query_vars' ) );
 			add_action( 'restrict_manage_posts', array( $this, 'filters' ) );
 		}
 
 		# 'Enter title here' filter:
-		if ( $this->args['enter_title_here'] ) {
+		if ( $this->args[ 'enter_title_here' ] ) {
 			add_filter( 'enter_title_here', array( $this, 'enter_title_here' ), 10, 2 );
 		}
 
 		# Hide month filter:
-		if ( isset( $this->args['admin_filters']['m'] ) && ! $this->args['admin_filters']['m'] ) {
+		if ( isset( $this->args[ 'admin_filters' ][ 'm' ] ) && ! $this->args[ 'admin_filters' ][ 'm' ] ) {
 			add_action( 'admin_head-edit.php', array( $this, 'admin_head' ) );
 		}
 
 		# Quick Edit:
-		if ( ! $this->args['quick_edit'] ) {
-			add_filter( 'post_row_actions',                          array( $this, 'remove_quick_edit_action' ), 10, 2 );
-			add_filter( 'page_row_actions',                          array( $this, 'remove_quick_edit_action' ), 10, 2 );
+		if ( ! $this->args[ 'quick_edit' ] ) {
+			add_filter( 'post_row_actions', array( $this, 'remove_quick_edit_action' ), 10, 2 );
+			add_filter( 'page_row_actions', array( $this, 'remove_quick_edit_action' ), 10, 2 );
 			add_filter( "bulk_actions-edit-{$this->cpt->post_type}", array( $this, 'remove_quick_edit_menu' ) );
 		}
 
 		# 'At a Glance' dashboard panels:
-		if ( $this->args['dashboard_glance'] ) {
-			add_filter( 'dashboard_glance_items', array( $this, 'glance_items' ), $this->cpt->args['menu_position'] );
+		if ( $this->args[ 'dashboard_glance' ] ) {
+			add_filter( 'dashboard_glance_items', array( $this, 'glance_items' ), $this->cpt->args[ 'menu_position' ] );
 		}
 
 		# Post updated messages:
-		add_filter( 'post_updated_messages',      array( $this, 'post_updated_messages' ), 1 );
+		add_filter( 'post_updated_messages', array( $this, 'post_updated_messages' ), 1 );
 		add_filter( 'bulk_post_updated_messages', array( $this, 'bulk_post_updated_messages' ), 1, 2 );
 
 	}
@@ -875,7 +875,7 @@ 
 		}
 
 		?>
-		<?php if ( isset( $this->args['admin_filters']['m'] ) && ! $this->args['admin_filters']['m'] ) { ?>
+		<?php if ( isset( $this->args[ 'admin_filters' ][ 'm' ] ) && ! $this->args[ 'admin_filters' ][ 'm' ] ) { ?>
 			<style type="text/css">
 				#posts-filter select[name="m"] {
 					display: none;
@@ -896,15 +896,15 @@ 
 		}
 
 		# If we've already ordered the screen, bail out:
-		if ( isset( $_GET['orderby'] ) ) {
+		if ( isset( $_GET[ 'orderby' ] ) ) {
 			return;
 		}
 
 		# Loop over our columns to find the default sort column (if there is one):
-		foreach ( $this->args['admin_cols'] as $id => $col ) {
-			if ( is_array( $col ) && isset( $col['default'] ) ) {
-				$_GET['orderby'] = $id;
-				$_GET['order']   = ( 'desc' === strtolower( $col['default'] ) ? 'desc' : 'asc' );
+		foreach ( $this->args[ 'admin_cols' ] as $id => $col ) {
+			if ( is_array( $col ) && isset( $col[ 'default' ] ) ) {
+				$_GET[ 'orderby' ] = $id;
+				$_GET[ 'order' ]   = ( 'desc' === strtolower( $col[ 'default' ] ) ? 'desc' : 'asc' );
 				break;
 			}
 		}
@@ -924,7 +924,7 @@ 
 			return $title;
 		}
 
-		return $this->args['enter_title_here'];
+		return $this->args[ 'enter_title_here' ];
 
 	}
 
@@ -1005,15 +1005,15 @@ 
 
 		$pto = get_post_type_object( $this->cpt->post_type );
 
-		foreach ( $this->args['admin_filters'] as $filter_key => $filter ) {
+		foreach ( $this->args[ 'admin_filters' ] as $filter_key => $filter ) {
 
-			if ( isset( $filter['cap'] ) && ! current_user_can( $filter['cap'] ) ) {
+			if ( isset( $filter[ 'cap' ] ) && ! current_user_can( $filter[ 'cap' ] ) ) {
 				continue;
 			}
 
-			if ( isset( $filter['taxonomy'] ) ) {
+			if ( isset( $filter[ 'taxonomy' ] ) ) {
 
-				$tax = get_taxonomy( $filter['taxonomy'] );
+				$tax = get_taxonomy( $filter[ 'taxonomy' ] );
 
 				if ( empty( $tax ) ) {
 					continue;
@@ -1033,13 +1033,13 @@ 
 				}
 
 				# If we haven't specified a title, use the all_items label from the taxonomy:
-				if ( ! isset( $filter['title'] ) ) {
-					$filter['title'] = $tax->labels->all_items;
+				if ( ! isset( $filter[ 'title' ] ) ) {
+					$filter[ 'title' ] = $tax->labels->all_items;
 				}
 
 				# Output the dropdown:
 				wp_dropdown_categories( array(
-					'show_option_all' => $filter['title'],
+					'show_option_all' => $filter[ 'title' ],
 					'hide_empty'      => false,
 					'hide_if_empty'   => true,
 					'hierarchical'    => true,
@@ -1048,23 +1048,23 @@ 
 					'selected_cats'   => get_query_var( $tax->query_var ),
 					'id'              => 'filter_' . $filter_key,
 					'name'            => $tax->query_var,
-					'taxonomy'        => $filter['taxonomy'],
+					'taxonomy'        => $filter[ 'taxonomy' ],
 					'walker'          => $walker,
 				) );
 
-			} else if ( isset( $filter['meta_key'] ) ) {
+			} else if ( isset( $filter[ 'meta_key' ] ) ) {
 
 				# If we haven't specified a title, generate one from the meta key:
-				if ( ! isset( $filter['title'] ) ) {
-					$filter['title'] = str_replace( array( '-', '_' ), ' ', $filter['meta_key'] );
-					$filter['title'] = ucwords( $filter['title'] ) . 's';
-					$filter['title'] = sprintf( 'All %s', $filter['title'] );
+				if ( ! isset( $filter[ 'title' ] ) ) {
+					$filter[ 'title' ] = str_replace( array( '-', '_' ), ' ', $filter[ 'meta_key' ] );
+					$filter[ 'title' ] = ucwords( $filter[ 'title' ] ) . 's';
+					$filter[ 'title' ] = sprintf( 'All %s', $filter[ 'title' ] );
 				}
 
-				if ( ! isset( $filter['options'] ) ) {
+				if ( ! isset( $filter[ 'options' ] ) ) {
 					# Fetch all the values for our meta key:
 					# @TODO AND m.meta_value != null ?
-					$filter['options'] = $wpdb->get_col( $wpdb->prepare( "
+					$filter[ 'options' ] = $wpdb->get_col( $wpdb->prepare( "
 						SELECT DISTINCT meta_value
 						FROM {$wpdb->postmeta} as m
 						JOIN {$wpdb->posts} as p ON ( p.ID = m.post_id )
@@ -1072,12 +1072,12 @@ 
 						AND m.meta_value != ''
 						AND p.post_type = %s
 						ORDER BY m.meta_value ASC
-					", $filter['meta_key'], $this->cpt->post_type ) );
-				} else if ( is_callable( $filter['options'] ) ) {
-					$filter['options'] = call_user_func( $filter['options'] );
+					", $filter[ 'meta_key' ], $this->cpt->post_type ) );
+				} else if ( is_callable( $filter[ 'options' ] ) ) {
+					$filter[ 'options' ] = call_user_func( $filter[ 'options' ] );
 				}
 
-				if ( empty( $filter['options'] ) ) {
+				if ( empty( $filter[ 'options' ] ) ) {
 					continue;
 				}
 
@@ -1085,7 +1085,7 @@ 
 
 				$use_key = false;
 
-				foreach ( $filter['options'] as $k => $v ) {
+				foreach ( $filter[ 'options' ] as $k => $v ) {
 					if ( ! is_numeric( $k ) ) {
 						$use_key = true;
 						break;
@@ -1095,9 +1095,9 @@ 
 				# Output the dropdown:
 				?>
 				<select name="<?php echo esc_attr( $filter_key ); ?>" id="filter_<?php echo esc_attr( $filter_key ); ?>">
-					<option value=""><?php echo esc_html( $filter['title'] ); ?></option>
+					<option value=""><?php echo esc_html( $filter[ 'title' ] ); ?></option>
 					<?php
-						foreach ( $filter['options'] as $k => $v ) {
+						foreach ( $filter[ 'options' ] as $k => $v ) {
 							$key = ( $use_key ? $k : $v );
 						?>
 						<option value="<?php echo esc_attr( $key ); ?>" <?php selected( $selected, $key ); ?>><?php echo esc_html( $v ); ?></option>
@@ -1105,34 +1105,34 @@ 
 				</select>
 				<?php
 
-			} else if ( isset( $filter['meta_search_key'] ) ) {
+			} else if ( isset( $filter[ 'meta_search_key' ] ) ) {
 
 				# If we haven't specified a title, generate one from the meta key:
-				if ( ! isset( $filter['title'] ) ) {
-					$filter['title'] = str_replace( array( '-', '_' ), ' ', $filter['meta_search_key'] );
-					$filter['title'] = ucwords( $filter['title'] );
+				if ( ! isset( $filter[ 'title' ] ) ) {
+					$filter[ 'title' ] = str_replace( array( '-', '_' ), ' ', $filter[ 'meta_search_key' ] );
+					$filter[ 'title' ] = ucwords( $filter[ 'title' ] );
 				}
 
 				$value = wp_unslash( get_query_var( $filter_key ) );
 
 				# Output the search box:
 				?>
-				<label><?php printf( '%s:', esc_html( $filter['title'] ) ); ?>&nbsp;<input type="text" name="<?php echo esc_attr( $filter_key ); ?>" id="filter_<?php echo esc_attr( $filter_key ); ?>" value="<?php echo esc_attr( $value ); ?>" /></label>
+				<label><?php printf( '%s:', esc_html( $filter[ 'title' ] ) ); ?>&nbsp;<input type="text" name="<?php echo esc_attr( $filter_key ); ?>" id="filter_<?php echo esc_attr( $filter_key ); ?>" value="<?php echo esc_attr( $value ); ?>" /></label>
 				<?php
 
-			} else if ( isset( $filter['meta_exists'] ) ) {
+			} else if ( isset( $filter[ 'meta_exists' ] ) ) {
 
 				# If we haven't specified a title, use the all_items label from the post type:
-				if ( ! isset( $filter['title'] ) ) {
-					$filter['title'] = $pto->labels->all_items;
+				if ( ! isset( $filter[ 'title' ] ) ) {
+					$filter[ 'title' ] = $pto->labels->all_items;
 				}
 
 				$selected = wp_unslash( get_query_var( $filter_key ) );
 
-				if ( 1 === count( $filter['meta_exists'] ) ) {
+				if ( 1 === count( $filter[ 'meta_exists' ] ) ) {
 
 					# Output a checkbox:
-					foreach ( $filter['meta_exists'] as $v => $t ) {
+					foreach ( $filter[ 'meta_exists' ] as $v => $t ) {
 						?>
 						<label><input type="checkbox" name="<?php echo esc_attr( $filter_key ); ?>" id="filter_<?php echo esc_attr( $filter_key ); ?>" value="<?php echo esc_attr( $v ); ?>" <?php checked( $selected, $v ); ?>>&nbsp;<?php echo esc_html( $t ); ?></label>
 						<?php
@@ -1142,8 +1142,8 @@ 
 					# Output a dropdown:
 					?>
 					<select name="<?php echo esc_attr( $filter_key ); ?>" id="filter_<?php echo esc_attr( $filter_key ); ?>">
-						<option value=""><?php echo esc_html( $filter['title'] ); ?></option>
-						<?php foreach ( $filter['meta_exists'] as $v => $t ) { ?>
+						<option value=""><?php echo esc_html( $filter[ 'title' ] ); ?></option>
+						<?php foreach ( $filter[ 'meta_exists' ] as $v => $t ) { ?>
 							<option value="<?php echo esc_attr( $v ); ?>" <?php selected( $selected, $v ); ?>><?php echo esc_html( $t ); ?></option>
 						<?php } ?>
 					</select>
@@ -1163,7 +1163,7 @@ 
 	 */
 	public function add_query_vars( array $vars ) {
 
-		$filters = array_keys( $this->args['admin_filters'] );
+		$filters = array_keys( $this->args[ 'admin_filters' ] );
 
 		return array_merge( $vars, $filters );
 
@@ -1176,11 +1176,11 @@ 
 	 */
 	public function maybe_filter( WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return;
 		}
 
-		$vars = Extended_CPT::get_filter_vars( $wp_query->query, $this->cpt->args['admin_filters'] );
+		$vars = Extended_CPT::get_filter_vars( $wp_query->query, $this->cpt->args[ 'admin_filters' ] );
 
 		if ( empty( $vars ) ) {
 			return;
@@ -1206,11 +1206,11 @@ 
 	 */
 	public function maybe_sort_by_fields( WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return;
 		}
 
-		$sort = Extended_CPT::get_sort_field_vars( $wp_query->query, $this->cpt->args['admin_cols'] );
+		$sort = Extended_CPT::get_sort_field_vars( $wp_query->query, $this->cpt->args[ 'admin_cols' ] );
 
 		if ( empty( $sort ) ) {
 			return;
@@ -1231,11 +1231,11 @@ 
 	 */
 	public function maybe_sort_by_taxonomy( array $clauses, WP_Query $wp_query ) {
 
-		if ( empty( $wp_query->query['post_type'] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query['post_type'] ) ) {
+		if ( empty( $wp_query->query[ 'post_type' ] ) || ! in_array( $this->cpt->post_type, (array) $wp_query->query[ 'post_type' ] ) ) {
 			return $clauses;
 		}
 
-		$sort = Extended_CPT::get_sort_taxonomy_clauses( $clauses, $wp_query->query, $this->cpt->args['admin_cols'] );
+		$sort = Extended_CPT::get_sort_taxonomy_clauses( $clauses, $wp_query->query, $this->cpt->args[ 'admin_cols' ] );
 
 		if ( empty( $sort ) ) {
 			return $clauses;
@@ -1274,7 +1274,7 @@ 
 		$text = '<a href="' . esc_url( $url ) . '">' . esc_html( $num . ' ' . $text ) . '</a>';
 
 		# Go!
-		$items[] = $text;
+		$items[ ] = $text;
 
 		return $items;
 
@@ -1318,10 +1318,10 @@ 
 				'%s updated.',
 				esc_html( $this->cpt->post_singular )
 			),
-			5 => isset( $_GET['revision'] ) ? sprintf(
+			5 => isset( $_GET[ 'revision' ] ) ? sprintf(
 				'%1$s restored to revision from %2$s',
 				esc_html( $this->cpt->post_singular ),
-				wp_post_revision_title( intval( $_GET['revision'] ), false )
+				wp_post_revision_title( intval( $_GET[ 'revision' ] ), false )
 			) : false,
 			6 => sprintf(
 				( $pto->publicly_queryable ? '%1$s published. <a href="%2$s">View %3$s</a>' : '%1$s published.' ),
@@ -1377,32 +1377,32 @@ 
 
 		$messages[ $this->cpt->post_type ] = array(
 			'updated' => sprintf(
-				self::n( '%2$s updated.', '%1$s %3$s updated.', $counts['updated'] ),
-				esc_html( number_format_i18n( $counts['updated'] ) ),
+				self::n( '%2$s updated.', '%1$s %3$s updated.', $counts[ 'updated' ] ),
+				esc_html( number_format_i18n( $counts[ 'updated' ] ) ),
 				esc_html( $this->cpt->post_singular ),
 				esc_html( $this->cpt->post_plural_low )
 			),
 			'locked' => sprintf(
-				self::n( '%2$s not updated, somebody is editing it.', '%1$s %3$s not updated, somebody is editing them.', $counts['locked'] ),
-				esc_html( number_format_i18n( $counts['locked'] ) ),
+				self::n( '%2$s not updated, somebody is editing it.', '%1$s %3$s not updated, somebody is editing them.', $counts[ 'locked' ] ),
+				esc_html( number_format_i18n( $counts[ 'locked' ] ) ),
 				esc_html( $this->cpt->post_singular ),
 				esc_html( $this->cpt->post_plural_low )
 			),
 			'deleted' => sprintf(
-				self::n( '%2$s permanently deleted.', '%1$s %3$s permanently deleted.', $counts['deleted'] ),
-				esc_html( number_format_i18n( $counts['deleted'] ) ),
+				self::n( '%2$s permanently deleted.', '%1$s %3$s permanently deleted.', $counts[ 'deleted' ] ),
+				esc_html( number_format_i18n( $counts[ 'deleted' ] ) ),
 				esc_html( $this->cpt->post_singular ),
 				esc_html( $this->cpt->post_plural_low )
 			),
 			'trashed' => sprintf(
-				self::n( '%2$s moved to the trash.', '%1$s %3$s moved to the trash.', $counts['trashed'] ),
-				esc_html( number_format_i18n( $counts['trashed'] ) ),
+				self::n( '%2$s moved to the trash.', '%1$s %3$s moved to the trash.', $counts[ 'trashed' ] ),
+				esc_html( number_format_i18n( $counts[ 'trashed' ] ) ),
 				esc_html( $this->cpt->post_singular ),
 				esc_html( $this->cpt->post_plural_low )
 			),
 			'untrashed' => sprintf(
-				self::n( '%2$s restored from the trash.', '%1$s %3$s restored from the trash.', $counts['untrashed'] ),
-				esc_html( number_format_i18n( $counts['untrashed'] ) ),
+				self::n( '%2$s restored from the trash.', '%1$s %3$s restored from the trash.', $counts[ 'untrashed' ] ),
+				esc_html( number_format_i18n( $counts[ 'untrashed' ] ) ),
 				esc_html( $this->cpt->post_singular ),
 				esc_html( $this->cpt->post_plural_low )
 			),
@@ -1420,14 +1420,14 @@ 
 	 */
 	public function sortables( array $cols ) {
 
-		foreach ( $this->args['admin_cols'] as $id => $col ) {
+		foreach ( $this->args[ 'admin_cols' ] as $id => $col ) {
 			if ( ! is_array( $col ) ) {
 				continue;
 			}
-			if ( isset( $col['sortable'] ) && ! $col['sortable'] ) {
+			if ( isset( $col[ 'sortable' ] ) && ! $col[ 'sortable' ] ) {
 				continue;
 			}
-			if ( isset( $col['meta_key'] ) || isset( $col['taxonomy'] ) || isset( $col['post_field'] ) ) {
+			if ( isset( $col[ 'meta_key' ] ) || isset( $col[ 'taxonomy' ] ) || isset( $col[ 'post_field' ] ) ) {
 				$cols[ $id ] = $id;
 			}
 		}
@@ -1526,13 +1526,13 @@ 
 
 		# Add existing columns we want to keep:
 		foreach ( $cols as $id => $title ) {
-			if ( in_array( $id, $keep ) && ! isset( $this->args['admin_cols'][ $id ] ) ) {
+			if ( in_array( $id, $keep ) && ! isset( $this->args[ 'admin_cols' ][ $id ] ) ) {
 				$new_cols[ $id ] = $title;
 			}
 		}
 
 		# Add our custom columns:
-		foreach ( array_filter( $this->args['admin_cols'] ) as $id => $col ) {
+		foreach ( array_filter( $this->args[ 'admin_cols' ] ) as $id => $col ) {
 			if ( is_string( $col ) && isset( $cols[ $col ] ) ) {
 				# Existing (ie. built-in) column with id as the value
 				$new_cols[ $col ] = $cols[ $col ];
@@ -1549,16 +1549,16 @@ 
 				}
 				$new_cols[ $k ] = esc_html__( 'Author' );
 			} else if ( is_array( $col ) ) {
-				if ( isset( $col['cap'] ) && ! current_user_can( $col['cap'] ) ) {
+				if ( isset( $col[ 'cap' ] ) && ! current_user_can( $col[ 'cap' ] ) ) {
 					continue;
 				}
-				if ( isset( $col['connection'] ) && ! function_exists( 'p2p_type' ) ) {
+				if ( isset( $col[ 'connection' ] ) && ! function_exists( 'p2p_type' ) ) {
 					continue;
 				}
-				if ( ! isset( $col['title'] ) ) {
-					$col['title'] = $this->get_item_title( $col );
+				if ( ! isset( $col[ 'title' ] ) ) {
+					$col[ 'title' ] = $this->get_item_title( $col );
 				}
-				$new_cols[ $id ] = esc_html( $col['title'] );
+				$new_cols[ $id ] = esc_html( $col[ 'title' ] );
 			}
 		}
 
@@ -1578,7 +1578,7 @@ 
 	public function col( $col ) {
 
 		# Shorthand:
-		$c = $this->args['admin_cols'];
+		$c = $this->args[ 'admin_cols' ];
 
 		# We're only interested in our custom columns:
 		$custom_cols = array_filter( array_keys( $c ) );
@@ -1587,26 +1587,26 @@ 
 			return;
 		}
 
-		if ( isset( $c[ $col ]['post_cap'] ) && ! current_user_can( $c[ $col ]['post_cap'], get_the_ID() ) ) {
+		if ( isset( $c[ $col ][ 'post_cap' ] ) && ! current_user_can( $c[ $col ][ 'post_cap' ], get_the_ID() ) ) {
 			return;
 		}
 
-		if ( ! isset( $c[ $col ]['link'] ) ) {
-			$c[ $col ]['link'] = 'list';
+		if ( ! isset( $c[ $col ][ 'link' ] ) ) {
+			$c[ $col ][ 'link' ] = 'list';
 		}
 
-		if ( isset( $c[ $col ]['function'] ) ) {
-			call_user_func( $c[ $col ]['function'] );
-		} else if ( isset( $c[ $col ]['meta_key'] ) ) {
-			$this->col_post_meta( $c[ $col ]['meta_key'], $c[ $col ] );
-		} else if ( isset( $c[ $col ]['taxonomy'] ) ) {
-			$this->col_taxonomy( $c[ $col ]['taxonomy'], $c[ $col ] );
-		} else if ( isset( $c[ $col ]['post_field'] ) ) {
-			$this->col_post_field( $c[ $col ]['post_field'], $c[ $col ] );
-		} else if ( isset( $c[ $col ]['featured_image'] ) ) {
-			$this->col_featured_image( $c[ $col ]['featured_image'], $c[ $col ] );
-		} else if ( isset( $c[ $col ]['connection'] ) ) {
-			$this->col_connection( $c[ $col ]['connection'], $c[ $col ] );
+		if ( isset( $c[ $col ][ 'function' ] ) ) {
+			call_user_func( $c[ $col ][ 'function' ] );
+		} else if ( isset( $c[ $col ][ 'meta_key' ] ) ) {
+			$this->col_post_meta( $c[ $col ][ 'meta_key' ], $c[ $col ] );
+		} else if ( isset( $c[ $col ][ 'taxonomy' ] ) ) {
+			$this->col_taxonomy( $c[ $col ][ 'taxonomy' ], $c[ $col ] );
+		} else if ( isset( $c[ $col ][ 'post_field' ] ) ) {
+			$this->col_post_field( $c[ $col ][ 'post_field' ], $c[ $col ] );
+		} else if ( isset( $c[ $col ][ 'featured_image' ] ) ) {
+			$this->col_featured_image( $c[ $col ][ 'featured_image' ], $c[ $col ] );
+		} else if ( isset( $c[ $col ][ 'connection' ] ) ) {
+			$this->col_connection( $c[ $col ][ 'connection' ], $c[ $col ] );
 		}
 
 	}
@@ -1623,18 +1623,18 @@ 
 		$echo = array();
 		sort( $vals );
 
-		if ( isset( $args['date_format'] ) ) {
+		if ( isset( $args[ 'date_format' ] ) ) {
 
-			if ( true === $args['date_format'] ) {
-				$args['date_format'] = get_option( 'date_format' );
+			if ( true === $args[ 'date_format' ] ) {
+				$args[ 'date_format' ] = get_option( 'date_format' );
 			}
 
 			foreach ( $vals as $val ) {
 
 				if ( is_numeric( $val ) ) {
-					$echo[] = date( $args['date_format'], $val );
+					$echo[ ] = date( $args[ 'date_format' ], $val );
 				} else if ( ! empty( $val ) ) {
-					$echo[] = mysql2date( $args['date_format'], $val );
+					$echo[ ] = mysql2date( $args[ 'date_format' ], $val );
 				}
 			}
 		} else {
@@ -1642,7 +1642,7 @@ 
 			foreach ( $vals as $val ) {
 
 				if ( ! empty( $val ) || ( '0' === $val ) ) {
-					$echo[] = $val;
+					$echo[ ] = $val;
 				}
 			}
 		}
@@ -1682,29 +1682,29 @@ 
 
 		foreach ( $terms as $term ) {
 
-			if ( $args['link'] ) {
+			if ( $args[ 'link' ] ) {
 
-				switch ( $args['link'] ) {
+				switch ( $args[ 'link' ] ) {
 					case 'view':
 						if ( $tax->public ) {
-							$out[] = sprintf(
+							$out[ ] = sprintf(
 								'<a href="%1$s">%2$s</a>',
 								esc_url( get_term_link( $term ) ),
 								esc_html( $term->name )
 							);
 						} else {
-							$out[] = esc_html( $term->name );
+							$out[ ] = esc_html( $term->name );
 						}
 						break;
 					case 'edit':
 						if ( current_user_can( $tax->cap->edit_terms ) ) {
-							$out[] = sprintf(
+							$out[ ] = sprintf(
 								'<a href="%1$s">%2$s</a>',
 								esc_url( get_edit_term_link( $term, $taxonomy, $post->post_type ) ),
 								esc_html( $term->name )
 							);
 						} else {
-							$out[] = esc_html( $term->name );
+							$out[ ] = esc_html( $term->name );
 						}
 						break;
 					case 'list':
@@ -1712,7 +1712,7 @@ 
 							'post_type' => $post->post_type,
 							$taxonomy   => $term->slug,
 						), admin_url( 'edit.php' ) );
-						$out[] = sprintf(
+						$out[ ] = sprintf(
 							'<a href="%1$s">%2$s</a>',
 							esc_url( $link ),
 							esc_html( $term->name )
@@ -1721,7 +1721,7 @@ 
 				}
 			} else {
 
-				$out[] = esc_html( $term->name );
+				$out[ ] = esc_html( $term->name );
 
 			}
 		}
@@ -1789,14 +1789,14 @@ 
 			return;
 		}
 
-		if ( isset( $args['width'] ) ) {
-			$width = is_numeric( $args['width'] ) ? sprintf( '%dpx', $args['width'] ) : $args['width'];
+		if ( isset( $args[ 'width' ] ) ) {
+			$width = is_numeric( $args[ 'width' ] ) ? sprintf( '%dpx', $args[ 'width' ] ) : $args[ 'width' ];
 		} else {
 			$width = 'auto';
 		}
 
-		if ( isset( $args['height'] ) ) {
-			$height = is_numeric( $args['height'] ) ? sprintf( '%dpx', $args['height'] ) : $args['height'];
+		if ( isset( $args[ 'height' ] ) ) {
+			$height = is_numeric( $args[ 'height' ] ) ? sprintf( '%dpx', $args[ 'height' ] ) : $args[ 'height' ];
 		} else {
 			$height = 'auto';
 		}
@@ -1842,13 +1842,13 @@ 
 		$meta  = $out = array();
 		$field = 'connected_' . $connection;
 
-		if ( isset( $args['field'] ) && isset( $args['value'] ) ) {
+		if ( isset( $args[ 'field' ] ) && isset( $args[ 'value' ] ) ) {
 			$meta = array(
 				'connected_meta' => array(
-					$args['field'] => $args['value'],
+					$args[ 'field' ] => $args[ 'value' ],
 				),
 			);
-			$field .= sanitize_title( '_' . $args['field'] . '_' . $args['value'] );
+			$field .= sanitize_title( '_' . $args[ 'field' ] . '_' . $args[ 'value' ] );
 		}
 
 		if ( ! isset( $_post->$field ) ) {
@@ -1877,39 +1877,39 @@ 
 				continue;
 			}
 
-			if ( $args['link'] ) {
+			if ( $args[ 'link' ] ) {
 
-				switch ( $args['link'] ) {
+				switch ( $args[ 'link' ] ) {
 					case 'view':
 
 						if ( $pto->public ) {
 							if ( $pso->protected ) {
-								$out[] = sprintf(
+								$out[ ] = sprintf(
 									'<a href="%1$s">%2$s</a>',
 									esc_url( get_preview_post_link() ),
 									esc_html( get_the_title() )
 								);
 							} else {
-								$out[] = sprintf(
+								$out[ ] = sprintf(
 									'<a href="%1$s">%2$s</a>',
 									esc_url( get_permalink() ),
 									esc_html( get_the_title() )
 								);
 							}
 						} else {
-							$out[] = esc_html( get_the_title() );
+							$out[ ] = esc_html( get_the_title() );
 						}
 
 						break;
 					case 'edit':
 						if ( current_user_can( 'edit_post', $post->ID ) ) {
-							$out[] = sprintf(
+							$out[ ] = sprintf(
 								'<a href="%1$s">%2$s</a>',
 								esc_url( get_edit_post_link() ),
 								esc_html( get_the_title() )
 							);
 						} else {
-							$out[] = esc_html( get_the_title() );
+							$out[ ] = esc_html( get_the_title() );
 						}
 						break;
 					case 'list':
@@ -1918,7 +1918,7 @@ 
 							'connected_type'  => $connection,
 							'connected_items' => $post->ID,
 						), $meta ), admin_url( 'edit.php' ) );
-						$out[] = sprintf(
+						$out[ ] = sprintf(
 							'<a href="%1$s">%2$s</a>',
 							esc_url( $link ),
 							esc_html( get_the_title() )
@@ -1927,7 +1927,7 @@ 
 				}
 			} else {
 
-				$out[] = esc_html( get_the_title() );
+				$out[ ] = esc_html( get_the_title() );
 
 			}
 		}
@@ -1951,7 +1951,7 @@ 
 			return $actions;
 		}
 
-		unset( $actions['inline'], $actions['inline hide-if-no-js'] );
+		unset( $actions[ 'inline' ], $actions[ 'inline hide-if-no-js' ] );
 		return $actions;
 
 	}
@@ -1964,7 +1964,7 @@ 
 	 */
 	public function remove_quick_edit_menu( array $actions ) {
 
-		unset( $actions['edit'] );
+		unset( $actions[ 'edit' ] );
 		return $actions;
 
 	}
@@ -2003,30 +2003,30 @@ 
 	 */
 	protected function get_item_title( array $item ) {
 
-		if ( isset( $item['taxonomy'] ) ) {
-			if ( $tax = get_taxonomy( $item['taxonomy'] ) ) {
+		if ( isset( $item[ 'taxonomy' ] ) ) {
+			if ( $tax = get_taxonomy( $item[ 'taxonomy' ] ) ) {
 				if ( ! empty( $tax->exclusive ) ) {
 					return $tax->labels->singular_name;
 				} else {
 					return $tax->labels->name;
 				}
 			} else {
-				return $item['taxonomy'];
+				return $item[ 'taxonomy' ];
 			}
-		} else if ( isset( $item['post_field'] ) ) {
-			return ucwords( trim( str_replace( array( 'post_', '_' ), ' ', $item['post_field'] ) ) );
-		} else if ( isset( $item['meta_key'] ) ) {
-			return ucwords( trim( str_replace( array( '_', '-' ), ' ', $item['meta_key'] ) ) );
-		} else if ( isset( $item['connection'] ) && isset( $item['value'] ) ) {
-			return ucwords( trim( str_replace( array( '_', '-' ), ' ', $item['value'] ) ) );
-		} else if ( isset( $item['connection'] ) ) {
-			if ( function_exists( 'p2p_type' ) && $this->p2p_connection_exists( $item['connection'] ) ) {
-				if ( $ctype = p2p_type( $item['connection'] ) ) {
+		} else if ( isset( $item[ 'post_field' ] ) ) {
+			return ucwords( trim( str_replace( array( 'post_', '_' ), ' ', $item[ 'post_field' ] ) ) );
+		} else if ( isset( $item[ 'meta_key' ] ) ) {
+			return ucwords( trim( str_replace( array( '_', '-' ), ' ', $item[ 'meta_key' ] ) ) );
+		} else if ( isset( $item[ 'connection' ] ) && isset( $item[ 'value' ] ) ) {
+			return ucwords( trim( str_replace( array( '_', '-' ), ' ', $item[ 'value' ] ) ) );
+		} else if ( isset( $item[ 'connection' ] ) ) {
+			if ( function_exists( 'p2p_type' ) && $this->p2p_connection_exists( $item[ 'connection' ] ) ) {
+				if ( $ctype = p2p_type( $item[ 'connection' ] ) ) {
 					$other = ( 'from' === $ctype->direction_from_types( 'post', $this->cpt->post_type ) ) ? 'to' : 'from';
 					return $ctype->side[ $other ]->get_title();
 				}
 			}
-			return $item['connection'];
+			return $item[ 'connection' ];
 		}
 
 	}
@@ -2068,13 +2068,13 @@ 
 
 		$new   = array();
 		$rules = $wp_rewrite->generate_rewrite_rules(
-			$struct['struct'],
-			$struct['ep_mask'],
-			$struct['paged'],
-			$struct['feed'],
-			$struct['forcomments'],
-			$struct['walk_dirs'],
-			$struct['endpoints']
+			$struct[ 'struct' ],
+			$struct[ 'ep_mask' ],
+			$struct[ 'paged' ],
+			$struct[ 'feed' ],
+			$struct[ 'forcomments' ],
+			$struct[ 'walk_dirs' ],
+			$struct[ 'endpoints' ]
 		);
 		$rules = array_merge( $rules, $additional );
 		$feedregex = implode( '|', $wp_rewrite->feeds );
@@ -2102,9 +2102,9 @@ 
 			// Change '$2' to '$matches[2]'
 			$result = preg_replace( '/\$([0-9]+)/', '\$matches[$1]', $result );
 			$new[ "/{$regex}" ] = $result;
-			if ( false !== strpos( $regex, $replace['(?:/([0-9]+))?'] ) ) {
+			if ( false !== strpos( $regex, $replace[ '(?:/([0-9]+))?' ] ) ) {
 				// Add an extra rule for this optional block
-				$regex = str_replace( $replace['(?:/([0-9]+))?'], '', $regex );
+				$regex = str_replace( $replace[ '(?:/([0-9]+))?' ], '', $regex );
 				$new[ "/{$regex}" ] = $result;
 			}
 		}
@@ -2147,9 +2147,9 @@ 
 
 		// Post type archive rewrites are generated separately. See the `has_archive` handling in `register_post_type()`.
 		if ( $pto->has_archive ) {
-			$archive_slug = ( $pto->has_archive === true ) ? $pto->rewrite['slug'] : $pto->has_archive;
+			$archive_slug = ( $pto->has_archive === true ) ? $pto->rewrite[ 'slug' ] : $pto->has_archive;
 
-			if ( $pto->rewrite['with_front'] ) {
+			if ( $pto->rewrite[ 'with_front' ] ) {
 				$archive_slug = substr( $wp_rewrite->front, 1 ) . $archive_slug;
 			} else {
 				$archive_slug = $wp_rewrite->root . $archive_slug;
@@ -2157,12 +2157,12 @@ 
 
 			$additional[ "{$archive_slug}/?$" ] = "index.php?post_type={$this->cpt->post_type}";
 
-			if ( $pto->rewrite['feeds'] && $wp_rewrite->feeds ) {
+			if ( $pto->rewrite[ 'feeds' ] && $wp_rewrite->feeds ) {
 				$feeds = '(' . trim( implode( '|', $wp_rewrite->feeds ) ) . ')';
 				$additional[ "{$archive_slug}/feed/{$feeds}/?$" ] = "index.php?post_type={$this->cpt->post_type}" . '&feed=$matches[1]';
 				$additional[ "{$archive_slug}/{$feeds}/?$" ] = "index.php?post_type={$this->cpt->post_type}" . '&feed=$matches[1]';
 			}
-			if ( $pto->rewrite['pages'] ) {
+			if ( $pto->rewrite[ 'pages' ] ) {
 				$additional[ "{$archive_slug}/{$wp_rewrite->pagination_base}/([0-9]{1,})/?$" ] = "index.php?post_type={$this->cpt->post_type}" . '&paged=$matches[1]';
 			}
 		}

vendor/wp-coding-standards/wpcs/WordPress/Tests/PHP/DisallowAlternativePHPTagsUnitTest.inc

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 <script language="php">
 echo $var;
 </script>
-<script language='php'>echo $var;</script>
+<script language='php'>echo $var; </script>
 <script type="text/php" language="php">
 echo $var;
 </script>

vendor/wp-coding-standards/wpcs/WordPress/Tests/PHP/DisallowAlternativePHPTagsUnitTest.php

Spacing +4 added lines, -4 removed lines

@@ -56,10 +56,10 @@
 		);
 
 		if ( true === $this->asp_tags ) {
-			$errors[4] = 1;
-			$errors[5] = 1;
-			$errors[6] = 1;
-			$errors[7] = 1;
+			$errors[ 4 ] = 1;
+			$errors[ 5 ] = 1;
+			$errors[ 6 ] = 1;
+			$errors[ 7 ] = 1;
 		}
 
 		return $errors;

vendor/wp-coding-standards/wpcs/WordPress/Tests/PHP/POSIXFunctionsUnitTest.inc

Spacing +1 added lines, -1 removed lines

@@ -23,4 +23,4 @@
 
 $title_parts = spliti( ' ', get_the_title(), 4 ); // Bad, spliti also deprecated. Use preg_split instead.
 
-sql_regcase( 'Foo - bar.'); // Bad. Deprecated.
+sql_regcase( 'Foo - bar.' ); // Bad. Deprecated.

Braces +3 added lines, -1 removed lines

@@ -10,8 +10,10 @@
 
 
 // These should all trigger an error.
-if ( ereg( '[A-Za-z]+', $title, $regs ) ) // Bad, ereg deprecated. Use preg_match instead.
+if ( ereg( '[A-Za-z]+', $title, $regs ) ) {
+	// Bad, ereg deprecated. Use preg_match instead.
 	die( $regs );
+}
 
 if ( eregi( '[a-z]+', $title, $regs ) ) {} // Bad, eregi deprecated. Use preg_match instead.
 

vendor/wp-coding-standards/wpcs/WordPress/Tests/PHP/YodaConditionsUnitTest.inc

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
 }
 
 // Make sure the test excludes functions on the conditional check.
-if ( strtolower( $check ) == $true  ) { // Good.
+if ( strtolower( $check ) == $true ) { // Good.
 	echo 'True';
 }
 // Makes sure the test excludes variable casting in the conditional check.
@@ -73,7 +73,7 @@ 
 
 if ( $foo == $bar ) {} // Ok.
 
-$accessibility_mode = ( 'on' === sanitize_key( $_GET['accessibility-mode'] ) ) ? 'on' : 'off'; // Ok.
+$accessibility_mode = ( 'on' === sanitize_key( $_GET[ 'accessibility-mode' ] ) ) ? 'on' : 'off'; // Ok.
 
 if ( $on !== self::$network_mode ) { // Ok.
 	self::$network_mode = (bool) $on;
@@ -83,9 +83,9 @@ 
 return 0 == $foo; // Ok.
 return $foo == 0; // Bad.
 
-if ( (int) $a['interval'] === (int) $b['interval'] ) {} // Ok.
+if ( (int) $a[ 'interval' ] === (int) $b[ 'interval' ] ) {} // Ok.
 
-if ( $GLOBALS['wpdb']->num_rows === 0 ) {} // Bad.
+if ( $GLOBALS[ 'wpdb' ]->num_rows === 0 ) {} // Bad.
 
 if ( $true == strtolower( $check ) ) {} // Bad.
 

Braces +46 added lines, -23 removed lines

@@ -1,73 +1,95 @@ 
 <?php
-if ( $true == true || $false == false ) {  // Bad x 2 (in an 'if').
+if ( $true == true || $false == false ) {
+// Bad x 2 (in an 'if').
 	echo 'True';
-} elseif ( $true == true && $false == true ) { // Bad x 2 (in an 'elseif').
+} elseif ( $true == true && $false == true ) {
+// Bad x 2 (in an 'elseif').
 	echo 'False';
-} elseif ( false == $true && true == $false ) { // Good - this is the correct way to do conditional checks.
+} elseif ( false == $true && true == $false ) {
+// Good - this is the correct way to do conditional checks.
 	echo 'False';
 }
 
 // Test for 'equals' conditional.
-if ( $true == true ) { // Bad x 1.
+if ( $true == true ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( false == $true ) { // Good.
+} elseif ( false == $true ) {
+// Good.
 	echo 'False';
 }
 
 // Test for 'not equals' conditional.
-if ( $true != true ) { // Bad x 1.
+if ( $true != true ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( false != $true ) { // Good.
+} elseif ( false != $true ) {
+// Good.
 	echo 'False';
 }
 
 // Test for 'exactly equals' conditional.
-if ( $true === true ) { // Bad x 1.
+if ( $true === true ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( false === $true ) { // Good.
+} elseif ( false === $true ) {
+// Good.
 	echo 'False';
 }
 
 // Test for 'not exactly equals' conditional.
-if ( $true !== true ) { // Bad x 1.
+if ( $true !== true ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( false !== $true ) { // Good.
+} elseif ( false !== $true ) {
+// Good.
 	echo 'False';
 }
 
 // Make sure the test excludes functions on the conditional check.
-if ( strtolower( $check ) == $true  ) { // Good.
+if ( strtolower( $check ) == $true  ) {
+// Good.
 	echo 'True';
 }
 // Makes sure the test excludes variable casting in the conditional check.
-if ( true == (bool) $true ) { // Good.
+if ( true == (bool) $true ) {
+// Good.
 	echo 'True';
-} elseif ( false == $true ) { // Good.
+} elseif ( false == $true ) {
+// Good.
 	echo 'False';
 }
 // Testing for string comparison.
-if ( $true == 'true' ) { // Bad x 1.
+if ( $true == 'true' ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( 'false' == $true ) { // Good x 1.
+} elseif ( 'false' == $true ) {
+// Good x 1.
 	echo 'False';
 }
 // Testing for integer comparison.
-if ( $true == 0 ) { // Bad x 1.
+if ( $true == 0 ) {
+// Bad x 1.
 	echo 'True';
-} elseif ( 1 == $false ) { // Good x 1.
+} elseif ( 1 == $false ) {
+// Good x 1.
 	echo 'False';
 }
 
 // Testing constant comparison.
-if ( $taxonomy === MyClass::TAXONOMY_SLUG ) { // Bad.
+if ( $taxonomy === MyClass::TAXONOMY_SLUG ) {
+// Bad.
 	$link = true;
-} elseif ( MyClass::TAXONOMY_SLUG === $taxonomy ) { // Ok.
+} elseif ( MyClass::TAXONOMY_SLUG === $taxonomy ) {
+// Ok.
 	$link = false;
 }
 
-if ( $foo === FOO_CONSTANT ) { // Bad.
+if ( $foo === FOO_CONSTANT ) {
+// Bad.
 	$link = true;
-} elseif ( FOO_CONSTANT === $foo ) { // Ok.
+} elseif ( FOO_CONSTANT === $foo ) {
+// Ok.
 	$link = false;
 }
 
@@ -75,7 +97,8 @@ 
 
 $accessibility_mode = ( 'on' === sanitize_key( $_GET['accessibility-mode'] ) ) ? 'on' : 'off'; // Ok.
 
-if ( $on !== self::$network_mode ) { // Ok.
+if ( $on !== self::$network_mode ) {
+// Ok.
 	self::$network_mode = (bool) $on;
 }
 

vendor/wp-coding-standards/wpcs/WordPress/Tests/PHP/DiscouragedFunctionsUnitTest.inc

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 register_globals(); // Bad.
 
 query_posts( 'post_type=attachment' ); // Bad, use WP_Query instead.
-while ( have_posts() ){
+while ( have_posts() ) {
 	the_post();
 	// ...
 }

Braces +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 register_globals(); // Bad.
 
 query_posts( 'post_type=attachment' ); // Bad, use WP_Query instead.
-while ( have_posts() ){
+while ( have_posts() ) {
 	the_post();
 	// ...
 }