ReservableProductFormPart.form_valid() - Code Metrics - Inspection of "Put ansible handlers in main.yml" - jaywink/kakaravaara3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca28e3...0fbdc5 )

by Jason

created 2016-05-14 18:39 UTC

ReservableProductFormPart.form_valid() A

↳ Parent: ReservableProductFormPart

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
c	2
b	0
f	0
dl	0
loc	5
rs	9.4285

from django.forms import ModelForm
from shoop.admin.form_part import FormPart, TemplatedFormDef

from reservations.models import ReservableProduct


class ReservableProductForm(ModelForm):

    class Meta:
        model = ReservableProduct
        fields = (
            "pricing_per_person",
            "pricing_per_person_included",
            "pricing_per_person_price",
            "sort_order",
            "check_out_time",
            "check_in_time",
            # "available_count",  # not implemented yet
        )


class ReservableProductFormPart(FormPart):
    priority = -980

    def _get_reservable_instance(self):
        if hasattr(self.object, "reservable"):

            return self.object.reservable

        else:
            reservable, created = ReservableProduct.objects.get_or_create(product=self.object)

            return reservable

    def get_form_defs(self):
        yield TemplatedFormDef(
            "reservableproduct",
            ReservableProductForm,
            template_name="reservations/_reservable_product_form.jinja",
            required=True,
            kwargs={
                "instance": self._get_reservable_instance(),
            }
        )

    def form_valid(self, form):
        try:
            form["reservableproduct"].save()
        except KeyError:
            pass


1			from django.forms import ModelForm
2			from shoop.admin.form_part import FormPart, TemplatedFormDef
3
4			from reservations.models import ReservableProduct
5
6
7			class ReservableProductForm(ModelForm):
8
9			class Meta:
10			model = ReservableProduct
11			fields = (
12			"pricing_per_person",
13			"pricing_per_person_included",
14			"pricing_per_person_price",
15			"sort_order",
16			"check_out_time",
17			"check_in_time",
18			# "available_count", # not implemented yet
19			)
20
21
22			class ReservableProductFormPart(FormPart):
23			priority = -980
24
25			def _get_reservable_instance(self):
26			if hasattr(self.object, "reservable"):
			0 ignored issues – show Bug introduced 2015-11-28 14:48 UTC by Report Bug Copy Issue Report The Instance of `ReservableProductFormPart` does not seem to have a member named `object`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
27			return self.object.reservable
			0 ignored issues – show Bug introduced 2015-11-28 14:48 UTC by Report Bug Copy Issue Report The Instance of `ReservableProductFormPart` does not seem to have a member named `object`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
28			else:
29			reservable, created = ReservableProduct.objects.get_or_create(product=self.object)
			0 ignored issues – show Bug introduced 2015-11-28 14:48 UTC by Report Bug Copy Issue Report The Class `ReservableProduct` does not seem to have a member named `objects`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history... Bug introduced 2015-11-28 14:48 UTC by Report Bug Copy Issue Report The Instance of `ReservableProductFormPart` does not seem to have a member named `object`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
30			return reservable
31
32			def get_form_defs(self):
33			yield TemplatedFormDef(
34			"reservableproduct",
35			ReservableProductForm,
36			template_name="reservations/_reservable_product_form.jinja",
37			required=True,
38			kwargs={
39			"instance": self._get_reservable_instance(),
40			}
41			)
42
43			def form_valid(self, form):
44			try:
45			form["reservableproduct"].save()
46			except KeyError:
47			pass
48

jaywink / kakaravaara3

GitHub Access Token became invalid

Push — master ( ca28e3...0fbdc5 )

ReservableProductFormPart.form_valid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like