GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.

ReservationsGetReservedDatesTestCase   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 75
Duplicated Lines 44 %

Importance

Changes 5
Bugs 0 Features 0
Metric Value
c 5
b 0
f 0
dl 33
loc 75
rs 10
wmc 5

5 Methods

Rating   Name   Duplication   Size   Complexity  
A test_get_reserved_dates_for_period_returns_correct_dates() 17 17 1
A test_get_reserved_dates_for_period_returns_correct_dates__spanning_months() 0 11 1
A setUp() 0 3 1
A test_is_period_free() 0 22 1
A test_get_reserved_dates_returns_correct_dates() 16 16 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
import datetime
2
3
from kakaravaara.tests import KakaravaaraTestsBase
4
from reservations.factories import ReservableProductFactory, ReservationFactory
5
from reservations.models import Reservation
6
7
8
class ReservationsGetReservedDatesTestCase(KakaravaaraTestsBase):
9
10
    def setUp(self):
11
        super(ReservationsGetReservedDatesTestCase, self).setUp()
12
        self.reservable = ReservableProductFactory()
13
14 View Code Duplication
    def test_get_reserved_dates_returns_correct_dates(self):
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
15
        ReservationFactory(
16
            reservable=self.reservable,
17
            start_time=datetime.datetime(year=2015, month=6, day=30, hour=15),
18
            end_time=datetime.datetime(year=2015, month=7, day=5, hour=12)
19
        )
20
        ReservationFactory(
21
            reservable=self.reservable,
22
            start_time=datetime.datetime(year=2015, month=7, day=10, hour=12),
23
            end_time=datetime.datetime(year=2015, month=7, day=15, hour=12)
24
        )
25
        dates = self.reservable.get_reserved_dates(
0 ignored issues
show
Bug introduced by
The Instance of ReservableProductFactory does not seem to have a member named get_reserved_dates.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
26
            start=datetime.date(year=2015, month=5, day=1),
27
            end=datetime.date(year=2015, month=8, day=1)
28
        )
29
        self.assertEquals(len(dates), 10)
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertEquals.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
30
31 View Code Duplication
    def test_get_reserved_dates_for_period_returns_correct_dates(self):
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
32
        self.reservable2 = ReservableProductFactory()
33
        ReservationFactory(
34
            reservable=self.reservable,
35
            start_time=datetime.datetime(year=2015, month=6, day=30, hour=15),
36
            end_time=datetime.datetime(year=2015, month=7, day=5, hour=12)
37
        )
38
        ReservationFactory(
39
            reservable=self.reservable2,
40
            start_time=datetime.datetime(year=2015, month=7, day=10, hour=12),
41
            end_time=datetime.datetime(year=2015, month=7, day=15, hour=12)
42
        )
43
        dates = Reservation.get_reserved_days_for_period(
44
            start_date=datetime.date(year=2015, month=6, day=30),
45
            end_date=datetime.date(year=2015, month=7, day=15)
46
        )
47
        self.assertEquals(len(dates), 10)
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertEquals.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
48
49
    def test_get_reserved_dates_for_period_returns_correct_dates__spanning_months(self):
50
        ReservationFactory(
51
            reservable=self.reservable,
52
            start_time=datetime.datetime(year=2015, month=6, day=30, hour=15),
53
            end_time=datetime.datetime(year=2015, month=8, day=5, hour=12)
54
        )
55
        dates = Reservation.get_reserved_days_for_period(
56
            start_date=datetime.date(year=2015, month=7, day=15),
57
            end_date=datetime.date(year=2015, month=7, day=20)
58
        )
59
        self.assertEquals(len(dates), 6)
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertEquals.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
60
61
    def test_is_period_free(self):
62
        ReservationFactory(
63
            reservable=self.reservable,
64
            start_time=datetime.datetime(year=2015, month=6, day=30, hour=15),
65
            end_time=datetime.datetime(year=2015, month=7, day=5, hour=12)
66
        )
67
        ReservationFactory(
68
            reservable=self.reservable,
69
            start_time=datetime.datetime(year=2015, month=7, day=10, hour=12),
70
            end_time=datetime.datetime(year=2015, month=7, day=15, hour=12)
71
        )
72
        self.assertFalse(self.reservable.is_period_days_free(
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertFalse.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
Bug introduced by
The Instance of ReservableProductFactory does not seem to have a member named is_period_days_free.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
73
            datetime.date(year=2015, month=6, day=27),
74
            datetime.date(year=2015, month=7, day=3)
75
        ))
76
        self.assertTrue(self.reservable.is_period_days_free(
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertTrue.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
Bug introduced by
The Instance of ReservableProductFactory does not seem to have a member named is_period_days_free.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
77
            datetime.date(year=2015, month=6, day=27),
78
            datetime.date(year=2015, month=6, day=29)
79
        ))
80
        self.assertTrue(self.reservable.is_period_days_free(
0 ignored issues
show
Bug introduced by
The Instance of ReservationsGetReservedDatesTestCase does not seem to have a member named assertTrue.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
Bug introduced by
The Instance of ReservableProductFactory does not seem to have a member named is_period_days_free.

This check looks for calls to members that are non-existent. These calls will fail.

The member could have been renamed or removed.

Loading history...
81
            datetime.date(year=2015, month=6, day=27),
82
            datetime.date(year=2015, month=6, day=30)
83
        ))
84