Issues in SimpleCache.php - New Issues - Inspection of "Add a storage engine using psr cache interface" - jaytaph/RateLimitBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — psr-cache ( 16d82e )

unknown

created 2018-06-26 13:37 UTC

Service/Storage/SimpleCache.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Noxlogic\RateLimitBundle\Service\Storage;

use Noxlogic\RateLimitBundle\Service\RateLimitInfo;
use Psr\SimpleCache\CacheInterface;

class SimpleCache implements StorageInterface
{
    /**
     * @var CacheInterface
     */
    protected $client;

    public function __construct(CacheInterface $client)
    {
        $this->client = $client;
    }

    public function getRateInfo($key)
    {
        $info = $this->client->get($key);
        if ($info === null || !array_key_exists('limit', $info)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        return $this->createRateInfo($info);
    }

    public function limitRate($key)

    {
        $info = $this->client->get($key);
        if ($info === null || !array_key_exists('limit', $info)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $info['calls']++;
        $ttl = $info['reset'] - time();

        $this->client->set($key, $info, $ttl);

        return $this->createRateInfo($info);
    }

    public function createRate($key, $limit, $period)
    {
        $info = [
            'limit' => $limit,
            'calls' => 1,
            'reset' => time() + $period,
        ];
        $this->client->set($key, $info, $period);

        return $this->createRateInfo($info);
    }

    public function resetRate($key)
    {
        $this->client->delete($key);

        return true;
    }

    private function createRateInfo(array $info)

    {
        $rateLimitInfo = new RateLimitInfo();
        $rateLimitInfo->setLimit($info['limit']);
        $rateLimitInfo->setCalls($info['calls']);
        $rateLimitInfo->setResetTimestamp($info['reset']);

        return $rateLimitInfo;
    }
}


1			<?php
2
3			namespace Noxlogic\RateLimitBundle\Service\Storage;
4
5			use Noxlogic\RateLimitBundle\Service\RateLimitInfo;
6			use Psr\SimpleCache\CacheInterface;
7
8			class SimpleCache implements StorageInterface
9			{
10			/**
11			* @var CacheInterface
12			*/
13			protected $client;
14
15	5		public function __construct(CacheInterface $client)
16			{
17	5		$this->client = $client;
18	5		}
19
20	1		public function getRateInfo($key)
21			{
22	1		$info = $this->client->get($key);
23	1		if ($info === null \|\| !array_key_exists('limit', $info)) {
24			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-06-26 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Noxlogic\RateLimitBundle...eInterface::getRateInfo` of type `Noxlogic\RateLimitBundle\Service\RateLimitInfo`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
25			}
26
27	1		return $this->createRateInfo($info);
28			}
29
30	2	View Code Duplication	public function limitRate($key)
			0 ignored issues – show Duplication introduced 2018-06-26 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			{
32	2		$info = $this->client->get($key);
33	2		if ($info === null \|\| !array_key_exists('limit', $info)) {
34	1		return false;
			0 ignored issues – show Bug Best Practice introduced 2017-03-17 20:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Noxlogic\RateLimitBundle...ageInterface::limitRate` of type `Noxlogic\RateLimitBundle\Service\RateLimitInfo`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
35			}
36
37	1		$info['calls']++;
38	1		$ttl = $info['reset'] - time();
39
40	1		$this->client->set($key, $info, $ttl);
41
42	1		return $this->createRateInfo($info);
43			}
44
45	1		public function createRate($key, $limit, $period)
46			{
47			$info = [
48	1		'limit' => $limit,
49	1		'calls' => 1,
50	1		'reset' => time() + $period,
51			];
52	1		$this->client->set($key, $info, $period);
53
54	1		return $this->createRateInfo($info);
55			}
56
57	1		public function resetRate($key)
58			{
59	1		$this->client->delete($key);
60
61	1		return true;
62			}
63
64	3	View Code Duplication	private function createRateInfo(array $info)
			0 ignored issues – show Duplication introduced 2018-06-26 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65			{
66	3		$rateLimitInfo = new RateLimitInfo();
67	3		$rateLimitInfo->setLimit($info['limit']);
68	3		$rateLimitInfo->setCalls($info['calls']);
69	3		$rateLimitInfo->setResetTimestamp($info['reset']);
70
71	3		return $rateLimitInfo;
72			}
73			}
74

jaytaph / RateLimitBundle

Push — psr-cache ( 16d82e )

Service/Storage/SimpleCache.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like