Noxlogic\RateLimitBundle\Service\Storage\Memcache

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	31.25 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getRateInfo()	0	6	1
A	limitRate()	0	16	4
A	createRate()	11	11	1
A	resetRate()	0	5	1
A	createRateInfo()	9	9	1

<?php

namespace Noxlogic\RateLimitBundle\Service\Storage;

use Noxlogic\RateLimitBundle\Service\RateLimitInfo;

class Memcache implements StorageInterface
{
    /**
     * @var \Memcached
     */
    protected $client;

    public function __construct(\Memcached $client)
    {
        $this->client = $client;
    }

    public function getRateInfo($key)
    {
        $info = $this->client->get($key);

        return $this->createRateInfo($info);
    }

    public function limitRate($key)
    {
        $cas = null;
        $i = 0;
        do {
            $info = $this->client->get($key, null, $cas);
            if (!$info) {
                return false;
            }

            $info['calls']++;
            $this->client->cas($cas, $key, $info);
        } while ($this->client->getResultCode() == \Memcached::RES_DATA_EXISTS && $i++ < 5);

        return $this->createRateInfo($info);
    }

    public function createRate($key, $limit, $period)

This method seems to be duplicated in your project.

    {
        $info = array();
        $info['limit'] = $limit;
        $info['calls'] = 1;
        $info['reset'] = time() + $period;

        $this->client->set($key, $info, $period);

        return $this->createRateInfo($info);
    }

    public function resetRate($key)
    {
        $this->client->delete($key);
        return true;
    }

    private function createRateInfo(array $info)

This method seems to be duplicated in your project.

    {
        $rateLimitInfo = new RateLimitInfo();
        $rateLimitInfo->setLimit($info['limit']);
        $rateLimitInfo->setCalls($info['calls']);
        $rateLimitInfo->setResetTimestamp($info['reset']);

        return $rateLimitInfo;
    }
}