This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
13
{
14
15
/**
16
* @var Request
17
*/
18
protected $request;
19
20
/**
21
* @var RateLimit|null
22
*/
23
protected $rateLimit;
24
25
public function __construct(Request $request, RateLimit $rateLimit = null)
You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().
Loading history...
26
{
27
$this->request = $request;
28
$this->rateLimit = $rateLimit;
29
}
30
31
/**
32
* @return RateLimit|null
33
*/
34
public function getRateLimit()
35
{
36
return $this->rateLimit;
37
}
38
39
/**
40
* @param RateLimit|null $rateLimit
41
*/
42
public function setRateLimit(RateLimit $rateLimit = null)
The type Noxlogic\RateLimitBundle...s\CheckedRateLimitEvent has been defined more than once; this definition is ignored, only the first definition in this file (L12-54) is considered.
This check looks for classes that have been defined more than once in the same file.
If you can, we would recommend to use standard object-oriented programming
techniques. For example, to avoid multiple types, it might make sense to create a
common interface, and then multiple, different implementations for that interface.
This also has the side-effect of providing you with better IDE auto-completion,
static analysis and also better OPCode caching from PHP.
This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
57
{
58
59
/**
60
* @var Request
61
*/
62
protected $request;
63
64
/**
65
* @var RateLimit|null
66
*/
67
protected $rateLimit;
68
69
public function __construct(Request $request, RateLimit $rateLimit = null)
You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().
Loading history...
70
{
71
$this->request = $request;
72
$this->rateLimit = $rateLimit;
73
}
74
75
/**
76
* @return RateLimit|null
77
*/
78
public function getRateLimit()
79
{
80
return $this->rateLimit;
81
}
82
83
/**
84
* @param RateLimit|null $rateLimit
85
*/
86
public function setRateLimit(RateLimit $rateLimit = null)
jaytaph /
RateLimitBundle
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.