JayaCode\Framework\Core\View\Template\BasicTemplate

Complexity

Total Complexity

12

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
B	buildScript()	0	13	6
A	render()	0	20	3
A	setParent()	0	4	1
A	getContentParent()	0	4	1
A	setContentParent()	0	4	1

<?php
namespace JayaCode\Framework\Core\View\Template;

/**
 * Class BasicTemplate
 * @package JayaCode\Framework\Core\View\Template
 */
class BasicTemplate extends Template
{
    /**
     * @var
     */
    protected $parent;

    /**
     * @return string
     */
    public function buildScript()
    {
        $fileCache = $this->cacheDir.str_replace(["/", "."], "_", $this->fileTemplate);
        if ($this->cacheDir && file_exists($fileCache) && empty($this->contentParent)) {

The expression $this->cacheDir of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $this->script = file_get_contents($fileCache);

It seems like file_get_contents($fileCache) of type string is incompatible with the declared type null of property $script.

        }

        $this->script = $this->converter->build(file_get_contents($this->locTemplate));
        
        if ($this->cacheDir && empty($this->contentParent)) {

The expression $this->cacheDir of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            file_put_contents($fileCache, $this->script);
        }
    }

    /**
     * @return mixed|string
     */
    public function render()
    {
        if (!$this->script) {
            $this->buildScript();
        }

        extract($this->vars->all());

$this->vars->all() cannot be passed to extract() as the parameter $var_array expects a reference.

        ob_start();
        eval("?>" . $this->script);

It is generally not recommended to use eval unless absolutely required.

        $result = ob_get_contents();
        ob_end_clean();
        
        if ($this->parent) {
            $fileParent = $this->parent.Template::$extension;
            $parent = new BasicTemplate($this->locView, $fileParent, $this->variableCollector, $this->converter);
            $parent->setContentParent($this->contentParent);
            return $parent->render();
        }
        return $result;
    }

    /**
     * @param $name
     */
    public function setParent($name)
    {
        $this->parent = $name;
    }

    /**
     * @var array
     */
    protected $contentParent = [];

    /**
     * @return array
     */
    public function getContentParent()
    {
        return $this->contentParent;
    }

    /**
     * @param array $contentParent
     */
    public function setContentParent($contentParent)
    {
        $this->contentParent = $contentParent;
    }
}