jaxon-php / jaxon-utils

src/File/FileMinifier.php

<?php

/**
 * FileMinifier.php - JS and CSS file minifier
 *
 * Minify the javascript code generated by the Jaxon library and plugins.
 *
 * @package jaxon-utils
 * @author Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @copyright 2022 Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @license https://opensource.org/licenses/BSD-3-Clause BSD 3-Clause License
 * @link https://github.com/jaxon-php/jaxon-core
 */

namespace Jaxon\Utils\File;

use JShrink\Minifier;

use Exception;

use function file_get_contents;
use function file_put_contents;
use function is_file;

class FileMinifier
{
    /**
     * Read the file content
     *
     * @param string $sPath
     *
     * @return string|false
     */
    private function readFile(string $sPath)
    {
        try
        {
            return file_get_contents($sPath);
        }
        catch(Exception $e)
        {
            return false;
        }
    }

    /**
     * Read the file content
     *
     * @param string $sCode
     *
     * @return string|false
     */
    private function minifyCode(string $sCode)
    {
        try
        {
            return Minifier::minify($sCode);

The expression return JShrink\Minifier::minify($sCode) returns the type boolean which is incompatible with the documented return type false|string.

        }
        catch(Exception $e)
        {
            return false;
        }
    }

    /**
     * Minify javascript code
     *
     * @param string $sJsFile The javascript file to be minified
     * @param string $sMinFile The minified javascript file
     *
     * @return bool
     */
    public function minify(string $sJsFile, string $sMinFile): bool
    {
        if(($sJsCode = $this->readFile($sJsFile)) === false ||
            ($sMinCode = $this->minifyCode($sJsCode)) === false)
        {
            return false;
        }
        file_put_contents($sMinFile, $sMinCode);
        return is_file($sMinFile);
    }
}