Passed
Push — main ( fd5484...10601e )
by Thierry
05:13
created
jaxon-core/src/App/Pagination/Paginator.php 1 patch
Spacing   +17 added lines, -20 removed lines patch added patch discarded remove patch
@@ -128,9 +128,8 @@  discard block
 block discarded – undo
128 128
      */
129 129
     private function updatePagesCount(): Paginator
130 130
     {
131
-        $this->nPagesCount = ($this->nItemsPerPage === 0 ? 0 :
132
-            (int)ceil($this->nItemsCount / $this->nItemsPerPage));
133
-        if($this->nPageNumber > $this->nPagesCount)
131
+        $this->nPagesCount = ($this->nItemsPerPage === 0 ? 0 : (int)ceil($this->nItemsCount / $this->nItemsPerPage));
132
+        if ($this->nPageNumber > $this->nPagesCount)
134 133
         {
135 134
             $this->nPageNumber = $this->nPagesCount;
136 135
         }
@@ -184,8 +183,7 @@  discard block
 block discarded – undo
184 183
     protected function getPrevPage(): Page
185 184
     {
186 185
         return $this->nPageNumber <= 1 ?
187
-            new Page('disabled', $this->sPreviousText, 0) :
188
-            new Page('enabled', $this->sPreviousText, $this->nPageNumber - 1);
186
+            new Page('disabled', $this->sPreviousText, 0) : new Page('enabled', $this->sPreviousText, $this->nPageNumber - 1);
189 187
     }
190 188
 
191 189
     /**
@@ -196,8 +194,7 @@  discard block
 block discarded – undo
196 194
     protected function getNextPage(): Page
197 195
     {
198 196
         return $this->nPageNumber >= $this->nPagesCount ?
199
-            new Page('disabled', $this->sNextText, 0) :
200
-            new Page('enabled', $this->sNextText, $this->nPageNumber + 1);
197
+            new Page('disabled', $this->sNextText, 0) : new Page('enabled', $this->sNextText, $this->nPageNumber + 1);
201 198
     }
202 199
 
203 200
     /**
@@ -209,7 +206,7 @@  discard block
 block discarded – undo
209 206
      */
210 207
     protected function getPage(int $nNumber): Page
211 208
     {
212
-        if($nNumber < 1)
209
+        if ($nNumber < 1)
213 210
         {
214 211
             return new Page('disabled', $this->sEllipsysText, 0);
215 212
         }
@@ -228,9 +225,9 @@  discard block
 block discarded – undo
228 225
     {
229 226
         $aPageNumbers = [];
230 227
 
231
-        if($this->nPagesCount <= $this->nMaxPages)
228
+        if ($this->nPagesCount <= $this->nMaxPages)
232 229
         {
233
-            for($i = 0; $i < $this->nPagesCount; $i++)
230
+            for ($i = 0; $i < $this->nPagesCount; $i++)
234 231
             {
235 232
                 $aPageNumbers[] = $i + 1;
236 233
             }
@@ -243,7 +240,7 @@  discard block
 block discarded – undo
243 240
 
244 241
         $nSlidingStart = 1;
245 242
         $nSlidingEndOffset = $nNumAdjacents + 3 - $this->nPageNumber;
246
-        if($nSlidingEndOffset < 0)
243
+        if ($nSlidingEndOffset < 0)
247 244
         {
248 245
             $nSlidingStart = $this->nPageNumber - $nNumAdjacents;
249 246
             $nSlidingEndOffset = 0;
@@ -251,23 +248,23 @@  discard block
 block discarded – undo
251 248
 
252 249
         $nSlidingEnd = $this->nPagesCount;
253 250
         $nSlidingStartOffset = $this->nPageNumber + $nNumAdjacents + 2 - $this->nPagesCount;
254
-        if($nSlidingStartOffset < 0)
251
+        if ($nSlidingStartOffset < 0)
255 252
         {
256 253
             $nSlidingEnd = $this->nPageNumber + $nNumAdjacents;
257 254
             $nSlidingStartOffset = 0;
258 255
         }
259 256
 
260 257
         // Build the list of page numbers.
261
-        if($nSlidingStart > 1)
258
+        if ($nSlidingStart > 1)
262 259
         {
263 260
             $aPageNumbers[] = 1;
264 261
             $aPageNumbers[] = 0; // Ellipsys;
265 262
         }
266
-        for($i = $nSlidingStart - $nSlidingStartOffset; $i <= $nSlidingEnd + $nSlidingEndOffset; $i++)
263
+        for ($i = $nSlidingStart - $nSlidingStartOffset; $i <= $nSlidingEnd + $nSlidingEndOffset; $i++)
267 264
         {
268 265
             $aPageNumbers[] = $i;
269 266
         }
270
-        if($nSlidingEnd < $this->nPagesCount)
267
+        if ($nSlidingEnd < $this->nPagesCount)
271 268
         {
272 269
             $aPageNumbers[] = 0; // Ellipsys;
273 270
             $aPageNumbers[] = $this->nPagesCount;
@@ -293,7 +290,7 @@  discard block
 block discarded – undo
293 290
      */
294 291
     public function pages(): array
295 292
     {
296
-        if($this->nPagesCount < 2)
293
+        if ($this->nPagesCount < 2)
297 294
         {
298 295
             return [];
299 296
         }
@@ -344,7 +341,7 @@  discard block
 block discarded – undo
344 341
     private function renderLinks(): string
345 342
     {
346 343
         $aPages = $this->pages();
347
-        if(count($aPages) === 0)
344
+        if (count($aPages) === 0)
348 345
         {
349 346
             return '';
350 347
         }
@@ -365,7 +362,7 @@  discard block
 block discarded – undo
365 362
     {
366 363
         $sHtml = $this->renderLinks();
367 364
         // The HTML code must always be displayed, even if it is empty.
368
-        if(is_a($this->xPlugin->response(), Response::class))
365
+        if (is_a($this->xPlugin->response(), Response::class))
369 366
         {
370 367
             /** @var Response */
371 368
             $xResponse = $this->xPlugin->response();
@@ -388,13 +385,13 @@  discard block
 block discarded – undo
388 385
      */
389 386
     public function render(JsExpr $xCall, string $sWrapperId = ''): void
390 387
     {
391
-        if(($xFunc = $xCall->func()) === null)
388
+        if (($xFunc = $xCall->func()) === null)
392 389
         {
393 390
             return;
394 391
         }
395 392
 
396 393
         $aParams = $this->showLinks(trim($sWrapperId));
397
-        if($aParams !== null)
394
+        if ($aParams !== null)
398 395
         {
399 396
             // Set click handlers on the pagination links
400 397
             $aParams['func'] = $xFunc->withPage()->jsonSerialize();
Please login to merge, or discard this patch.
jaxon-core/src/App/View/ViewTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     {
54 54
         $this->sDirectory = '';
55 55
         $this->sExtension = '';
56
-        if(isset($this->aDirectories[$sNamespace]))
56
+        if (isset($this->aDirectories[$sNamespace]))
57 57
         {
58 58
             // Make sure there's only one '/' at the end of the string
59 59
             $this->sDirectory = rtrim($this->aDirectories[$sNamespace]['path'], '/') . '/';
Please login to merge, or discard this patch.
jaxon-core/src/App/View/TemplateView.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
         $sViewName = $store->getViewName();
60 60
         $sNamespace = $store->getNamespace();
61 61
         // In this view renderer, the namespace must always be prepended to the view name.
62
-        if(substr($sViewName, 0, strlen($sNamespace) + 2) != $sNamespace . '::')
62
+        if (substr($sViewName, 0, strlen($sNamespace) + 2) != $sNamespace . '::')
63 63
         {
64 64
             $sViewName = $sNamespace . '::' . $sViewName;
65 65
         }
Please login to merge, or discard this patch.
jaxon-core/src/App/View/Helper/EventAttr.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
      */
60 60
     public function on(string $event, JsExpr $xJsExpr): self
61 61
     {
62
-        if($this->sSelector === '')
62
+        if ($this->sSelector === '')
63 63
         {
64 64
             return $this;
65 65
         }
Please login to merge, or discard this patch.
jaxon-core/src/App/View/Helper/HtmlAttrHelper.php 1 patch
Spacing   +5 added lines, -8 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     public function html(JxnCall $xJsCall): string
55 55
     {
56 56
         $sClassName = $xJsCall->_class();
57
-        if(!$sClassName)
57
+        if (!$sClassName)
58 58
         {
59 59
             return '';
60 60
         }
@@ -88,8 +88,7 @@  discard block
 block discarded – undo
88 88
     public function pagination(JxnCall $xJsCall): string
89 89
     {
90 90
         // The pagination is always rendered with the same Pagination component.
91
-        $sComponent = $this->sPaginationComponent ?:
92
-            ($this->sPaginationComponent = rq(Pagination::class)->_class());
91
+        $sComponent = $this->sPaginationComponent ?: ($this->sPaginationComponent = rq(Pagination::class)->_class());
93 92
         $sItem = $xJsCall->_class();
94 93
         return "jxn-bind=\"$sComponent\" jxn-item=\"$sItem\"";
95 94
     }
@@ -154,15 +153,14 @@  discard block
 block discarded – undo
154 153
      */
155 154
     private function setEventHandler(array $aHandler, ?EventAttr $xAttr = null): EventAttr|null
156 155
     {
157
-        if(!$this->eventIsValid($aHandler))
156
+        if (!$this->eventIsValid($aHandler))
158 157
         {
159 158
             return $xAttr;
160 159
         }
161 160
         // The array content is valid.
162 161
         [$sSelector, $sEvent, $xJsExpr] = $aHandler;
163 162
         return !$xAttr ?
164
-            $this->select($sSelector)->on($sEvent, $xJsExpr) :
165
-            $xAttr->select($sSelector)->on($sEvent, $xJsExpr);
163
+            $this->select($sSelector)->on($sEvent, $xJsExpr) : $xAttr->select($sSelector)->on($sEvent, $xJsExpr);
166 164
     }
167 165
 
168 166
     /**
@@ -207,8 +205,7 @@  discard block
 block discarded – undo
207 205
         };
208 206
         $sCode = trim($sCode);
209 207
 
210
-        return $sType !== 'ready' || $sCode === '' ? $sCode :
211
-            // Call the ready code with the jaxon.dom.ready function.
208
+        return $sType !== 'ready' || $sCode === '' ? $sCode : // Call the ready code with the jaxon.dom.ready function.
212 209
             "jaxon.dom.ready(() => $sCode)";
213 210
     }
214 211
 }
Please login to merge, or discard this patch.
jaxon-core/src/App/View/ViewRenderer.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -97,18 +97,18 @@  discard block
 block discarded – undo
97 97
      */
98 98
     public function addNamespaces(Config $xAppConfig): void
99 99
     {
100
-        if(empty($aNamespaces = $xAppConfig->getOptionNames('views')))
100
+        if (empty($aNamespaces = $xAppConfig->getOptionNames('views')))
101 101
         {
102 102
             return;
103 103
         }
104 104
 
105 105
         $sPackage = $xAppConfig->getOption('package', '');
106
-        foreach($aNamespaces as $sNamespace => $sOption)
106
+        foreach ($aNamespaces as $sNamespace => $sOption)
107 107
         {
108 108
             // Save the namespace
109 109
             $aNamespace = $xAppConfig->getOption($sOption);
110 110
             $aNamespace['package'] = $sPackage;
111
-            if(!isset($aNamespace['renderer']))
111
+            if (!isset($aNamespace['renderer']))
112 112
             {
113 113
                 $aNamespace['renderer'] = 'jaxon'; // 'jaxon' is the default renderer.
114 114
             }
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
             $aNamespaces = array_filter($this->aNamespaces, function($aOptions) use($sId) {
148 148
                 return $aOptions['renderer'] === $sId;
149 149
             });
150
-            foreach($aNamespaces as $sName => $aOptions)
150
+            foreach ($aNamespaces as $sName => $aOptions)
151 151
             {
152 152
                 $xRenderer->addNamespace($sName, $aOptions['directory'], $aOptions['extension']);
153 153
             }
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
      */
181 181
     public function getNamespaceRenderer(string $sNamespace): ?ViewInterface
182 182
     {
183
-        if(!isset($this->aNamespaces[$sNamespace]))
183
+        if (!isset($this->aNamespaces[$sNamespace]))
184 184
         {
185 185
             return null;
186 186
         }
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      */
206 206
     protected function store(): Store
207 207
     {
208
-        if(!$this->xStore)
208
+        if (!$this->xStore)
209 209
         {
210 210
             $this->xStore = new Store();
211 211
         }
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     public function shareValues(array $aValues): ViewRenderer
251 251
     {
252
-        foreach($aValues as $sName => $xValue)
252
+        foreach ($aValues as $sName => $xValue)
253 253
         {
254 254
             $this->share($sName, $xValue);
255 255
         }
@@ -273,14 +273,14 @@  discard block
 block discarded – undo
273 273
         $sNamespace = $this->sDefaultNamespace;
274 274
         // Get the namespace from the view name
275 275
         $nSeparatorPosition = strrpos($sViewName, '::');
276
-        if($nSeparatorPosition !== false)
276
+        if ($nSeparatorPosition !== false)
277 277
         {
278 278
             $sNamespace = substr($sViewName, 0, $nSeparatorPosition);
279 279
             $sViewName = substr($sViewName, $nSeparatorPosition + 2);
280 280
         }
281 281
 
282 282
         $xRenderer = $this->getNamespaceRenderer($sNamespace);
283
-        if(!$xRenderer)
283
+        if (!$xRenderer)
284 284
         {
285 285
             // Cannot render a view if there's no renderer corresponding to the namespace.
286 286
             return $this->xEmptyStore;
Please login to merge, or discard this patch.
jaxon-core/src/App/DataBag/DataBag.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
     public function new(string $sBag, string $sKey, $xValue): void
91 91
     {
92 92
         // Set the value only if it doesn't already exist.
93
-        if(!isset($this->aData[$sBag]) || !key_exists($sKey, $this->aData[$sBag]))
93
+        if (!isset($this->aData[$sBag]) || !key_exists($sKey, $this->aData[$sBag]))
94 94
         {
95 95
             $this->set($sBag, $sKey, $xValue);
96 96
         }
Please login to merge, or discard this patch.
jaxon-core/src/App/PageDatabagTrait.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,8 +37,7 @@
 block discarded – undo
37 37
     private function getPageNumber(int $pageNumber): int
38 38
     {
39 39
         // If no page number is provided, then get the value from the databag.
40
-        return $pageNumber > 0 ? $pageNumber :
41
-            (int)$this->bag($this->bagName())->get($this->bagAttr(), 1);
40
+        return $pageNumber > 0 ? $pageNumber : (int)$this->bag($this->bagName())->get($this->bagAttr(), 1);
42 41
     }
43 42
 
44 43
     /**
Please login to merge, or discard this patch.
jaxon-core/src/Request/Handler/Psr/PsrAjaxMiddleware.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
         // and the other classes will get this request from there.
65 65
         $this->di->val(ServerRequestInterface::class, $request);
66 66
 
67
-        if(!$this->xRequestHandler->canProcessRequest())
67
+        if (!$this->xRequestHandler->canProcessRequest())
68 68
         {
69 69
             // Unable to find a plugin to process the request
70 70
             return $handler->handle($request);
Please login to merge, or discard this patch.