jaxon-php / jaxon-dialogs

templates/jqueryconfirm/alert.js

jaxon.dialogs.jconfirm = {

The variable jaxon seems to be never declared. If this is a global, consider adding a /** global: jaxon */ comment.

    dialog: null,
    show: function(args) {
        // Add buttons
        for(key in args.data.buttons)

The variable key seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.key.

        {
            button = args.data.buttons[key];

The variable button seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.button.

            if(button.action === 'close')
            {
                button.action = function(){jaxon.dialogs.jconfirm.dialog.close();};

The variable jaxon seems to be never declared. If this is a global, consider adding a /** global: jaxon */ comment.

            }
            else
            {
                button.action = new Function(button.action);

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

            }
        }
        args.data.closeIcon = true;
        if((jaxon.dialogs.jconfirm.dialog))

The variable jaxon seems to be never declared. If this is a global, consider adding a /** global: jaxon */ comment.

        {
            jaxon.dialogs.jconfirm.dialog.close();
        }
        jaxon.dialogs.jconfirm.dialog = $.confirm(args.data);
    },
    hide: function(args) {

The parameter args is not used and could be removed.

        if((jaxon.dialogs.jconfirm.dialog))

The variable jaxon seems to be never declared. If this is a global, consider adding a /** global: jaxon */ comment.

        {
            jaxon.dialogs.jconfirm.dialog.close();
        }
        jaxon.dialogs.jconfirm.dialog = null;
    },
    success: function(content, title) {
        $.alert({content: content, title: title, type: 'green', icon: 'fa fa-success'});
    },
    info: function(content, title) {
        $.alert({content: content, title: title, type: 'blue', icon: 'fa fa-info'});
    },
    warning: function(content, title) {
        $.alert({content: content, title: title, type: 'orange', icon: 'fa fa-warning'});
    },
    error: function(content, title) {
        $.alert({content: content, title: title, type: 'red', icon: 'fa fa-error'});
    },
    confirm: function(question, title, yesCallback, noCallback) {
        if(noCallback == undefined)

Comparing noCallback to undefined using the == operator is not safe. Consider using === instead.

            noCallback = function(){};

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

        $.confirm({
            title: title,
            content: question,
            buttons: {
                yes: {
                    btnClass: "btn-blue",
                    text: "<?php echo $this->yes ?>",
                    action: yesCallback
                },
                no: {
                    text: "<?php echo $this->no ?>",
                    action: noCallback
                }
            }
        });
    }
};