jaxon-php / jaxon-core

src/App/App.php

<?php

/**
 * App.php
 *
 * Jaxon application
 *
 * @package jaxon-core

Package name "jaxon-core" is not valid; consider "Jaxoncore" instead

 * @author Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @copyright 2019 Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @license https://opensource.org/licenses/BSD-3-Clause BSD 3-Clause License
 * @link https://github.com/jaxon-php/jaxon-core
 */

PHP version not specified

Missing @category tag in file comment

namespace Jaxon\App;

use Jaxon\Di\Container;
use Jaxon\App\Traits\AjaxSendTrait;
use Jaxon\App\Traits\AppTrait;
use Jaxon\Exception\RequestException;
use Jaxon\Exception\SetupException;

use function file_exists;
use function http_response_code;
use function intval;
use function is_array;

class App implements AppInterface

Missing doc comment for class App

{
    use AppTrait;
    use AjaxSendTrait;

    /**
     * The class constructor
     *
     * @param Container $xContainer

Missing parameter comment

     */
    public function __construct(Container $xContainer)

Expected 2 blank lines before function; 1 found

    {
        $this->initApp($xContainer);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Read config options from a config file and set up the library
     *
     * @param string $sConfigFile    The full path to the config file

Expected 1 spaces after parameter name; 4 found

     *
     * @return void
     * @throws SetupException
     */
    public function setup(string $sConfigFile)
    {
        if(!file_exists($sConfigFile))
        {
            $sMessage = $this->xTranslator->trans('errors.file.access', ['path' => $sConfigFile]);
            throw new SetupException($sMessage);
        }

        // Read the config options.
        $aOptions = $this->xConfigManager->read($sConfigFile);

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $aLibOptions = $aOptions['lib'] ?? [];
        $aAppOptions = $aOptions['app'] ?? [];
        if(!is_array($aLibOptions) || !is_array($aAppOptions))
        {
            $sMessage = $this->xTranslator->trans('errors.file.content', ['path' => $sConfigFile]);
            throw new SetupException($sMessage);
        }
        // The bootstrap set this to false. It needs to be changed.
        if(!isset($aLibOptions['core']['response']['send']))
        {
            $aLibOptions['core']['response']['send'] = true;
        }

        $this->bootstrap()
            ->lib($aLibOptions)

Space found before object operator

            ->app($aAppOptions)

Space found before object operator

            ->setup();

Space found before object operator

    }

Expected 2 blank lines after function; 1 found

    /**

Parameter $sCode should have a doc-comment as per coding-style.

     * @inheritDoc
     * @throws RequestException
     */

Missing @return tag in function comment

    public function httpResponse(string $sCode = '200')
    {
        // Set the HTTP response code
        http_response_code(intval($sCode));

        // Send the response
        $this->sendResponse();
    }

Expected 2 blank lines after function; 0 found

}