Jaxon\Container\Traits\RequestTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getRequestHandler()	0	3	1
A	getRequestFactory()	0	3	1
A	registerRequests()	0	14	1
A	getParameterFactory()	0	3	1

<?php

Missing file doc comment

namespace Jaxon\Container\Traits;

use Jaxon\Jaxon;
use Jaxon\Plugin\Manager as PluginManager;
use Jaxon\Request\Factory\ParameterFactory;
use Jaxon\Request\Factory\RequestFactory;
use Jaxon\Request\Handler\Handler as RequestHandler;
use Jaxon\Request\Plugin\FileUpload;
use Jaxon\Request\Support\CallableRegistry;
use Jaxon\Response\Manager as ResponseManager;
use Jaxon\Response\Plugin\DataBag;

trait RequestTrait

Missing doc comment for trait RequestTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerRequests()

Expected 2 blank lines before function; 0 found

    {
        // Request Handler
        $this->set(RequestHandler::class, function($c) {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new RequestHandler($c->g(Jaxon::class), $c->g(PluginManager::class),
                $c->g(ResponseManager::class), $c->g(FileUpload::class), $c->g(DataBag::class));
        });
        // Request Factory
        $this->set(RequestFactory::class, function($c) {
            return new RequestFactory($c->g(CallableRegistry::class));
        });
        // Parameter Factory
        $this->set(ParameterFactory::class, function() {
            return new ParameterFactory();
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the request handler
     *
     * @return RequestHandler
     */
    public function getRequestHandler()
    {
        return $this->g(RequestHandler::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the request factory
     *
     * @return RequestFactory
     */
    public function getRequestFactory()
    {
        return $this->g(RequestFactory::class);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the parameter factory
     *
     * @return ParameterFactory
     */
    public function getParameterFactory()
    {
        return $this->g(ParameterFactory::class);
    }

Expected 2 blank lines after function; 0 found

}