Jaxon\Container\Traits\PluginTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	registerPlugins()	0	21	1
A	getPluginManager()	0	3	1

<?php

Missing file doc comment

namespace Jaxon\Container\Traits;

use Jaxon\Jaxon;
use Jaxon\Plugin\Code\Generator as CodeGenerator;
use Jaxon\Plugin\Manager as PluginManager;
use Jaxon\Request\Plugin\FileUpload;
use Jaxon\Request\Support\FileUpload as FileUploadSupport;
use Jaxon\Response\Manager as ResponseManager;
use Jaxon\Response\Plugin\DataBag;
use Jaxon\Response\Plugin\JQuery as JQueryPlugin;

trait PluginTrait

Missing doc comment for trait PluginTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerPlugins()

Expected 2 blank lines before function; 0 found

    {
        // Plugin Manager
        $this->set(PluginManager::class, function($c) {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new PluginManager($c->g(Jaxon::class), $c->g(CodeGenerator::class));
        });
        // File upload support
        $this->set(FileUploadSupport::class, function() {
            return new FileUploadSupport();
        });
        // File upload plugin
        $this->set(FileUpload::class, function($c) {
            return new FileUpload($c->g(ResponseManager::class), $c->g(FileUploadSupport::class));
        });
        // JQuery response plugin
        $this->set(JQueryPlugin::class, function() {
            return new JQueryPlugin();
        });
        // DataBag response plugin
        $this->set(DataBag::class, function() {
            return new DataBag();
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the plugin manager
     *
     * @return PluginManager
     */
    public function getPluginManager()
    {
        return $this->g(PluginManager::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 0 found

}