Jaxon\Container\Traits\ConfigTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	newConfig()	0	3	1
A	getConfigReader()	0	3	1
A	getConfig()	0	3	1
A	registerConfigs()	0	7	1

<?php

Missing file doc comment

namespace Jaxon\Container\Traits;

use Jaxon\Utils\Config\Config;
use Jaxon\Utils\Config\Reader;

trait ConfigTrait

Missing doc comment for trait ConfigTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerConfigs()

Expected 2 blank lines before function; 0 found

    {
        $this->set(Config::class, function($c) {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new Config($c->g('jaxon.core.options'));
        });
        $this->set(Reader::class, function($c) {
            return new Reader($c->g(Config::class));
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the config manager
     *
     * @return Config
     */
    public function getConfig()
    {
        return $this->g(Config::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the config reader
     *
     * @return Reader
     */
    public function getConfigReader()
    {
        return $this->g(Reader::class);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Create a new the config manager
     *
     * @param array             $aOptions           The options array

Expected 2 spaces after parameter type; 13 found

Expected 1 spaces after parameter name; 11 found

     * @param string            $sKeys              The keys of the options in the array

Expected 4 spaces after parameter name; 14 found

Expected 1 spaces after parameter type; 12 found

     *
     * @return Config            The config manager
     */
    public function newConfig(array $aOptions = [], $sKeys = '')
    {
        return new Config($aOptions, $sKeys);
    }

Expected 2 blank lines after function; 0 found

}