jaxon-php / jaxon-core

src/Request/Request.php

Doc Comments +2 added lines, -1 removed lines

@@ -54,7 +54,8 @@
     /**
      * The constructor.
      * 
-     * @param string        $sFunction            The javascript function
+     * @param string $sName
+     * @param string $sType
      */
     public function __construct($sName, $sType)
     {

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 
 namespace Jaxon\Request;
 
-use JsonSerializable;
 use Jaxon\Jaxon;
 
 class Request extends JsCall

Spacing +18 added lines, -18 removed lines

@@ -69,9 +69,9 @@ 
      */
     public function hasPageNumber()
     {
-        foreach($this->aParameters as $xParameter)
+        foreach ($this->aParameters as $xParameter)
         {
-            if($xParameter->getType() == Jaxon::PAGE_NUMBER)
+            if ($xParameter->getType() == Jaxon::PAGE_NUMBER)
             {
                 return true;
             }
@@ -89,9 +89,9 @@ 
     public function setPageNumber($nPageNumber)
     {
         // Set the value of the Jaxon::PAGE_NUMBER parameter
-        foreach($this->aParameters as $xParameter)
+        foreach ($this->aParameters as $xParameter)
         {
-            if($xParameter->getType() == Jaxon::PAGE_NUMBER)
+            if ($xParameter->getType() == Jaxon::PAGE_NUMBER)
             {
                 $xParameter->setValue(intval($nPageNumber));
                 break;
@@ -111,7 +111,7 @@ 
     {
         $this->sCondition = '__confirm__';
         $this->aMessageArgs = func_get_args();
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -132,7 +132,7 @@ 
         $this->sCondition = Parameter::make($sCondition)->getScript();
         $this->aMessageArgs = func_get_args();
         array_shift($this->aMessageArgs); // Remove the first entry (the condition) from the array
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -153,7 +153,7 @@ 
         $this->sCondition = '!(' . Parameter::make($sCondition)->getScript() . ')';
         $this->aMessageArgs = func_get_args();
         array_shift($this->aMessageArgs); // Remove the first entry (the condition) from the array
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -178,12 +178,12 @@ 
         // This array will avoid declaring many variables with the same value.
         // The array key is the variable value, while the array value is the variable name.
         $aVariables = array(); // Array of local variables.
-        foreach($this->aParameters as &$xParameter)
+        foreach ($this->aParameters as &$xParameter)
         {
             $sParameterStr = $xParameter->getScript();
-            if($xParameter instanceof \Jaxon\JQuery\Dom\Element)
+            if ($xParameter instanceof \Jaxon\JQuery\Dom\Element)
             {
-                if(!array_key_exists($sParameterStr, $aVariables))
+                if (!array_key_exists($sParameterStr, $aVariables))
                 {
                     // The value is not yet defined. A new variable is created.
                     $sVarName = "jxnVar$nVarId";
@@ -201,19 +201,19 @@ 
         }
 
         $sPhrase = '';
-        if(count($this->aMessageArgs) > 0)
+        if (count($this->aMessageArgs) > 0)
         {
             $sPhrase = array_shift($this->aMessageArgs); // The first array entry is the question.
             // $sPhrase = "'" . addslashes($sPhrase) . "'"; // Wrap the phrase with single quotes
-            if(count($this->aMessageArgs) > 0)
+            if (count($this->aMessageArgs) > 0)
             {
                 $nParamId = 1;
-                foreach($this->aMessageArgs as &$xParameter)
+                foreach ($this->aMessageArgs as &$xParameter)
                 {
                     $sParameterStr = $xParameter->getScript();
-                    if($xParameter instanceof \Jaxon\JQuery\Dom\Element)
+                    if ($xParameter instanceof \Jaxon\JQuery\Dom\Element)
                     {
-                        if(!array_key_exists($sParameterStr, $aVariables))
+                        if (!array_key_exists($sParameterStr, $aVariables))
                         {
                             // The value is not yet defined. A new variable is created.
                             $sVarName = "jxnVar$nVarId";
@@ -236,17 +236,17 @@ 
         }
 
         $sScript = $this->getOption('core.prefix.' . $this->sType) . parent::getScript();
-        if($this->sCondition == '__confirm__')
+        if ($this->sCondition == '__confirm__')
         {
             $xConfirm = $this->getPluginManager()->getConfirm();
             $sScript = $xConfirm->confirm($sPhrase, $sScript, '');
         }
-        else if($this->sCondition !== null)
+        else if ($this->sCondition !== null)
         {
             $xAlert = $this->getPluginManager()->getAlert();
             $xAlert->setReturn(true);
             $sScript = 'if(' . $this->sCondition . '){' . $sScript . ';}';
-            if(($sPhrase))
+            if (($sPhrase))
             {
                 $sScript .= 'else{' . $xAlert->warning($sPhrase) . ';}';
             }

Braces +3 added lines, -6 removed lines

@@ -190,8 +190,7 @@ 
                     $aVariables[$sParameterStr] = $sVarName;
                     $sVars .= "$sVarName=$xParameter;";
                     $nVarId++;
-                }
-                else
+                } else
                 {
                     // The value is already defined. The corresponding variable is assigned.
                     $sVarName = $aVariables[$sParameterStr];
@@ -220,8 +219,7 @@ 
                             $aVariables[$sParameterStr] = $sVarName;
                             $sVars .= "$sVarName=$xParameter;";
                             $nVarId++;
-                        }
-                        else
+                        } else
                         {
                             // The value is already defined. The corresponding variable is assigned.
                             $sVarName = $aVariables[$sParameterStr];
@@ -240,8 +238,7 @@ 
         {
             $xConfirm = $this->getPluginManager()->getConfirm();
             $sScript = $xConfirm->confirm($sPhrase, $sScript, '');
-        }
-        else if($this->sCondition !== null)
+        } else if($this->sCondition !== null)
         {
             $xAlert = $this->getPluginManager()->getAlert();
             $xAlert->setReturn(true);

src/Request/Support/BrowserEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
      * the client script that is sent to the browser
      *
      * @param string        $sName                The name of the configuration option
-     * @param string        $sValue                The value of the configuration option
+     * @param string        $mValue                The value of the configuration option
      *
      * @return void
      */

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 namespace Jaxon\Request\Support;
 
 use Jaxon\Request\Request;
-use Jaxon\Request\Manager as RequestManager;
-use Jaxon\Response\Manager as ResponseManager;
 
 class BrowserEvent
 {

Spacing +3 added lines, -3 removed lines

@@ -119,11 +119,11 @@ 
         $sEventPrefix = $this->getOption('core.prefix.event');
         $sMode = '';
         $sMethod = '';
-        if(isset($this->aConfiguration['mode']))
+        if (isset($this->aConfiguration['mode']))
         {
             $sMode = $this->aConfiguration['mode'];
         }
-        if(isset($this->aConfiguration['method']))
+        if (isset($this->aConfiguration['method']))
         {
             $sMethod = $this->aConfiguration['method'];
         }
@@ -145,7 +145,7 @@ 
      */
     public function fire($aArgs)
     {
-        foreach($this->aHandlers as $xHandler)
+        foreach ($this->aHandlers as $xHandler)
         {
             $xHandler->call($aArgs);
         }

src/Request/Support/UserFunction.php

Doc Comments +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
     /**
      * Constructs and returns a <Jaxon\Request\Request> object which is capable of generating the javascript call to invoke this jaxon enabled function
      *
-     * @return Jaxon\Request\Request
+     * @return Request
      */
     public function generateRequest()
     {

Spacing +8 added lines, -8 removed lines

@@ -90,13 +90,13 @@ 
     {
         $this->aConfiguration = array();
         $this->sAlias = '';
-        if(is_array($sUserFunction))
+        if (is_array($sUserFunction))
         {
-            if(count($sUserFunction) != 2 && count($sUserFunction) != 3)
+            if (count($sUserFunction) != 2 && count($sUserFunction) != 3)
             {
                 throw new \Jaxon\Exception\Error($this->trans('errors.functions.invalid-declaration'));
             }
-            if(count($sUserFunction) == 3)
+            if (count($sUserFunction) == 3)
             {
                 $this->sAlias = $sUserFunction[0];
                 $this->sUserFunction = array_slice($sUserFunction, 1);
@@ -106,7 +106,7 @@ 
                 $this->sUserFunction = $sUserFunction;
             }
         }
-        else if(is_string($sUserFunction))
+        else if (is_string($sUserFunction))
         {
             $this->sUserFunction = $sUserFunction;
         }
@@ -124,7 +124,7 @@ 
     public function getName()
     {
         // Do not use sAlias here!
-        if(is_array($this->sUserFunction))
+        if (is_array($this->sUserFunction))
         {
             return $this->sUserFunction[1];
         }
@@ -141,7 +141,7 @@ 
      */
     public function configure($sName, $sValue)
     {
-        switch($sName)
+        switch ($sName)
         {
         case 'alias':
             $this->sAlias = $sValue;
@@ -195,12 +195,12 @@ 
      */
     public function call($aArgs = array())
     {
-        if(($this->sInclude))
+        if (($this->sInclude))
         {
             ob_start();
             require_once $this->sInclude;
             $sOutput = ob_get_clean();
-            if(($sOutput))
+            if (($sOutput))
             {
                 $sOutput = $this->trans('debug.function.include', array(
                     'file' => $this->sInclude,

Braces +3 added lines, -6 removed lines

@@ -100,17 +100,14 @@
             {
                 $this->sAlias = $sUserFunction[0];
                 $this->sUserFunction = array_slice($sUserFunction, 1);
-            }
-            else
+            } else
             {
                 $this->sUserFunction = $sUserFunction;
             }
-        }
-        else if(is_string($sUserFunction))
+        } else if(is_string($sUserFunction))
         {
             $this->sUserFunction = $sUserFunction;
-        }
-        else
+        } else
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.functions.invalid-declaration'));
         }

src/Request/Traits/Factory.php

Doc Comments -2 removed lines

@@ -89,7 +89,6 @@ 
      * Return the javascript call to an Jaxon object method
      *
      * @param string         $sMethod           The method (without class) name
-     * @param ...            $xParams           The parameters of the method
      *
      * @return object
      */
@@ -110,7 +109,6 @@ 
      * @param integer $nItemsPerPage the number of items per page
      * @param integer $nCurrentPage the current page
      * @param string  $sMethod the name of the method
-     * @param ... $parameters the parameters of the method
      *
      * @return string the pagination links
      */

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
      */
     public function getJaxonClassName()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Make the Jaxon class name for a class without an associated callable
             // !! Warning !! This can happen only if this object is not registered with the Jaxon libary
@@ -62,7 +62,7 @@ 
      */
     public function getJaxonNamespace()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Return an empty string.
             return '';
@@ -77,7 +77,7 @@ 
      */
     public function getJaxonClassPath()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Return an empty string.
             return '';

src/Response/Response.php

Doc Comments +50 added lines, -51 removed lines

@@ -155,7 +155,7 @@ 
      * @param array         $aAttributes        Associative array of attributes that will describe the command
      * @param mixed            $mData                The data to be associated with this command
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function addCommand($aAttributes, $mData)
     {
@@ -196,7 +196,7 @@ 
     /**
      * Clear all the commands already added to the response
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function clearCommands()
     {
@@ -208,11 +208,11 @@ 
     /**
      * Add a response command that is generated by a plugin
      *
-     * @param Plugin        $xPlugin            The plugin object
+     * @param \Jaxon\Plugin\Response        $xPlugin            The plugin object
      * @param array         $aAttributes        The attributes for this response command
-     * @param mixed         $mData              The data to be sent with this command
+     * @param string         $mData              The data to be sent with this command
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function addPluginCommand($xPlugin, $aAttributes, $mData)
     {
@@ -273,7 +273,7 @@ 
      * @param integer        $iCmdNumber            The number of commands to skip upon cancel
      * @param string        $sMessage            The message to display to the user
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function confirmCommands($iCmdNumber, $sMessage)
     {
@@ -293,7 +293,7 @@ 
      * @param string        $sAttribute           The attribute to be assigned
      * @param string        $sData                The value to be assigned to the attribute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function assign($sTarget, $sAttribute, $sData)
     {
@@ -315,7 +315,7 @@ 
      * @param string        $sTarget              The id of the html element on the browser
      * @param string        $sData                The value to be assigned to the attribute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function html($sTarget, $sData)
     {
@@ -329,7 +329,7 @@ 
      * @param string        $sAttribute            The name of the attribute to be appended to
      * @param string        $sData                The data to be appended to the attribute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function append($sTarget, $sAttribute, $sData)
     {    
@@ -350,7 +350,7 @@ 
      * @param string        $sAttribute            The name of the attribute to be prepended to
      * @param string        $sData                The value to be prepended to the attribute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function prepend($sTarget, $sAttribute, $sData)
     {
@@ -372,7 +372,7 @@ 
      * @param string        $sSearch            The needle to search for
      * @param string        $sData                The data to use in place of the needle
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function replace($sTarget, $sAttribute, $sSearch, $sData)
     {
@@ -395,7 +395,7 @@ 
      * @param string        $sTarget            The id of the element to be updated.
      * @param string        $sAttribute            The attribute to be cleared
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function clear($sTarget, $sAttribute)
     {
@@ -411,7 +411,7 @@ 
      * @param string        $sAttribute            The attribute to be updated
      * @param string        $sData                The value to assign
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function contextAssign($sAttribute, $sData)
     {
@@ -433,7 +433,7 @@ 
      * @param string        $sAttribute            The attribute to be appended to
      * @param string        $sData                The value to append
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function contextAppend($sAttribute, $sData)
     {
@@ -455,7 +455,7 @@ 
      * @param string        $sAttribute            The attribute to be updated
      * @param string        $sData                The value to be prepended
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function contextPrepend($sAttribute, $sData)
     {
@@ -476,7 +476,7 @@ 
      *
      * @param string        $sAttribute            The attribute to be cleared
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function contextClear($sAttribute)
     {
@@ -488,7 +488,7 @@ 
      *
      * @param string        $sMessage            The message to be displayed
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function alert($sMessage)
     {
@@ -505,7 +505,7 @@ 
      *
      * @param string        $sMessage            The message to be displayed
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function debug($sMessage)
     {
@@ -523,7 +523,7 @@ 
      * @param string        $sURL                The relative or fully qualified URL
      * @param integer        $iDelay                Number of seconds to delay before the redirect occurs
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function redirect($sURL, $iDelay=0)
     {
@@ -576,7 +576,7 @@ 
      *
      * @param string        $sJS                The script to execute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function script($sJS)
     {
@@ -593,7 +593,7 @@ 
      *
      * @param string        $sFunc                The name of the function to call
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function call($sFunc)
     {
@@ -613,7 +613,7 @@ 
      *
      * @param string        $sTarget            The id of the element to be removed
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function remove($sTarget)
     {
@@ -633,7 +633,7 @@ 
      * @param string        $sTag                The tag name to be used for the new element
      * @param string        $sId                The id to assign to the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function create($sParent, $sTag, $sId)
     {
@@ -654,7 +654,7 @@ 
      * @param string        $sTag                The tag name to be used for the new element
      * @param string        $sId                The id to assign to the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function insert($sBefore, $sTag, $sId)
     {
@@ -671,11 +671,10 @@ 
     /**
      * Add a command to insert a new element after the specified
      *
-     * @param string        $sBefore            The id of the element used as a reference point for the insertion
      * @param string        $sTag                The tag name to be used for the new element
      * @param string        $sId                The id to assign to the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function insertAfter($sAfter, $sTag, $sId)
     {
@@ -697,7 +696,7 @@ 
      * @param string        $sName                The name of the new input element
      * @param string        $sId                The id of the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function createInput($sParent, $sType, $sName, $sId)
     {
@@ -720,7 +719,7 @@ 
      * @param string        $sName                The name of the new input element
      * @param string        $sId                The id of the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function insertInput($sBefore, $sType, $sName, $sId)
     {
@@ -743,7 +742,7 @@ 
      * @param string        $sName                The name of the new input element
      * @param string        $sId                The id of the new element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function insertInputAfter($sAfter, $sType, $sName, $sId)
     {
@@ -765,7 +764,7 @@ 
      * @param string        $sEvent                The name of the event
      * @param string        $sScript            The javascript to execute when the event is fired
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function setEvent($sTarget, $sEvent, $sScript)
     {
@@ -785,7 +784,7 @@ 
      * @param string        $sTarget            The id of the element that contains the event
      * @param string        $sScript            The javascript to execute when the event is fired
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function onClick($sTarget, $sScript)
     {
@@ -801,7 +800,7 @@ 
      * @param string        $sEvent                The name of the event
      * @param string        $sHandler            The javascript function to call when the event is fired
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function addHandler($sTarget, $sEvent, $sHandler)
     {
@@ -822,7 +821,7 @@ 
      * @param string        $sEvent                The name of the event
      * @param string        $sHandler            The javascript function called when the event is fired
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function removeHandler($sTarget, $sEvent, $sHandler)
     {
@@ -843,7 +842,7 @@ 
      * @param string        $sArgs                Comma separated list of parameter names
      * @param string        $sScript            The javascript code that will become the body of the function
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function setFunction($sFunction, $sArgs, $sScript)
     {
@@ -870,7 +869,7 @@ 
      * @param string        $sReturnValueVar    The name of the variable that will retain the return value
      *                                             from the call to the original function
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function wrapFunction($sFunction, $sArgs, $aScripts, $sReturnValueVar)
     {
@@ -891,7 +890,7 @@ 
      * @param string        $sFileName            The relative or fully qualified URI of the javascript file
      * @param string        $sType                Determines the script type. Defaults to 'text/javascript'
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function includeScript($sFileName, $sType = null, $sId = null)
     {
@@ -912,7 +911,7 @@ 
      * @param string        $sFileName            The relative or fully qualified URI of the javascript file
      * @param string        $sType                Determines the script type. Defaults to 'text/javascript'
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function includeScriptOnce($sFileName, $sType = null, $sId = null)
     {
@@ -935,7 +934,7 @@ 
      * @param string        $sFileName            The relative or fully qualified URI of the javascript file
      * @param string        $sUnload            Name of a javascript function to call prior to unlaoding the file
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function removeScript($sFileName, $sUnload = '')
     {
@@ -956,7 +955,7 @@ 
      * @param string        $sFileName            The relative or fully qualified URI of the css file
      * @param string        $sMedia                The media type of the CSS file. Defaults to 'screen'
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function includeCSS($sFileName, $sMedia = null)
     {
@@ -975,7 +974,7 @@ 
      *
      * @param string        $sFileName            The relative or fully qualified URI of the css file
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function removeCSS($sFileName, $sMedia = null)
     {
@@ -1000,7 +999,7 @@ 
      * @param integer        $iTimeout            The number of 1/10ths of a second to pause before timing out
      *                                             and continuing with the execution of the response commands
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function waitForCSS($iTimeout = 600)
     {
@@ -1025,7 +1024,7 @@ 
      * @param integer        $tenths                The number of 1/10ths of a second to wait before timing out
      *                                             and continuing with the execution of the response commands.
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function waitFor($script, $tenths)
     {
@@ -1046,7 +1045,7 @@ 
      *
      * @param integer        $tenths                The number of 1/10ths of a second to sleep
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function sleep($tenths)
     {
@@ -1075,7 +1074,7 @@ 
      * @param string        $variable            The DOM element name (id or class)
      * @param string        $tag                The HTML tag of the new DOM element
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domCreateElement($variable, $tag)
     {
@@ -1095,7 +1094,7 @@ 
      * @param string        $key                The name of the attribute
      * @param string        $value                The value of the attribute
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domSetAttribute($variable, $key, $value)
     {
@@ -1116,7 +1115,7 @@ 
      * @param string        $skip                The ??
      * @param string        $remove                The ??
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domRemoveChildren($parent, $skip = null, $remove = null)
     {
@@ -1137,7 +1136,7 @@ 
      * @param string        $parent                The DOM parent element
      * @param string        $variable            The DOM element name (id or class)
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domAppendChild($parent, $variable)
     {
@@ -1156,7 +1155,7 @@ 
      * @param string        $target                The DOM target element
      * @param string        $variable            The DOM element name (id or class)
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domInsertBefore($target, $variable)
     {
@@ -1175,7 +1174,7 @@ 
      * @param string        $target                The DOM target element
      * @param string        $variable            The DOM element name (id or class)
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domInsertAfter($target, $variable)
     {
@@ -1194,7 +1193,7 @@ 
      * @param string        $parent                The DOM parent element
      * @param string        $text                The HTML text to append
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function domAppendText($parent, $text)
     {
@@ -1235,7 +1234,7 @@ 
      *
      * @param mixed        $value                Any value
      *
-     * @return \Jaxon\Plugin\Response
+     * @return Response
      */
     public function setReturnValue($value)
     {

Spacing +40 added lines, -40 removed lines

@@ -97,7 +97,7 @@ 
     public function plugin($sName)
     {
         $xPlugin = $this->getPluginManager()->getResponsePlugin($sName);
-        if(!$xPlugin)
+        if (!$xPlugin)
         {
             return false;
         }
@@ -160,21 +160,21 @@ 
     public function addCommand($aAttributes, $mData)
     {
         /* merge commands if possible */
-        if(in_array($aAttributes['cmd'], array('js', 'ap')))
+        if (in_array($aAttributes['cmd'], array('js', 'ap')))
         {
-            if(($aLastCommand = array_pop($this->aCommands)))
+            if (($aLastCommand = array_pop($this->aCommands)))
             {
-                if($aLastCommand['cmd'] == $aAttributes['cmd'])
+                if ($aLastCommand['cmd'] == $aAttributes['cmd'])
                 {
-                    if($aLastCommand['cmd'] == 'js') 
+                    if ($aLastCommand['cmd'] == 'js') 
                     {
-                        $mData = $aLastCommand['data'].'; '.$mData;
+                        $mData = $aLastCommand['data'] . '; ' . $mData;
                     } 
-                    else if($aLastCommand['cmd'] == 'ap' &&
+                    else if ($aLastCommand['cmd'] == 'ap' &&
                             $aLastCommand['id'] == $aAttributes['id'] &&
                             $aLastCommand['prop'] == $aAttributes['prop'])
                     {
-                        $mData = $aLastCommand['data'].' '.$mData;
+                        $mData = $aLastCommand['data'] . ' ' . $mData;
                     }
                     else
                     {
@@ -231,11 +231,11 @@ 
      */
     public function appendResponse($mCommands, $bBefore = false)
     {
-        if( $mCommands instanceof Response )
+        if ($mCommands instanceof Response)
         {
             $this->returnValue = $mCommands->returnValue;
             
-            if($bBefore)
+            if ($bBefore)
             {
                 $this->aCommands = array_merge($mCommands->aCommands, $this->aCommands);
             }
@@ -244,9 +244,9 @@ 
                 $this->aCommands = array_merge($this->aCommands, $mCommands->aCommands);
             }
         }
-        else if(is_array($mCommands))
+        else if (is_array($mCommands))
         {
-            if($bBefore)
+            if ($bBefore)
             {
                 $this->aCommands = array_merge($mCommands, $this->aCommands);
             }
@@ -257,7 +257,7 @@ 
         }
         else
         {
-            if(!empty($mCommands))
+            if (!empty($mCommands))
             {
                 throw new \Jaxon\Exception\Error($this->trans('errors.response.data.invalid'));
             }
@@ -525,33 +525,33 @@ 
      *
      * @return \Jaxon\Plugin\Response
      */
-    public function redirect($sURL, $iDelay=0)
+    public function redirect($sURL, $iDelay = 0)
     {
         // we need to parse the query part so that the values are rawurlencode()'ed
         // can't just use parse_url() cos we could be dealing with a relative URL which
         // parse_url() can't deal with.
         $queryStart = strpos($sURL, '?', strrpos($sURL, '/'));
-        if($queryStart !== false)
+        if ($queryStart !== false)
         {
             $queryStart++;
             $queryEnd = strpos($sURL, '#', $queryStart);
-            if($queryEnd === false)
+            if ($queryEnd === false)
                 $queryEnd = strlen($sURL);
-            $queryPart = substr($sURL, $queryStart, $queryEnd-$queryStart);
+            $queryPart = substr($sURL, $queryStart, $queryEnd - $queryStart);
             parse_str($queryPart, $queryParts);
             $newQueryPart = "";
-            if($queryParts)
+            if ($queryParts)
             {
                 $first = true;
-                foreach($queryParts as $key => $value)
+                foreach ($queryParts as $key => $value)
                 {
-                    if($first)
+                    if ($first)
                         $first = false;
                     else
                         $newQueryPart .= '&';
-                    $newQueryPart .= rawurlencode($key).'='.rawurlencode($value);
+                    $newQueryPart .= rawurlencode($key) . '=' . rawurlencode($value);
                 }
-            } else if($_SERVER['QUERY_STRING']) {
+            } else if ($_SERVER['QUERY_STRING']) {
                     //couldn't break up the query, but there's one there
                     //possibly "http://url/page.html?query1234" type of query?
                     //just encode it and hope it works
@@ -559,8 +559,8 @@ 
                 }
             $sURL = str_replace($queryPart, $newQueryPart, $sURL);
         }
-        if($iDelay)
-            $this->script('window.setTimeout("window.location = \'' . $sURL . '\';",' . ($iDelay*1000) . ');');
+        if ($iDelay)
+            $this->script('window.setTimeout("window.location = \'' . $sURL . '\';",' . ($iDelay * 1000) . ');');
         else
             $this->script('window.location = "' . $sURL . '";');
         return $this;
@@ -897,10 +897,10 @@ 
     {
         $command = array('cmd'  =>  'in');
         
-        if(($sType))
+        if (($sType))
             $command['type'] = trim((string)$sType, " \t");
         
-        if(($sId))
+        if (($sId))
             $command['elm_id'] = trim((string)$sId, " \t");
 
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
@@ -918,10 +918,10 @@ 
     {
         $command = array('cmd' => 'ino');
         
-        if(($sType))
+        if (($sType))
             $command['type'] = trim((string)$sType, " \t");
         
-        if(($sId))
+        if (($sId))
             $command['elm_id'] = trim((string)$sId, " \t");
             
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
@@ -962,7 +962,7 @@ 
     {
         $command = array('cmd' => 'css');
         
-        if(($sMedia))
+        if (($sMedia))
             $command['media'] = trim((string)$sMedia, " \t");
         
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
@@ -981,7 +981,7 @@ 
     {
         $command = array('cmd' => 'rcss');
         
-        if(($sMedia))
+        if (($sMedia))
             $command['media'] = trim((string)$sMedia, " \t");
         
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
@@ -1122,10 +1122,10 @@ 
     {
         $command = array('cmd' => 'DRC');
 
-        if(($skip))
+        if (($skip))
             $command['skip'] = $skip;
 
-        if(($remove))
+        if (($remove))
             $command['remove'] = $remove;
 
         return $this->addCommand($command, $parent);
@@ -1251,17 +1251,17 @@ 
     public function sendHeaders()
     {
         $xRequestManager = $this->getRequestManager();
-        if($xRequestManager->getRequestMethod() == Jaxon::METHOD_GET)
+        if ($xRequestManager->getRequestMethod() == Jaxon::METHOD_GET)
         {
-            header ("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
-            header ("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
-            header ("Cache-Control: no-cache, must-revalidate");
-            header ("Pragma: no-cache");
+            header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
+            header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
+            header("Cache-Control: no-cache, must-revalidate");
+            header("Pragma: no-cache");
         }
         
         $sCharacterSet = '';
         $sCharacterEncoding = trim($this->getOption('core.encoding'));
-        if(($sCharacterEncoding) && strlen($sCharacterEncoding) > 0)
+        if (($sCharacterEncoding) && strlen($sCharacterEncoding) > 0)
         {
             $sCharacterSet = '; charset="' . trim($sCharacterEncoding) . '"';
         }
@@ -1278,13 +1278,13 @@ 
     {
         $response = array();
         
-        if(($this->returnValue))
+        if (($this->returnValue))
         {
             $response['jxnrv'] = $this->returnValue;
         }
         $response['jxnobj'] = array();
 
-        foreach($this->aCommands as $xCommand)
+        foreach ($this->aCommands as $xCommand)
         {
             $response['jxnobj'][] = $xCommand;
         }

Braces +44 added lines, -40 removed lines

@@ -169,19 +169,16 @@ 
                     if($aLastCommand['cmd'] == 'js') 
                     {
                         $mData = $aLastCommand['data'].'; '.$mData;
-                    } 
-                    else if($aLastCommand['cmd'] == 'ap' &&
+                    } else if($aLastCommand['cmd'] == 'ap' &&
                             $aLastCommand['id'] == $aAttributes['id'] &&
                             $aLastCommand['prop'] == $aAttributes['prop'])
                     {
                         $mData = $aLastCommand['data'].' '.$mData;
-                    }
-                    else
+                    } else
                     {
                         $this->aCommands[] = $aLastCommand;
                     }
-                }
-                else
+                } else
                 {
                     $this->aCommands[] = $aLastCommand;
                 }
@@ -238,24 +235,20 @@ 
             if($bBefore)
             {
                 $this->aCommands = array_merge($mCommands->aCommands, $this->aCommands);
-            }
-            else
+            } else
             {
                 $this->aCommands = array_merge($this->aCommands, $mCommands->aCommands);
             }
-        }
-        else if(is_array($mCommands))
+        } else if(is_array($mCommands))
         {
             if($bBefore)
             {
                 $this->aCommands = array_merge($mCommands, $this->aCommands);
-            }
-            else
+            } else
             {
                 $this->aCommands = array_merge($this->aCommands, $mCommands);
             }
-        }
-        else
+        } else
         {
             if(!empty($mCommands))
             {
@@ -535,8 +528,9 @@ 
         {
             $queryStart++;
             $queryEnd = strpos($sURL, '#', $queryStart);
-            if($queryEnd === false)
-                $queryEnd = strlen($sURL);
+            if($queryEnd === false) {
+                            $queryEnd = strlen($sURL);
+            }
             $queryPart = substr($sURL, $queryStart, $queryEnd-$queryStart);
             parse_str($queryPart, $queryParts);
             $newQueryPart = "";
@@ -545,10 +539,11 @@ 
                 $first = true;
                 foreach($queryParts as $key => $value)
                 {
-                    if($first)
-                        $first = false;
-                    else
-                        $newQueryPart .= '&';
+                    if($first) {
+                                            $first = false;
+                    } else {
+                                            $newQueryPart .= '&';
+                    }
                     $newQueryPart .= rawurlencode($key).'='.rawurlencode($value);
                 }
             } else if($_SERVER['QUERY_STRING']) {
@@ -559,10 +554,11 @@ 
                 }
             $sURL = str_replace($queryPart, $newQueryPart, $sURL);
         }
-        if($iDelay)
-            $this->script('window.setTimeout("window.location = \'' . $sURL . '\';",' . ($iDelay*1000) . ');');
-        else
-            $this->script('window.location = "' . $sURL . '";');
+        if($iDelay) {
+                    $this->script('window.setTimeout("window.location = \'' . $sURL . '\';",' . ($iDelay*1000) . ');');
+        } else {
+                    $this->script('window.location = "' . $sURL . '";');
+        }
         return $this;
     }
 
@@ -897,11 +893,13 @@ 
     {
         $command = array('cmd'  =>  'in');
         
-        if(($sType))
-            $command['type'] = trim((string)$sType, " \t");
+        if(($sType)) {
+                    $command['type'] = trim((string)$sType, " \t");
+        }
         
-        if(($sId))
-            $command['elm_id'] = trim((string)$sId, " \t");
+        if(($sId)) {
+                    $command['elm_id'] = trim((string)$sId, " \t");
+        }
 
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
     }
@@ -918,11 +916,13 @@ 
     {
         $command = array('cmd' => 'ino');
         
-        if(($sType))
-            $command['type'] = trim((string)$sType, " \t");
+        if(($sType)) {
+                    $command['type'] = trim((string)$sType, " \t");
+        }
         
-        if(($sId))
-            $command['elm_id'] = trim((string)$sId, " \t");
+        if(($sId)) {
+                    $command['elm_id'] = trim((string)$sId, " \t");
+        }
             
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
     }
@@ -962,8 +962,9 @@ 
     {
         $command = array('cmd' => 'css');
         
-        if(($sMedia))
-            $command['media'] = trim((string)$sMedia, " \t");
+        if(($sMedia)) {
+                    $command['media'] = trim((string)$sMedia, " \t");
+        }
         
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
     }
@@ -981,8 +982,9 @@ 
     {
         $command = array('cmd' => 'rcss');
         
-        if(($sMedia))
-            $command['media'] = trim((string)$sMedia, " \t");
+        if(($sMedia)) {
+                    $command['media'] = trim((string)$sMedia, " \t");
+        }
         
         return $this->addCommand($command, trim((string)$sFileName, " \t"));
     }
@@ -1122,11 +1124,13 @@ 
     {
         $command = array('cmd' => 'DRC');
 
-        if(($skip))
-            $command['skip'] = $skip;
+        if(($skip)) {
+                    $command['skip'] = $skip;
+        }
 
-        if(($remove))
-            $command['remove'] = $remove;
+        if(($remove)) {
+                    $command['remove'] = $remove;
+        }
 
         return $this->addCommand($command, $parent);
     }

src/Utils/Container.php

Doc Comments +1 added lines, -1 removed lines

@@ -201,7 +201,7 @@
     /**
      * Create a new the config manager
      *
-     * @return Jaxon\Utils\Config\Config            The config manager
+     * @return Config\Config            The config manager
      */
     public function newConfig()
     {

Spacing +21 added lines, -21 removed lines

@@ -27,7 +27,7 @@ 
 
     public static function getInstance()
     {
-        if(!self::$xInstance)
+        if (!self::$xInstance)
         {
             self::$xInstance = new Container();    
         }
@@ -65,19 +65,19 @@ 
          * Managers
          */
         // Plugin Manager
-        $this->di['plugin_manager'] = function($c){
+        $this->di['plugin_manager'] = function($c) {
             return new \Jaxon\Plugin\Manager();
         };
         // Request Manager
-        $this->di['request_manager'] = function($c){
+        $this->di['request_manager'] = function($c) {
             return new \Jaxon\Request\Manager();
         };
         // Request Factory
-        $this->di['request_factory'] = function($c){
+        $this->di['request_factory'] = function($c) {
             return new \Jaxon\Request\Factory();
         };
         // Response Manager
-        $this->di['response_manager'] = function($c){
+        $this->di['response_manager'] = function($c) {
             return new \Jaxon\Response\Manager();
         };
 
@@ -85,35 +85,35 @@ 
          * Services
          */
         // Config manager
-        $this->di['config'] = function($c){
+        $this->di['config'] = function($c) {
             return new Config\Config();
         };
         // Minifier
-        $this->di['minifier'] = function($c){
+        $this->di['minifier'] = function($c) {
             return new Template\Minifier();
         };
         // Translator
-        $this->di['translator'] = function($c){
+        $this->di['translator'] = function($c) {
             return new Translation\Translator($c['translation_dir'], $c['config']);
         };
         // Template engine
-        $this->di['template'] = function($c){
+        $this->di['template'] = function($c) {
             return new Template\Template($c['template_dir']);
         };
         // Validator
-        $this->di['validator'] = function($c){
+        $this->di['validator'] = function($c) {
             return new Validation\Validator();
         };
         // Pagination Renderer
-        $this->di['pagination.renderer'] = function($c){
+        $this->di['pagination.renderer'] = function($c) {
             return new Pagination\Renderer();
         };
         // Pagination Paginator
-        $this->di['pagination.paginator'] = function($c){
+        $this->di['pagination.paginator'] = function($c) {
             return new Pagination\Paginator($c['pagination.renderer']);
         };
         // Event Dispatcher
-        $this->di['events'] = function($c){
+        $this->di['events'] = function($c) {
             return new EventDispatcher();
         };
 
@@ -121,27 +121,27 @@ 
          * Core library objects
          */
         // Global Response
-        $this->di['response'] = function($c){
+        $this->di['response'] = function($c) {
             return new \Jaxon\Response\Response();
         };
         // Jaxon Core
-        $this->di['jaxon'] = function($c){
+        $this->di['jaxon'] = function($c) {
             return new \Jaxon\Jaxon();
         };
         // Jaxon Sentry
-        $this->di['sentry'] = function($c){
+        $this->di['sentry'] = function($c) {
             // This class is not defined in this package
             $sClass = '\\Jaxon\\Sentry\\Sentry';
             return new $sClass;
         };
         // Armada
-        $this->di['armada'] = function($c){
+        $this->di['armada'] = function($c) {
             // This class is not defined in this package
             $sClass = '\\Jaxon\\Armada\\Armada';
             return new $sClass;
         };
         // View Renderer Facade
-        $this->di['sentry.view.renderer'] = function($c){
+        $this->di['sentry.view.renderer'] = function($c) {
             $aRenderers = $c['view.data.renderers'];
             $sDefaultNamespace = $c['view.data.namespace.default'];
             return new \Jaxon\Sentry\View\Facade($aRenderers, $sDefaultNamespace);
@@ -396,9 +396,9 @@ 
             $renderer = $c['sentry.view.base.' . $sId];
             // Init the renderer with the template namespaces
             $aNamespaces = $this->di['view.data.namespaces'];
-            if(key_exists($sId, $aNamespaces))
+            if (key_exists($sId, $aNamespaces))
             {
-                foreach($aNamespaces[$sId] as $ns)
+                foreach ($aNamespaces[$sId] as $ns)
                 {
                     $renderer->addNamespace($ns['namespace'], $ns['directory'], $ns['extension']);
                 }
@@ -416,7 +416,7 @@ 
      */
     public function getViewRenderer($sId = '')
     {
-        if(!$sId)
+        if (!$sId)
         {
             // Return the view renderer facade
             return $this->di['sentry.view.renderer'];

src/Utils/Pagination/Paginator.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
     }
 
     /**
-     * @return string
+     * @return Request
      */
     public function getRequest()
     {

Spacing +21 added lines, -21 removed lines

@@ -65,7 +65,7 @@ 
 
     protected function updateNumPages()
     {
-        $this->numPages = ($this->itemsPerPage == 0 ? 0 : (int) ceil($this->totalItems/$this->itemsPerPage));
+        $this->numPages = ($this->itemsPerPage == 0 ? 0 : (int)ceil($this->totalItems / $this->itemsPerPage));
     }
 
     /**
@@ -74,7 +74,7 @@ 
      */
     public function setMaxPagesToShow($maxPagesToShow)
     {
-        if($maxPagesToShow < 3)
+        if ($maxPagesToShow < 3)
         {
             throw new \InvalidArgumentException('maxPagesToShow cannot be less than 3.');
         }
@@ -154,7 +154,7 @@ 
     {
         $this->request = $request;
         // Append the page number to the parameter list, if not yet given.
-        if(($this->request) && !$this->request->hasPageNumber())
+        if (($this->request) && !$this->request->hasPageNumber())
         {
             $this->request->addParameter(Jaxon::PAGE_NUMBER, 0);
         }
@@ -193,7 +193,7 @@ 
 
     public function getNextPage()
     {
-        if($this->currentPage < $this->numPages)
+        if ($this->currentPage < $this->numPages)
         {
             return $this->currentPage + 1;
         }
@@ -203,7 +203,7 @@ 
 
     public function getPrevPage()
     {
-        if($this->currentPage > 1)
+        if ($this->currentPage > 1)
         {
             return $this->currentPage - 1;
         }
@@ -213,7 +213,7 @@ 
 
     public function getNextCall()
     {
-        if(!$this->getNextPage())
+        if (!$this->getNextPage())
         {
             return null;
         }
@@ -226,7 +226,7 @@ 
      */
     public function getPrevCall()
     {
-        if(!$this->getPrevPage())
+        if (!$this->getPrevPage())
         {
             return null;
         }
@@ -254,14 +254,14 @@ 
     {
         $pages = array();
 
-        if($this->numPages <= 1)
+        if ($this->numPages <= 1)
         {
             return array();
         }
 
-        if($this->numPages <= $this->maxPagesToShow)
+        if ($this->numPages <= $this->maxPagesToShow)
         {
-            for($i = 1; $i <= $this->numPages; $i++)
+            for ($i = 1; $i <= $this->numPages; $i++)
             {
                 $pages[] = $this->createPage($i, $i == $this->currentPage);
             }
@@ -269,9 +269,9 @@ 
         else
         {
             // Determine the sliding range, centered around the current page.
-            $numAdjacents = (int) floor(($this->maxPagesToShow - 3) / 2);
+            $numAdjacents = (int)floor(($this->maxPagesToShow - 3) / 2);
 
-            if($this->currentPage + $numAdjacents > $this->numPages)
+            if ($this->currentPage + $numAdjacents > $this->numPages)
             {
                 $slidingStart = $this->numPages - $this->maxPagesToShow + 2;
             }
@@ -279,28 +279,28 @@ 
             {
                 $slidingStart = $this->currentPage - $numAdjacents;
             }
-            if($slidingStart < 2)
+            if ($slidingStart < 2)
             {
                 $slidingStart = 2;
             }
 
             $slidingEnd = $slidingStart + $this->maxPagesToShow - 3;
-            if($slidingEnd >= $this->numPages)
+            if ($slidingEnd >= $this->numPages)
             {
                 $slidingEnd = $this->numPages - 1;
             }
 
             // Build the list of pages.
             $pages[] = $this->createPage(1, $this->currentPage == 1);
-            if($slidingStart > 2)
+            if ($slidingStart > 2)
             {
                 $pages[] = $this->createPageEllipsis();
             }
-            for($i = $slidingStart; $i <= $slidingEnd; $i++)
+            for ($i = $slidingStart; $i <= $slidingEnd; $i++)
             {
                 $pages[] = $this->createPage($i, $i == $this->currentPage);
             }
-            if($slidingEnd < $this->numPages - 1)
+            if ($slidingEnd < $this->numPages - 1)
             {
                 $pages[] = $this->createPageEllipsis();
             }
@@ -346,7 +346,7 @@ 
      */
     public function toHtml()
     {
-        if($this->getNumPages() <= 1)
+        if ($this->getNumPages() <= 1)
         {
             return '';
         }
@@ -369,7 +369,7 @@ 
     {
         $first = ($this->currentPage - 1) * $this->itemsPerPage + 1;
 
-        if($first > $this->totalItems)
+        if ($first > $this->totalItems)
         {
             return null;
         }
@@ -380,13 +380,13 @@ 
     public function getCurrentPageLastItem()
     {
         $first = $this->getCurrentPageFirstItem();
-        if($first === null)
+        if ($first === null)
         {
             return null;
         }
 
         $last = $first + $this->itemsPerPage - 1;
-        if($last > $this->totalItems)
+        if ($last > $this->totalItems)
         {
             return $this->totalItems;
         }

Braces +2 added lines, -4 removed lines

@@ -265,8 +265,7 @@ 
             {
                 $pages[] = $this->createPage($i, $i == $this->currentPage);
             }
-        }
-        else
+        } else
         {
             // Determine the sliding range, centered around the current page.
             $numAdjacents = (int) floor(($this->maxPagesToShow - 3) / 2);
@@ -274,8 +273,7 @@ 
             if($this->currentPage + $numAdjacents > $this->numPages)
             {
                 $slidingStart = $this->numPages - $this->maxPagesToShow + 2;
-            }
-            else
+            } else
             {
                 $slidingStart = $this->currentPage - $numAdjacents;
             }

src/Utils/Translation/Translator.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      * Get a translated string
      *
      * @param string        $sText                The key of the translated string
-     * @param string        $aPlaceHolders        The placeholders of the translated string
+     * @param string        $placeholders        The placeholders of the translated string
      * @param string        $sLanguage            The language of the translated string
      *
      * @return string        The translated string

Indentation +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
         }
         if(!array_key_exists($sLanguage, $this->aMessages) || !array_key_exists($sText, $this->aMessages[$sLanguage]))
         {
-           return $sText;
+            return $sText;
         }
         $message = $this->aMessages[$sLanguage][$sText];
         foreach($placeholders as $name => $value)

Spacing +7 added lines, -7 removed lines

@@ -45,17 +45,17 @@ 
      */
     public function loadMessages($sFilePath, $sLanguage)
     {
-        if(!file_exists($sFilePath))
+        if (!file_exists($sFilePath))
         {
             return;
         }
         $aMessages = require($sFilePath);
-        if(!is_array($aMessages))
+        if (!is_array($aMessages))
         {
             return;
         }
         // Load the translations
-        if(!array_key_exists($sLanguage, $this->aMessages))
+        if (!array_key_exists($sLanguage, $this->aMessages))
         {
             $this->aMessages[$sLanguage] = $aMessages;
         }
@@ -77,20 +77,20 @@ 
     public function trans($sText, array $placeholders = array(), $sLanguage = null)
     {
         $sText = trim((string)$sText);
-        if(!$sLanguage)
+        if (!$sLanguage)
         {
             $sLanguage = $this->xConfig->getOption('language');
         }
-        if(!$sLanguage)
+        if (!$sLanguage)
         {
             $sLanguage = $this->sDefaultLocale;
         }
-        if(!array_key_exists($sLanguage, $this->aMessages) || !array_key_exists($sText, $this->aMessages[$sLanguage]))
+        if (!array_key_exists($sLanguage, $this->aMessages) || !array_key_exists($sText, $this->aMessages[$sLanguage]))
         {
            return $sText;
         }
         $message = $this->aMessages[$sLanguage][$sText];
-        foreach($placeholders as $name => $value)
+        foreach ($placeholders as $name => $value)
         {
             $message = str_replace(":$name", $value, $message);
         }

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
         if(!array_key_exists($sLanguage, $this->aMessages))
         {
             $this->aMessages[$sLanguage] = $aMessages;
-        }
-        else
+        } else
         {
             $this->aMessages[$sLanguage] = array_merge($aMessages, $this->aMessages[$sLanguage]);
         }

src/Request/Support/CallableObject.php

Spacing +22 added lines, -22 removed lines

@@ -92,7 +92,7 @@ 
      */
     public function __construct($xCallable)
     {
-        if(is_string($xCallable)) // Received a class name
+        if (is_string($xCallable)) // Received a class name
         {
             $this->reflectionClass = new \ReflectionClass($xCallable);
             $this->callableObject = null;
@@ -118,12 +118,12 @@ 
      */
     private function setCallable($xCallable = null)
     {
-        if($xCallable == null)
+        if ($xCallable == null)
         {
             $xCallable = $this->reflectionClass->newInstance();
         }
         // Save the Jaxon callable object into the user callable object
-        if($this->reflectionClass->hasMethod('setJaxonCallable'))
+        if ($this->reflectionClass->hasMethod('setJaxonCallable'))
         {
             $xCallable->setJaxonCallable($this);
         }
@@ -137,7 +137,7 @@ 
      */
     public function getRegisteredObject()
     {
-        if($this->callableObject == null)
+        if ($this->callableObject == null)
         {
             $this->setCallable();
         }
@@ -167,7 +167,7 @@ 
         // The class name without the namespace.
         $name = $this->reflectionClass->getShortName();
         // Append the classpath to the name
-        if(($this->classpath))
+        if (($this->classpath))
         {
             $name = $this->classpath . $this->separator . $name;
         }
@@ -204,16 +204,16 @@ 
     public function getMethods()
     {
         $aReturn = array();
-        foreach($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
+        foreach ($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
         {
             $sMethodName = $xMethod->getShortName();
             // Don't take magic __call, __construct, __destruct methods
-            if(strlen($sMethodName) > 2 && substr($sMethodName, 0, 2) == '__')
+            if (strlen($sMethodName) > 2 && substr($sMethodName, 0, 2) == '__')
             {
                 continue;
             }
             // Don't take excluded methods
-            if(in_array($sMethodName, $this->aProtectedMethods))
+            if (in_array($sMethodName, $this->aProtectedMethods))
             {
                 continue;
             }
@@ -234,37 +234,37 @@ 
     public function configure($sMethod, $sName, $sValue)
     {
         // Set the namespace
-        if($sName == 'namespace')
+        if ($sName == 'namespace')
         {
-            if($sValue != '')
+            if ($sValue != '')
                 $this->namespace = $sValue;
             return;
         }
         // Set the classpath
-        if($sName == 'classpath')
+        if ($sName == 'classpath')
         {
-            if($sValue != '')
+            if ($sValue != '')
                 $this->classpath = $sValue;
             return;
         }
         // Set the separator
-        if($sName == 'separator')
+        if ($sName == 'separator')
         {
-            if($sValue == '_' || $sValue == '.')
+            if ($sValue == '_' || $sValue == '.')
                 $this->separator = $sValue;
             return;
         }
         // Set the excluded methods
-        if($sName == 'protected')
+        if ($sName == 'protected')
         {
-            if(is_array($sValue))
+            if (is_array($sValue))
                 $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
-            else if(is_string($sValue))
+            else if (is_string($sValue))
                 $this->aProtectedMethods[] = $sValue;
             return;
         }
         
-        if(!isset($this->aConfiguration[$sMethod]))
+        if (!isset($this->aConfiguration[$sMethod]))
         {
             $this->aConfiguration[$sMethod] = array();
         }    
@@ -284,16 +284,16 @@ 
 
         // Common options to be set on all methods
         $aCommonConfig = array_key_exists('*', $this->aConfiguration) ? $this->aConfiguration['*'] : array();
-        foreach($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
+        foreach ($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
         {
             $sMethodName = $xMethod->getShortName();
             // Don't export magic __call, __construct, __destruct methods
-            if(strlen($sMethodName) > 0 && substr($sMethodName, 0, 2) == '__')
+            if (strlen($sMethodName) > 0 && substr($sMethodName, 0, 2) == '__')
             {
                 continue;
             }
             // Don't export "protected" methods
-            if(in_array($sMethodName, $this->aProtectedMethods))
+            if (in_array($sMethodName, $this->aProtectedMethods))
             {
                 continue;
             }
@@ -343,7 +343,7 @@ 
      */
     public function call($sMethod, $aArgs)
     {
-        if(!$this->hasMethod($sMethod))
+        if (!$this->hasMethod($sMethod))
             return;
         $reflectionMethod = $this->reflectionClass->getMethod($sMethod);
         $callableObject = $this->getRegisteredObject();

Braces +21 added lines, -15 removed lines

@@ -92,12 +92,13 @@ 
      */
     public function __construct($xCallable)
     {
-        if(is_string($xCallable)) // Received a class name
+        if(is_string($xCallable)) {
+            // Received a class name
         {
             $this->reflectionClass = new \ReflectionClass($xCallable);
-            $this->callableObject = null;
         }
-        else // if(is_object($xCallable)) // Received a class instance
+            $this->callableObject = null;
+        } else // if(is_object($xCallable)) // Received a class instance
         {
             $this->reflectionClass = new \ReflectionClass(get_class($xCallable));
             $this->setCallable($xCallable);
@@ -236,31 +237,35 @@ 
         // Set the namespace
         if($sName == 'namespace')
         {
-            if($sValue != '')
-                $this->namespace = $sValue;
+            if($sValue != '') {
+                            $this->namespace = $sValue;
+            }
             return;
         }
         // Set the classpath
         if($sName == 'classpath')
         {
-            if($sValue != '')
-                $this->classpath = $sValue;
+            if($sValue != '') {
+                            $this->classpath = $sValue;
+            }
             return;
         }
         // Set the separator
         if($sName == 'separator')
         {
-            if($sValue == '_' || $sValue == '.')
-                $this->separator = $sValue;
+            if($sValue == '_' || $sValue == '.') {
+                            $this->separator = $sValue;
+            }
             return;
         }
         // Set the excluded methods
         if($sName == 'protected')
         {
-            if(is_array($sValue))
-                $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
-            else if(is_string($sValue))
-                $this->aProtectedMethods[] = $sValue;
+            if(is_array($sValue)) {
+                            $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
+            } else if(is_string($sValue)) {
+                            $this->aProtectedMethods[] = $sValue;
+            }
             return;
         }
         
@@ -343,8 +348,9 @@ 
      */
     public function call($sMethod, $aArgs)
     {
-        if(!$this->hasMethod($sMethod))
-            return;
+        if(!$this->hasMethod($sMethod)) {
+                    return;
+        }
         $reflectionMethod = $this->reflectionClass->getMethod($sMethod);
         $callableObject = $this->getRegisteredObject();
         $this->getResponseManager()->append($reflectionMethod->invokeArgs($callableObject, $aArgs));